summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2017-02-24Make ToolbarMode's "IsExperimental" property non-nillableSzymon Kłos
Change-Id: Ia83776d7ee23fa56c0fc541c228c68b1832c3d11 Reviewed-on: https://gerrit.libreoffice.org/34585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-23change intervall -> intervalDavid Tardon
Change-Id: Ib211619428f16304603d9c0a9fce0b22dde2a617
2017-02-22tdf#103323 Single Toolbar without experimental modeSzymon Kłos
Only Notebookbar mode should be marked as experimental. This patch allows to enable Single Toolbar or Sidebar mode without experimental mode activation. Change-Id: I9dcf1602b2f560aaa9ea29c07c4a7ed473be0352 Reviewed-on: https://gerrit.libreoffice.org/34431 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-21Fix typos/translations, following 04644956e53dAndrea Gelmini
No automatic tools Change-Id: I3a6d18760f90c4ee02b9380758f97f6fca6c4428 Reviewed-on: https://gerrit.libreoffice.org/30874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-21loplugin:subtlezeroinit: frameworkStephan Bergmann
Change-Id: I88871abd4b57debeb8002a25ef5f59f57e065803
2017-02-21Use module name when getting labelsMaxim Monastirsky
Change-Id: I1d5196e1ca888dfb11d5bd6ef4676937dce49fdc
2017-02-21Single GlobalAcceleratorConfiguration should be enoughMaxim Monastirsky
avoid reading the configuration again and again. Change-Id: I4179da53114990e5ee68b47125ccef356ca00d53
2017-02-21Revert "Resolves: #i120029# Unregister on dispose."Maxim Monastirsky
This reverts commit 11f8e53d6c9942185702552445a751c6f542942d. At the time this commit was imported from AOO, we had the original problem fixed already with dd8fa7c25af9614dbee5a7795b95d8583093f65b ("fix more lifecycle problems"). Change-Id: Id8288d30c1cb908b68e5b9ef0279237412aae357
2017-02-21tdf#95844 Refactor CommandInfoProviderRohan Kumar
Instead of a singleton, CommandInfoProvider should just be a set of static methods. Change-Id: I16d4406e361a72f013d78f18d6bd0ae20c0cc5e9
2017-02-16drop unused Private from EProtocol enumNoel Grandin
Change-Id: Ic3f64eb211e520dbafed4ef98344ab5cb0811599
2017-02-16drop enum framework::GlobalSettings::UIElementTypeNoel Grandin
since we only ever use the one enumerator. Consequently renaming some methods Change-Id: Ia8c022135df6661b8f300e037ea3e7cf610b63ac
2017-02-16convert LoadEnv::EFeature to o3tl::typed_flagsNoel Grandin
Change-Id: I4c16b68c820783e9bd27fa273f2017b5088f4b85
2017-02-16drop unused enumerators from TargetHelper::ESpecialTargetNoel Grandin
Change-Id: Ieda0b6f09b0e4cb463de32309a2617018bb7cee5
2017-02-16tdf#100726 Improved readability of OUString concatenationsFakabbir Amin
Cleanup in filter, framework and svtools directory. Change-Id: Icf4f04cff1207e58ce55ea3dc8c21b0635c3b6ec Reviewed-on: https://gerrit.libreoffice.org/34298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-16convert FrameListAnalyzer::EDetect to scoped enumNoel Grandin
Change-Id: I4e1bd449c4ad60ec810ef52c73d6c6ff3dd313ee
2017-02-15Some simplifications, using UNO_QUERY_THROWStephan Bergmann
Change-Id: I313b17cea20fc9dc3b617ecc41626410c0dfb127 Reviewed-on: https://gerrit.libreoffice.org/34267 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-14Convert WindowType to scoped enumNoel Grandin
Change-Id: I85cfe02f28729e13f2c0dd3d91cd89e6f3e3b6a9 Reviewed-on: https://gerrit.libreoffice.org/34219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-12tdf#42029 Use a floating toolbar to show clipped itemsMaxim Monastirsky
Change-Id: I6b366f115258ef8497807163179d3e08ab3d5e6f Reviewed-on: https://gerrit.libreoffice.org/34180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-10convert InsertOperation to scoped enumNoel Grandin
and drop unused LINK enumerator Change-Id: I6c42424ae5a7503b3e14e5f04fcf7a49b595b416
2017-02-10convert ConfigNameFormat to scoped enumNoel Grandin
and drop unused constants CONFIG_NAME_PLAINTEXT_NAME CONFIG_NAME_FULL_PATH Change-Id: Ibf7e88da0ae54516cb863b8efa995201f2a95268
2017-02-09Resolves: tdf#66237 set layout manager the way it used toCaolán McNamara
model Frame::setLayoutManager after the Frame::impl_setPropertyValue handler for FRAME_PROPHANDLE_LAYOUTMANAGER which used to be used before commit b248624126c271c88381d3dad6e04fc954f65779 Date: Fri Mar 22 09:24:15 2013 +0200 fdo#46808, Convert frame::Frame to new style i.e. - Reference< XPropertySet > xFrameProps( m_xFrame, UNO_QUERY_THROW ); - xFrameProps->setPropertyValue( OUString( "LayoutManager" ), makeAny(Reference< XLayoutManager >()) ); + m_xFrame->setLayoutManager( Reference< XLayoutManager >() ); Change-Id: I00f1a2cb8e4fafc6d484634619cbeaf58c603d87
2017-02-07tdf#104101 Improve the session management handlingJuergen Funk
- Set the current time to the SessionID - Split the SetProperties-Data, and send DeleteProperties for DiscardCommand (above both topic is the same as kate and plasma-desktop to do) - in statusChange the saveDone was not called, and call only once the saveDone - in shutdownCanceled must be send the saveDone too Change-Id: I42855c75b88b5d651ef8091947e359dc2c3f9209 Reviewed-on: https://gerrit.libreoffice.org/33215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-02-07Stop question in context of session manager when cancel a frameJuergen Funk
When shutdown or logout, LO make the question for all open windows, but when you cancel a window the question for the other windows are not necessary, this patch breaks the other questions. in dependency of tdf#104101 Change-Id: I7119317d392ccd808c67fb57f82b1e990062abf2 Reviewed-on: https://gerrit.libreoffice.org/33311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-02-06MenuToolbarController improvementsMaxim Monastirsky
- Make it self-contained, instead of having its code spread across ToolBarManager. - Base it on svt::ToolboxController directly, since it uses nothing from GenericToolbarController. - Move the code from dtor to dispose method. - Call ToolBox::SetItemDown to make the button work on a second click. Change-Id: I5b38ef532ba40ef0ac31bc53de5b6be4ccd1a118 Reviewed-on: https://gerrit.libreoffice.org/33982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06Typo: s/dependend/dependent/iTor Lillqvist
Change-Id: If02798894ad6f0e0442ed60aaec6eca40e6dcb61
2017-02-06framework: Pass Item ID to Menu::GetUserValue() instead of indexTakeshi Abe
This also avoids needless cast. Change-Id: I3fd1517657b489115f20e26f4f75f3e3a5b7c9b7 Reviewed-on: https://gerrit.libreoffice.org/33944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-06framework: Retrieve shortcuts from document-specific configurationTakeshi Abe
No known symptoms, but it seems like a typo when comparing with MenuBarManager::RetrieveShortcuts(). Change-Id: I83f6e5766f5e0a0e01f5fd4863772ad1d99c70d2 Reviewed-on: https://gerrit.libreoffice.org/33945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-06loplugin:unusedenumconstants in frameworkNoel Grandin
Convert EProtocol to scoped enum and drop E_UNKNOWN_PROTOCOL. Convert ToggleButtonToolbarController::Style to scoped enum and drop STYLE_TOGGLEBUTTON. Convert TargetHelper::ESpecialTarget to scoped enum and drop E_NOT_SPECIAL. Change-Id: I412adacac15192cf6563ce4d5e5b74bfffff4737 Reviewed-on: https://gerrit.libreoffice.org/33949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-05.uno:ScriptOrganizer should be menu:menuitemMaxim Monastirsky
... so it won't show as an empty submenu in the customization dialog, and allow accidentally overwriting it. Change-Id: I9431e5240485a58f63a2333850a9052e475db63e
2017-02-05tdf#105737 Menu::GetItemType takes position not item idMaxim Monastirsky
And get rid of a pointless sal_uInt32-sal_uInt16 casting. Change-Id: Ia27fd87ceb4d060dab9ea7fffd4803903a1893da
2017-02-05Restore custom tooltip supportMaxim Monastirsky
This reverts the toolbarmanager.cxx part of 38839ae10cb565ff1977b1839de1c8278eac657b ("Remove the ability to set tooltips in the toolbar xml files"). It is true that tooltips can't be set in xml files, but toolbars can also be created/modified via the UIConfigurationManager and LayoutManager APIs, e.g. the test doc of i#105626 . Change-Id: Ida1559e61e7fd9bd6dcdd7b7159bc5efe070c721
2017-02-05Revert "Remove unused toolbar:text define"Maxim Monastirsky
This reverts commit 8ce70a7e267bf45aa5eaae203ee26ad3826e91a8. It is true that toolbar:text shouldn't be used during LO development, but it's still used by toolbar customization, and such customized XMLs should still validate against the dtd. Change-Id: I95227a22ecc00a27f39591163ee09a78adde3168
2017-02-05HelpURL toolbar property is unusedMaxim Monastirsky
Change-Id: I74b22509f59899b7c15aa791a01c60c8d982221f
2017-02-03TyposJulien Nabet
Change-Id: I36f443c266670bd26aa6b813075e18653f372f52 Reviewed-on: https://gerrit.libreoffice.org/33900 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-03new loplugin:unusedenumconstantsNoel Grandin
These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02Fix some typosSamuel Mehrbrodt
Change-Id: Ide3786aad5589e2d430a4e3890d51117b145e51d Reviewed-on: https://gerrit.libreoffice.org/33842 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-02unnecessary use of OUStringBuffer in throwing exceptionsNoel Grandin
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f Reviewed-on: https://gerrit.libreoffice.org/33788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31more SAL_WARN_UNUSEDNoel Grandin
Change-Id: Idf44fe0302b4504c443f083e527b63b2461ada85
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25Remove unused macrosStephan Bergmann
Change-Id: Ib3f8f6cde75b6a605052a3d941380ab27db0f326
2017-01-25Fix typo in comments: relativ -> relativeTakeshi Abe
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-25loplugin: unnecessary destructor forms..idlcNoel Grandin
Change-Id: I765e0fa61f8134a60e5ea24452c6bbcb3fa8b054 Reviewed-on: https://gerrit.libreoffice.org/33492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-21move GetXGraphic to its only userCaolán McNamara
Change-Id: I72ec4a7e72ca3355a97f987fab70b3e3a8e45168
2017-01-20empty Image is an empty XGraphicCaolán McNamara
Change-Id: I43fa17c2ef9324c841344554b093500d0fb26165
2017-01-20don't need an intermediate ImageCaolán McNamara
Change-Id: Ibdc4b94e284a1d54b94abfdeb99df393b6a7bf59
2017-01-19New loplugin:dynexcspec: Add @throws documentation, frameworkStephan Bergmann
Change-Id: I19a4517449be3defe97fe0d78dd1a16b08b79247
generated by cgit (git 2.34.1) at 2024-12-25 05:29:49 +0000