summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2019-01-28Fix icon load error for uno commands with paramsMuhammet Kara
Change-Id: I31e4c28322a3492a603bce5c7226e2dbcf131173 Reviewed-on: https://gerrit.libreoffice.org/66980 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-25tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScSpreadsheetSettings. Change-Id: Id969a566fcb4e544c26a4097e0f49a01bc967ad7 Reviewed-on: https://gerrit.libreoffice.org/66926 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-25tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScTableValidationObj. Change-Id: If058f40ff73203d2705bf9841d0496d52ff93ed8 Reviewed-on: https://gerrit.libreoffice.org/66890 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-24tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScSheetLinksObj. Change-Id: Ibe4571cf75abf96edc4361d884c63be0a972cab2 Reviewed-on: https://gerrit.libreoffice.org/66819 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-23tdf#45904 Clean up _XDrawPageSummarizer Java testsJens Carl
The XDrawPageSummarizer interface is deprecated since commit d081c80877dc1ae413b9d65c206485b6821d0ef8 Change-Id: I041c5d5df11d1b5208b846c76ef82427c4df4585 Reviewed-on: https://gerrit.libreoffice.org/66757 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-21o3tl::make_unique -> std::make_unique in dbaccess...frameworkGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Iad5a422bc5a7da43d905edc91d1c46793332ec5e Reviewed-on: https://gerrit.libreoffice.org/66545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScDDELinksObj. Change-Id: I91d8ea1b51cde36996847371a03406b899e23d79 Reviewed-on: https://gerrit.libreoffice.org/66559 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-17tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScTableConditionalFormat. Change-Id: Ib2575920e05d56feed68c6f4c15b485ab7993600 Reviewed-on: https://gerrit.libreoffice.org/66488 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-16tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScStyleFamiliesObj. Change-Id: I0c21e35f1c303bb430010b51795285c0a2e7e283 Reviewed-on: https://gerrit.libreoffice.org/66347 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-14tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScDataPilotTablesObj. Change-Id: I43bd4ca0688e38792080710c288ca746f95460d9 Reviewed-on: https://gerrit.libreoffice.org/66273 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-13tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScDatabaseRangesObj. Change-Id: Id54f9bc1a9215a4524be4a1f52800049ce438c8a Reviewed-on: https://gerrit.libreoffice.org/66250 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-13tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScFunctionListObj. Change-Id: I2db954ed8801937271b946e814bb1773c089d9ab Reviewed-on: https://gerrit.libreoffice.org/66244 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-11Replace OUStringBuffer::appendCopy with append(std::u16string_view)Stephan Bergmann
...which is more general Change-Id: I94f28f8eda887120cf5f143b4549e0339b60e6a7 Reviewed-on: https://gerrit.libreoffice.org/66155 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-20tdf#42949 Fix IWYU warnings in include/vcl/[t-u]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f Reviewed-on: https://gerrit.libreoffice.org/65386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-20Fix typoAndrea Gelmini
Change-Id: I211b3deb6089835486744eaea5879392994cc66e Reviewed-on: https://gerrit.libreoffice.org/65467 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-19framework: allow loading a component on the main threadMiklos Vajna
The user-visible problem was that embedded (OLE) objects contained in a document that was loaded on a thread were not editable. This works in the loaded-with-UI case because the Windows version of the SalData constructor in vcl calls CoInitialize() (which sets the concurrency model of the main thread to STA) and then later the OleComponent constructor in embeddedobj calls OleInitialize(), which just realizes that the concurrency model is already set, and OLE editing works. However, if the document is loaded on a thread, things are different. The concurrency model of the thread is set to MTA in oslWorkerWrapperFunction() in sal, so the later OleInitialize() will fail with RPC_E_CHANGED_MODE, as it's not possible to set the concurrency model of a thread once it's set. Solve the problem by providing in opt-in way to execute the actual import on the main thread, since remote UNO clients always invoke Desktop::loadComponentFromURL() on a thread. Change-Id: I94f2721b599c3ae3e2ebc1c90dea649a69d51ef7 Reviewed-on: https://gerrit.libreoffice.org/65453 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-19HandlerCFGAccess::read should take referencesNoel Grandin
Change-Id: Icecb26e15d97fcf9c6694053fafc99b62385ffb5 Reviewed-on: https://gerrit.libreoffice.org/65395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-18tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScScenariosObj. Change-Id: I73dd65e672e1e98a6839cea03c30cfafb7da4ff4 Reviewed-on: https://gerrit.libreoffice.org/65313 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-12loplugin:useuniqueptr in basic and frameworkNoel Grandin
Change-Id: I409c9c572eb8f3d68c8a387844b43988b4ab5c32 Reviewed-on: https://gerrit.libreoffice.org/64949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-08use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-08tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScCellFieldsObj. Change-Id: I09e7c6be401bb54e1314da95d6797790aedefbe1 Reviewed-on: https://gerrit.libreoffice.org/64795 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-08reduce the amount of senseless exceptions during document loadMarkus Mohrhard
Change-Id: If9d0a0539002c013f077b8fb692de4c29ca032b7 Reviewed-on: https://gerrit.libreoffice.org/64791 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-12-07loplugin:singlevalfields extend to all static varsNoel Grandin
Change-Id: Ic238bb5291539fd1b7e98cb4afc9b25f37e7d528 Reviewed-on: https://gerrit.libreoffice.org/64710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScCellFormatsObj. Change-Id: I5ef1e789a535af55705c3a39f07a9396666adbed Reviewed-on: https://gerrit.libreoffice.org/64648 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05Make Application::SetDialogCancelMode "private"Jan-Marek Glogowski
Change callers to Application::EnableHeadlessMode instead except for the Frame dispose sequence, which has to disable a fatal mode temporary. Since Frame is not a unique identifier, rename it to XFrameImpl, otherwise we get a "non-unique" compile error for other files. When we update our gcc baseline, we should be able to forward declare and friend XFrameImpl and really make it private. Change-Id: Ifcad0355adade8f6539ec092b174dd70af8352c2 Reviewed-on: https://gerrit.libreoffice.org/64050 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-05loplugin:unnecessaryparen include more assignmentsNoel Grandin
Change-Id: I9fb8366634b31230b732dd38a98f800075529714 Reviewed-on: https://gerrit.libreoffice.org/64510 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05tdf#45904 Move XRefreshable Java tests to C++Jens Carl
Move XRefreshable Java tests to C++ for ScDDELinkObj. Change-Id: I121d9fe6a66c549e402b0cf6fd54fea1201e443f Reviewed-on: https://gerrit.libreoffice.org/64511 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-03tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScLabelRangesObj. Change-Id: Icf49fb7e8c24b169e4fe33ffed8cc1412d21f9e8 Reviewed-on: https://gerrit.libreoffice.org/64432 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-03tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: Id7af9a6eaefc8b49a790eb299620c4fa97067a11 Reviewed-on: https://gerrit.libreoffice.org/64429 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-02tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScAnnotationsObj. Change-Id: Ife8c2d51a3aae409fa008c5ad2515a8976481771 Reviewed-on: https://gerrit.libreoffice.org/64407 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java test to C++ for ScAreaLinksObj. Change-Id: I374b7301caf67c900b7a64920d2ac5b642a8c6fd Reviewed-on: https://gerrit.libreoffice.org/64376 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScCellsObj. Change-Id: If721582a36ef5a82fba20d4ec7e0806d1d0524d9 Reviewed-on: https://gerrit.libreoffice.org/64365 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-29tdf#42949 Fix IWYU warnings in include/vcl/[i-m]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If1b2e04872eb0dd6725802c1709a9085f4cd8c91 Reviewed-on: https://gerrit.libreoffice.org/64141 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-29remove unnecessary "if (!empty()" checks before loopsNoel Grandin
found with git grep -n -A4 'if.*!.*empty' | grep -B3 -P '(\bfor)|(\bwhile)|(\bdo)' Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334 Reviewed-on: https://gerrit.libreoffice.org/64169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28Fix typo deactiveAndrea Gelmini
Change-Id: I68a87a9435784f949f1e7b730270641bd8e05b43 Reviewed-on: https://gerrit.libreoffice.org/63149 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28drop some unnecessary includesCaolán McNamara
Change-Id: I474b5762e6a07982fddc0315a67181399ea4c30e Reviewed-on: https://gerrit.libreoffice.org/64156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27tdf#42949 Fix IWYU warnings in include/vcl/[f-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ice2eb8c5994bf2ccb88972332ca4a1d3ed41752a Reviewed-on: https://gerrit.libreoffice.org/63826 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I8d98aa7dd77fbd79611b8a4aba77e8c378fd1cae Reviewed-on: https://gerrit.libreoffice.org/63981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-21tdf#42949 Fix IWYU warnings in include/vcl/[B-E]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca Reviewed-on: https://gerrit.libreoffice.org/63623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_TableChartsEnumeration. Change-Id: Ibbfcf9ec92c3bae4d6add044d2e62472f32d801e Reviewed-on: https://gerrit.libreoffice.org/63678 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20tdf#121537 Add testSamuel Mehrbrodt
Change-Id: Ifdf46dc79f9b3e2b5ab4c9635619a9d7f598affc Reviewed-on: https://gerrit.libreoffice.org/63654 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-20Actually run CheckXTitle testsSamuel Mehrbrodt
@Test annotation was missing Change-Id: I9e58026e5e131b18e35ab81d7927905316b58f11 Reviewed-on: https://gerrit.libreoffice.org/63653 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-20tdf#121537 Display SuggestedSaveAsName in title if setSamuel Mehrbrodt
Change-Id: I762eb7766a5cbe788c0a360c8a6f37b9b1106412 Reviewed-on: https://gerrit.libreoffice.org/63639 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java test to C++ for ScIndexEnumeration_SubTotalFieldsEnumeration. Change-Id: Ibe2b283e99230c5e517eb80858ff31459f2c9844 Reviewed-on: https://gerrit.libreoffice.org/63627 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20Drop some headless mode variantsJan-Marek Glogowski
This fixes OSX "make debugrun" by dropping VCL_HIDE_WINDOWS handling and removing the internal GetPseudoHeadless() API. While at it moves the DialogCancelMode enum out of Application. Change-Id: I4876e752ddbfc39dd44faa673fb0e97810089a75 Reviewed-on: https://gerrit.libreoffice.org/61598 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_SpreadsheetViewPanesEnumeration. Change-Id: I03c05cd894bf84816618ac28deb01ecb2fd8779e Reviewed-on: https://gerrit.libreoffice.org/63622 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_SpreadsheetsEnumeration. Change-Id: Id6fbc4dab54e2b50be42df7ade912a5aaf1cb97c Reviewed-on: https://gerrit.libreoffice.org/63621 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_TableAutoFormatEnumeration. Change-Id: Ibe9f4cffaecc4f3fada04f82425031e6773b32d7 Reviewed-on: https://gerrit.libreoffice.org/63619 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>