summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2019-04-09[API CHANGE] Asserts to never clear already cleared guardMike Kaganski
... which could help catch copy-paste errors when wrong guard is cleared second time. Also an assert added that when resetting, there's something to reset (i.e., no descendant class had cleared protected pResetT, making reset impossible, and thus actually unable to guard anything). framework/source/layoutmanager/layoutmanager.cxx: made sure to not call clear() second time framework/source/layoutmanager/toolbarlayoutmanager.cxx: restored lock lost in commit 777bc22ca6490a4300f30fc1b45287dce789a36f forms/source/misc/InterfaceContainer.cxx: removed a leftover from commit a19cd21e3c03559877428315bebc0ceaf367a461 which reduced guarded scope forms/source/component/DatabaseForm.cxx: fixed clear-reset sequence broken from the initial commit bf4154eb5307ec8c35f000fd1df39ef3abb2eb6d Change-Id: Ibab6660c79561eee31faf3e6c1128ab141a7e8a3 Reviewed-on: https://gerrit.libreoffice.org/70381 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-07Don't use resettable/clearable guard where plain guard is enoughMike Kaganski
Also use scope where possible. This allows to limit guard scope at language level; visualises the scope clearly; and helps avoiding errors like fixed in commit 61e4437c857854b331fa01da6f39b2b3b58a800b. Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41 Reviewed-on: https://gerrit.libreoffice.org/70376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-07Clear correct guardMike Kaganski
Change-Id: I3f3ab91c10f3077d61a8fd0c351be75cf2e63963 Reviewed-on: https://gerrit.libreoffice.org/70375 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-06Simplify: avoid OUString copy() and get just needed tokensMatteo Casalin
Change-Id: I708f222e408223cfaeaac56f87d68375f1d0503f Reviewed-on: https://gerrit.libreoffice.org/69237 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-04-05Remove unused using declarations in directories [e-l]*Gabor Kelemen
Found by: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: Iee4e9df37d4c971ea97256d041afbc3d3aaa3d27 Reviewed-on: https://gerrit.libreoffice.org/70027 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-03Fix typosJens Carl
Change indefinite article "an" to "a" before the word unique and some variants. Change-Id: Ia14a6f3b9ec6b257ad8bed3b089faa9b6f07d44f Reviewed-on: https://gerrit.libreoffice.org/70174 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03tdf#45904 Move XCellRange Java tests to C++Jens Carl
Move XCellRange Java tests to C++ for ScTableRowObj. Change-Id: I2735779cae777c5af4e622bc1b538df2d8bf70df Reviewed-on: https://gerrit.libreoffice.org/70163 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-02tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScAutoFormatObj. Change-Id: I01ad72f7f48b3626085203ceac4f49bca847cdab Reviewed-on: https://gerrit.libreoffice.org/70097 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-25new loplugin:unoqueryNoel Grandin
look for places we are doing code like: Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty() which might result in a SIGSEGV is the query fails Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e Reviewed-on: https://gerrit.libreoffice.org/69044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-21tdf#121671 Floating toolbars remain their position after reopenIlhan Yesil
Calculate the relative position of the floating toolbars by calling the ImplCallMove function, where the current position is read from the real window. Change-Id: I6a142055c3340dda2339980fbc5a7ebb431e228b Reviewed-on: https://gerrit.libreoffice.org/64093 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-20Simplify: avoid OUString copy() and get just needed tokensMatteo Casalin
Change-Id: I10c4b59cce39bc4e436d26d8a1d391cb2ec4a922 Reviewed-on: https://gerrit.libreoffice.org/69236 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-17tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScAutoFormatsObj. Change-Id: I2cbf6dd7f8dd77da51e20c5f60f19d300ecae62e Reviewed-on: https://gerrit.libreoffice.org/69350 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-15tdf#45904 Move XTableColumns Java tests to C++Jens Carl
Move XTableColumns Java tests to C++ for ScTableColumnsObj. Change-Id: Iead7ca3d7c07820086f75d86833b7bfc97978751 Reviewed-on: https://gerrit.libreoffice.org/69286 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-14Use indexed getToken()Matteo Casalin
Change-Id: Ie6a69f8d7630fefd18404c7a93e2d38bd06e3d16 Reviewed-on: https://gerrit.libreoffice.org/69238 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-13tdf#124042: There are no progress bars that vcl would handle on iOS or AndroidTor Lillqvist
Don't even bother trying to dislay such. Any progress feedback to the user will be handled through LibreOfficeKit callbacks. (Sure, the code probably thought it had created a "window" for the progress bar, but there wasn't anything real in the data structure that would actually display anything anywhere, no CG context (on iOS) etc.) Change-Id: Ie0ca18bbb22da41882bdaba4a0ce77a52112a059
2019-03-13tdf#45904 Move XNameReplace Java tests to C++Jens Carl
Move XNameReplace Java tests to C++ for ScStyleFamilyObj. Fixes i#23594 by creating a new "com.sun.star.style.CellStyle" rather then using an existing one. Change-Id: Ie42e627020aff475173af5bc014bc28d7a11ec56 Reviewed-on: https://gerrit.libreoffice.org/69140 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-09loplugin:unusedmethodsNoel Grandin
Change-Id: I242f56f2bc5dc8fce6db1ba8f1f8269da4fec0fa Reviewed-on: https://gerrit.libreoffice.org/68938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06loplugin:unnecessaryparen improve member expressionNoel Grandin
Change-Id: I304621018cb1e2a47e478e86df4229bcf2176741 Reviewed-on: https://gerrit.libreoffice.org/68757 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScDataPilotFieldObj. Change-Id: I9fa5d153cced1aae8892d2422025dfcdcda73c69 Reviewed-on: https://gerrit.libreoffice.org/68782 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-03tdf#45904 Move XTextRange Java tests to C++Jens Carl
Move XTextRange Java tests to C++ for ScAnnotationObj (also fixes i109517). Change-Id: Id7e45d9f1159b45fb267cb28dc875b62eae12e24 Reviewed-on: https://gerrit.libreoffice.org/68634 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-01clang-format DispatchHelperSamuel Mehrbrodt
To reduce excessive whitespace in function definitons Change-Id: I8dbf58e5ba53ddcf6c5a8e212636c1306584aa2e Reviewed-on: https://gerrit.libreoffice.org/68533 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-01Use lambda instead of std::bind + wrapper functionSamuel Mehrbrodt
Change-Id: I52ef7c61d615120b172268b78827affa9b5f8f96 Reviewed-on: https://gerrit.libreoffice.org/68532 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-27CppunitTest_framework_dispatch: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: I2de32f700125fc8306c16fe4963ef76f87b0034c Reviewed-on: https://gerrit.libreoffice.org/68435 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-24loplugin:unusedfields in frameworkNoel Grandin
Change-Id: I7c633bf3e217a71c51bd3781fe716cb06fe92b0c Reviewed-on: https://gerrit.libreoffice.org/68227 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-19tdf#42949 Fix IWYU warnings in include/framework/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia9616f644a68ec6da22e646ba0d919a3489a9481 Reviewed-on: https://gerrit.libreoffice.org/67745 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-19MSForms: Fix a regression in inplace menu handlingTamás Zolnai
We should not call implts_resetInplaceMenuBar() unconditionally. The problem which was fixed by that call can be solved by setting m_bInplaceMenuSet to false, which is the proper solution. So after the menu cleared up (inplace menu too), this indicator flag also contains the right value. Regression from: dc3a2546bd0ad0afe20cba9940934405174fd593 Change-Id: I85243417eb273629cc57b762b98fdd32dc9b1dd5 Reviewed-on: https://gerrit.libreoffice.org/68009 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-18Simplify containers iterations in [f-l]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: Ib3fab47318d1bfbb4df8f886a8cd9596525a420f Reviewed-on: https://gerrit.libreoffice.org/67914 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-16MSForms: Introduce a new Forms menu which is compatible with MS WordTamás Zolnai
* It's a Writer only menu by now * Displayed when the compatibility option is set * The menubar is changed during creation, so the option has an effect only after a restart. * MS compatible Forms menu contains only some ActiveX controls now Change-Id: I459f489c15ea7a25514f379b1800b926cc2087ce Reviewed-on: https://gerrit.libreoffice.org/67904 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16MSForms: Extract menu creation to a separate methodTamás Zolnai
No functional change is intended. Change-Id: Ieb88e746b08c6a6daac14c08a206db73cbeef8a9 Reviewed-on: https://gerrit.libreoffice.org/67903 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-15loplugin:simplifybool extend to !(a == b) where comparison an overloaded opNoel Grandin
Change-Id: I08fcbe2569c07f5f97269ad861fa6d38f23a7cc7 Reviewed-on: https://gerrit.libreoffice.org/67816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11new loplugin writeonlyvarsNoel Grandin
largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09loplugin:indentation in frameworkNoel Grandin
Change-Id: I9d0ef502eb812499b0372436083f673bb19ff578 Reviewed-on: https://gerrit.libreoffice.org/67557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-05tdf#42949 Fix IWYU warnings in include/svtools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I937ed12f2a96943664087ddcdd035f1347e84a57 Reviewed-on: https://gerrit.libreoffice.org/67102 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-02tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScDataPilotFieldsObj. Change-Id: I4b8bf204ccf4229ee5c57c03caef9fa5459e28a8 Reviewed-on: https://gerrit.libreoffice.org/67269 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-30tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScSpreadsheetSettingsObj. Change-Id: I59da149983ee3b897c1cdeaf5f40962b917c91ba Reviewed-on: https://gerrit.libreoffice.org/67101 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29framework: allow dispatching a command on the main threadMiklos Vajna
This is similar to commit 2dc3a6c273cb82506842864481d78df7294debbf (framework: allow loading a component on the main thread, 2018-12-19), just it allows saving (via .uno:Save) and other commands operating in a similar environment. The use-case is that once a document is loaded on the main thread (see commit message of the above mentioned commit), then saving also has to happen on the main thread, or OLE objects on Windows may be lost. Change-Id: I7321659550b556e96085ac20f197a87d5d13f1ed Reviewed-on: https://gerrit.libreoffice.org/67089 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-29framework: avoid crashing in ~HandlerCFGAccess() in atexit()Michael Stahl
Commit d587931fba77246db3a2ccc6ab61ca77446d23f4 changed HandlerCache::s_pConfig to a unique_ptr, which may now crash on shutdown because it's a utl::ConfigItem and by atexit() time the configmgr is long gone. Due to the HandlerCache::m_nRefCount, the crash probably only happens in case of an unclean shutdown, but we don't know whether this can happen in practice or not, so just avoid crashing on shutdown. Change-Id: Ifd2b782aa5592c344d1bc85acaa434c3f2a69b60 Reviewed-on: https://gerrit.libreoffice.org/67029 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-29tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScFilterDescriptorBase. Change-Id: I86a16f3c53a5aacea0ce88a54ec8b340d13dff4f Reviewed-on: https://gerrit.libreoffice.org/67038 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-28Fix icon load error for uno commands with paramsMuhammet Kara
Change-Id: I31e4c28322a3492a603bce5c7226e2dbcf131173 Reviewed-on: https://gerrit.libreoffice.org/66980 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-25tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScSpreadsheetSettings. Change-Id: Id969a566fcb4e544c26a4097e0f49a01bc967ad7 Reviewed-on: https://gerrit.libreoffice.org/66926 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-25tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScTableValidationObj. Change-Id: If058f40ff73203d2705bf9841d0496d52ff93ed8 Reviewed-on: https://gerrit.libreoffice.org/66890 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-24tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScSheetLinksObj. Change-Id: Ibe4571cf75abf96edc4361d884c63be0a972cab2 Reviewed-on: https://gerrit.libreoffice.org/66819 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-23tdf#45904 Clean up _XDrawPageSummarizer Java testsJens Carl
The XDrawPageSummarizer interface is deprecated since commit d081c80877dc1ae413b9d65c206485b6821d0ef8 Change-Id: I041c5d5df11d1b5208b846c76ef82427c4df4585 Reviewed-on: https://gerrit.libreoffice.org/66757 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-21o3tl::make_unique -> std::make_unique in dbaccess...frameworkGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Iad5a422bc5a7da43d905edc91d1c46793332ec5e Reviewed-on: https://gerrit.libreoffice.org/66545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScDDELinksObj. Change-Id: I91d8ea1b51cde36996847371a03406b899e23d79 Reviewed-on: https://gerrit.libreoffice.org/66559 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-17tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScTableConditionalFormat. Change-Id: Ib2575920e05d56feed68c6f4c15b485ab7993600 Reviewed-on: https://gerrit.libreoffice.org/66488 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-16tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScStyleFamiliesObj. Change-Id: I0c21e35f1c303bb430010b51795285c0a2e7e283 Reviewed-on: https://gerrit.libreoffice.org/66347 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-14tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScDataPilotTablesObj. Change-Id: I43bd4ca0688e38792080710c288ca746f95460d9 Reviewed-on: https://gerrit.libreoffice.org/66273 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-13tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScDatabaseRangesObj. Change-Id: Id54f9bc1a9215a4524be4a1f52800049ce438c8a Reviewed-on: https://gerrit.libreoffice.org/66250 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
generated by cgit (git 2.34.1) at 2025-03-13 13:56:17 +0000