summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2018-12-08use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-08tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScCellFieldsObj. Change-Id: I09e7c6be401bb54e1314da95d6797790aedefbe1 Reviewed-on: https://gerrit.libreoffice.org/64795 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-08reduce the amount of senseless exceptions during document loadMarkus Mohrhard
Change-Id: If9d0a0539002c013f077b8fb692de4c29ca032b7 Reviewed-on: https://gerrit.libreoffice.org/64791 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-12-07loplugin:singlevalfields extend to all static varsNoel Grandin
Change-Id: Ic238bb5291539fd1b7e98cb4afc9b25f37e7d528 Reviewed-on: https://gerrit.libreoffice.org/64710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScCellFormatsObj. Change-Id: I5ef1e789a535af55705c3a39f07a9396666adbed Reviewed-on: https://gerrit.libreoffice.org/64648 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05Make Application::SetDialogCancelMode "private"Jan-Marek Glogowski
Change callers to Application::EnableHeadlessMode instead except for the Frame dispose sequence, which has to disable a fatal mode temporary. Since Frame is not a unique identifier, rename it to XFrameImpl, otherwise we get a "non-unique" compile error for other files. When we update our gcc baseline, we should be able to forward declare and friend XFrameImpl and really make it private. Change-Id: Ifcad0355adade8f6539ec092b174dd70af8352c2 Reviewed-on: https://gerrit.libreoffice.org/64050 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-05loplugin:unnecessaryparen include more assignmentsNoel Grandin
Change-Id: I9fb8366634b31230b732dd38a98f800075529714 Reviewed-on: https://gerrit.libreoffice.org/64510 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05tdf#45904 Move XRefreshable Java tests to C++Jens Carl
Move XRefreshable Java tests to C++ for ScDDELinkObj. Change-Id: I121d9fe6a66c549e402b0cf6fd54fea1201e443f Reviewed-on: https://gerrit.libreoffice.org/64511 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-03tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScLabelRangesObj. Change-Id: Icf49fb7e8c24b169e4fe33ffed8cc1412d21f9e8 Reviewed-on: https://gerrit.libreoffice.org/64432 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-03tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: Id7af9a6eaefc8b49a790eb299620c4fa97067a11 Reviewed-on: https://gerrit.libreoffice.org/64429 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-02tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScAnnotationsObj. Change-Id: Ife8c2d51a3aae409fa008c5ad2515a8976481771 Reviewed-on: https://gerrit.libreoffice.org/64407 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java test to C++ for ScAreaLinksObj. Change-Id: I374b7301caf67c900b7a64920d2ac5b642a8c6fd Reviewed-on: https://gerrit.libreoffice.org/64376 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScCellsObj. Change-Id: If721582a36ef5a82fba20d4ec7e0806d1d0524d9 Reviewed-on: https://gerrit.libreoffice.org/64365 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-29tdf#42949 Fix IWYU warnings in include/vcl/[i-m]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If1b2e04872eb0dd6725802c1709a9085f4cd8c91 Reviewed-on: https://gerrit.libreoffice.org/64141 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-29remove unnecessary "if (!empty()" checks before loopsNoel Grandin
found with git grep -n -A4 'if.*!.*empty' | grep -B3 -P '(\bfor)|(\bwhile)|(\bdo)' Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334 Reviewed-on: https://gerrit.libreoffice.org/64169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28Fix typo deactiveAndrea Gelmini
Change-Id: I68a87a9435784f949f1e7b730270641bd8e05b43 Reviewed-on: https://gerrit.libreoffice.org/63149 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28drop some unnecessary includesCaolán McNamara
Change-Id: I474b5762e6a07982fddc0315a67181399ea4c30e Reviewed-on: https://gerrit.libreoffice.org/64156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27tdf#42949 Fix IWYU warnings in include/vcl/[f-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ice2eb8c5994bf2ccb88972332ca4a1d3ed41752a Reviewed-on: https://gerrit.libreoffice.org/63826 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I8d98aa7dd77fbd79611b8a4aba77e8c378fd1cae Reviewed-on: https://gerrit.libreoffice.org/63981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-21tdf#42949 Fix IWYU warnings in include/vcl/[B-E]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca Reviewed-on: https://gerrit.libreoffice.org/63623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_TableChartsEnumeration. Change-Id: Ibbfcf9ec92c3bae4d6add044d2e62472f32d801e Reviewed-on: https://gerrit.libreoffice.org/63678 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20tdf#121537 Add testSamuel Mehrbrodt
Change-Id: Ifdf46dc79f9b3e2b5ab4c9635619a9d7f598affc Reviewed-on: https://gerrit.libreoffice.org/63654 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-20Actually run CheckXTitle testsSamuel Mehrbrodt
@Test annotation was missing Change-Id: I9e58026e5e131b18e35ab81d7927905316b58f11 Reviewed-on: https://gerrit.libreoffice.org/63653 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-20tdf#121537 Display SuggestedSaveAsName in title if setSamuel Mehrbrodt
Change-Id: I762eb7766a5cbe788c0a360c8a6f37b9b1106412 Reviewed-on: https://gerrit.libreoffice.org/63639 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java test to C++ for ScIndexEnumeration_SubTotalFieldsEnumeration. Change-Id: Ibe2b283e99230c5e517eb80858ff31459f2c9844 Reviewed-on: https://gerrit.libreoffice.org/63627 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20Drop some headless mode variantsJan-Marek Glogowski
This fixes OSX "make debugrun" by dropping VCL_HIDE_WINDOWS handling and removing the internal GetPseudoHeadless() API. While at it moves the DialogCancelMode enum out of Application. Change-Id: I4876e752ddbfc39dd44faa673fb0e97810089a75 Reviewed-on: https://gerrit.libreoffice.org/61598 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_SpreadsheetViewPanesEnumeration. Change-Id: I03c05cd894bf84816618ac28deb01ecb2fd8779e Reviewed-on: https://gerrit.libreoffice.org/63622 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_SpreadsheetsEnumeration. Change-Id: Id6fbc4dab54e2b50be42df7ade912a5aaf1cb97c Reviewed-on: https://gerrit.libreoffice.org/63621 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_TableAutoFormatEnumeration. Change-Id: Ibe9f4cffaecc4f3fada04f82425031e6773b32d7 Reviewed-on: https://gerrit.libreoffice.org/63619 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_SheetCellRangesEnumeration. Change-Id: Ic3bc6f38244c4f476d29826accc397b4b6902f31 Reviewed-on: https://gerrit.libreoffice.org/63605 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_FunctionDescriptionEnumeration. Change-Id: I6c15abff293996a6bac8e4a6c0004853fae13990 Reviewed-on: https://gerrit.libreoffice.org/63604 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-19tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_DatabaseRangesEnumeration. Change-Id: I33fac410b4b05f88dad45f859ae466fabb8303fc Reviewed-on: https://gerrit.libreoffice.org/63592 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-19tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_CellAreaLinksEnumeration. Change-Id: I0cbb97689522d9ff5d3ba0799b6d1e3f215cf533 Reviewed-on: https://gerrit.libreoffice.org/63590 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-19tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_CellAnnotationsEnumeration. Change-Id: I06ad265c09fa4c29e056527c79c0470634abaabc Reviewed-on: https://gerrit.libreoffice.org/63549 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-18tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_NamedRangesEnumeration. Change-Id: I7cbe9fbeddd4d8ecbccddfdfd14cdcae01a06684 Reviewed-on: https://gerrit.libreoffice.org/63517 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-18tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I60bb778a88dd5619efd4858eb74d56d28616c777 Reviewed-on: https://gerrit.libreoffice.org/63520 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-18tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_LabelRangesEnumeration. Change-Id: I89c24de2323a2507fd5c1639af72c6b7121e77c9 Reviewed-on: https://gerrit.libreoffice.org/63516 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-18tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_SheetLinksEnumeration. Change-Id: I19bd376cc7921c9dcb7b08394c9c299c336921e3 Reviewed-on: https://gerrit.libreoffice.org/63511 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-18tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_DataPilotTablesEnumeration. Change-Id: I6f5f8439b50cdf313b00f9dd69b780d654b5cdb4 Reviewed-on: https://gerrit.libreoffice.org/63507 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-18tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_DataPilotFieldsEnumeration. Change-Id: Iac7c60c3971756bcc47fc68a4aa86b442af266c5 Reviewed-on: https://gerrit.libreoffice.org/63506 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-17Fix typosAndrea Gelmini
Change-Id: Ic7a29f572ce4c42cc88e5d45ebbb774c4b21aaa0 Reviewed-on: https://gerrit.libreoffice.org/63488 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-17Fix typosAndrea Gelmini
Change-Id: Ie41eaccb9a70769e43b945595039f6f598e78c8a Reviewed-on: https://gerrit.libreoffice.org/63489 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-17Adapt to C++2a char_tStephan Bergmann
u8 literals incompatibly change their type (as implemented by recent Clang trunk) Change-Id: Ia4f7b91f5d86656a056303d2754981ab2093a739 Reviewed-on: https://gerrit.libreoffice.org/63494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-17tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_TableConditionalEntryEnumeration. Change-Id: I205a224160af39bba611cc4af76286082dd7966f Reviewed-on: https://gerrit.libreoffice.org/63486 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-17tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_TableColumnsEnumeration. Change-Id: Id4a3f78942b3bed2a09f617b961507a01374f455 Reviewed-on: https://gerrit.libreoffice.org/63485 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-17tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_TextFieldEnumeration. Change-Id: I92e8c4779a22b6da1dabf5a24bbb76fe20ec398c Reviewed-on: https://gerrit.libreoffice.org/63484 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-16Fix typosAndrea Gelmini
Change-Id: I25660634dcb9ebb31292275e31ed7a047e4ddd25 Reviewed-on: https://gerrit.libreoffice.org/63474 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-16Fix typosAndrea Gelmini
Change-Id: I63b3cdae2dfb4442d10430d9041145f892b31967 Reviewed-on: https://gerrit.libreoffice.org/63480 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-15tdf#45904 Move XEnumeration Java test to C++Jens Carl
Move XEnumeration Java tests for ScIndexEnumeration_ScenariosEnumeration to C++; Change-Id: Ia778f644cbb2836e6c6bfc12ae389cda3420e5b2 Reviewed-on: https://gerrit.libreoffice.org/63399 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-15tdf#45904 Move XEnumeration tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_DDELinksEnumeration. Change-Id: I586fbd67f6c862f529461265536e68fea84b8c17 Reviewed-on: https://gerrit.libreoffice.org/63394 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>