Age | Commit message (Collapse) | Author |
|
and drop DATACHANGED_DATETIME because no-one is using it
Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
|
|
- remove the SHORT_WAIT test parameter, no-one is using it
- inline the various independent shortWait() methods
- use the util.utils.shortWait() utility method everywhere
Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
|
|
since all of it's methods and fields are static.
Change-Id: Ia2b652969489c5a21e01a35cda65c6e84346aac0
|
|
and remove the need to worry about keeping indexes correct
Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
|
|
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
|
|
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
|
|
In framework/inc/stdtypes.h. class OUStringList.
Removed inheritance and separated additional functionality into more general
functions. Changed to using std::vector<OUString> rather than SequenceAsVector.
The functions now work for any vector. Although they could be made more general
and support any container by altering the arguments.
Change-Id: I472267029dc69da1ad0a98d55e26e3784f6b07cd
Reviewed-on: https://gerrit.libreoffice.org/13612
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f
Reviewed-on: https://gerrit.libreoffice.org/13733
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
|
|
Beside scope changes, it fixes lack of initialization in a few places.
Change-Id: Ia09fdb9845d8ac17256330a5ec5168401c84f0f2
Reviewed-on: https://gerrit.libreoffice.org/13755
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I4c9e5f754974b6726fc86bc87775ba81832b3984
|
|
gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1)
framework/source/fwe/classes/addonsoptions.cxx: In member function ‘void framework::AddonsOptions_Impl::ReadAndAssociateImages(const rtl::OUString&, const rtl::OUString&)’:
framework/source/fwe/classes/addonsoptions.cxx:267:16: error: array subscript is above array bounds [-Werror=array-bounds]
struct ImageEntry
^
The combination of aScaled[2]; aImage[2]; aURL[2] in sequence apparently lead
to some overoptimization and/or alignment problem, already declaring aImage[3]
helped (but not aScaled[3]), but that's not what we want.
Change-Id: I82e28d4887ab8072a17d0a9341d322c1cf61aedc
|
|
Change-Id: I54f9019297913683605b5aea9f79b3defc1dcc13
|
|
found by CodePro
Change-Id: If1b75e43f81d70984422e437147048a491395b66
|
|
found by looking for unused parameters (in Eclipse)
Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
|
|
found by PMD
Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
|
|
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
|
|
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
|
|
Change-Id: Id697b3b799c7437d937de6534edf88083e5c4dfd
|
|
Found by FindBugs.
Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
|
|
It is just being used as a Runnable
Change-Id: I1e652ab0f3b0450d3a85384b9dd513419e2f8046
|
|
Change-Id: I5da5cd3254102c742021b3e7b4e1f907ca897ca5
|
|
This addresses some cppcheck warnings.
Change-Id: I57f336c6ab3c418eac82397edeadecb4c1b168a7
Reviewed-on: https://gerrit.libreoffice.org/13495
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I72bb5ff2ab8a55061072fde567fcc1c4a8e20a2f
|
|
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6
Reviewed-on: https://gerrit.libreoffice.org/13408
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3
Reviewed-on: https://gerrit.libreoffice.org/13406
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
|
|
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
|
|
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
|
|
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
|
|
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
|
|
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
|
|
The timer could run after the ToolBarManager is deleted because the
dispose() method can accidentally restart the timer somehow.
Change-Id: I86868f08f436976761e814d4cea1cd5a0e348935
|
|
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
|
|
Change-Id: I9a426f40f8cdce1f1ebe207dd9ada8154d8fde46
Reviewed-on: https://gerrit.libreoffice.org/12195
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
|
|
Change-Id: Ide0ea8f8ff145d487e409b0091918b59f1f83405
|
|
Change-Id: I9e5bff735b0035c147e10ae066da3a4873d66749
|
|
We are experimenting with a pruned configuration database in the desktop case,
and letting the exception propagate here killed the document loading.
Change-Id: I59e5d016617c17c2bc36de2fd69c6691bfa6b135
|
|
Change-Id: I20049b482c831e4ac2221fddfe80deb9847e72c3
|
|
Removing the duplicate code,and consolidating changes
by using method "getExpandedFilePath" of comphelper.
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>: adapted to recent change
from comphelper::getExpandedFilePath to comphelper::getExpandedUri; fixed the
two changes in framework to actually modify the by--non-const--ref argument;
fixed a loplugin:unreffun. More clean-up to follow.
Change-Id: Ie8875bcb61b616385bd64151f0a915bf7cce04e5
|
|
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f
Reviewed-on: https://gerrit.libreoffice.org/13134
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I7df5ff730436b95cb93af9f813d7bc572da2b951
Reviewed-on: https://gerrit.libreoffice.org/13098
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873
Reviewed-on: https://gerrit.libreoffice.org/13097
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If89443c1668ca01c826c8fc353b20097c7da7bf4
|
|
This reverts commit b0a7722ebfa720255b6ce1e383a3aacae0ce5e9f, now that
fced31697bcc2a2a4da34d804582002de0320302 "comphelper::SequenceAsHashMap: throw
IllegalArgumentException" made the underlying problem go away.
Conflicts:
framework/source/services/modulemanager.cxx
Change-Id: I6599cf25d4f28d2bab19da67d5de5caacd84a622
|
|
This reverts commit 0a87f4ad1a45aaaaad885a1418d0d6bed21db456, now that
fced31697bcc2a2a4da34d804582002de0320302 "comphelper::SequenceAsHashMap: throw
IllegalArgumentException" made the underlying problem go away.
Conflicts:
framework/source/inc/loadenv/loadenv.hxx
framework/source/loadenv/loadenv.cxx
Change-Id: Id2f468bf0f24f5a8a7a0e6eb113ccfedd35b03cc
|
|
This reverts commit ecd00991fd5884cd769ed00c9c3f42ba44d64511, now that
fced31697bcc2a2a4da34d804582002de0320302 "comphelper::SequenceAsHashMap: throw
IllegalArgumentException" made the underlying problem go away.
Conflicts:
framework/source/inc/loadenv/loadenv.hxx
framework/source/loadenv/loadenv.cxx
Change-Id: I7821ae67b5cc99b8591fbf06396ac20098e55c8d
|