summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2023-06-15tdf#155699 - MRU: show pinned documents at the beginning of the listAndreas Heinisch
Change-Id: Id08678708ee74a4a278baa1e67930044f25e5d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152690 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-06-06use more officecfg for SvtMiscOptionsNoel Grandin
Change-Id: I6c87025fc0997b5edbc085fc88333fe9e150eb3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-06SvtCommandOptions only supports CMDOPTION_DISABLEDNoel Grandin
CMDOPTION_NONE is just ignored, so remove this parameter Change-Id: If9de22a6b0522620a267cbc92b118f79e200d999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152671 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-31do not throw DisposedException when inside a dispose() methodNoel Grandin
There is no need to do this, as the documentation of css.lang.XComponent::dispose at udkapi/com/sun/star/lang/XComponent.idl states: After this method has been called, the object should behave as passive as possible, thus it should ignore all calls Otherwise, the effect of throwing here is mostly to disturb the flow of logic in caller code, preventing other parts of teardown from proceeding smoothly. Change-Id: I30e6d1b35f85b727debf4405a995fdc0a4fccde6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152450 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-25merge some stringaddsNoel Grandin
found with a lightly tweaked version of the loplugin:stringadd and some hand-holding. Change-Id: I146aadcaf665e98fea89a9cad2df4dc3935622f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-25[API CHANGE] remove XModuleUIConfigurationManager3 and XUIConfigurationManager3Miklos Vajna
The motivation was to not modify XModuleUIConfigurationManager / XUIConfigurationManager, but as pointed out at <https://gerrit.libreoffice.org/c/core/+/151798/10#message-31d00a775989b981a5f50639623cc773d6ea930d>, it may be fine to modify XModuleUIConfigurationManager2 and XUIConfigurationManager2 instead of adding XModuleUIConfigurationManager3 and XUIConfigurationManager3. Indeed, searching for usage in <https://github.com/libreoffice/wollmux>, only the published interfaces are used, so let's fold XModuleUIConfigurationManager3 into XModuleUIConfigurationManager2 and XUIConfigurationManager3 into XUIConfigurationManager2. This is a reasonable middle ground between 0 API change and breaking known users of the public API. Change-Id: I2dedee7e255f9dda9c9057961e6c829f83b2b709 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152254 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-23[API CHANGE] Add createShortCutManager function to uiconfigurationmanager.Gökay Şatır
We need to have different accelerator classes for differnt languages. This PR creates a new accelerator class for different languages. Since current code uses single instance for accelerators, i needed to add a create function. Also we now have an unordered map for different languages and modules. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147157 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148680 Tested-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: Ia646f20b3206f430ece614fc127e8b748044e4c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151798 Tested-by: Jenkins
2023-05-13simplifyNoel Grandin
no need to use a map here, a set will do Change-Id: I8e8b35f390ffba5b7da6caa52eb3e33d3b50d354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-07framework/taskcreator: declare ARGUMENT_HIDDENFORCONVERSION and use itJulien Nabet
Change-Id: Ie4e8c24bf776d0ba0e1b7f986fd506521816d2e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151477 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-07Simplify some initializations in framework/source/classes/taskcreator.cxxJulien Nabet
Change-Id: I56480780903a39534c3bab8e79e3864fcba10470 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151473 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-07framework/inc/taskcreatordefs.hxx: these are bool and not sal_Bool (2)Julien Nabet
Thank you Mike for having spotted it! :-) Change-Id: I210edf2e05eb6ba02ac9cdd999c4f2233819cfa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151476 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-07framework/inc/taskcreatordefs.hxx: these are bool and not sal_Bool since 2014Julien Nabet
See a6287e21f1dab6ae382c24ceeb4c0212b7cad2d7 "framework: sal_Bool->bool" + /opt/lo/bin/clang-format -i framework/inc/taskcreatordefs.hxx as requested when submitting patch with logerrit Change-Id: Icb21563590a4104f3cb678db44fc4b5f1d884764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151475 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-07Typo: freature->featureJulien Nabet
Change-Id: Ia30740ce0422b2fe5a85e288f18de68a1dca9b33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151474 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-07improve some usage of OInterfaceIteratorHelper4Noel Grandin
we can drop the lock immediately after construction (since the iterator holds a thread-safe COW link to the underlying listener container) Change-Id: I08f8fa9ed7393747938572097f3c25f5f3f847fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-28survive exporting to pdf without config for fuzzingCaolán McNamara
Change-Id: I229f25a8a15b21257756ecfa008b9e99681003c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-28remove dodgy code in OReadToolBoxDocumentHandlerNoel Grandin
comparing hashcodes without doing an actual comparison is not safe. Code was like this since commit 6845330a228f7b516425e2dcb0aa5f2cdfaedc85 Author: Carsten Driesner <cd@openoffice.org> Date: Wed Oct 17 09:57:37 2001 +0000 #87255# support toolbar item style and help id Change-Id: Ie49647da257e6199d9502c916da2dd3d39d52377 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-20Run clang-tidy with misc-unused-using-decls on modules [d-o]*Gabor Kelemen
To remove unneeded using declarations. Via the simple script: for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do clang-tidy-12 --checks="-*,misc-unused-using-decls" "$i"; done Change-Id: Idd8aa3d3cfec456c4babb65e89af712051b4deb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150609 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-04-17Remove some unused includesMiklos Vajna
Mostly com/sun/star/frame/Desktop.hpp is unused after inheriting from UnoApiTest. Change-Id: I71b75fa5c880337ff294583b96af09c90b5059c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150514 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-15Simplify initialized checkMike Kaganski
The previous complexity did nothing useful; it allowed to have a single unguarded boolean value check, for the cost of releasing and acquiring the mutex again. Change-Id: I426304e9ef6f27ca371544951bf3cc029887019e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150437 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-14loplugin:stringviewparam improvementsNoel Grandin
improve the check by checking for methods that exclude using string_view, rather than checking for methods that __can__ use string_view, which leads to exposing some holes in our o3tl/string_view.hxx coverage. Change-Id: Ic9dd60441c671f502692f9cd2a1bb67301c4b960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13try to fix CppunitTest_framework_dispatch on windowsNoel Grandin
I see occasional failures here, possibly they are a threading issue since we are touching these fields from multiple threads. Add a mutex to see if it helps. Change-Id: I7277e96d07d292a6bc1d333dabec7a82fc607465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150281 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-12OUString::intern is a relicNoel Grandin
and a pessimisation. Remove usage thereof. Change-Id: I98f6197aa375349b909a7ef1403ec06ca37890d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-10Use of O(U)StringNumber for float/double is actually a pessimisationMike Kaganski
They use rtl_(u)str_valueOf(Float|Double), to fill the buffer, and the latter use doubleToString, which creates an rtl_(u)String, copies to the buffer, and releases the rtl_(u)String. So instead just use the rtl_(u)String from rtl_math_doubleTo(U)String directly. Even when the end result is not needed as O(U)String, this would avoid an extra copy step. Also, this avoids separate LIBO_INTERNAL_ONLY implementations. Change-Id: Ib1d9ecebd7876dfff7dc758f89ee4c1536647a50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150150 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-07drop unused eventtesting stuffCaolán McNamara
eventtesting with input of fuzzed keystroke was a fairly nifty idea, but I never did anything with it beyond an initial experimental run and its cluttering up things so drop it now Change-Id: I44571e3e33124f522374d7c6772b7a7e7721aa1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150125 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-05Resolves: tdf#154308 if start center frame exists, use it as dialog parentCaolán McNamara
At least for the case the document is launched from the StartCenter, put that StartCenter as the parent for any dialogs that may appear during typedetection, this avoids such dialogs not getting associated with the start center and going behind the dialog if the start center is clicked while the dialog was appearing. The start center is always recycled to become the next document if it exists, so its window is the window the final document would appear in if successful. Change-Id: I75a92ff424aa0b9d5d6b808e2f7f1766a80fa50c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-01use more XVclWindowPeerNoel Grandin
Rather than using it's superclass XWindowPeer and implicitly relying on it being XVclWindowPeer and casting it everywhere. Change-Id: Icfb46f3b920d00f4a167a31803a71bbb0368d05c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149894 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-25loplugin:stringadd in editeng..frameworkNoel Grandin
after my patch to merge the bufferadd loplugin into stringadd Change-Id: Ieac16a01fde6467a2f6fe47864069304a3c44e47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-23rtl::Static to thread-safe-staticNoel Grandin
Change-Id: Ife02e6d2be3ebfbb08522ab0183ef4aa31a99e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22fix crash seen when experimenting with tdf#129547Caolán McNamara
Change-Id: I0b26a7f683f91d3307856f86c5a437fde1155451 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-21sc drawstyles: Handle style commands and undoMaxim Monastirsky
Change-Id: Ibd81f7aba9ef2efca89556c31cd9b09867419d0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149203 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-03-20little optimization in acceleratorsJuergen Funk
remove double calls Change-Id: I4242067bdc0fdcc5184d555bb293f17d66965fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147094 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-03-20tdf#153587 If one of the multiple shortcuts is deleted,Juergen Funk
the next one is not displayed This patch solve the part 2 of the bug, the problem was that it did not take into account whether a command was assigned multiple keys, it simply deleted the whole command Change-Id: I4e09096d3bc112ed49a4210dd294d1acf7a48159 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147093 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-03-14elide some temporary OStringsNoel Grandin
where we can pass a string_view into OStringToOUString Change-Id: If7803ba49aa15f6e9c7bd386d32fb84003155390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148844 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-14Related tdf#129547 and tdf#154136: add COLON keyJulien Nabet
Change-Id: I17978dbb100fbfa6f6ddbbbdf96872076bc2a289 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86713 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-03flatten DocumentUndoGuardNoel Grandin
which is a small object, and doesn't need a pimpl pattern Change-Id: Ib76f6e5ad0347be61fe29b22f57e1211ce3337cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148172 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28tdf#153857 Writer hangs right-clicking on form fieldNoel Grandin
regression from commit 5032262fccd0ef7f274323ae481b3230ffd42d3a Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Feb 21 15:05:37 2023 +0200 BaseMutex->std::mutex in PopupMenuControllerBase Change-Id: I01bdab09ac0ce1d9b35ed45ad36d1c5179702c6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147920 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-22BaseMutex->std::mutex in PopupMenuControllerBaseNoel Grandin
Change-Id: I26877ac7b6e5e39f511418d978199189c62cca6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147416 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-21BaseMutex->std::mutex in JobExecutorNoel Grandin
Change-Id: I7be392f3023cf188bd6115053dcb1691b32b3e4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-17osl::Mutex->std::mutex in UndoManagerHelper_ImplNoel Grandin
Change-Id: I57973db459633a4672c0d59c23bd3a682834ace8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-15Drop 'using namespace ::std' in dirs [e-p]*Gabor Kelemen
Change-Id: Ibe6a2f662f5721c594d28a8e0d7340d0f3cffe95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147075 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-02-15Resolves: tdf#30920 don't terminate app on closing license frameCaolán McNamara
when there is a backing window (start center) also open Change-Id: I64051467ac90ee321b7fc54cb96775c5a1e8d3a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-14osl::Mutex->std::mutex in LoadEnvListenerNoel Grandin
Change-Id: If76feb51f0d2f187603fb1af7c27bbe3391b645b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146944 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-14osl::Mutex->std::mutex in ConfigurationAccess_UICommandNoel Grandin
Change-Id: Id92161815cd1f336c030aa4491e67a84aaddeb87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-09tdf#95936: Tooltip not updated in Toolbars after change ShortcutJuergen Funk
The update of all toobars after change the shortcut was missing, this patch update the toolbars now Change-Id: Ibc896dc48c9143307b028a3c271476482111c2c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146678 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-02-05tdf#143148 Use pragma once instead of include guardsGreg Kelesidis
Change-Id: Iaeabe4e21ffe407684a57e1988a836e7cf85b2a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146560 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-02-03tdf#56696 - Sort recent document list according to current LibO moduleAndreas Heinisch
Change-Id: I246dc9538e011b8981bea04963995559d2b43cc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146456 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-02-02osl::Mutex->std::mutex in ConfigurationAccess_UICategoryNoel Grandin
Change-Id: I55da051ad9368920224f2c762c9f95b3ea85098a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-02osl::Mutex->std::mutex in ConfigurationAccess_WindowStateNoel Grandin
Change-Id: I399bb434da3e2c92c6df64dd6048121ad030bfb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-31Fix locking orderStephan Bergmann
JunitTest_sfx2_complex occasionally deadlocked when the main thread at > framework::UndoManagerHelper::isUndoPossible > chart::UndoCommandDispatch::fireStatusEvent > chart::CommandDispatch::addStatusListener > svt::ToolboxController::bindListener > framework::ToolBarManager::UpdateControllers > framework::ToolBarManager::AsyncUpdateControllersHdl > Scheduler::CallbackTaskScheduling > SalTimer::CallCallback > SvpSalInstance::CheckTimeout > SvpSalInstance::ImplYield > SvpSalInstance::DoYield > ImplYield > Application::Execute > desktop::Desktop::Main has acquired the SolarMutex in framework::ToolBarManager::AsyncUpdateControllersHdl and is now trying to acquire framework::UndoManagerHelper_Impl::m_aMutex, while a cppu_threadpool at > framework::UndoManagerHelper_Impl::impl_clear > std::function<void ()>::operator() > framework::(anonymous namespace)::UndoManagerRequest::execute > framework::UndoManagerHelper_Impl::impl_processRequest > framework::UndoManagerHelper_Impl::clear > framework::UndoManagerHelper::clear > gcc3::callVirtualMethod first acquired framework::UndoManagerHelper_Impl::m_aMutex and then tries to acquire the SolarMutex. That additional acquiring of the SolarMutex had been added to framework::UndoManagerHelper_Impl::impl_clear in 8611f6e259b807b4f19c8dc0eab86ca648891ce3 "ref-count SdrObject". Change-Id: Ifcb8765b29b65f773be6bbe54092346c5ae3a33b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146371 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-15 01:29:58 +0000