Age | Commit message (Collapse) | Author |
|
Change-Id: I75514fe3a3c55691ca9adfa136bfcd5ff9a2b706
|
|
Change-Id: Ifbdbd2bb8a21afa76271728c46f88c11a887fc5a
|
|
Change-Id: I74898e791e17971a3105febe660a2140aafaece9
|
|
Change-Id: I2504291e2167cbc4be91e01de654ca63f89dbd2a
|
|
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
|
|
of which there are several.
There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
numeric values to the underlying code, but perhaps further fixing is necessary?
Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
|
|
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
|
|
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
|
|
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
|
|
Change-Id: I822c5ebc321ebda87c238a1781a31793c1623e34
|
|
Change-Id: Ibc2f7412b6bf8ef75f93d649812836c01224e43f
|
|
Change-Id: I86bdd1c2603c984380b52b080504b7583155b0fb
|
|
Change-Id: I249fe09319d6e0995d9ffdc7e4396b9b1787ad28
|
|
Change-Id: I69ab0ca9c017c9a1c10d18fd850f32a92c641d12
Reviewed-on: https://gerrit.libreoffice.org/14631
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157
Reviewed-on: https://gerrit.libreoffice.org/14292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
found with some minor modifications to find/find-unused-defines.sh
Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
Change-Id: I6f2014f3dfc650a61e8c0dc0bb7d7d4fdb88dbe9
|
|
Change-Id: I0ba3fe95ab6ef317166b286531a718287308f62f
|
|
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
|
|
Change-Id: Ib19462d2095ca46eace28e1d3170b559027a2acd
|
|
This addresses some cppcheck warnings.
Change-Id: I9812658e8a96dd35d686c7ae7a8b829267c5c8bc
Reviewed-on: https://gerrit.libreoffice.org/13499
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I4e6b8077fd564be9508e5a08f2eb66032f5f3f40
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I8aba67ae5bf5ffb7530be8f6d5b2511b554717db
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ia52d6cd32aa3e3838d31ea2a994117e6820a503d
|
|
Change-Id: Icd67d066eb72b951f3e4846d45d00e7863a6000e
|
|
I'm guessing that this is what was meant. Though
hstr2ksstr and kstr2hstr still don't match, and I'm assuming
they are supposed to be mirror images of each other.
Change-Id: I0fccd086e16c043324af43a5c999c2fde7cf7505
|
|
Change-Id: I9fca98995131358b3b112b11e0b28feb1a3267d1
|
|
Change-Id: Iac70c9be13892a36bfb5975f62e5345b88d4f144
|
|
I don't know how to check it's ok, I just took example above
It seems there was a wrong mix between header and footer test
Change-Id: Ia5bb838e92306f3bb160069a7c62707e365e8ab2
|
|
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
|
|
Change-Id: I1b61151df81c75bf794fbeda967769501026bb05
|
|
Change-Id: I028148a1112cdbe83ff7fb439cc4280a7723338b
|
|
Change-Id: Ibf5e6475b3bbfbb25e0204e3999674e59555eddf
|
|
Change-Id: Ic634f183a531c1ecda61b31a0883934bd7842dcc
|
|
Change-Id: I0d57e227be45bb2c098969ab24eedab30514313f
|
|
...as reported by -fsanitize=address CppunitTest_hwpfilter_test_hwpfilter, where
stack-local HStream stream from HwpReader::filter is still referenced from
HStreamIODev in
HStreamIODev::close
HStreamIODev::~HStreamIODev
HWPFile::~HWPFile
HwpReader::~HwpReader
which is only harmless because HStream::closeInput is a nop.
Change-Id: Idbc5539ab5f463ec6d5d72f428ce60327ebdb063
|
|
Change-Id: Ifc07a0b3f09dc1209e434056eb007a4401a09d3e
|
|
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
|
|
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
|
|
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
|
|
Change-Id: Ib8d2bc5a5772f6611f9d977376f6fef9505c6a59
|
|
Change-Id: I2b83f3e5a4fb65819244b88fdad7e48fe918b4bd
|
|
Change-Id: I3f0b7796b4ea28c55255327ccf5b2d523ecca053
|