summaryrefslogtreecommitdiff
path: root/i18nlangtag
AgeCommit message (Collapse)Author
2022-01-09tdf#146084 No hyphenation warning for PashtoHossein
Pashto language, which is spoken in Afghanistan and Pakistan uses the Arabic script, and does not use hyphenation. Change-Id: I87a1235b183055b0961ab27f45281be7aa9965c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128191 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 7ac5ee3546e15455c5ee306af234bb7fe8a29049) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128148
2022-01-09tdf#146084 Don't warn for languages without hyphenationHossein
Upon opening a Writer document containing some languages that do not use hyphen, an alert is created with the text: 'Missing hyphenation data Please install the hyphenation package for locale "ab_CD".' in which 'ab_CD' is the locale. This patch removes the warning for these languages, that do not use hyphenation: * Arabic script languages (except Uighur) + Persian (Farsi) + Kashmiri + Kurdish (Central Kurdish and Southern Kurdish with Arabic script) + Punjabi + Sindhi + Malai + Somali + Swahili + Urdu "Words are not hyphenated in Arabic language text, however hyphenation is possible for Uighur text written in the Arabic script" https://www.w3.org/International/i18n-tests/results/word-break-shaping The list from MS documents is lenghty, but some of the languages are were not available in LibreOffice, so they are ommited: https://docs.microsoft.com/en-us/typography/script-development/arabic There were languages like Hausa and Kanuri from Nigeria that use both Latin and Arabic script, but only Latin script was listed in the LibreOffice languages, so they were also ommited. * CJK languages + Japanese + Korean + Chinese + Yue Chinese "CJK languages differ from European languages in that there are no hyphenation rules" https://tug.org/TUGboat/tb25-0/cho.pdf * Vietnamese "In Vietnamese all words consist of single syllables, so they are often very short; hyphenation is not allowed at all." https://tug.org/TUGboat/tb29-1/tb91thanh-vntex.pdf Hyphenation is declined in Vietnamese orthography since 1975 https://www.quora.com/When-did-hyphenation-decline-in-Vietnamese-orthography The fix for Japanese (tdf#143422) was previously done in: 53d5555f13371252874ec962dee4643168d26780 and the functionality is preserverd with the current patch. An alternate approach would be adding all the unicode scripts, specifying the script for each langauge, and decide upon the script (mostly) and not (only) the language. More information about the hyphenation usage of many scripts can be found in: https://r12a.github.io/scripts/ This is the list of Unicode scripts: https://unicode.org/standard/supported.html https://en.wikipedia.org/wiki/Script_(Unicode)#List_of_scripts_in_Unicode Change-Id: I7d2b4ee55a0893d1f0d1f9cd3b7cc037a49589b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126435 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 151c56ed547490a99d912524c0e56b5d6d4a1939) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128082 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-18Change Interslavic Latin tag to {art-Latn-x-interslv}, tdf#145853 follow-upEike Rathke
Change-Id: I4d19251fe350d8d2139ede9adbe0de1e3b570a5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127028 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6e91ff7b57a231ca34f619a40297cf6ef1904ea2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127049
2021-12-18Resolves: tdf#145853 Add Interslavic Latin|Cyrillic to language listEike Rathke
Interslavic Latin {art-x-interslv} 0x06AD Interslavic Cyrillic {art-Cyrl-x-interslv} 0x06AE Change-Id: I487d6593db89af038555a192674298e2dabf5582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127018 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 430a6fea4012752eed0c61bff4936e9c366aa750) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126981
2021-12-15Related: tdf#146228 convertIsoNamesToLanguage() fallback for empty tagEike Rathke
An empty tag might be the result of a bad LANGUAGE=":" setting. The old implementation tried an unconditional "-" tag (for both language and country empty) that was wrong anyway. Do not keep the resulting LANGUAGE_SYSTEM as that is exactly what we want to know the actual locale for. Change-Id: I7d6587f59e9a3362c7d877926a325ebcfe7b48db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126863 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 7c22bed187c12122fe29459279771ca414799ac8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126879
2021-12-15Resolves: tdf#146228 env-var $LANGUAGE can be a colon separated listEike Rathke
Try to extract a first or second if first is empty. Ideally the sequence would be matched against available UI localizations, but that's simply not available at this stage. Change-Id: I37d0c289fe165c76a98086c63279aacf6856900c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126862 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit f2c3c927021cd008366291e67606f6537e3e20be) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126878
2021-11-23Removed break; after returnAndrea Gelmini
Change-Id: Ib712072deec9368a3a580562dd1fc3bc28e86e68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125679 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Eike Rathke <erack@redhat.com>
2021-11-22osl::Mutex->std::recursive_mutex in LanguageTagNoel Grandin
Change-Id: I75e2d0b78ebf4390ed67d94eb1021145f245fe50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125631 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-10initialization-order-fiasco, againStephan Bergmann
...after b5758cb2729236d9eaf52bd25b1b113a3ff06b4e "rtl::Static to thread-safe static" (which this partially reverts again), like 71d0c43fb4cf535239cb41baf7b6e03de765ce7a "initialization-order-fiasco" in the past Change-Id: Ie3f352a63ee3939b1727faf6cf11b2768173437c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124998 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-10rtl::Static to thread-safe staticNoel Grandin
Change-Id: Ie4c26b0b2c0880bcf6ec6d786b219f142d715af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124930 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-08Convert erroneous kw-UK language tag to kw-GB when encounteringEike Rathke
Change-Id: I67a79dab3fac36b494ebc66b81d6d571e2486b1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124842 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-11-08The country code for the United Kingdom is GB not UKCaolán McNamara
e.g. see gd and cy Change-Id: Ic2f9746dc1fc2b08f000f8efff113f5981e427f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124839 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-25Introduce LanguageTag::convertToLanguageTypeWithFallback(Locale)Eike Rathke
... with keeping LANGUAGE_SYSTEM not resolved or falling back. Change-Id: I10211c2b2140a9822f1403dc00af3ee9ded08f69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124140 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-25Get rid of fuzziness in MsLangId::Conversion::convertIsoNamesToLanguage()Eike Rathke
With on-the-fly LanguageTag the fuzzy fallbacks for a few languages aren't needed anymore. Proper fallbacks should be obtained when needed, like when configuring default locales, or configured values used after. Change-Id: I8b85b8099e085508435036ac846db6c3e516dc23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124127 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-24Return LANGUAGE_ENGLISH_US for AppleLanguageId::ENGLISHEike Rathke
Most likely was an oversight when using LANGUAGE_ENGLISH as other LANGUAGE_FRENCH and LANGUAGE_GERMAN are locales already. Change-Id: Ie16395340cef9939a5397e3d10d6df6b13ac8d99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124124 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-19Related: tdf#145173 Add English (Israel) {en-IL} 0xB409 to language listEike Rathke
Change-Id: I0c1d89a8869e3788f18851ae004bac24275923b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123829 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-18Introduce MsLangId::getConfiguredSystemLanguage()Eike Rathke
To be used instead of getSystemLanguage() in a subsequent change. For details see commit summary of commit aec5312ffab24236876693d7a8b55843847f2a48 CommitDate: Mon Oct 18 21:14:24 2021 +0200 Related: tdf#145173 Ensure known supported system and default document locale Change-Id: I5bed125e47c2a03fe2e7a4f84988b2e8841143c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123766 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-03A more lightweight O[U]StringConcatenationStephan Bergmann
...compared to a full-blown O[U]String, for temporary objects holding an O[U]StringConcat result that can then be used as a std::[u16]string_view. It's instructive to see how some invocations of operator ==, operator !=, and O[U]StringBuffer::insert with an O[U]StringConcat argument required implicit materialization of an O[U]String temporary, and how that expensive operation has now been made explicit with the explicit O[U]StringConcatenation ctor. (The additional operator == and operator != overloads are necessary because the overloads taking two std::[u16]string_view parameters wouldn't even be found here with ADL. And the OUString-related ones would cause ambiguities in at least sal/qa/rtl/strings/test_oustring_stringliterals.cxx built with RTL_STRING_UNITTEST, so have simply been disabled for that special test-code case.) Change-Id: Id29799fa8da21a09ff9794cbc7cc9b366e6803b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122890 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-30Resolves: tdf#144059 Tigrigna {ti-*} (Ethi) is CTLEike Rathke
Change-Id: I5fb56e039c854471ae444395feee27e820902181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121297 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-21Resolves: tdf#143946 Add Klingon, tlhIngan Hol {tlh} 0x06AC to language listEike Rathke
Change-Id: Icf7452b2aef3ecae8ccdbcd4a66ab8b121a8120c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120814 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-21Unit test for LanguageTagIcu::getDisplayName()Eike Rathke
Change-Id: Ibe95fba21ed94be7fb4848f19161d492bc403e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120798 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-08-21Introduce LanguageTagIcu::getDisplayName()Eike Rathke
To be used in generating display names for on-the-fly language tags in the language listbox. Change-Id: Ibb36fe312e550f77f1e2d3acc2dbff9e83c15f7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120797 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-06Adapt LCIDs and language tags to [MS-LCID] rev.15Eike Rathke
See https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/70feba9f-294e-491e-b6eb-56532684c37f https://winprotocoldoc.blob.core.windows.net/productionwindowsarchives/MS-LCID/%5bMS-LCID%5d-210625.pdf and commit 402dab839b2e451dec81bfb83dadbe0d5a231db2 CommitDate: Wed Aug 4 21:21:51 2021 +0200 update list of [MS-LCID] from 6/25/2021 15.0 rev. Change-Id: I44db2bfaf894ead119c7014e3770fc44be537148 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120128 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-04update list of [MS-LCID] from 6/25/2021 15.0 rev.DaeHyun Sung
update list of [MS-LCID] from 6/25/2021 15.0 revision see [MS-LCID]: Windows Language Code Identifier (LCID) Reference Link: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/70feba9f-294e-491e-b6eb-56532684c37f Change-Id: I8264a246d3a0f34a19f35684bdb987565f37e69d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119772 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-08-02initialization-order-fiascoStephan Bergmann
...after a943936eeff04b60ebd0b2552bc18b42606f3321 "rtl::Static -> static local" (and the relevant static isn't even local), when building e.g. Gallery/backgrounds, see <https://ci.libreoffice.org/job/lo_ubsan/2090/>: > ==26993==ERROR: AddressSanitizer: initialization-order-fiasco on address 0x2b52e50be408 at pc 0x2b52e4d32753 bp 0x7fff5670f090 sp 0x7fff5670f088 > READ of size 8 at 0x2b52e50be408 thread T0 > #0 0x2b52e4d32752 in std::_Rb_tree<rtl::OUString, std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> >, std::_Select1st<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > >, (anonymous namespace)::compareIgnoreAsciiCaseLess, std::allocator<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > > >::_M_begin() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_tree.h:737:64 > #1 0x2b52e4d355f3 in std::_Rb_tree<rtl::OUString, std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> >, std::_Select1st<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > >, (anonymous namespace)::compareIgnoreAsciiCaseLess, std::allocator<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > > >::find(rtl::OUString const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_tree.h:2523:37 > #2 0x2b52e4d3507d in std::__cxx1998::map<rtl::OUString, std::shared_ptr<LanguageTagImpl>, (anonymous namespace)::compareIgnoreAsciiCaseLess, std::allocator<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > > >::find(rtl::OUString const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_map.h:1164:21 > #3 0x2b52e4cf116c in std::__debug::map<rtl::OUString, std::shared_ptr<LanguageTagImpl>, (anonymous namespace)::compareIgnoreAsciiCaseLess, std::allocator<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > > >::find(rtl::OUString const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/debug/map.h:561:32 > #4 0x2b52e4d00dcd in LanguageTag::registerImpl() const /i18nlangtag/source/languagetag/languagetag.cxx:888:50 > #5 0x2b52e4cdf693 in LanguageTag::getImpl() /i18nlangtag/source/languagetag/languagetag.cxx:1004:18 > #6 0x2b52e4cdf3fd in LanguageTag::LanguageTag(rtl::OUString const&, bool) /i18nlangtag/source/languagetag/languagetag.cxx:489:9 > #7 0x2b52b9aed628 in __cxx_global_var_init.2 /sfx2/source/view/lokhelper.cxx:77:13 > #8 0x2b52b9aed75e in _GLOBAL__sub_I_lokhelper.cxx /sfx2/source/view/lokhelper.cxx > #9 0x2b52b4f069c2 in _dl_init_internal (/lib64/ld-linux-x86-64.so.2+0xf9c2) > #10 0x2b52b4ef8179 (/lib64/ld-linux-x86-64.so.2+0x1179) > > 0x2b52e50be408 is located 40 bytes inside of global variable '(anonymous namespace)::theMapBcp47' defined in '/home/tdf/lode/jenkins/workspace/lo_ubsan/i18nlangtag/source/languagetag/languagetag.cxx:93:10' (0x2b52e50be3e0) of size 72 > registered at: > #0 0x43f4c8 in __asan_register_globals.part.13 /home/tdf/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/asan_globals.cc:362 > #1 0x2b52e4d4031b in asan.module_ctor (/instdir/program/libi18nlangtag.so+0x16831b) > LLVMSymbolizer: error reading file: No such file or directory > #2 0x7fff567143b7 ([stack]+0x203b7) This is a partial revert of a943936eeff04b60ebd0b2552bc18b42606f3321 "rtl::Static -> static local". Change-Id: I5d6803d217d4e8927b5864b2392f3ddd18310a5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119882 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-07-31rtl::Static -> static localNoel Grandin
in a handful cases, like a map or a vector, we don't need init on demand at all, the default constructor can be laid out at compile time Change-Id: Ifa3188af7a65cd475ce0f603d15a8c26bcda7e6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-12Resolves: tdf#123466 Add Microsoft ill-used {x-none} to known language tagsEike Rathke
'x-none' is a private-use tag and letting it escape into the wild isn't such a private use.. This just prevents the lt_string_value assertion that doesn't harm anyway but seems to confuse people and makes the tag known to LibreOffice with a reproducible assigned LCID instead of an on-the-fly generated one. Whatever it may take to actually support something tagged with 'x-none'. Change-Id: I3f32c9ba18a2528584a112157509c1dfda75e29c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118788 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-07-09Make loplugin:stringadd slightly more aggressiveStephan Bergmann
...by assuming that all const member functions are side-effect free. (This presumably means that some of the special cases in StringAdd::isSideEffectFree are obsoleted by this more general case, but any such removal is postponed to later clean-up.) (Came across this when idly wondering why 8b7f948d9d79393bc6c1b11d239706666fd5d7de "sc, VmlFormControlExporter: avoid OStringBuffer style" had not been found by the plugin before.) Change-Id: I6bca10df53885b14a590543aabd61f23b3748572 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118675 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-01Add Sesotho {st-LS} 0x8030 to language listEike Rathke
Change-Id: Ifb304fb1a5ed05e79bcaaaf96e12171377973222 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116552 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-05-06Add English (Denmark) {en-DK} locale dataEike Rathke
Using ',' comma decimal separator and '.' dot group separator. ISO 8601 date(+time) formats. Inheriting calendar from {en-GB} (week-1stweek=4 first_weekday=2). Currency DKK 'kr.' symbol. Secondary currency EUR '€' symbol. See also https://lh.2xlibre.net/locale/en_DK/ Change-Id: Idcf1e52af0ac20412efa42d3873ab1e34a2f1eaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115177 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-08Update commentStephan Bergmann
...after 86cadd43f002959d6cfcb7b3e4066076f6d05997 "rtl::Static -> function local static" Change-Id: I1013e7d38a85a596f279ac8107a4ac6d8b940950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113788 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-07rtl::Static -> function local staticNoel Grandin
Change-Id: Iee030633d2e2b020f38797d0d323680fa552b81a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113713 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-24Using .md extension/Markdown syntax for modules READMEHossein
Renaming all README files for all top level modules to README.md, applying no content change at this stage to be able to track history of the files. These files should be edited to use correct Markdown syntax later. Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-02-13Resolves: tdf#138839 Add Cabécar {cjp-CR} 0x06AA, Bribri {bzd-CR} 0x06ABEike Rathke
Change-Id: Ib80d080fc69ba2c87c9a859a0571f9d82f7c7bac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110832 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-02-10Remove unneeded breaksAndrea Gelmini
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: If7e6f9c4079c2e0b48e642aa0b140fb4e03996bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110520 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-08Improve loplugin:cppunitassertequal for CPPUNIT_ASSERT(a && b)Stephan Bergmann
...by re-enabling the code temporarily #if'ed-out in a528392e71bc70136021be4e3d83732fccbb885e "Fixed/improved loplugin:cppunitassertequals" (and which then triggers lots of other lopglugin:cppunitassertequal CPPUNIT_ASSERT -> CPPUNIT_ASSERT_EQUAL warnings). For two css::uno::Reference equality comparisons in cppu/qa/test_any.cxx, it was more straightforward to rewrite them with an explicit call to operator == (which silences loplugin:cppunitassertequal) than to adapt them to CPPUNIT_ASSERT_EQUAL's requirement for arguments of identical types. In sc/qa/unit/ucalc_pivottable.cxx, ScDPItemData needs toString, which has been implemented trivially for now, but might want to combine that with the DEBUG_PIVOT_TABLE-only ScDPItemData::Dump. Change-Id: Iae6d09cf69bd4e52fe4411bba9e50c48e696291c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110546 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-01Resolves: tdf#139607 Add Pali Thai {pi-Thai} 0x0A67 to CTL language listEike Rathke
Change-Id: Iccd2c93e220c0580ed27d414477b81ebe8efdf45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110257 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-01-26loplugin:passstuffbyrefNoel
Change-Id: I330e0ab6c9955939dad313f9d472f93e39dbd313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-04loplugin:stringviewparam: operator +=Stephan Bergmann
Change-Id: I30ce1b5bd8fb168da7067c1967c5af2569df2653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108512 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-03fix assert message inside liblangtagNoel Grandin
lt-string.c: line 189: assertion `string != ((void *)0)' failed Change-Id: I64d3374de57637fa61ac0148f7e82bd37c285a06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107160 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-30loplugin:stringviewparam include comparisons with string literalsNoel
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-18loplugin:stringviewparam: No good reason to exclude operator functionsStephan Bergmann
(at least not in general) Change-Id: I71337b53dc9735e90a37ee532d0a8a08797b518c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-13tdf#123936 Formatting files in module i18nlangtag with clang-formatPhilipp Hofer
Change-Id: I221f9e46af1bfa729c0d38e6748a74af66fdece7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105677 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-11loplugin:stringviewNoel
Add new methods "subView" to O(U)String to return substring views of the underlying data. Add a clang plugin to warn when replacing existing calls to copy() would be better to use subView(). Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-10new loplugin:reducevarscopeNoel Grandin
Change-Id: Iefe922c2e0d605114d54673d63eccc5e4abd545d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102143 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-22long->tools::Long in hwpfilter..ooxNoel
Change-Id: I9ab8876aac7b2f8b488db6dfa9c6fd0cecd2238b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104626 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-06-18 21:15:44 +0000