Age | Commit message (Collapse) | Author |
|
With simple transliteration, TextSearch::searchForward used to use
whole string to perform the search, then started to create substring
to search. But it left the precautions from
commit c00601dab0f5533b152cd63cec0a89bfec1ba95f by Eike Rathke:
searching for $ may actually return a result set pointing behind the
search string which it does with the ICU regex engine.
The precaution made it to skip reverse mapping if index was 0.
Commit 9aae521b451269007f03527c83645b8b935eb419 by Michael Stahl
didn't consider the case when nStop is 0, and startPos > 0. Then it
tried to get offset[-1].
Anyway, using value of startPos in those conditions seems illogical.
Removed those precautions (and made assertions for that).
Fixed handling zero indexes.
Change-Id: I2066abc51fff7fb7323bc7f6198bdea06439d4f3
Reviewed-on: https://gerrit.libreoffice.org/19840
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I11822c50fa66d038a3d6f38054ab35c2e613f077
|
|
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
|
|
Enabling the ICU Breakiterator causes Khmer spelling checkers to be worthless
as well as wrecks havoc on various minority languages that use the Khmer
script. See this https://bugs.documentfoundation.org/show_bug.cgi?id=52020
this: https://bugs.freedesktop.org/show_bug.cgi?id=59448 and this:
https://bugs.documentfoundation.org/show_bug.cgi?id=59447&redirected_from=fdo
Change-Id: I84529db9cca72ffe1108d2e12c1885f63a48f89d
|
|
with the variadic variants.
Change-Id: I0381de7fde198df74556355984bdaba2ecdedd4b
Reviewed-on: https://gerrit.libreoffice.org/17768
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I7ef1dc1d42237ef101731b363359801d9e1e9db6
|
|
Change-Id: I5bad1428e96c76f7d295f69e10beea4397d560ff
|
|
Change-Id: Ic91ddc695e9f3c7d8ba4d2bb67c8c84de2a22d5c
|
|
...which had already been conditional on U_ICU_VERSION_MAJOR_NUM > 51, so
452a06b70578eb83067c6c744cd97eebafc4003c "Activate unit test for Lao
breakiterator support" should merely have extended that #if to the function
declaration/definition in response to loplugin:unreffun, not unconditionally
enabled it.
Change-Id: Ia1ce4e99b4a960b1e70cae0a61b0d526b0353d9a
|
|
Change-Id: I26abf6d0e102712f76977e0763c4a672434a1325
|
|
In f24fa8efad247bdc296e4724b914f73f01ef2d0b added unit test wasn't
activated. Activating it now reveals that the test is failing. Add
TODOs for the failing asserts.
Change-Id: I6c9f36be3aa84a5d5092d2a3f576af39a15b935e
|
|
Change-Id: I6ef4ae530b7fb4e615100803ae6e3972d9b4545f
|
|
Change-Id: I6f2fabd9248b1b385439ff5c074342029fb660e0
|
|
Change-Id: I283dddaa4bd8baf05b90ce5f81d43b785021a3c4
|
|
Change-Id: I770c1b3e5164cb486b5a5c2b1259f713914a1bae
|
|
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
|
|
Issue:
OUString uses UTF-16, so for a Unicode surrogate character there are 2
values stored, not just 1.
So we are getting assert failure in "rtl_uString_iterateCodePoints" method.
erAck: Underlying cause was that the dictionary breakiterator misused UTF-16 positions as Unicode code point positions.
Change-Id: I923485f56c2d879b63687adaea2b489a3479991c
Reviewed-on: https://gerrit.libreoffice.org/6955
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
This breaks windows build with localized versions of MSVC.
Change-Id: I23c46830f96ae661eced88352476e7ae61fbcc2a
Reviewed-on: https://gerrit.libreoffice.org/6847
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Convert code like:
aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") );
to:
aOStringBuf.append( " is missing )" );
which compiles down to the same code.
Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
|
|
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
|
|
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
|
|
Change-Id: I6da721dc25394dfee12e3028aefbf0546d1be984
Reviewed-on: https://gerrit.libreoffice.org/6669
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
|
|
And use some templates inside include/com/sun/star/uno/Sequence.hxx
Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47
Reviewed-on: https://gerrit.libreoffice.org/6599
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|
|
Change-Id: Icf3324a224d02425acd679a286f3c4a0b7e3ed1c
|
|
Change-Id: I56f08d58d8d8a0e397412580451c90f9605bcb46
|
|
Change-Id: Ic1240114d667fb7797afae4847427cc889f3cb48
|
|
commit 30c303 "Make charmap.cxx compile with icu >= 4.4." was incomplete
and had wrong version checks. After ICU 4.8 (4.8.1.1) the next version
of ICU was 49 (49.1) so U_ICU_VERSION_MAJOR_NUM contains two digets (49),
earlier that it was just one digit (4). The correct header to include to
do version checks is unicode/uversion.h. USCRIPT_MANDAEAN is the old
alias of USCRIPT_MANDAIC (same numeric value). U_JG_FARSI_YEH is only
available since ICU 4.4. Note that on older icu versions (4.2.1) the
200B (ZWSP) Zero Width Space breakiterator testcase fails (others
succeed).
Change-Id: If73c1402239a28546077437e9382f0bd38642bad
Reviewed-on: https://gerrit.libreoffice.org/4139
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
|
|
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.
Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
|
|
|
|
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
|
|
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.
This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.
Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
|
|
Change-Id: I1bd840391496daab2cfe32af6ac00e98de3ed72e
|
|
Change-Id: Ie56e68459f655a66bf33368cee5e9a99b9dd0141
|
|
Change-Id: I46062bcece6ccbcebf421bc4334c1af05f27a8fb
|
|
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms
Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Done with a perl regex:
s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms
Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: I8e409ba63d32dca9a1c7f09d143165d1d702d642
|
|
(cherry picked from commit 854f4ad6c57be62bd922df08f603d8bfb7b918a5)
Additionally fixed unit test, searching backward shall not produce a
different result from searching forward. (erAck)
Change-Id: I952509276875441005e6a4036e6c3089be627dd9
|
|
Change-Id: I7fc203900256839e679bf73b717d121fedc42087
|
|
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
|
|
Re-enable build with ICU 4.6 and 4.8
ICU versions prior to 49 don't know Conditional_Japanese_Starter and
Hebrew_Letter
Also, the change in i18npool/CustomTarget_breakiterator.mk
- -e "s#\[:LineBreak = Close_Punctuation:\]#\[& \[:LineBreak = Close_Parenthesis:\]\]#" \
with i18npool/source/breakiterator/data/line.txt
-$CL = [:LineBreak = Close_Punctuation:] ;
+$CL = [:LineBreak = Close_Parenthesis:];
did not produce equivalent results. Instead use
$CP = [:LineBreak = Close_Parenthesis:];
$CL = [[:LineBreak = Close_Punctuation:] $CP];
Change-Id: I14fc14319ea34f23393264560452a79bb49fc3a7
|
|
since commit f20ed8959bc0a984177377a734d34f767653625b
Change-Id: I4f2fc5d9eb7a581b9ed707a3c3f96be817141846
|
|
For "simple" known (to us) locales avoid the overhead of liblangtag,
also in preparation of not having to initialize its database during
startup.
This also enables recognition of the 'qtz' pseudolocale for key ID
resources again, see fdo#57413
Change-Id: Id52a1ddc37b42063e3bf68a6dbeaeacfbfa704ef
|
|
Change-Id: I4dad05dbbe668ac7d7058cb43989f6a9f8e488a6
Reviewed-on: https://gerrit.libreoffice.org/1118
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
|
|
Change-Id: Id78a989ab981d658dd8f331b030e00ce201c8bc9
|
|
ported from the broken java ver.
adds a native ICU regex sanity test.
|
|
Change-Id: I05baf163cc00d3770b9a8b25b099ffcbd9623a2f
|
|
Change-Id: I8f6c3814aa3630f5f640f611fb51ce72641715c6
|