Age | Commit message (Collapse) | Author |
|
TransliterationModules_FULLWIDTH_HALFWIDTH,
TransliterationModules_UPPERCASE_LOWERCASE and
TransliterationModules_LOWERCASE_UPPERCASE are not mask bits but values,
so need to be treated differently.
Change-Id: I6726bddab4fec1c222a318de61eaa41a402f6286
|
|
Change-Id: I98d80f9153abe9f536b818c899008bb865b1bd34
Reviewed-on: https://gerrit.libreoffice.org/14962
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
|
|
Thanks to Eike for finding this:
The anchors ^ and $ now anchor at the selection boundary because the
only text the regex matcher gets passed is the selected text. This in
two paragraphs
aaa bbb aaa bbb
aaa bbb aaa bbb
when the selection spans from the second aaa to the third bbb, for
"^aaa" finds the second aaa, where previously it found the third aaa at
the real paragraph start.
This may not be expected by the user, because the behavior of ^ is
described as "Match at the beginning of a line" (or paragraph in our
case), which the previous implementation did.
(regression from 806ced87cfe3da72df0d8e4faf5b82535fc7d1b7)
Unfortunately it's not obvious how to implement the same in
searchBackward().
Change-Id: I07f7a8476b672d9511fa74ca473c32eea427698f
|
|
There does not appear to be a good reason why searchBackward()
needs to call transliterate() on the entire passed string, so don't do that,
as in the previous commit for the other direction.
Change-Id: Iadfca806da89bf8825e5a3df7fcad64ea08d7f9c
|
|
There does not appear to be a good reason why searchForward() needs to
call transliterate() on the entire passed string.
Restricting it to the passed range speeds it up from 104 billion to 0.19
billion callgrind cycles when built with GCC 4.9.2 -m32 -Os.
Change-Id: I440f16c34f38659b64f1eb60c50f0e414e3dfee8
|
|
Change-Id: I88c53ade0101cfd7735a45b2038879bd027b0314
|
|
Change-Id: I6519a4c9da2a95efcc54288b3ef9d0a19ccfef3c
|
|
TransliterationImpl::transliterate() has a slow-path for the case when
more than one trasliteration module is cascaded which swaps 2
uno::Sequence. This is unbelievably slow because non-const
Sequence::operator[] does a function call into cppu to check whether COW
has to be done.
This speeds up transliterate() from 344 billion to 101 billion callgrind
cycles when built with GCC 4.9.2 -m32 -Os.
Commit d2771b63b94a8aae3c25c83e9dae9f83242f46c1 added a second
transliteration module that is enabled by default, making the problem
visible, especially with long paragraphs in Writer.
Change-Id: I2799df9173ac73aab8c4eb4cc6f592976b06c8da
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Change-Id: I596e9f0941dbc9d2106767c19569e9771c42b076
|
|
... before the next horrible attempt arrives, use my own horrible
translation ;-)
Change-Id: I1dd72772977717da6a2da048adbfd27861e8c191
|
|
...in some places where it is obvious that it does not hurt that for an empty
vector the obtained pointer is not necessarily a nullptr.
Change-Id: Id5d66b1559ca8b8955d379bcdbfae6986ef46a51
|
|
Implementation only, new local date/time routines not used yet from the
outside in this step.
|
|
Change-Id: I6c5295110292ae48ff0cb3472e4dbea287645d2a
|
|
Change-Id: Ie0097c20429104f10eb188ae0cbfcf5bc5a44e14
|
|
Change-Id: Idbb928b2898bc6b2b5bfe3bdbfde0b81d68e4473
|
|
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
|
|
* Added a space to formatindex 46, to make it look nicer;
* Long datetime default changed to formatindex 47.
Change-Id: I50e05f1a4432ab4373fa0034a390658b59775f0b
Reviewed-on: https://gerrit.libreoffice.org/13650
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This commit improves the numbering types for zh_CN locale.
Since we can set more than 8 LC_NumberingLevel in the locale data file, I am adding all the commonly used numbering types in the list. This will make it easy to apply numbering.
Change-Id: I067904b875046682cd56a7051258ffffab242c25
Reviewed-on: https://gerrit.libreoffice.org/13646
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7f6311c541db507236f6c6ab999aee5db8683f33
|
|
Change-Id: I66109a89a7aced1a4595825ee587a1844b6864e8
|
|
Apparently commonly used, as suggested by Sérgio Marques
Change-Id: I6cdbcd96034ec7bb04f364ec5747b069e32ec379
|
|
Change-Id: I6f2fabd9248b1b385439ff5c074342029fb660e0
|
|
This addresses some cppcheck warnings.
Change-Id: I7e85aca5a86f993a9906525edffbd44a179dc245
Reviewed-on: https://gerrit.libreoffice.org/13510
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
...to use single ASCII character literals "more directly" in the OUString API
(instead of having to go via an intermediary OUString ctor call). Especially
useful for character literals that are defined as const variables or via macros
("direct" uses of character literals in the OUString API can often simply be
replaced with single-character string literals, for improved readability).
(The functions overloaded for OUStringLiteral1 are those that are actually used
by the existing LO code; more could potentially be added. The asymmetry in the
operator ==/!= parameter types is by design, though---writing code like
'x' == s
is an abomination that shall not be abetted.)
Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
|
|
Change-Id: I82fea345a05c0327af3b75ccfd3358f54523c082
|
|
In the locale data xml file, formatindex 47 is used for date-and-time
editing. If the format code does not match the defined date/time
separators, it will cause the cell value to be treated as string text
(rather than a date time value).
Change-Id: I75a59d943d832f28a0a6153a17e6f671e5328abd
Reviewed-on: https://gerrit.libreoffice.org/13306
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I8ab36fd1e93b0d1297c95f47a3efd3603fd58c8f
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ibc658c6d1db5f1d5de8fd02d6eb0e269a625644f
|
|
As could be seen when running in dbgutil build or with environment
variable OOO_ENABLE_LOCALE_DATA_CHECKS=1
Change-Id: Iaf3b4cbe58acea9fa8aed0b1793e0ff28c089de6
|
|
Change-Id: I0ba08182f1c2b75a5b625f7858c23bcd8ba2dce5
Reviewed-on: https://gerrit.libreoffice.org/12284
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
and
coverity#1250438 Uninitialized scalar field
Change-Id: I029e033feb0805a0f744c68d43602217f9f01f6e
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Thanks to the patch from Kevin Suo, see https://bugs.freedesktop.org/attachment.cgi?id=107768
Signed-off-by: Eike Rathke <erack@redhat.com>
With additional change to the DateAcceptancePattern.
Change-Id: I80695028d51c6b91e9e9418e2d1ce33d76d23893
Reviewed-on: https://gerrit.libreoffice.org/11958
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I8cde0dfd7b760d8075f53b9de8a8d3a81a57dc27
|
|
Change-Id: I583e49180b37705ea124c0d88c2e2a8cb1470dfe
|
|
Change-Id: I88290e5ccfd6ab250fe1526e452609e6de020dcd
|
|
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
|
|
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...
Change-Id: I0a8171aa474070bb1a8584e5c8c714fe34694618
|
|
aa33dd16b0e3075f28c56656678c0f5cb7642222 changed the currency symbol
from ¢ to ₡ but changed only the symbol. Actually changing the number
format codes wasn't necessary at all, but changing only the symbol is
wrong, see also the ATTLIST Currency legacyOnly description in
i18npool/source/localedata/data/locale.dtd
Hopefully nothing relies on the actual symbol used in the number format
codes ...
Change-Id: I92e79403fbb80f18c44dc3ecf5a3830a52fd2ff8
|
|
Change-Id: Ia418876b8535cb69b544217fa7976514e77a88b7
|
|
Change-Id: I569d203178668a2d63f4a53baca51ac16bf2361a
Reviewed-on: https://gerrit.libreoffice.org/11776
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Found while trying to reproduce fdo#83141, but not related to
that - it just happened to trigger the relevant assert on a dbgutil
build.
The change to TextSearch::NSrchFrwrd() fixes the crash triggered
by reproducing the above bug.
The change to TextSearch::NSrchBkwrd() is by analogy but seems an
equally good idea.
Change-Id: I68c2c87b632dd53453f92394519a06f62e41bbad
Reviewed-on: https://gerrit.libreoffice.org/11830
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I084e8dfd026d59374d92d9b4cb45d63af2aea470
|
|
Change-Id: Iea517d2287bded4a702c73dfdd1f182023425d67
|