summaryrefslogtreecommitdiff
path: root/i18npool
AgeCommit message (Collapse)Author
2023-07-06tdf#52577: Classify superscript numbers in Latin-1 block as ScriptType::WEAKKhaled Hosny
So that they inherit the script from the surrounding text like the rest if superscripts and subscripts. Change-Id: Ib5c19f84b080eca0f24009a4e6dd2dd4019441d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154094 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-29loplugin:unusedmethodsNoel Grandin
Change-Id: I95ab7581dec35b113cb657ce8e5ee27c89c73593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29tdf#152723: NatNum12 modifier, keep decimal separator from local settingsJulien Nabet
Change-Id: If49e7b42ac37eead4ef0a902b2e56735bb4017bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153732 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-06-26new loplugin:constexprliteralNoel Grandin
OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-23fix a from-scratch i18npool build problemCaolán McNamara
genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/count_word.brk", "U_FILE_ACCESS_ERROR" make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/count_word.brk] Error 4 make[1]: *** Waiting for unfinished jobs.... genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/edit_word_he.brk", "U_FILE_ACCESS_ERROR" make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/edit_word_he.brk] Error 4 genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_he.brk", "U_FILE_ACCESS_ERROR" make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_he.brk] Error 4 genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_prepostdash.brk", "U_FILE_ACCESS_ERROR" make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_prepostdash.brk] Error 4 genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_nodash.brk", "U_FILE_ACCESS_ERROR" make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_nodash.brk] Error 4 genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_hu.brk", "U_FILE_ACCESS_ERROR" make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_hu.brk] Error 4 genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word.brk", "U_FILE_ACCESS_ERROR" make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word.brk] Error 4 probably since: commit c276694bc06ae460a78532757db08e531b478e20 Date: Wed Jun 21 13:14:42 2023 +0300 Remove another workaround for old versions of ICU Change-Id: I31f07900d46a042a50d1bbbdd889ef6cee6bed8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-21Remove another workaround for old versions of ICUKhaled Hosny
Change-Id: Id13bdb10bf4bf89a136b28a26c4b3d1113971871 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153388 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-21Require icu-i18n >= 66Khaled Hosny
We were requiring ICU 4.6 which was released in 2011, and ifdef'ing our way through newer ICU versions. ICU is a core dependency and it makes no sense to build LibreOffice with such ancient versions of it. This change requires ICU 66 (released in 2020), and removes all the ifdefs for older versions. There are more cleanups to do, but these will be done separately. Change-Id: I2e4f7608a08f4d531b0a4c74bbfdf91a451f833f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153387 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-18Regression from speed up startup time(e51b4fc8c278bfa0b0671bbdb0ab35346881ebb7)Julien Nabet
for getOutlineNumberingLevels TB Jenkins_Linux_Ubsan 26316 [_RUN_____] SwDialogsTest::openAnyDialog 26317 NEXT /i18npool/source/localedata/localedata.cxx:1330:33: runtime error: call to function getOutlineNumberingLevels_de_DE through pointer to incorrect function type ´const rtl::OUString ***(*)(short &, short &, short &)´ 26318 /workdir/CustomTarget/i18npool/localedata/localedata_de_DE.cxx:1475: note: getOutlineNumberingLevels_de_DE defined here 26319 #0 0x7f5f948b75d8 in i18npool::LocaleDataImpl::getOutlineNumberingLevels(com::sun::star::lang::Locale const&) /i18npool/source/localedata/localedata.cxx:1330:33 26320 #1 0x7f5f948263ba in i18npool::DefaultNumberingProvider::getDefaultOutlineNumberings(com::sun::star::lang::Locale const&) /i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx:345:36 26321 #2 0x7f5f948264ee in non-virtual thunk to i18npool::DefaultNumberingProvider::getDefaultOutlineNumberings(com::sun::star::lang::Locale const&) /i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx 26322 #3 0x7f5fc2d8e917 in svx::sidebar::OutlineTypeMgr::Init() /svx/source/sidebar/nbdtmg.cxx:585:35 Change-Id: Ic291f9badad2047980bff848e83bc56b8beaa723 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153235 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-16Fix typoAndrea Gelmini
Change-Id: I914d0d62b1807daddea042ced173195d115f31e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153186 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-16tdf#125154 i18npool,sw: fix group separators in numbers in formulasMichael Stahl
Commit 776f7e7463de3e97f3056712ee567f49a314829d changed cclass_Unicode to reject group separators in numbers by default, but users are complaining that the neat "5.000" numbers in their existing documents are now considered invalid. * in SwCalc, use GROUP_SEPARATOR_IN_NUMBER * in cclass_Unicode::parseText(), reject a group separator if it is not followed by at least 3 digits With this, a number from tdf#42518 "0.19" is still considered invalid, while "5.000" is now valid again. Change-Id: If86f2ed4c27be16f866d7f4cee00789344e9ee2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153047 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-16remove dead codeNoel Grandin
Change-Id: Ia8523e992b30ba8674ca88374906cb3c671df5e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-16speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: Idd27071c1200d6ced2c4f43e10310df786fbc8fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-16speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: I652f02f6f1f354e2dab4f0ca866e8499cd3c50f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-15speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: Ief35b1e3e08ed44c1b9161485a69ef504e1a1c89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-15speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Here we trigger a problem - EditDLL has static data that tends to get torn down __after__ the i18npool shared library has been removed from memory, which means it tries to access OUStringLiteral objects that no longer exists. So use vcl::DeleteOnExit to explicitly clear that on application shutdown. Change-Id: Ie4bfcef7eb4656316ea825474ac42f85844d1dcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-15speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: Iae879408d6761098d0e73526a65863d8f3cdb9ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-14speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: I95214d09938036935a45e8b8e9752596246dd2e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153058 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-14speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: Ia8186b2e6540287eae1312bf9755d5e6bea359c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153057 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-14speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: I4aac81c9224971683cfc7c9085edc7dcd3ee5f10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-14speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: I7d9b7bd923765b3fd37c4c45f4fd47add26beef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153055 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-14fix ubscan buildNoel Grandin
after commit ee76ed70e97448082f4c00c5c4207a44e1a91617 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Jun 13 21:39:31 2023 +0200 speed up startup time Change-Id: I577e2cccc9f17f417e7ae5ef0b8eaa5f90aed48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153041 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-06-14speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: Iecc822169a2fcd2f4678e4d6c303083c54a54456 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153005 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-14speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: I405806aef050e374b18a57cbf47e13a295821ccf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153004 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-29Remove recently unused CTLScriptType codeKhaled Hosny
This is now unused after: commit 98f7ec383db74a6491e925e30125d3fbf270afc2 Author: Khaled Hosny <khaled@libreoffice.org> Date: Sun May 28 16:28:52 2023 +0300 tdf#139863, tdf#155514: Don’t split COMPLEX text portions The code is also broken as it doesn’t handle surrogate pairs. The UNO API now throws an exception. Change-Id: I454ed741e3834e762a2731d671c21a3e73515da3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-05-14use more optional in i18npoolNoel Grandin
Change-Id: If813a8bc339013c58f1b2d1f45f05b58d57f0abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-06update loplugin:stringview* for o3tl::iterateCodePointsNoel Grandin
And change o3tl::iterateCodePoints to use sal_Int32 for its second param, to integrate better with places where the parameter comes from an UNO API, which cannot use std::size_t Change-Id: I7b9dd2c9bc7f48e6c4a912f039f1b5dae7beae69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151421 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-02Resolves: tdf#154987 Add Santali {sat-IN} locale dataEike Rathke
Change-Id: I9da3003a4db91bfa432bb68edcf577b73df5ee2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150949 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-04-28Remove duplicate com.sun.star.i18n.IndexEntrySupplier_ja_phonetic_* implsStephan Bergmann
Ever since 95823ae83c8c13c5c10c5084e2a90549ff2eb25e "#95565#add new phonetic entry for CJK index modules", "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)" was using the same implementation as "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by syllable)", and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)" was using the same implementation as "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped by syllable)". But there appears to be no evidence that those implementation names "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)" and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)" are actually used anywhere (see also c9b6bf655e6de50c55629b4805399932c90a3b30 "Add some tests for (Japanese) i18n::IndexEntrySupplier behavior"). And a problem with the current setup is that instantiation those two implementation names will return implementations whose getImplementationName() does not match those implementation names (but rather returns "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by syllable)" and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped by syllable)", resp.)---which is something that would create failures with an improved CppunitTest_services. Change-Id: I27cf4ffdb2b84195c6d96f8a7a269120f6a17714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151144 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-25tdf#56258 i18npool en-US: re-arrange outline numbering suggestionsJustin Luth
This patch brings order out of chaos, organizing the outline choices into academic, modern, simple numeric, and misc columns. The very first suggestion should be the academic standard. Next comes a distinctly different modern alternative Simple numeric moves over to be above the other numeric, followed by a demo of the kind of mixture that can be designed in LO. Since the academic standard uses Roman numerals, it is offset on the next row by the other one containing Roman numerals followed by a modern classic, and the all-numeric ISO standard retains it current position. The bullet oddball logically remains as the last suggestion. In this patch there was no change made to the actual suggestions themselves. Earlier patches made changes to 3 definitions, which allowed for the nice correlations. I missed changing the descriptive "strings" in the earlier patches. I had assumed earlier that these monotonous descriptions were dynamically produced... Since the English description should not be translated, I added a comment that will be extracted to the PO as a comment. (Thanks Andras). I think it would be nice to use strings "Academic MLA/CMOS/Turabian/OWL compliant outline" "ISO 2145 outine" but that could be made in a separate patch. Let me just point out what happened with the strings in case this helps with translation NOTE: only languages that ultimately inherit from en_US need to re-translate: old RID_SVXSTR_OUTLINENUM_DESCRIPTION_0 -no string change -moved to _3 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_1 -string changed / list modified earlier -moved to _5 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_2 -string changed / list modified earlier -moved to _1 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_3 -no string change -moved to _2 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_4 -string changed / list modified earlier -moved to _0 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_5 -no string change -moved to _4 RID_SVXSTR_OUTLINENUM_DESCRIPTION_6 -no change RID_SVXSTR_OUTLINENUM_DESCRIPTION_7 -no change Suggested translation order: -cut _3 and paste into _2 -cut _0 and paste into _3 -cut _4 and paste into _0 and fix definition -cut _5 and paste into _4 -cut _1 and paste into _5 and re-define -re-define _1 Change-Id: Ie4ec8423acddc24efefb270d9ed19ab77566e6e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150805 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-04-25Group sort bo_IN.xml LC_FORMAT FormatElement for better comparabilityEike Rathke
Change-Id: I6e17c01ce4d3a351a2cb49d214f73468d425b4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150952 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25Inherit ml_IN formats and numberings from hi_INEike Rathke
Change-Id: Ied5f3f8e051d8d9292888d8831ae3e6a88270198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150953 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25Group sort hi_IN.xml LC_FORMAT FormatElement for better comparabilityEike Rathke
... and eliminate doubled space. Change-Id: I84229145072283975ff17e2db661784205fa9af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150950 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25Add some tests for (Japanese) i18n::IndexEntrySupplier behaviorStephan Bergmann
...in preparation for some upcoming i18npool/util/i18npool.component clean-up Change-Id: I8e93aa33759f2bdd6b9422b3833a608cfbed1df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150948 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-24Fix some getImplementationNameStephan Bergmann
...to match the corresponding .component entries, > com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by consonant) etc. rather than > com.sun.star.i18n.IndexEntrySupplier_"(alphanumeric first) (grouped by consonant)" etc. Change-Id: I7fa0f9c7615b5cb1b7c0c6a8908cad27f0ac5712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150760 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-23Fix some getImplementationNameStephan Bergmann
...to match the corresponding .component entries Change-Id: I1f32d4533a49f0988a2d5c2b8d20198baab515a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150761 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-21Fix apparent copy/paste typo in implementation nameStephan Bergmann
...introduced in 155c056b1d4674d5ff73bbb5e1ad1dcd1e6aae36 "i18npool: create instances with uno constructors" Change-Id: Ie9094ec5c58aa98cdb379051ecbad80638aae02a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150759 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-21Fix some getImplementationNameStephan Bergmann
...to match the corresponding .component entry Change-Id: I56ac64be65740450df92f03aac4d2f4f447f08a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150694 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-20Fix some getImplementationNameStephan Bergmann
...to match the corresponding .component entries Change-Id: Ic5286d4969635bee5e606dcf186fbc7b297263c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150695 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-16Document locale data ReservedWordsEike Rathke
Change-Id: Ie7085e437f6c80a7d13c9d01a7259f97ab05649c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150454 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-16Resolves: tdf#154832 Add Creole (Mauritius) {mfe-MU} [0x06B2] locale dataEike Rathke
Change-Id: Ia49e3dfb6ef7abc35f981712077018f98ef94297 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150449 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-13Fix UBSan function-type-mismatchStephan Bergmann
...as seen with the additions to CppunitTest_i18npool_transliteration made here, > i18npool/source/transliteration/textToPronounce_zh.cxx:175:17: runtime error: call to function get_zh_zhuyin through pointer to incorrect function type 'unsigned short **(*)()' > workdir/CustomTarget/i18npool/indexentry/zh_zhuyin.cxx:1512: note: get_zh_zhuyin defined here > #0 in i18npool::TextToPronounce_zh::TextToPronounce_zh(char const*) at i18npool/source/transliteration/textToPronounce_zh.cxx:175:17 > #1 in i18npool::TextToChuyin_zh_TW::TextToChuyin_zh_TW() at i18npool/source/transliteration/textToPronounce_zh.cxx:149:5 > #2 in TextToChuyin_zh_TW_CreateInstance(com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory> const&) at i18npool/source/registerservices/registerservices.cxx:236:1 > #3 in cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceEveryTime(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx:173:24 > #4 in cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx:230:12 > #5 in non-virtual thunk to cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx > #6 in cppuhelper::ServiceManager::Data::Implementation::doCreateInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx:709:26 > #7 in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool) at cppuhelper/source/servicemanager.cxx:675:16 > #8 in cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx:1006:36 > #9 in non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx > #10 in i18npool::TransliterationImpl::loadBody(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::i18n::XExtendedTransliteration>&) at i18npool/source/transliteration/transliterationImpl.cxx:619:45 > #11 in i18npool::TransliterationImpl::loadModuleByName(std::basic_string_view<char16_t, std::char_traits<char16_t>>, com::sun::star::uno::Reference<com::sun::star::i18n::XExtendedTransliteration>&, com::sun::star::lang::Locale const&) at i18npool/source/transliteration/transliterationImpl.cxx:630:5 > #12 in i18npool::TransliterationImpl::loadModuleByImplName(rtl::OUString const&, com::sun::star::lang::Locale const&) at i18npool/source/transliteration/transliterationImpl.cxx:278:9 > #13 in (anonymous namespace)::Transliteration::testTextToChuyin_zh_TW() at i18npool/qa/cppunit/transliteration.cxx:120:27 For one, there had always been a mismatch between the return type `const sal_uInt16**` generated in i18npool/source/indexentry/genindex_data.cxx since d319c4611e932b286c0bef14387382da0f2e92d2 "INTEGRATION: CWS i18n24 (1.1.2); FILE ADDED" vs. `sal_uInt16**` used in i18npool/source/transliteration/textToPronounce_zh.cxx since f4705bf0a3efeebfe74568abb355ad60621300dd "INTEGRATION: CWS i18n24 (1.8.36); FILE MERGED". And for another (and more severe, as it caused random writes), there had also been a mismatch between the parameters `(sal_Int16 &max_index)` newly generated in i18npool/source/indexentry/genindex_data.cxx since 7696cd3902ca248951205f15930787488368ea26 "INTEGRATION: CWS i18n31 (1.4.60); FILE MERGED" (and correctly used in i18npool/source/indexentry/indexentrysupplier_asian.cxx since 58dcf0ffaf8668827fc2f47445c9d8faf3d29555 "INTEGRATION: CWS i18n31 (1.9.60); FILE MERGED") vs. the original `()` used in i18npool/source/transliteration/textToPronounce_zh.cxx ever since f4705bf0a3efeebfe74568abb355ad60621300dd "INTEGRATION: CWS i18n24 (1.8.36); FILE MERGED". For DISABLE_DYNLOADING, the second (missing max_index parameter) issue appears to have been broken even further with 9db03b879b912d79060ab06f03a54d4a59e6ac65 "i18npool: fix wrong static function symbols", replacing the wrong sal_uInt16** get_zh_zhuyin(); sal_uInt16** get_zh_pinyin(); declarations in i18npool/source/transliteration/textToPronounce_zh.cxx with the even worse declarations sal_uInt16** get_collator_data_zh_zhuyin(); sal_uInt16** get_collator_data_zh_pinyin(); corresponding to function definitions generated by i18npool/source/collator/gencoll_rule.cxx (which also happen to have zero parameters, but non-matching return types, and apparently completely different collation vs. transliteration semantics). Change-Id: Id91b17eeb7fcdd0c711d52a624375356dc47fc32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150302 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-12loplugin:stringview whitelist getLength and isEmptyNoel Grandin
Change-Id: I38f3410c0b25ff579879b9de1f266af4d8fd51e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-05Add missing constructor attributesStephan Bergmann
...that were apparently forgotten by 155c056b1d4674d5ff73bbb5e1ad1dcd1e6aae36 "i18npool: create instances with uno constructors" and d2140a6320cd1cf4dea29b174cdb3bcb5261056b "i18npool: create instances with uno constructors", respectively Change-Id: I3caedf9d2a941a8671fab554a2358776d95c4938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150066 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-05Remove dead com.sun.star.i18n.Transliteration.ignoreKana service implementationStephan Bergmann
In 2002, fc680b643030fc2c99dcfffe75e762ee35e5f292 "#97583# Modify for new services" had added the two com.sun.star.i18n.Transliteration.IGNORE_KANA and com.sun.star.i18n.Transliteration.ignoreKana service implementations, both using the also added ignoreKana_CreateInstance factory function, to i18npool/source/registerservices/registerservices.cxx (back in a time when that still used active component registration via component_writeInfo). Then in 2010 a3c8a0ed0c5c6be1cb5c940750222f6381608bd7 "sb129: #i113189# change UNO components to use passive registration" (dropping the active component registration via component_writeInfo) faithfully listed both those service implementations in i18npool/util/i18npool.component. And in 2014 a4f17c00b16f5a983cd91ac5d2c43454f1775931 "i18npool: Constructor feature for few more implementations" switched the com.sun.star.i18n.Transliteration.IGNORE_KANA service implementation to use a constructor attribute in i18npool/util/i18npool.component. But it also removed from i18npool/source/registerservices/registerservices.cxx the ignoreKana_createInstance factory function and the > IMPL_TRANSLITERATION_ITEM (ignoreKana), aInstances element through which the other com.sun.star.i18n.Transliteration.ignoreKana service implementation was created via i18npool_component_getFactory. (It presumably either intended to also change com.sun.star.i18n.Transliteration.ignoreKana to use a constructor, but forgot to implement that, or accidentally broke that service implementation.) So the com.sun.star.i18n.Transliteration.ignoreKana service implementation has not been instantiatable ever since 2014. But it appears that nobody missed it much, so maybe it had already been a mistake to add it (alongside the com.sun.star.i18n.Transliteration.IGNORE_KANA service implementation) in 2002. So just remove it completely for good now. Change-Id: Ieda888038a70f4123a0c5f9f4e3306491f32ed64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150068 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-05tdf#148906: Ukrainian letters miss in bullets and numbering dialogJulien Nabet
Change-Id: Ieef2b2a7052da342709baf298b618d2c29fa3e43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149768 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-04Fix typos in XML that broke three implementation elementsStephan Bergmann
The typos all originated with d2140a6320cd1cf4dea29b174cdb3bcb5261056b "i18npool: create instances with uno constructors", causing three intended constructor attributes to rather be plain character data. Which apparently went unnoticed until recently (see the TODOs resolved here that had been introduced with 456a146b9eb643655ae2bd336740e8c5536913aa "tdf#151971: Fix used implementation names of transliteration services"), in part because the Parser class in cppuhelper/source/servicemanager.cxx silently ignores any unexpected character data via xmlreader::XmlReader::Text::NONE.) Change-Id: Ia8fdbc09c67d10530b4d86dbbbde2b6b84038e66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150021 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-04tdf#151971: Fix used implementation names of transliteration servicesStephan Bergmann
...after 04af4e4f55f3ef319a78edd4d0109e2e7eba90b6 "[API CHANGE] Fix all bad UNOIDL identifiers across offapi" had changed the spelling (character case) of some of the css.i18n.TransliterationModules[New] enum values involved here, so that the TmItem1 macro generated broken TMList::implName values now. (Which in turn caused TransliterationImpl::loadBody to throw "unsatisfied query for interface of type com.sun.star.i18n.XExtendedTransliteration!" css::uno::RuntimeExceptions, which remained uncaught.) Also add a test verifying that loading all those transliteration services no longer fails throwing exceptions. Which lead to two open TODOs: For one, the value of maxCascade in i18npool/inc/transliterationImpl.hxx might come from a time when there were fewer TransliterationModules[New] enum values and might no longer be appropriate. This would need some further investigation. But for another, there are two transliteration services that cannot currently be instantiated. That looks like a regression that should be fixed in a follow-up commit. Change-Id: Icfca3e841360d4b471013e2c96d6868a75a21a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150018 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-30loplugin:stringadd in variousNoel Grandin
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I8cf6a47ad357ddc73e2c430d966be72d5efd1485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149767 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-28Resolves: tdf#154433 Correct {uk-UA} quotation mark charactersEike Rathke
Change-Id: Id5c251ee632d2da134ffbbb352844152f12c1f77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149654 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-18loplugin:stringadd use more O[U]StringCharNoel Grandin
Change-Id: I196e4539ad430a39415eff9d7170b33df7228230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-27 16:16:08 +0000