summaryrefslogtreecommitdiff
path: root/i18npool
AgeCommit message (Collapse)Author
2023-01-10tdf#56258 i18npool en-US: partial revert 5th outline levelJustin Luth
This reverts the change of A.I.a.i. -> A.I.a.i.1. made by commit dd8ed1fdbc63499ac958d28536c3c5540455358b. While it wasn't necessarily a bad change, it no longer has any justification, since the complementary change in the other outline definition was modified to become MLA compliant. Rather than make any change at all, just revert back to the original definition, and leave the level definition to the normal 4 levels of numbering before the bullets start. Change-Id: I88d792a6dd20bd519755349905975cf9028f9fa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145236 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-10tdf#56258 i18npool en-US: extend outline 1.a) to 4 levelsJustin Luth
Change 1. a) -> 1) a) 1) A) This is intended as a clean, modern style of outline that has good visual spacing in LibreOffice. This differentiates it a bit more from the first option, and extends the numbered level to the typical depth of 4, while still keeping a logical suffix pattern and maintaining the general "theme" of the previous definition. Yes, it is a bit odd to have a capital A following a smaller case a. However, this is at the fourth level, which isn't reached very often, and I wanted to keep a choice that focuses on a small a. Surprisingly, with the default 12pt/Liberation font, a 10) still fits in the allotted space before the tabstop, so in most cases this outline will have proper visual spacing all the way up to 99). There are plenty of choices that start with 1 followed by a dot, so I used this opportunity to create the only list that starts with a ")" suffix. Google docs for example has a 1) a) i) choice, but for modern lists I don't think we want to use roman numerals. Change-Id: I34725d6aa113831eaeaa88c295b3b3f1294f8998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145155 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-09tdf#56258 i18npool en-US: document ISO 2145 compliant outline list formatJustin Luth
Change-Id: I2cccc7c2c3621434a4dbbcdd032672c668632494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145158 Tested-by: Jenkins Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-09tdf#56258 i18npool en-US: replace illogical outline 1.(a).i.AJustin Luth
Change 1.(a).i.A. -> A.1.a.1. This is intended as a clean, modern style of outline that has good visual spacing in LibreOffice. It provides a simple alternative to the second style, reversing the order while still keeping a logical suffix pattern. This design will easily allow large/long lists to fit in the allotted space before the tabstop. There was no attempt to match the theme of the previous definition, since it neither looked good in LO's default spacing, nor was it consistent/logical. Change-Id: If7de1302110a3c97922bd2eeba7a917444110b27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145156 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
2023-01-09tdf#56258 i18npool en-US: change outline order to match MLA styleJustin Luth
Changed I.A.i.a) -> I.A.1.a.i. The overwhelming result of a google search for "official/correct outline list format" indicates that the third level should be a 1, not an i. MLA Handbook (according to wikipedia) uses the order I.A.1.a.i. (a) (1) i) Chicago Mode of Style is usually interpreted as I.A.1.a) or I.A.1.a. with varying lower sublevels/suffixes. Wikipedia also suggest the logical order of I.A.1.a.i.I) A) 1) a) i) (I) (A) (1) (a) (i) Change-Id: I7fcc8a1ee727d6cddca4bf0c6a8461538769cf5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145147 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-06tdf#56258 i18npool: add "adjust" to locale.dtd for outline numberingJustin Luth
Although Adjust was already defined in all of the code structures, it was not defined in the dtd file. Thanks to Eike for pointing out this requirement. Change-Id: I43ed0c26ed5bccb2309a255db79f5afa32f78c38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145146 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2023-01-06tdf#56258: allow i18npool to define SvxAdjust for outlineJustin Luth
Deciding whether the numbering should be Left, Right, or Center is a rather important setting. Specifically for Roman numerals (which grow very wide as they increment to 7 and 8) the numbering styles set these to right aligned. This really helps for keeping the text nicely aligned. The numbering styles are built-in LO defaults, but locale files can define numbering and outline choices. This patch add the setting for "adjust" on the outline levels. For en_US, it makes sense to right-align roman numeral levels. [The only other highly likely candidate for this that I could find was old Hungarian (SZEKELY_ROVAS), but it doesn't seem to be used in any locale definitions.] I only changed en_US for now, but of course many other locales are also using NumType="3" and NumType="4". This only applies to the toolbar/sidebar SVX code path. The Bullets and Numbering dialog does not currently modify any spacing, so I didn't apply the adjustment either. It also doesn't make sense to do this on single numbering changes (aka ContinuousNumberingLevels or LC_NumberingLevel) because we don't know or control the first line indent there either. But at least for toolbar Outlines, we do change every level, and so can set a (somewhat) appropriate spacing. [Setting SvxAdjust without adjusting the spacing is pointless. Don't make any changes at all if the spacing ends up causing problems.] The Numbering IVX/ivx styles set the firstLineIndent to -174, so I did the same here. This is the scariest part of this change. AFAICS SvxAdjust::Left is a non-locale aDefNumStyle default, so hardcoding that for undefined LC_OutlineNumberingLevel shouldn't be too scary. Change-Id: I52deefe88aa55c55c9531b651411f64accb86f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144978 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-05tdf#56258 en_US: increase outline levels definitions to 6Justin Luth
There are 10 levels in numbering, so it only makes sense to allow outline definitions for all 10 levels. Note that DOC/X formats only allow 9 levels, There are two code paths that read these definitions. The SVX toolbar code to allow 10 levels (SVX_MAX_NUM) was already completed in the previous patch. This commit allows 10 levels for the Bullets and Numbering menu dialog. Since all choices MUST define the same number of levels, I only added one more. I hope that there isn't some secret kind of requirement that ALL LOCALE's must also use the same number of definitions - it doesn't seem to. [Although not a direct comparison, bg_BG defines 10 single number levels, compared to en_US's 8, and some Chinese locales also do more than 8.] Change-Id: Ibe00d54cfa4577db83eba368b92be11055b076ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144976 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-05Revert all the recent loplugin:unocast changesStephan Bergmann
...as obsoleted by ef533553559fe09b4afab651fc692885d1acf4ed "Rudimentary support for dynamic_cast on UNO proxy objects". This reverts all of: 4cfcc9ac37b90ce64c8402a41eb4638adb185b5c "loplugin:unocast (framework::Desktop)" 03efbf72f4ddf7a84aa8aabef348331bd4b75e8a "loplugin:unocast (vclcanvas::TextLayout)" 80099fdd51a69eaa6c36ca88ef772810e4a777fa "loplugin:unocast (SalGtkXWindow)" cc147f576d8687fb79c77d47d41dc4ba1678a469 "loplugin:unocast (sdext::presenter::CachablePresenterView)" 40db42be1d8fd0f9c6c8c5ba3767ddb9ee2034c2 "loplugin:unocast (vclcanvas::CanvasFont)" 2d1e7995eae29e2826449eb5179f5fae181794a5 "loplugin:unocast (CairoColorSpace)" 4c0bbe4bd97636207cf71a6aa120c67698891da9 "loplugin:unocast (canvas::ParametricPolyPolygon)" 89803666621c07d1b1ac9d3bd883f0ca192a91a0 "loplugin:unocast (vclcanas::CanvasBitmap)" d5e0c2c8db71878d21c2a7255af08cf5f9a6dd04 "loplugin:unocast (sfx2::DigitalSignatures)" c0c4519e0d5b555f59bbc04cc616454edfd1f4ce "loplugin:unocast (VCLXAccessibleComponent)" feb8b833a6245d42400f42a0bc789dc84594ee6f "loplugin:unocast (VCLXDialog)" 1fa58cc6cc9c3849753342a5d9a6ddfa461b5e66 "loplugin:unocast (VCLXMultiPage)" f481f036deb1b1b46f3038074c4659f3a91b9c6c "loplugin:unocast (DocumentSettingsSerializer)" 73df933f5fa5932f94e5a1b338a3eda00a9ce354 "loplugin:unocast (css::embed::EmbeddedUpdate)" 420165ab0ef03c0467f9d17f504de2d2fc78f0e6 "loplugin:unocast (canvas::tools' StandardColorSpace, StandardNoAlphaColorSpace)" 9abe8ee067e6c00f19d8a13346d53c4641c27166 "loplugin:unocast (MutableTreeNode)" 9f3022ceb036f23b4b0994c3e2fbd1001bff225a "loplugin:unocast (VCLXTabPage)" 1be70dda02c12a60778b7607cff2520ae1aa611e "loplugin:unocast (vcl::unotools::VclCanvasBitmap)" d6a70bb641b96e8e5616448c2378131ed62658b4 "loplugin:unocast (basegfx::unotools::UnoPolyPolygon)" 5a14f009e6782c077463c8cbb8e9cea3d7950107 "loplugin:unocast (xmlsecurity::Certificate)" 99009c9535dfa3e0d838989ccc7d84bfa2320ff4 "loplugin:unocast (sd::Annotation)" 0c7585c5fa78887e5459885ed744e8044fd76137 "loplugin:unocast (sd::TextApiObject)" 24e14afd1bfcaed6c200ab081973fba7e47267ca "loplugin:unocast (SignatureVerifierImpl)" 1a7ad0c10d286ce9ae2700ceb2fd50eed1fb43a4 "loplugin:unocast (pcr::PropertyEventTranslation)" a97e2d2702d9a6f37775ccee2c08c4f3b2479c4b "loplugin:unocast (RangePageBreaks)" 19dfdf86ad1f5b08041d8b7a9f196caf881231ab "iloplugin:unocast (pcr::OFormattedNumericControl)" f9785ea595fd8e911f6370e836fa579225b9e571 "loplugin:unocast (frm::OInterfaceContainer)" 5e5f40a4a92a31b0932c690219d002fcf18598cf "loplugin:unocast (ScVbaShapes)" 27b35b2c215b4832d4378ec3a7ecbba926552d06 "loplugin:unocast (ScVbaShapeRange)" cb3108f860065928552a86cf8acc4b3a95718ecf "cid#1517812 Dereference null return value" feba0ddb1521d1142560fe54b7d7696ee910237f "loplugin:unocast (weld::TransportAsXWindow)" 4d6c23216559eb48f9943bb49d6e475a6d64ba15 "loplugin:unocast (oox::ForumlaImExportBase)" 4844c096a8ab6a9a620c410a0949d4499f12a504 "loplugin:unocast (cairocanvas::SurfaceProvider)" 9a0b523e0a84d403b9092176ccec4b3e3efe42d0 "loplugin:unocast (cairocanvas::CanvasBitmap)" 8a5648d8e59b4b007dbbf3824777c19a21efc61e "loplugin:unocast (cairocanvas::TextLayout)" 28c27a0623bc78a0590858f97d03b620985bc84c "loplugin:unocast (cairocanvas::CanvasFont)" 53bc223cb3288e32a417696ee61c29e5f01f209d "loplugin:unocast (cairocanvas::RepaintTarget)" 5f70b0b9f6bc4ab145ddbd9155590ed4a3b1b9ec "loplugin:unocast (SvXMLImport)" 068187a898cdd2e26e9b16c348ecc1ed2dee3f29 "loplugin:unocast (VCLXWindow)" 88b4f966202717cd4ad38a30a8eda22c3e69ed35 "loplugin:unocast (sfx2::sidebar::SidebarController)" f1b7a69b280aefe2f1b3b0f32193494fd765f2bd "loplugin:unocast (SvxLineStyleToolBoxControl)" ba76f0ba7e8de4d2953739c952004b7d9af47197 "loplugin:unocast (i18npool::Calendar_gregorian)" 840154daf934d8df52ead1cb7acd798c4d30f007 "loplugin:unocast (framework::AddonsToolBarWrapper)" b0e9c4c5f063cefa9557810e3349bdb9c7493091 "loplugin:unocast (GrammarCheckingIterator)" 8ee6cfc9655ce9de4617cea1a0d9cb9d7a4fbfac "loplugin:unocast (ucb::ucp::ext::Content)" 5b8cd77c112bc8c0e92b8fec215c3c8e802bbc0a "loplugin:unocast (basic::SfxScriptLibraryContainer)" 9e73ff9fce12e102bb3c3cea8d8bb96c88f2c9ad "loplugin:unocast (sdext::presenter::PresenterNotesView)" a98acca8fbc38d3fd5600ae5056a8e42b6d8a40d "loplugin:unocast (SelectionChangeHandler)" c0b59ad6e35b0cb0dea0821e95f95569739078c1 "Consistently use comphelper::getSomethingImpl<I>(aIdentifier, this)" 276e3ccbdd3259ec3daf8a1a98fa7f406b14e21c "loplugin:unocast (vclcanvas::RepaintTarget)" Change-Id: I37c73e3422a5154bf6cb647640d2d3f23db8bc34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-03NFC tdf#56258 i18npool OutLineNumberingLevel: use ref="en_US"Justin Luth
In preparing to see what improvements can be made to list defaults, it is helpful to see what customizations have been made to the US defaults. Those that match identically were changed to simple refs. Thanks to https://www.linuxtopia.org/online_books/ linux_tool_guides/the_sed_faq/sedfaq4_013.html The script there helped to generate sed expressions. sed -f ref.sed *.xml ----- ref.sed ----- \#<LC_OutLineNumberingLevel>#,\#</LC_OutLineNumberingLevel># { :ack N; \#</LC_OutLineNumberingLevel>#! b ack s#<LC_OutLineNumberingLevel>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="1" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix="(" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="3" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="0" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix="." \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="2" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="0" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="3" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="0" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="2" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="3" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="1" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="2" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="3" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="4" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="27A2" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="E006" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=")" \+BulletChar="E004" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ </LC_OutLineNumberingLevel>#<LC_OutLineNumberingLevel ref="en_US"/>#; } ------------------- Change-Id: I6853c09ed10a9d71b39e79fb665f7d056e945864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144945 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-03tdf#56258 i18npool: should be a SvxAdjust, not a HoriOrientJustin Luth
Although this is unused AFAICS, lets at least use the correct enum, because these two do not match up. HoriOrient::LEFT = 3, while SvxAdjust::Left = 0 (3 is Center) Change-Id: I1cd8cce6d4e223ac272d8d4ba5e22c52c7657499 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144977 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-02NFC tdf#56258 i18npool NumberingLevel: use ref="en_US"Justin Luth
In preparing to see what improvements can be made to list defaults, it is helpful to see what customizations have been made to the US defaults. Those that match identically were changed to simple refs. Thanks to https://www.linuxtopia.org/online_books/ linux_tool_guides/the_sed_faq/sedfaq4_013.html The script there helped to generate sed expressions. sed -f ref.sed *.xml ----- ref.sed ----- \#<LC_NumberingLevel>#,\#</LC_NumberingLevel># { :ack N; \#</LC_NumberingLevel>#! b ack s#<LC_NumberingLevel>\ <NumberingLevel NumType="4" Prefix=" *" \+Suffix=")" */>\ <NumberingLevel NumType="4" Prefix=" *" \+Suffix="." */>\ <NumberingLevel NumType="4" Prefix="(" \+Suffix=")" */>\ <NumberingLevel NumType="2" Prefix=" *" \+Suffix="." */>\ <NumberingLevel NumType="0" Prefix=" *" \+Suffix=")" */>\ <NumberingLevel NumType="1" Prefix=" *" \+Suffix=")" */>\ <NumberingLevel NumType="1" Prefix="(" \+Suffix=")" */>\ <NumberingLevel NumType="3" Prefix=" *" \+Suffix="." */>\ </LC_NumberingLevel>#<LC_NumberingLevel ref="en_US"/>#; } ------------------- ----- ref2.sed ----- \#<LC_NumberingLevel>#,\#</LC_NumberingLevel># { :ack N; \#</LC_NumberingLevel>#! b ack s#<LC_NumberingLevel>\ <NumberingLevel Prefix=" " \+NumType="4" Suffix=")" */>\ <NumberingLevel Prefix=" " \+NumType="4" Suffix="." */>\ <NumberingLevel Prefix="(" \+NumType="4" Suffix=")" */>\ <NumberingLevel Prefix=" " \+NumType="2" Suffix="." */>\ <NumberingLevel Prefix=" " \+NumType="0" Suffix=")" */>\ <NumberingLevel Prefix=" " \+NumType="1" Suffix=")" */>\ <NumberingLevel Prefix="(" \+NumType="1" Suffix=")" */>\ <NumberingLevel Prefix=" " \+NumType="3" Suffix="." */>\ </LC_NumberingLevel>#<LC_NumberingLevel ref="en_US"/>#; } -------------------- Change-Id: I85d8a8ed095f19d08b035d7f2c4e2cd94ff08c76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144890 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-01tdf#152785: typo "disabte" instead of "dissabte" for Saturday in occitanJulien Nabet
Refs: 1) https://locongres.org/oc/aplicacions/dicodoc-oc/dicodoc-recerca?option=com_dicodoc&view=search&Itemid=168&type=fr-oc&dic%5B%5D=BASIC&dic%5B%5D=LAUS&dic%5B%5D=LAGA&q=samedi&q2=&submit=Cercar 2) https://en.wiktionary.org/wiki/Appendix:Days_of_the_week like this since the beginning 5b7b4e81144619c8350b5c59d9d17ba7f75aeccb " INTEGRATION: CWS locales23 (1.1.2); FILE ADDED 2007/04/25 19:14:54 er 1.1.2.1: #i76044# add Occitan_France (oc_FR) locale data; contributed by Bruno Gallart <bgallart@ooo> " Thank you to quentinantonin@free.fr for having spotted this + provided refs! Change-Id: I8b81e561885bc2e1eea6c5f88a3924ea58141791 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144926 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-12-17tdf#152520: Crash when using TITLE_CASE/SENTENCE_CASE in Transliteration moduleJulien Nabet
relevant part of bt: 7 0x00007f50c85b3796 in com::sun::star::uno::Sequence<int>::realloc(int) (this=0x0, nSize=11) at include/com/sun/star/uno/Sequence.hxx:215 8 0x00007f50c85d9240 in i18npool::transliterate_titlecase_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t> >, int, int, com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<int>*) (inStr=u"AB cd. eF. ", startPos=0, nCount=11, rLocale=..., pOffset=0x0) at i18npool/source/transliteration/transliteration_body.cxx:267 9 0x00007f50c85d955b in i18npool::Transliteration_sentencecase::transliterateImpl(rtl::OUString const&, int, int, com::sun::star::uno::Sequence<int>*) (this=0x557834ea0bb0, inStr="AB cd. eF. ", startPos=0, nCount=11, pOffset=0x0) at i18npool/source/transliteration/transliteration_body.cxx:298 10 0x00007f50c85dcc10 in i18npool::transliteration_commonclass::transliterateString2String(rtl::OUString const&, int, int) (this=0x557834ea0bb0, inStr="AB cd. eF. ", startPos=0, nCount=11) at i18npool/source/transliteration/transliteration_commonclass.cxx:109 11 0x00007f50c85dcc5d in non-virtual thunk to i18npool::transliteration_commonclass::transliterateString2String(rtl::OUString const&, int, int) () at i18npool/source/transliteration/transliteration_commonclass.cxx:109 12 0x00007f50c85e0d89 in i18npool::TransliterationImpl::transliterateString2String(rtl::OUString const&, int, int) (this=0x557834854dc0, inStr="AB cd. eF. ", startPos=0, nCount=11) at i18npool/source/transliteration/transliterationImpl.cxx:395 full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=184205 Regression from: c7551e8a46e2f9f8142aa7921a0494221ae096e8 (speedup CharacterClassificationImpl::toUpper) Change-Id: I40e383fc87213d88fbde50876f61947b04190a90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144375 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-14loplugin:unocast (i18npool::Calendar_gregorian)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I1b0e544145c364cb9ee669b913132f41c1a8a66a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144147 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-28Resolves: tdf#148792 Add Portuguese (Mozambique) {pt-MZ} locale and dataEike Rathke
Basically copies pt_PT.xml but replaces translated with untranslated keywords (AA,AAAA => YY,YYYY), hence no ref="pt_PT" for LC_FORMAT (and LC_CTYPE). Also use sort-formats.awk -v group=1 to sort FormatElement by usage group and formatIndex as those went quite wild over time.. Change-Id: Iececac0ebdd0317fd14ab65f32c08501f3ce32c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143398 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-27{pt-AO} change to untranslated YY,YYYY keywords, translated AA never workedEike Rathke
Apparently copied from {pt-PT} year AA and AAAA format codes should not had made it across but also never worked as LANGUAGE_USER_PORTUGUESE_ANGOLA was missing in ImpSvNumberformatScan::SetDependentKeywords() so date codes displayed literal AA instead. Seems no one is using that locale with dates.. Since commit 5d833d37851597c1fb9076710d9eb03e4c94ca07 CommitDate: Fri Apr 8 20:51:13 2011 +0200 add pt_AO locale data (edited version of Mandrake's patch) Change-Id: Icd5f81d0a49462ad2514655742d6c05f069f55fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143354 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-27Resolves: tdf#150011 Switch default currency HRK Croatian Kuna to EUR EuroEike Rathke
HR will join Euro area on 2023-01-01. Change-Id: I3836804ff68419550091826ea2414bc0edd55a84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143346 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-23loplugin:unusedfields make some fields privateNoel Grandin
this is one of the secondary analyses this plugin performs Change-Id: Iaa4424c2396470c6f1df85b0290fbffdda35fa08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-22loplugin:unusedfieldsNoel Grandin
Change-Id: Icf6e7e116a087e7f68b86bdb645850a2edaa2f78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143087 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-14tdf#115007 i18npool: add NatNum12 support to Persian, fix HebrewLászló Németh
Add NatNum12 cardinal support for new Persian (Farsi) module of libnumbertext 1.0.11. Hebrew has no uppercase letters, also currency support is broken yet, so remove bad number formats. Follow-up to commit b7d53247eb2fab04f5f6d82d405f1ac0c73542b2 "tdf#115007 i18npool: add NatNum12 formats to locale" and commit 6064b3382102bcbc153156f5874fbc8dfde97b98 "tdf#115007 tdf#148672 bump libnumbertext 1.0.11". Change-Id: I9a2a40e7485d4d4ff150d9946e58aed0d7526678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142658 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-06-Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): i18npoolStephan Bergmann
Change-Id: Id5c9892df6dd3f4e66098a312a79e91bd6b9e8ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142328 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-03tdf#115007 i18npool: add NatNum12 formats to localesLászló Németh
supported by libnumbertext. Note: English currency formats got title case and upper case items, the other one lower case and upper case items. English standard numbers got title case, sentence case, lower and upper case items, while the other one got all cases except title case. Note: libnumbertext update will fix missing currency names of en_DK, en_IS etc.; Irish; es_SV, es_VE etc. Change-Id: I1621d1256e06e9fd843f5b66fd39b16f12cf1b96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142126 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-03tdf#115007 add NatNum12 number format list items, fix title caseLászló Németh
Add NumberText NatNum12 number formats, e.g. "One Hundred", and currency formats, e.g. "One U.S. Dollar and Twenty Cents" to number formatting dialog windows, i.e. Format Cells->Numbers in Calc and Format Numbers in Writer (Edit Fields->Format-> Additional formats...). Fix also bad English title case: "One Euro *and* *Twenty-Two* cents" (not *And* and *Twenty-two*) Details: – svl: list NatNum12 NumberText currency codes in Currency formats (i.e. after choosing Currency category). – svx: Recognize bank symbol "CURRENCY" in NatNum12 parameters defined in locale resource files. For example, "[NatNum12 CURRENCY]" is converted to "[NatNum12 USD]" in the number format dialog windows, using bank symbol of the current locale settings. Recognize compatible (old) bank symbol "CCC" in NatNum12 parameters defined in locale resource files. For example, "[NatNum12 CCC]" is converted to "[NatNum12 DEM]" in the number format dialog windows, using bank symbol of the compatible currency of the German locale settings. User-defined formats with arbitrary bank codes are recognized as currency formats, e.g. modifying "[NatNum12 USD]" to "[NatNum12 EUR]" in the dialog window results a new currency format item. – i18npool/*en_US.xml: define four Standard NatNum12 formats (lower case, sentence case, title case, upper case) and four Currency NatNum12 formats (title case, title case with digits, upper case, upper case with digits). – cui: use lower sample numbers for spell out formats: – 100 for Standard: One Hundred one hundred One hundred ONE HUNDRED – 1.2 for Currency: One U.S. Dollar ONE U.S. DOLLAR One U.S. Dollar and Twenty Cents ONE U.S. DOLLAR AND TWENTY CENTS – i18npool: fix English title casing of NatNum12 conversions: – Don't apply casing on "and", according to the title case rules, for example: "One Euro and One Cent" instead of "One Euro And One Cent". – Apply casing on the second element of the hyphenated compound words: "Twenty-One" instead of the bad "Twenty-one". – add unit test for extended Number and Currency categories. Note: according to the changes, update user-defined number format id in chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt Change-Id: Ieaf9a8f75a4f197b858eaf67f83484df70295834 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141994 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-10-13Change split regexp from \~ to ~Eike Rathke
gawk: ./list-dateacceptancepattern.awk:70: warning: regexp escape sequence `\~' is not a known regexp operator Also set the executable bit again.. Change-Id: Icdf45979d6fb19d207dcf5475845767438c3ef6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141340 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-11Deduplicate O(U)StringConcatenationMike Kaganski
And use an overloaded helper function with a better (?) unified name to show that the result is not an O(U)String. Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-06Do not use double hyphen in DTD comment to satisfy xmllintEike Rathke
Change-Id: I0358abf107c2c80aa142627dd37819c55023be10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141028 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-24tdf#151148 Finding KATAKANA which has voice consonant mark wrongNoel Grandin
regression from commit c7551e8a46e2f9f8142aa7921a0494221ae096e8 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Sep 16 10:36:48 2021 +0200 speedup CharacterClassificationImpl::toUpper Change-Id: I0309dec3d08220b9616be185360013869598fa1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140541 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-21tdf#135451 - Change the skipSpace implementation of the break iteratorAndreas Heinisch
Change the ICU whitespace function of the break iterator from u_isWhitespace to u_isUWhiteSpace to include no-break spaces. u_isWhitespace includes Java isWhitespace; Z + whitespace ISO controls but excludes no-break spaces u_isUWhiteSpace includes all code points with the Unicode White_Space property; most of general categories "Z" (separators) + most whitespace ISO controls (including no-break spaces, but excluding IS1..IS4) See https://unicode-org.github.io/icu-docs/apidoc/dev/icu4c/uchar_8h.html for further details. Change-Id: I21fddefaf2149096824908f644310a59d6e2f38d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137582 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-08-19tdf#91764: Combining marks from “complex” scripts can’t be searched forKhaled Hosny
Don’t skip search results that are in the middle of a grapheme cluster (AKA cell in LO speak). It is not clear why it was done like this, as these checks are present all the way back to the first commit of this file: commit 36eb193f4809221af42c01c5ac226a97cf74ec21 Author: Rüdiger Timm <rt@openoffice.org> Date: Tue Apr 8 15:01:00 2003 +0000 INTEGRATION: CWS calc06 (1.1.2); FILE ADDED 2003/03/26 15:54:42 er 1.1.2.1: #i3393# moved from i18n module, cleaned out tools module usage, and added support for regexp But ignoring such results and only for so-called “complex” scripts seems arbitrary, and as the linked issue shows, people want to be able to search for combining marks. Furthermore, it prevents searching for a base character followed by a combining mark, unless ignoring diacritics is enabled. Change-Id: I530788d928861ddfa18dd7b813d0a13f53c0b77b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138410 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-07-22Resolves: tdf#150011 Add HRK Croatian Kuna conversion to EUR EuroEike Rathke
TODO: switch defaults before 2023-01-01 in i18npool/source/localedata/data/hr_HR.xml Change-Id: Ifc62aefbc8c9fe8bbf044f61ae4fd6eeff692185 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137371 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-21elide some makeStringAndClear() callsNoel Grandin
Change-Id: I8636102554a76f2ba3f6297219b40761473a4489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137285 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-11Resolves: tdf#141565 Correct character sequence for Devanagari unique IDEike Rathke
A copy-paste error of the Farsi sequence. Change-Id: Ib19f97f0bc3bf018d659f8e998d0daa71e1d5c24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136958 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-15use stack buffer in transliterateImplNoel Grandin
Change-Id: I7c3e24f3974dafeb9abb2af9e2a986003af7bfc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135873 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-15unnecessary reallocNoel Grandin
the transliterate functions will realloc the Sequence, no need to do it here Change-Id: Ia53e79b7586679b5c8a2a47c11b86e336195a4cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-11Add English (Mauritius) {en-MU} locale dataEike Rathke
Change-Id: Ib384ceb8bdd3268d8d1e076ea2d2d4baeef1f475 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135628 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-06-06Resolves: tdf#147390 tag oc-FR to oc-FR-lengadoc, oc-ES to oc-ES-aranesEike Rathke
Change-Id: I849e8e2c6cf2a61b81b25c96b79478bc04907b5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135458 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-05Resolves: tdf#148428 Add Dhivehi (Maldives) {dv-MV} locale dataEike Rathke
Co-authored-by: Adam, M. A. <adam7171@gmail.com> Change-Id: Ia8259d8ad67fd4105bffb752d0442102d6576f33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135438 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-05-26clang-tidy modernize-pass-by-value in i18npoolNoel Grandin
Change-Id: I96d99fbdce2b0432676acec8b327cece7c39bcb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134983 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-17elide some OUString allocationNoel Grandin
Change-Id: Iadd73477bf3b0edaa0fb7db10f9ffca88fe737e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-03add o3tl::equalsAsciiNoel Grandin
Change-Id: I042b8dcadbf7581de325c161763fe35aecde5ca2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-01use more string_view in variousNoel Grandin
found by examining uses of OUString::copy() for likely places Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-29tdf#148851 Unmap + close file again in xdictionary dtorMichael Weghorn
The file opened and mapped to memory in the `xdictionary` ctor was never unmapped and closed again, resulting in a memory leak. For Android Viewer, this resulted in the app running out of memory after a while when scrolling up and down in the Chinese sample doc from tdf#148851. On Android, closing the file is actually the relevant part, because the content of files from `/assets` is automatically loaded into memory when the files are opened (s. the call to `openMemoryAsFile` in `openFilePath` in `sal/osl/unx/file.cxx`) and that memory is only freed when the file is closed again (s. `osl_closeFile`). When using the sample doc, the file in question was "file:///assets/share/dict_zh.data", which has a size of 2.2 MB and is therefore actually loaded into memory anew every time, since only files below 50 KiB are handled by the file cache introduced in commit 26a46c1143e34e361d76d6459535c2056c59de77 Date: Fri Dec 20 14:46:36 2019 +0000 android: file-cache to improve performance. Fix the memory leak by unmapping and closing the file again in the dtor. Change-Id: I3388964877080d1f2b3cf2682a41549e0bfb850c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133581 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-17loplugin:stringviewparam convert methods using copy()Noel Grandin
which converts to std::string_view::substr() Change-Id: I3f42213b41a97e77ddcc79d84d512f49d68ca559 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132729 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-15apply ICU test workaround to < 70 to "fix" test with ICU 71Rene Engelhard
See also 263961306ede0656ebb7904034a2172615ce81d0 Change-Id: Ib64ec43dba59ffddb34fe7f1a0f0d2e589c3455c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133063 Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-04-13Update remaining DevGuide wiki links.Ilmari Lauhakangas
My Kate editor decided to do some whitespace cleanup, but maybe it's fine as the main changes are not targeting functional bits anyway. Change-Id: I5292e77e43055f94a6256a7f72d49fd59287d194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132928 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-04-12Pick better type for a variableStephan Bergmann
Change-Id: I30916b188c7f8de06aec0719e79aa134a3250aef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132890 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-11use more string_viewNoel Grandin
found by tweaking the loplugin:stringview and making it whitelist getLength Change-Id: Ic41cd4e3026d93b70a76fe1279c6de3abbe6b4a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-11loplugin:stringview add check for getToken().toInt32Noel Grandin
where we can convert that to o3tl::toInt32(o3tl::getToken( and avoid the heap allocation of a temporary string Change-Id: Ib11c19c6e6cdc0de3e551affd3578d181e292de4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-12tdf#147905 calc PROPER function doesn't like mulithreadingNoel Grandin
regression from commit dac29c278531d5474289eb54aa03987c4958ac83 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Sep 16 11:03:04 2021 +0200 if you hit Transliteration_casemapping hard enough, like in this test case, the state changes become a problem, so remove that by having multiple copies. Change-Id: I1d795af4370d6f79468387997202ba11c6a9d7b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-19 04:08:44 +0000