summaryrefslogtreecommitdiff
path: root/i18npool
AgeCommit message (Collapse)Author
2020-04-20fix regressionNoel Grandin
from commit c5424e19338a3edaec3f0459c8ac5d53ca92d9fe loplugin:useuniqueptr in i18npool which would have resulted in the block at line 245 inside #if (U_ICU_VERSION_MAJOR_NUM < 58) never doing anything spotted while doing improvements to my make_shared plugin Change-Id: I79c664c7e4a051f3c764cb49d99870b51b19ce55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15loplugin:buriedassign in f,h,i*Noel Grandin
Change-Id: Iac753e528e13cb2565832a484e87f88061bbc91e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-08loplugin:flatten in i18npoolNoel Grandin
and workaround a clang crash Change-Id: Ida94c8abb4b2e997d38a7f430e59f73aadf8fcc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91844 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-08fix Korean Hangul Syllable Character order tdf#130067DaeHyun Sung
i18npool/source/collator/data/ko_charset.txt Korean Hangul syllables ordering is wrong. Some hangul syllables are dissapeared on the text file. Hangul Syllable ordering is already specified on Unicode Code chart. Ref. Hangul Syllables Range: AC00–D7AF https://unicode.org/charts/PDF/UAC00.pdf That commit applies only Hangul Syllables range. Korean Hanja[한자/漢字] range will require investigation. hanja[한자/漢字] is korean name for chinese character. Change-Id: I31e5cbf04294ee3bd6bff3277f9fe1328530ac3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87018 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-04-02Resolves: tdf#131829 [vi-VN] set currency VND decimals to 0Eike Rathke
Change-Id: I865d6b3dcb7f3bff037a4015aa98db2fa2578672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91593 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-31Translate German variable namesJohnny_M
Ende -> End Change-Id: I47faa58be14d9e608a4fad61279026d676c185c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91207 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-25tdf#131153 Correct LongDateDaySeparator for fr_CH and it_CHJean-Louis Fuchs
According to localeplanet [1] [2], in comparison to other software and people living it these areas, the LongDateDaySeparator '.' for fr_CH and it_CH in LibreOffice is not correct. It should be omitted. [1] http://www.localeplanet.com/icu/it-CH/index.html [2] http://www.localeplanet.com/icu/fr-CH/index.html This means for the FormatElement index 22, 23, 24, 25, 26 should be the same in fr_CH/fr_FR and it_CH/it_IT. Change-Id: Ief4de0d8728c7a3bbcfac7f6200f37f2d2c647aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90427 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-23sw: add pad-to-5 numberingMiklos Vajna
This is the last padded numbering type that is supported by Word but was not supported by Writer. Change-Id: Ica1a0843897c61a4b569105fd21e5bfe7b5012cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90912 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-22tdf#131464: fix create an index of Writer in Japanese localeJulien Nabet
in i18npool/source/collator/collator_unicode.cxx, we got: 177 // replace algorithm name to implementation name. 178 if (rAlgorithm == "phonetic (alphanumeric first)") 179 aBuf.append("phonetic_alphanumeric_first"); 180 else if (rAlgorithm == "phonetic (alphanumeric last)") 181 aBuf.append("phonetic_alphanumeric_last"); 182 else 183 aBuf.append(rAlgorithm); So don't add extra ja_ before "phonetic..." Also we already add "ja" in buffer with line: 158 aBuf.append("get_").append(rLocale.Language).append("_"); so right functions from ICU will be retrieved Change-Id: I163c3ca4bb4dcfa1e5d29313190c5ba3e6396c4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90877 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-20sw pad-to-4 numbering: add ODF filterMiklos Vajna
This makes the UI work as well. Change-Id: I4e94b85097cc359b257b07ba7517edfab3011093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90827 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-20sw pad-to-4 numbering: add doc model, UNO API and layoutMiklos Vajna
This is the actual numbering the customer needed, pad-to-2 and pad-to-3 was added just for compleness (since Word has it and it's related). Change-Id: I7fdf67488955ab3ee0db169f11fffd21d9cc1e3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90791 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-18sw pad-to-3 numbering: add ODF filterMiklos Vajna
This makes the UI work as well. Change-Id: I8d64b88e57ba3e4fd61afba892f0ee2267f1c8b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90683 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-17sw pad-to-3 numbering: add doc model, UNO API and layoutMiklos Vajna
This is similar to the existing padded numbering, but that one padded to 2. Another difference is pad-to-2 has more file format support: pad-to-3 is not supported in DOC and RTF. Change-Id: Ie2ac2691c58a89e181d24d7002cf873ebab380c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90656 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-15Check for some more expected calendar elementsEike Rathke
Change-Id: I615ffc60fcc235fcc84848a22fd7bd3b0d8179d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90441 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-13Fix for tdf#131297 Add Sundanese [sun-ID] locale data.rizmut
Change-Id: I2a7de5723f8ce82cf10b59ed5f77d2a7dfbb10e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90353 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-12Survive missing <Eras> elementEike Rathke
Change-Id: Ic7e609ebac10921b4891877802892fe2cde9ecbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90406 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-03sw padded numbering: add ODF filterMiklos Vajna
ODF allows any string as style:num-format="...", go with "01, 02, 03, ...", because that seems to be consistent with both DefaultNumberingProvider::makeNumberingIdentifier()'s fallback mechanism and with OOXML (which uses "001, 002, 003, ..." for the "pad to 3" case). Change-Id: I5c5c7ee5bd61175afc3e682276e69344852106d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89891 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-03sw padded numbering: add layoutMiklos Vajna
lcl_formatArabicZero() looks a bit over-complicated with its hardcoded limit of 2. Word supports limits of 3, 4 and 5 as well, so prepare for handling them in a generic way. Change-Id: If6e5634b11616f0ac05e1387016e22f4b171bbfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89864 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-02Fix Korea's Hanja Upper Numbers codepoint array #tdf130077DaeHyun Sung
fix code point for Korean Numenic strings codepoint array 5 伍 1000 阡 Change-Id: Id6b37fbaf5ca538ae61555d8c2237c66406c4fb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87240 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-02can pass length to icu compare hereNoel Grandin
which will skip the need to do strlen() Change-Id: I0c9663f5f51f158179c4e0725c1901d7256173e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-28Use icu::UnicodeString's readonly-aliasing char16_t* constructorMike Kaganski
Then it stores a pointer to the passed const UTF-16 string, so avoids extra overhead (both memory and CPU) to copy the data Change-Id: I561998d5534f76ae450577ce6fcbd9c08207f2fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89698 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-28tdf#130984: use RegexMatcher::region to properly limit the searchMike Kaganski
This allows to pass enough of the text into the matcher to have the context for anchors/assertions, and at the same time, control the search region correctly for the cases where the end position is not at the end of the passed text, like when searching only inside runs of text having specified attributes. Change-Id: I6d1ff379c61cec734c0aa2a1dd913b1a73c5b84d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89660 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-22Resolves: tdf#130563 Add predefined 4-digit year date+time formatEike Rathke
Add a predefined NF_DATETIME_SYS_DDMMYYYY_HHMM format code with formatindex="50" to all locale data files, which shifts all reserved area internally generated built-in formats up by one. Reserved area was filled already so that boundary has to be increased as well. Add some flexibility for future additions by setting the new boundary to 65, free first format index to be used by additional locale data formats is 66 now. Adapt all locales to the new boundary. The existing predefined NF_DATETIME_SYSTEM_SHORT_HHMM format code with formatindex="46" mostly was and is used with 2-digit years (stemming back from the old binary format and Excel compatibility), some locales that don't use 2-digit years at all already defined it to 4-digit years. Keep those but move the default="true" attribute (if so) to the new "50" format. Modify populating the format list such that resulting duplicates will be suppressed there as well. Also try to match the new format in ODF import if a long year was requested with date+time. Finally set the new format as default for all *_IT locales. In future changing the default date+time format to 4-digit year is just a matter of moving the default="true" attribute to the new format. Change-Id: Ib16aa9fda0e71b2d03f78e3dd013785de03cd288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89265 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-21Resolves: tdf#130772 Add Minangkabau [min-ID] locale dataEike Rathke
Co-authored-by: Peter Farley <publish.workshop@gmail.com> Change-Id: Ia9f4358984617e005ef80fbd30663ac126b86c98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89217 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-21Resolves: tdf#130579 Add Ligurian [lij-IT] locale dataEike Rathke
Co-authored-by: Jean Maillard <jean@maillard.it> Change-Id: I31aa0dfb83dd6facb564fbbcd22bc5239233da7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89208 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-19Related: tdf#130772 Prepare id-ID currency formats to ref-derive fromEike Rathke
Change-Id: I35a5311b9b9b6c5dd76352fdf12d64361bbaa5fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89024 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-16GBUILD_TRACE, support for finding out where the build time is spentLuboš Luňák
See instructions in solenv/gbuild/Trace.mk . This generates a file than can be viewed e.g. in the Chromium tracing view. Change-Id: I5f90647c58ca729375525b6daed2d4918adc8188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88754 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13tdf#130563 Change the default dates format for Italian localeMarina Latini (SUSE)
Change the default dates format from the year with two digits to the year with four digits avoiding misleading interpretations of the years. The change applies to: it_CH, it_IT, fur_IT, lld_IT, sc_IT, vec_IT Change-Id: Ib0d2d72e84a162c0e8daee8d4702173013e60af6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88462 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-12clang-analyzer-deadcode.DeadStoresNoel Grandin
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31tdf#129240 More date acceptance patterns for Hungarian languageKelemen Gábor
Now cell values matching these patterns are accepted as date: 2019-12-24 2019.12.24 2019.12.24. 2019. 12. 24. 12-24 12.24 12.24. 12. 24. Change-Id: Ida08deb054fd29aef5d941626c8225732e447662 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85385 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-30Update ICU RegexMatcher::setTimeLimit() documentation link to new locationEike Rathke
Stumbled upon in a side step of grepping for icu4c. Change-Id: I3f9cda5239e265258c7dc7a6a0689b3bc5f052ac
2020-01-28New loplugin:unsignedcompareStephan Bergmann
"Find explicit casts from signed to unsigned integer in comparison against unsigned integer, where the cast is presumably used to avoid warnings about signed vs. unsigned comparisons, and could thus be replaced with o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx) o3tl::make_unsigned requires its argument to be non-negative, and there is a chance that some original code like static_cast<sal_uInt32>(n) >= c used the explicit cast to actually force a (potentially negative) value of sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the cast to avoid a false "signed vs. unsigned comparison" warning in a case where n is known to be non-negative. It appears that restricting this plugin to non- equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=) is a useful heuristic to avoid such false positives. The only remainging false positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast from sal_Int32 to sal_uInt32". But which of course does not mean that there were no further false positivies that I missed. So this commit may accidentally introduce some false hits of the assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan --enable-dbgutil) `make check && make screenshot`. It is by design that o3tl::make_unsigned only accepts signed integer parameter types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in include/oox/helper/helper.hxx is used with both signed and unsigned types, so needs a little oox::detail::make_unsigned helper function for now. (The ultimate fix being to get rid of the macro in the first place.) Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-25tdf#124176: Use pragma once instead of include guardsBurak Bala
Change-Id: I95f09f5bb969107b0736a72b739ccce078582c6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87387 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-24loplugin:makeshared in hwpfilter..i18npoolNoel Grandin
Change-Id: I2e757043215164df173c89e21cebe2f4c9c05de9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMesut Çifci
Change-Id: Ice7c0ecc8ee05a5c3b0af458ceeee8191bdde322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86752 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-14loplugin:finalclasses in i18npool..linguisticNoel Grandin
Change-Id: Ib903fb2fdb4c4c25f73053065b828dade8b63785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86687 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-08tdf#96505:Get rid of cargo cult long integer literalsayhanyalcinsoy
Change-Id: I6ee1f79d4b96c4ed161eff11c1b75574d89902dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85843 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-08tdf#94411 use f. and ff. in alphabetical indexSeth Chaiklin
Corrects en_US for index At present en_GB index is defined as en_US, and all other (en_*) are defined as en_US or en_GB Change-Id: Ib4c3e189c1d9a08c8f4eb17a1da526fbf23291d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86080 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-03Elaborate comment what happens, tdf#78840 follow-upEike Rathke
Change-Id: I30bfc2891e422e8cfcb83f01136c654e3a1b03f5
2020-01-03tdf#78840: disable case-insensitive transliteration for regex searchMike Kaganski
Allow regex engine use its own case-insensitive search instead. We already set UREGEX_CASE_INSENSITIVE ICU flag when case-insensitive search is requested in TextSearch::RESrchPrepare. Case-insensitive transliteration used when preparing the string for passing to regex engine creates a lowercase string, where case-sensitive search is impossible, even when regex includes explicit flags for that. This change allows to honor (?-i)/(?i) flags in the regex if present. It removes case-sensitive flag from consideration for creation of transliteration service if regex search is requested. Change-Id: I0d8960670c1681f7c6bc162a4f858006596c7c36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85650 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-12-19sal_Char->char in formula..i18npoolNoel Grandin
Change-Id: I765979f41842befcf25909944100d1caa97f81a8 Reviewed-on: https://gerrit.libreoffice.org/85476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-19tdf#65038: use trailing string characters for look-ahead assertionsMike Kaganski
... like commit eb973a46ba0e34026db2d2929f2aa10505623872 did for look-behind assertions Change-Id: I86ece5d3ee49b0c5d86f2cfab5fed2830d5ad777 Reviewed-on: https://gerrit.libreoffice.org/85487 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-19tdf#75806: use actual string leading characters for correct precondition matchMike Kaganski
Having an arbitrary prepended character prevents e.g. matching start of a word for search continuation. Trimming the string to the start of the search breaks correct look-behind assertion matching (e.g. for regexes like `(?<!abc)abc`). As Michael Stahl suggested, we should use actual preceding characters instead of the arbitraty prefix. Let's use up to 100 preceding characters in the hope that this would be fast enough, and yet cover 99.999% of useful assertions. When the search string does not start with a look-behind assertion, use up to 3 preceding characters (to account for UTF-16 surrogate pairs). Change-Id: Ie19238ac792116c1d52fb2454d3142e35b6ed379 Reviewed-on: https://gerrit.libreoffice.org/85382 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-03Adapt CPPUNIT_ASSERT to C++20 deleted ostream << for sal_Unicode (aka char16_t)Stephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print an integer rather than a (presumably expected) character. But for simplicity (and to avoid issues with non-printing characters), keep printing an integer here. Change-Id: I751b99ee32d418eb488131ffa130d6f7d6d38dc7 Reviewed-on: https://gerrit.libreoffice.org/84348 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03remove some useless comment linesNoel Grandin
which merely announce that the next declaration is a class Change-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc Reviewed-on: https://gerrit.libreoffice.org/84229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-24cppcheck: performing init in init list (hwpfilter, i., l.)Julien Nabet
Change-Id: Idf5b7be45d48076fbe191fbf1a2fa63c6da71902 Reviewed-on: https://gerrit.libreoffice.org/83617 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19tdf#124536 android: fix breakiterator mismatch (separate data files for zh/ja)Christian Lohmaier
There was a mismatch between the define DICT_JA_ZH_IN_DATAFILE (which is effectively set for android as well via DISABLE_DYNLOADING in i18npool/Library_i18npool.mk and the makefile rules to actually compile the data files and set the DICT_JA_ZH_IN_DATAFILE define in other places that were guarded by checks for iOS. Change-Id: Ia0f117220ab3bad92093a3bf6c613aa9c4812ed4 Reviewed-on: https://gerrit.libreoffice.org/83102 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-11-19Improved loplugin:external, handling class typesStephan Bergmann
...renaming type as TMList to avoid ambiguity between i18npool::TMlist and i18npool::(anonymous namespace)::TMlist Change-Id: I712fca9a9a7023e5a217c019195e3aa51e858f81 Reviewed-on: https://gerrit.libreoffice.org/83132 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-03loplugin:stringaddNoel Grandin
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-15 03:50:20 +0000