summaryrefslogtreecommitdiff
path: root/i18npool
AgeCommit message (Collapse)Author
2023-05-06update loplugin:stringview* for o3tl::iterateCodePointsNoel Grandin
And change o3tl::iterateCodePoints to use sal_Int32 for its second param, to integrate better with places where the parameter comes from an UNO API, which cannot use std::size_t Change-Id: I7b9dd2c9bc7f48e6c4a912f039f1b5dae7beae69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151421 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-02Resolves: tdf#154987 Add Santali {sat-IN} locale dataEike Rathke
Change-Id: I9da3003a4db91bfa432bb68edcf577b73df5ee2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150949 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-04-28Remove duplicate com.sun.star.i18n.IndexEntrySupplier_ja_phonetic_* implsStephan Bergmann
Ever since 95823ae83c8c13c5c10c5084e2a90549ff2eb25e "#95565#add new phonetic entry for CJK index modules", "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)" was using the same implementation as "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by syllable)", and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)" was using the same implementation as "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped by syllable)". But there appears to be no evidence that those implementation names "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)" and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)" are actually used anywhere (see also c9b6bf655e6de50c55629b4805399932c90a3b30 "Add some tests for (Japanese) i18n::IndexEntrySupplier behavior"). And a problem with the current setup is that instantiation those two implementation names will return implementations whose getImplementationName() does not match those implementation names (but rather returns "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by syllable)" and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped by syllable)", resp.)---which is something that would create failures with an improved CppunitTest_services. Change-Id: I27cf4ffdb2b84195c6d96f8a7a269120f6a17714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151144 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-25tdf#56258 i18npool en-US: re-arrange outline numbering suggestionsJustin Luth
This patch brings order out of chaos, organizing the outline choices into academic, modern, simple numeric, and misc columns. The very first suggestion should be the academic standard. Next comes a distinctly different modern alternative Simple numeric moves over to be above the other numeric, followed by a demo of the kind of mixture that can be designed in LO. Since the academic standard uses Roman numerals, it is offset on the next row by the other one containing Roman numerals followed by a modern classic, and the all-numeric ISO standard retains it current position. The bullet oddball logically remains as the last suggestion. In this patch there was no change made to the actual suggestions themselves. Earlier patches made changes to 3 definitions, which allowed for the nice correlations. I missed changing the descriptive "strings" in the earlier patches. I had assumed earlier that these monotonous descriptions were dynamically produced... Since the English description should not be translated, I added a comment that will be extracted to the PO as a comment. (Thanks Andras). I think it would be nice to use strings "Academic MLA/CMOS/Turabian/OWL compliant outline" "ISO 2145 outine" but that could be made in a separate patch. Let me just point out what happened with the strings in case this helps with translation NOTE: only languages that ultimately inherit from en_US need to re-translate: old RID_SVXSTR_OUTLINENUM_DESCRIPTION_0 -no string change -moved to _3 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_1 -string changed / list modified earlier -moved to _5 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_2 -string changed / list modified earlier -moved to _1 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_3 -no string change -moved to _2 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_4 -string changed / list modified earlier -moved to _0 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_5 -no string change -moved to _4 RID_SVXSTR_OUTLINENUM_DESCRIPTION_6 -no change RID_SVXSTR_OUTLINENUM_DESCRIPTION_7 -no change Suggested translation order: -cut _3 and paste into _2 -cut _0 and paste into _3 -cut _4 and paste into _0 and fix definition -cut _5 and paste into _4 -cut _1 and paste into _5 and re-define -re-define _1 Change-Id: Ie4ec8423acddc24efefb270d9ed19ab77566e6e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150805 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-04-25Group sort bo_IN.xml LC_FORMAT FormatElement for better comparabilityEike Rathke
Change-Id: I6e17c01ce4d3a351a2cb49d214f73468d425b4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150952 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25Inherit ml_IN formats and numberings from hi_INEike Rathke
Change-Id: Ied5f3f8e051d8d9292888d8831ae3e6a88270198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150953 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25Group sort hi_IN.xml LC_FORMAT FormatElement for better comparabilityEike Rathke
... and eliminate doubled space. Change-Id: I84229145072283975ff17e2db661784205fa9af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150950 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25Add some tests for (Japanese) i18n::IndexEntrySupplier behaviorStephan Bergmann
...in preparation for some upcoming i18npool/util/i18npool.component clean-up Change-Id: I8e93aa33759f2bdd6b9422b3833a608cfbed1df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150948 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-24Fix some getImplementationNameStephan Bergmann
...to match the corresponding .component entries, > com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by consonant) etc. rather than > com.sun.star.i18n.IndexEntrySupplier_"(alphanumeric first) (grouped by consonant)" etc. Change-Id: I7fa0f9c7615b5cb1b7c0c6a8908cad27f0ac5712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150760 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-23Fix some getImplementationNameStephan Bergmann
...to match the corresponding .component entries Change-Id: I1f32d4533a49f0988a2d5c2b8d20198baab515a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150761 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-21Fix apparent copy/paste typo in implementation nameStephan Bergmann
...introduced in 155c056b1d4674d5ff73bbb5e1ad1dcd1e6aae36 "i18npool: create instances with uno constructors" Change-Id: Ie9094ec5c58aa98cdb379051ecbad80638aae02a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150759 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-21Fix some getImplementationNameStephan Bergmann
...to match the corresponding .component entry Change-Id: I56ac64be65740450df92f03aac4d2f4f447f08a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150694 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-20Fix some getImplementationNameStephan Bergmann
...to match the corresponding .component entries Change-Id: Ic5286d4969635bee5e606dcf186fbc7b297263c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150695 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-16Document locale data ReservedWordsEike Rathke
Change-Id: Ie7085e437f6c80a7d13c9d01a7259f97ab05649c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150454 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-16Resolves: tdf#154832 Add Creole (Mauritius) {mfe-MU} [0x06B2] locale dataEike Rathke
Change-Id: Ia49e3dfb6ef7abc35f981712077018f98ef94297 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150449 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-13Fix UBSan function-type-mismatchStephan Bergmann
...as seen with the additions to CppunitTest_i18npool_transliteration made here, > i18npool/source/transliteration/textToPronounce_zh.cxx:175:17: runtime error: call to function get_zh_zhuyin through pointer to incorrect function type 'unsigned short **(*)()' > workdir/CustomTarget/i18npool/indexentry/zh_zhuyin.cxx:1512: note: get_zh_zhuyin defined here > #0 in i18npool::TextToPronounce_zh::TextToPronounce_zh(char const*) at i18npool/source/transliteration/textToPronounce_zh.cxx:175:17 > #1 in i18npool::TextToChuyin_zh_TW::TextToChuyin_zh_TW() at i18npool/source/transliteration/textToPronounce_zh.cxx:149:5 > #2 in TextToChuyin_zh_TW_CreateInstance(com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory> const&) at i18npool/source/registerservices/registerservices.cxx:236:1 > #3 in cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceEveryTime(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx:173:24 > #4 in cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx:230:12 > #5 in non-virtual thunk to cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx > #6 in cppuhelper::ServiceManager::Data::Implementation::doCreateInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx:709:26 > #7 in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool) at cppuhelper/source/servicemanager.cxx:675:16 > #8 in cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx:1006:36 > #9 in non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx > #10 in i18npool::TransliterationImpl::loadBody(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::i18n::XExtendedTransliteration>&) at i18npool/source/transliteration/transliterationImpl.cxx:619:45 > #11 in i18npool::TransliterationImpl::loadModuleByName(std::basic_string_view<char16_t, std::char_traits<char16_t>>, com::sun::star::uno::Reference<com::sun::star::i18n::XExtendedTransliteration>&, com::sun::star::lang::Locale const&) at i18npool/source/transliteration/transliterationImpl.cxx:630:5 > #12 in i18npool::TransliterationImpl::loadModuleByImplName(rtl::OUString const&, com::sun::star::lang::Locale const&) at i18npool/source/transliteration/transliterationImpl.cxx:278:9 > #13 in (anonymous namespace)::Transliteration::testTextToChuyin_zh_TW() at i18npool/qa/cppunit/transliteration.cxx:120:27 For one, there had always been a mismatch between the return type `const sal_uInt16**` generated in i18npool/source/indexentry/genindex_data.cxx since d319c4611e932b286c0bef14387382da0f2e92d2 "INTEGRATION: CWS i18n24 (1.1.2); FILE ADDED" vs. `sal_uInt16**` used in i18npool/source/transliteration/textToPronounce_zh.cxx since f4705bf0a3efeebfe74568abb355ad60621300dd "INTEGRATION: CWS i18n24 (1.8.36); FILE MERGED". And for another (and more severe, as it caused random writes), there had also been a mismatch between the parameters `(sal_Int16 &max_index)` newly generated in i18npool/source/indexentry/genindex_data.cxx since 7696cd3902ca248951205f15930787488368ea26 "INTEGRATION: CWS i18n31 (1.4.60); FILE MERGED" (and correctly used in i18npool/source/indexentry/indexentrysupplier_asian.cxx since 58dcf0ffaf8668827fc2f47445c9d8faf3d29555 "INTEGRATION: CWS i18n31 (1.9.60); FILE MERGED") vs. the original `()` used in i18npool/source/transliteration/textToPronounce_zh.cxx ever since f4705bf0a3efeebfe74568abb355ad60621300dd "INTEGRATION: CWS i18n24 (1.8.36); FILE MERGED". For DISABLE_DYNLOADING, the second (missing max_index parameter) issue appears to have been broken even further with 9db03b879b912d79060ab06f03a54d4a59e6ac65 "i18npool: fix wrong static function symbols", replacing the wrong sal_uInt16** get_zh_zhuyin(); sal_uInt16** get_zh_pinyin(); declarations in i18npool/source/transliteration/textToPronounce_zh.cxx with the even worse declarations sal_uInt16** get_collator_data_zh_zhuyin(); sal_uInt16** get_collator_data_zh_pinyin(); corresponding to function definitions generated by i18npool/source/collator/gencoll_rule.cxx (which also happen to have zero parameters, but non-matching return types, and apparently completely different collation vs. transliteration semantics). Change-Id: Id91b17eeb7fcdd0c711d52a624375356dc47fc32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150302 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-12loplugin:stringview whitelist getLength and isEmptyNoel Grandin
Change-Id: I38f3410c0b25ff579879b9de1f266af4d8fd51e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-05Add missing constructor attributesStephan Bergmann
...that were apparently forgotten by 155c056b1d4674d5ff73bbb5e1ad1dcd1e6aae36 "i18npool: create instances with uno constructors" and d2140a6320cd1cf4dea29b174cdb3bcb5261056b "i18npool: create instances with uno constructors", respectively Change-Id: I3caedf9d2a941a8671fab554a2358776d95c4938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150066 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-05Remove dead com.sun.star.i18n.Transliteration.ignoreKana service implementationStephan Bergmann
In 2002, fc680b643030fc2c99dcfffe75e762ee35e5f292 "#97583# Modify for new services" had added the two com.sun.star.i18n.Transliteration.IGNORE_KANA and com.sun.star.i18n.Transliteration.ignoreKana service implementations, both using the also added ignoreKana_CreateInstance factory function, to i18npool/source/registerservices/registerservices.cxx (back in a time when that still used active component registration via component_writeInfo). Then in 2010 a3c8a0ed0c5c6be1cb5c940750222f6381608bd7 "sb129: #i113189# change UNO components to use passive registration" (dropping the active component registration via component_writeInfo) faithfully listed both those service implementations in i18npool/util/i18npool.component. And in 2014 a4f17c00b16f5a983cd91ac5d2c43454f1775931 "i18npool: Constructor feature for few more implementations" switched the com.sun.star.i18n.Transliteration.IGNORE_KANA service implementation to use a constructor attribute in i18npool/util/i18npool.component. But it also removed from i18npool/source/registerservices/registerservices.cxx the ignoreKana_createInstance factory function and the > IMPL_TRANSLITERATION_ITEM (ignoreKana), aInstances element through which the other com.sun.star.i18n.Transliteration.ignoreKana service implementation was created via i18npool_component_getFactory. (It presumably either intended to also change com.sun.star.i18n.Transliteration.ignoreKana to use a constructor, but forgot to implement that, or accidentally broke that service implementation.) So the com.sun.star.i18n.Transliteration.ignoreKana service implementation has not been instantiatable ever since 2014. But it appears that nobody missed it much, so maybe it had already been a mistake to add it (alongside the com.sun.star.i18n.Transliteration.IGNORE_KANA service implementation) in 2002. So just remove it completely for good now. Change-Id: Ieda888038a70f4123a0c5f9f4e3306491f32ed64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150068 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-05tdf#148906: Ukrainian letters miss in bullets and numbering dialogJulien Nabet
Change-Id: Ieef2b2a7052da342709baf298b618d2c29fa3e43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149768 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-04Fix typos in XML that broke three implementation elementsStephan Bergmann
The typos all originated with d2140a6320cd1cf4dea29b174cdb3bcb5261056b "i18npool: create instances with uno constructors", causing three intended constructor attributes to rather be plain character data. Which apparently went unnoticed until recently (see the TODOs resolved here that had been introduced with 456a146b9eb643655ae2bd336740e8c5536913aa "tdf#151971: Fix used implementation names of transliteration services"), in part because the Parser class in cppuhelper/source/servicemanager.cxx silently ignores any unexpected character data via xmlreader::XmlReader::Text::NONE.) Change-Id: Ia8fdbc09c67d10530b4d86dbbbde2b6b84038e66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150021 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-04tdf#151971: Fix used implementation names of transliteration servicesStephan Bergmann
...after 04af4e4f55f3ef319a78edd4d0109e2e7eba90b6 "[API CHANGE] Fix all bad UNOIDL identifiers across offapi" had changed the spelling (character case) of some of the css.i18n.TransliterationModules[New] enum values involved here, so that the TmItem1 macro generated broken TMList::implName values now. (Which in turn caused TransliterationImpl::loadBody to throw "unsatisfied query for interface of type com.sun.star.i18n.XExtendedTransliteration!" css::uno::RuntimeExceptions, which remained uncaught.) Also add a test verifying that loading all those transliteration services no longer fails throwing exceptions. Which lead to two open TODOs: For one, the value of maxCascade in i18npool/inc/transliterationImpl.hxx might come from a time when there were fewer TransliterationModules[New] enum values and might no longer be appropriate. This would need some further investigation. But for another, there are two transliteration services that cannot currently be instantiated. That looks like a regression that should be fixed in a follow-up commit. Change-Id: Icfca3e841360d4b471013e2c96d6868a75a21a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150018 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-30loplugin:stringadd in variousNoel Grandin
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I8cf6a47ad357ddc73e2c430d966be72d5efd1485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149767 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-28Resolves: tdf#154433 Correct {uk-UA} quotation mark charactersEike Rathke
Change-Id: Id5c251ee632d2da134ffbbb352844152f12c1f77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149654 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-18loplugin:stringadd use more O[U]StringCharNoel Grandin
Change-Id: I196e4539ad430a39415eff9d7170b33df7228230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17Related: tdf#153842 {dsb-DE} remove confusing commentEike Rathke
The format is needed, even if not used / offered as default. Change-Id: Ifd4e5114a1d763a9a7ef69046949dfb7cf96ef84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149055 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-03-17Related: tdf#153842 {hsb-DE} does not use AM/PMEike Rathke
Switch defaults and remove from 47 date+time edit format code. Change-Id: I4832c26490adcc369a2d88e524fded724d01e996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149054 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-13make more use of OUStringBuffer::append(OUStringConcat)Noel Grandin
where we can avoid constructing temporary OUStrings Change-Id: I0eacd68a8d1b450894c2ea769055f16886b78ad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-02tdf#143148 Use pragma once instead of include guardsAbdallah Elhdad
Change-Id: Iddda2d30dce37fd90ce8c1834666f2baf8bd7fb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148116 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-03-01Related: tdf#153842 {dsb-DE} group separator is '.' dot instead of NBSPEike Rathke
See also https://icu4c-demos.unicode.org/icu-bin/locexp?d_=en&_=dsb_DE Change-Id: I1f6797829812893aaab711ab670a722673a86a42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148025 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-02-28Resolves: tdf#153842 {hsb-DE} currency symbol follows amount with blankEike Rathke
Change-Id: Id8a86541d1f8299763274e048f36af95eee03d72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148023 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-02-15Drop 'using namespace ::std' in dirs [e-p]*Gabor Kelemen
Change-Id: Ibe6a2f662f5721c594d28a8e0d7340d0f3cffe95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147075 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-01-31tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroektagoel12
Also change some range based for Change-Id: I2e17feaba7a6b219aa0c9126c5046cf3bdf855d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145988 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-01-10tdf#56258 i18npool en-US: partial revert 5th outline levelJustin Luth
This reverts the change of A.I.a.i. -> A.I.a.i.1. made by commit dd8ed1fdbc63499ac958d28536c3c5540455358b. While it wasn't necessarily a bad change, it no longer has any justification, since the complementary change in the other outline definition was modified to become MLA compliant. Rather than make any change at all, just revert back to the original definition, and leave the level definition to the normal 4 levels of numbering before the bullets start. Change-Id: I88d792a6dd20bd519755349905975cf9028f9fa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145236 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-10tdf#56258 i18npool en-US: extend outline 1.a) to 4 levelsJustin Luth
Change 1. a) -> 1) a) 1) A) This is intended as a clean, modern style of outline that has good visual spacing in LibreOffice. This differentiates it a bit more from the first option, and extends the numbered level to the typical depth of 4, while still keeping a logical suffix pattern and maintaining the general "theme" of the previous definition. Yes, it is a bit odd to have a capital A following a smaller case a. However, this is at the fourth level, which isn't reached very often, and I wanted to keep a choice that focuses on a small a. Surprisingly, with the default 12pt/Liberation font, a 10) still fits in the allotted space before the tabstop, so in most cases this outline will have proper visual spacing all the way up to 99). There are plenty of choices that start with 1 followed by a dot, so I used this opportunity to create the only list that starts with a ")" suffix. Google docs for example has a 1) a) i) choice, but for modern lists I don't think we want to use roman numerals. Change-Id: I34725d6aa113831eaeaa88c295b3b3f1294f8998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145155 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-09tdf#56258 i18npool en-US: document ISO 2145 compliant outline list formatJustin Luth
Change-Id: I2cccc7c2c3621434a4dbbcdd032672c668632494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145158 Tested-by: Jenkins Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-09tdf#56258 i18npool en-US: replace illogical outline 1.(a).i.AJustin Luth
Change 1.(a).i.A. -> A.1.a.1. This is intended as a clean, modern style of outline that has good visual spacing in LibreOffice. It provides a simple alternative to the second style, reversing the order while still keeping a logical suffix pattern. This design will easily allow large/long lists to fit in the allotted space before the tabstop. There was no attempt to match the theme of the previous definition, since it neither looked good in LO's default spacing, nor was it consistent/logical. Change-Id: If7de1302110a3c97922bd2eeba7a917444110b27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145156 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
2023-01-09tdf#56258 i18npool en-US: change outline order to match MLA styleJustin Luth
Changed I.A.i.a) -> I.A.1.a.i. The overwhelming result of a google search for "official/correct outline list format" indicates that the third level should be a 1, not an i. MLA Handbook (according to wikipedia) uses the order I.A.1.a.i. (a) (1) i) Chicago Mode of Style is usually interpreted as I.A.1.a) or I.A.1.a. with varying lower sublevels/suffixes. Wikipedia also suggest the logical order of I.A.1.a.i.I) A) 1) a) i) (I) (A) (1) (a) (i) Change-Id: I7fcc8a1ee727d6cddca4bf0c6a8461538769cf5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145147 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-06tdf#56258 i18npool: add "adjust" to locale.dtd for outline numberingJustin Luth
Although Adjust was already defined in all of the code structures, it was not defined in the dtd file. Thanks to Eike for pointing out this requirement. Change-Id: I43ed0c26ed5bccb2309a255db79f5afa32f78c38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145146 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2023-01-06tdf#56258: allow i18npool to define SvxAdjust for outlineJustin Luth
Deciding whether the numbering should be Left, Right, or Center is a rather important setting. Specifically for Roman numerals (which grow very wide as they increment to 7 and 8) the numbering styles set these to right aligned. This really helps for keeping the text nicely aligned. The numbering styles are built-in LO defaults, but locale files can define numbering and outline choices. This patch add the setting for "adjust" on the outline levels. For en_US, it makes sense to right-align roman numeral levels. [The only other highly likely candidate for this that I could find was old Hungarian (SZEKELY_ROVAS), but it doesn't seem to be used in any locale definitions.] I only changed en_US for now, but of course many other locales are also using NumType="3" and NumType="4". This only applies to the toolbar/sidebar SVX code path. The Bullets and Numbering dialog does not currently modify any spacing, so I didn't apply the adjustment either. It also doesn't make sense to do this on single numbering changes (aka ContinuousNumberingLevels or LC_NumberingLevel) because we don't know or control the first line indent there either. But at least for toolbar Outlines, we do change every level, and so can set a (somewhat) appropriate spacing. [Setting SvxAdjust without adjusting the spacing is pointless. Don't make any changes at all if the spacing ends up causing problems.] The Numbering IVX/ivx styles set the firstLineIndent to -174, so I did the same here. This is the scariest part of this change. AFAICS SvxAdjust::Left is a non-locale aDefNumStyle default, so hardcoding that for undefined LC_OutlineNumberingLevel shouldn't be too scary. Change-Id: I52deefe88aa55c55c9531b651411f64accb86f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144978 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-05tdf#56258 en_US: increase outline levels definitions to 6Justin Luth
There are 10 levels in numbering, so it only makes sense to allow outline definitions for all 10 levels. Note that DOC/X formats only allow 9 levels, There are two code paths that read these definitions. The SVX toolbar code to allow 10 levels (SVX_MAX_NUM) was already completed in the previous patch. This commit allows 10 levels for the Bullets and Numbering menu dialog. Since all choices MUST define the same number of levels, I only added one more. I hope that there isn't some secret kind of requirement that ALL LOCALE's must also use the same number of definitions - it doesn't seem to. [Although not a direct comparison, bg_BG defines 10 single number levels, compared to en_US's 8, and some Chinese locales also do more than 8.] Change-Id: Ibe00d54cfa4577db83eba368b92be11055b076ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144976 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-05Revert all the recent loplugin:unocast changesStephan Bergmann
...as obsoleted by ef533553559fe09b4afab651fc692885d1acf4ed "Rudimentary support for dynamic_cast on UNO proxy objects". This reverts all of: 4cfcc9ac37b90ce64c8402a41eb4638adb185b5c "loplugin:unocast (framework::Desktop)" 03efbf72f4ddf7a84aa8aabef348331bd4b75e8a "loplugin:unocast (vclcanvas::TextLayout)" 80099fdd51a69eaa6c36ca88ef772810e4a777fa "loplugin:unocast (SalGtkXWindow)" cc147f576d8687fb79c77d47d41dc4ba1678a469 "loplugin:unocast (sdext::presenter::CachablePresenterView)" 40db42be1d8fd0f9c6c8c5ba3767ddb9ee2034c2 "loplugin:unocast (vclcanvas::CanvasFont)" 2d1e7995eae29e2826449eb5179f5fae181794a5 "loplugin:unocast (CairoColorSpace)" 4c0bbe4bd97636207cf71a6aa120c67698891da9 "loplugin:unocast (canvas::ParametricPolyPolygon)" 89803666621c07d1b1ac9d3bd883f0ca192a91a0 "loplugin:unocast (vclcanas::CanvasBitmap)" d5e0c2c8db71878d21c2a7255af08cf5f9a6dd04 "loplugin:unocast (sfx2::DigitalSignatures)" c0c4519e0d5b555f59bbc04cc616454edfd1f4ce "loplugin:unocast (VCLXAccessibleComponent)" feb8b833a6245d42400f42a0bc789dc84594ee6f "loplugin:unocast (VCLXDialog)" 1fa58cc6cc9c3849753342a5d9a6ddfa461b5e66 "loplugin:unocast (VCLXMultiPage)" f481f036deb1b1b46f3038074c4659f3a91b9c6c "loplugin:unocast (DocumentSettingsSerializer)" 73df933f5fa5932f94e5a1b338a3eda00a9ce354 "loplugin:unocast (css::embed::EmbeddedUpdate)" 420165ab0ef03c0467f9d17f504de2d2fc78f0e6 "loplugin:unocast (canvas::tools' StandardColorSpace, StandardNoAlphaColorSpace)" 9abe8ee067e6c00f19d8a13346d53c4641c27166 "loplugin:unocast (MutableTreeNode)" 9f3022ceb036f23b4b0994c3e2fbd1001bff225a "loplugin:unocast (VCLXTabPage)" 1be70dda02c12a60778b7607cff2520ae1aa611e "loplugin:unocast (vcl::unotools::VclCanvasBitmap)" d6a70bb641b96e8e5616448c2378131ed62658b4 "loplugin:unocast (basegfx::unotools::UnoPolyPolygon)" 5a14f009e6782c077463c8cbb8e9cea3d7950107 "loplugin:unocast (xmlsecurity::Certificate)" 99009c9535dfa3e0d838989ccc7d84bfa2320ff4 "loplugin:unocast (sd::Annotation)" 0c7585c5fa78887e5459885ed744e8044fd76137 "loplugin:unocast (sd::TextApiObject)" 24e14afd1bfcaed6c200ab081973fba7e47267ca "loplugin:unocast (SignatureVerifierImpl)" 1a7ad0c10d286ce9ae2700ceb2fd50eed1fb43a4 "loplugin:unocast (pcr::PropertyEventTranslation)" a97e2d2702d9a6f37775ccee2c08c4f3b2479c4b "loplugin:unocast (RangePageBreaks)" 19dfdf86ad1f5b08041d8b7a9f196caf881231ab "iloplugin:unocast (pcr::OFormattedNumericControl)" f9785ea595fd8e911f6370e836fa579225b9e571 "loplugin:unocast (frm::OInterfaceContainer)" 5e5f40a4a92a31b0932c690219d002fcf18598cf "loplugin:unocast (ScVbaShapes)" 27b35b2c215b4832d4378ec3a7ecbba926552d06 "loplugin:unocast (ScVbaShapeRange)" cb3108f860065928552a86cf8acc4b3a95718ecf "cid#1517812 Dereference null return value" feba0ddb1521d1142560fe54b7d7696ee910237f "loplugin:unocast (weld::TransportAsXWindow)" 4d6c23216559eb48f9943bb49d6e475a6d64ba15 "loplugin:unocast (oox::ForumlaImExportBase)" 4844c096a8ab6a9a620c410a0949d4499f12a504 "loplugin:unocast (cairocanvas::SurfaceProvider)" 9a0b523e0a84d403b9092176ccec4b3e3efe42d0 "loplugin:unocast (cairocanvas::CanvasBitmap)" 8a5648d8e59b4b007dbbf3824777c19a21efc61e "loplugin:unocast (cairocanvas::TextLayout)" 28c27a0623bc78a0590858f97d03b620985bc84c "loplugin:unocast (cairocanvas::CanvasFont)" 53bc223cb3288e32a417696ee61c29e5f01f209d "loplugin:unocast (cairocanvas::RepaintTarget)" 5f70b0b9f6bc4ab145ddbd9155590ed4a3b1b9ec "loplugin:unocast (SvXMLImport)" 068187a898cdd2e26e9b16c348ecc1ed2dee3f29 "loplugin:unocast (VCLXWindow)" 88b4f966202717cd4ad38a30a8eda22c3e69ed35 "loplugin:unocast (sfx2::sidebar::SidebarController)" f1b7a69b280aefe2f1b3b0f32193494fd765f2bd "loplugin:unocast (SvxLineStyleToolBoxControl)" ba76f0ba7e8de4d2953739c952004b7d9af47197 "loplugin:unocast (i18npool::Calendar_gregorian)" 840154daf934d8df52ead1cb7acd798c4d30f007 "loplugin:unocast (framework::AddonsToolBarWrapper)" b0e9c4c5f063cefa9557810e3349bdb9c7493091 "loplugin:unocast (GrammarCheckingIterator)" 8ee6cfc9655ce9de4617cea1a0d9cb9d7a4fbfac "loplugin:unocast (ucb::ucp::ext::Content)" 5b8cd77c112bc8c0e92b8fec215c3c8e802bbc0a "loplugin:unocast (basic::SfxScriptLibraryContainer)" 9e73ff9fce12e102bb3c3cea8d8bb96c88f2c9ad "loplugin:unocast (sdext::presenter::PresenterNotesView)" a98acca8fbc38d3fd5600ae5056a8e42b6d8a40d "loplugin:unocast (SelectionChangeHandler)" c0b59ad6e35b0cb0dea0821e95f95569739078c1 "Consistently use comphelper::getSomethingImpl<I>(aIdentifier, this)" 276e3ccbdd3259ec3daf8a1a98fa7f406b14e21c "loplugin:unocast (vclcanvas::RepaintTarget)" Change-Id: I37c73e3422a5154bf6cb647640d2d3f23db8bc34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-03NFC tdf#56258 i18npool OutLineNumberingLevel: use ref="en_US"Justin Luth
In preparing to see what improvements can be made to list defaults, it is helpful to see what customizations have been made to the US defaults. Those that match identically were changed to simple refs. Thanks to https://www.linuxtopia.org/online_books/ linux_tool_guides/the_sed_faq/sedfaq4_013.html The script there helped to generate sed expressions. sed -f ref.sed *.xml ----- ref.sed ----- \#<LC_OutLineNumberingLevel>#,\#</LC_OutLineNumberingLevel># { :ack N; \#</LC_OutLineNumberingLevel>#! b ack s#<LC_OutLineNumberingLevel>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="1" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix="(" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="3" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="0" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix="." \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="2" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="0" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="3" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="0" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="2" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="3" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="1" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="2" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="3" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="4" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ <OutlineStyle>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="27A2" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="E006" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=")" \+BulletChar="E004" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\ </OutlineStyle>\ </LC_OutLineNumberingLevel>#<LC_OutLineNumberingLevel ref="en_US"/>#; } ------------------- Change-Id: I6853c09ed10a9d71b39e79fb665f7d056e945864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144945 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-03tdf#56258 i18npool: should be a SvxAdjust, not a HoriOrientJustin Luth
Although this is unused AFAICS, lets at least use the correct enum, because these two do not match up. HoriOrient::LEFT = 3, while SvxAdjust::Left = 0 (3 is Center) Change-Id: I1cd8cce6d4e223ac272d8d4ba5e22c52c7657499 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144977 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-02NFC tdf#56258 i18npool NumberingLevel: use ref="en_US"Justin Luth
In preparing to see what improvements can be made to list defaults, it is helpful to see what customizations have been made to the US defaults. Those that match identically were changed to simple refs. Thanks to https://www.linuxtopia.org/online_books/ linux_tool_guides/the_sed_faq/sedfaq4_013.html The script there helped to generate sed expressions. sed -f ref.sed *.xml ----- ref.sed ----- \#<LC_NumberingLevel>#,\#</LC_NumberingLevel># { :ack N; \#</LC_NumberingLevel>#! b ack s#<LC_NumberingLevel>\ <NumberingLevel NumType="4" Prefix=" *" \+Suffix=")" */>\ <NumberingLevel NumType="4" Prefix=" *" \+Suffix="." */>\ <NumberingLevel NumType="4" Prefix="(" \+Suffix=")" */>\ <NumberingLevel NumType="2" Prefix=" *" \+Suffix="." */>\ <NumberingLevel NumType="0" Prefix=" *" \+Suffix=")" */>\ <NumberingLevel NumType="1" Prefix=" *" \+Suffix=")" */>\ <NumberingLevel NumType="1" Prefix="(" \+Suffix=")" */>\ <NumberingLevel NumType="3" Prefix=" *" \+Suffix="." */>\ </LC_NumberingLevel>#<LC_NumberingLevel ref="en_US"/>#; } ------------------- ----- ref2.sed ----- \#<LC_NumberingLevel>#,\#</LC_NumberingLevel># { :ack N; \#</LC_NumberingLevel>#! b ack s#<LC_NumberingLevel>\ <NumberingLevel Prefix=" " \+NumType="4" Suffix=")" */>\ <NumberingLevel Prefix=" " \+NumType="4" Suffix="." */>\ <NumberingLevel Prefix="(" \+NumType="4" Suffix=")" */>\ <NumberingLevel Prefix=" " \+NumType="2" Suffix="." */>\ <NumberingLevel Prefix=" " \+NumType="0" Suffix=")" */>\ <NumberingLevel Prefix=" " \+NumType="1" Suffix=")" */>\ <NumberingLevel Prefix="(" \+NumType="1" Suffix=")" */>\ <NumberingLevel Prefix=" " \+NumType="3" Suffix="." */>\ </LC_NumberingLevel>#<LC_NumberingLevel ref="en_US"/>#; } -------------------- Change-Id: I85d8a8ed095f19d08b035d7f2c4e2cd94ff08c76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144890 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-01tdf#152785: typo "disabte" instead of "dissabte" for Saturday in occitanJulien Nabet
Refs: 1) https://locongres.org/oc/aplicacions/dicodoc-oc/dicodoc-recerca?option=com_dicodoc&view=search&Itemid=168&type=fr-oc&dic%5B%5D=BASIC&dic%5B%5D=LAUS&dic%5B%5D=LAGA&q=samedi&q2=&submit=Cercar 2) https://en.wiktionary.org/wiki/Appendix:Days_of_the_week like this since the beginning 5b7b4e81144619c8350b5c59d9d17ba7f75aeccb " INTEGRATION: CWS locales23 (1.1.2); FILE ADDED 2007/04/25 19:14:54 er 1.1.2.1: #i76044# add Occitan_France (oc_FR) locale data; contributed by Bruno Gallart <bgallart@ooo> " Thank you to quentinantonin@free.fr for having spotted this + provided refs! Change-Id: I8b81e561885bc2e1eea6c5f88a3924ea58141791 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144926 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-12-17tdf#152520: Crash when using TITLE_CASE/SENTENCE_CASE in Transliteration moduleJulien Nabet
relevant part of bt: 7 0x00007f50c85b3796 in com::sun::star::uno::Sequence<int>::realloc(int) (this=0x0, nSize=11) at include/com/sun/star/uno/Sequence.hxx:215 8 0x00007f50c85d9240 in i18npool::transliterate_titlecase_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t> >, int, int, com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<int>*) (inStr=u"AB cd. eF. ", startPos=0, nCount=11, rLocale=..., pOffset=0x0) at i18npool/source/transliteration/transliteration_body.cxx:267 9 0x00007f50c85d955b in i18npool::Transliteration_sentencecase::transliterateImpl(rtl::OUString const&, int, int, com::sun::star::uno::Sequence<int>*) (this=0x557834ea0bb0, inStr="AB cd. eF. ", startPos=0, nCount=11, pOffset=0x0) at i18npool/source/transliteration/transliteration_body.cxx:298 10 0x00007f50c85dcc10 in i18npool::transliteration_commonclass::transliterateString2String(rtl::OUString const&, int, int) (this=0x557834ea0bb0, inStr="AB cd. eF. ", startPos=0, nCount=11) at i18npool/source/transliteration/transliteration_commonclass.cxx:109 11 0x00007f50c85dcc5d in non-virtual thunk to i18npool::transliteration_commonclass::transliterateString2String(rtl::OUString const&, int, int) () at i18npool/source/transliteration/transliteration_commonclass.cxx:109 12 0x00007f50c85e0d89 in i18npool::TransliterationImpl::transliterateString2String(rtl::OUString const&, int, int) (this=0x557834854dc0, inStr="AB cd. eF. ", startPos=0, nCount=11) at i18npool/source/transliteration/transliterationImpl.cxx:395 full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=184205 Regression from: c7551e8a46e2f9f8142aa7921a0494221ae096e8 (speedup CharacterClassificationImpl::toUpper) Change-Id: I40e383fc87213d88fbde50876f61947b04190a90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144375 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-14loplugin:unocast (i18npool::Calendar_gregorian)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I1b0e544145c364cb9ee669b913132f41c1a8a66a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144147 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-28Resolves: tdf#148792 Add Portuguese (Mozambique) {pt-MZ} locale and dataEike Rathke
Basically copies pt_PT.xml but replaces translated with untranslated keywords (AA,AAAA => YY,YYYY), hence no ref="pt_PT" for LC_FORMAT (and LC_CTYPE). Also use sort-formats.awk -v group=1 to sort FormatElement by usage group and formatIndex as those went quite wild over time.. Change-Id: Iececac0ebdd0317fd14ab65f32c08501f3ce32c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143398 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-27{pt-AO} change to untranslated YY,YYYY keywords, translated AA never workedEike Rathke
Apparently copied from {pt-PT} year AA and AAAA format codes should not had made it across but also never worked as LANGUAGE_USER_PORTUGUESE_ANGOLA was missing in ImpSvNumberformatScan::SetDependentKeywords() so date codes displayed literal AA instead. Seems no one is using that locale with dates.. Since commit 5d833d37851597c1fb9076710d9eb03e4c94ca07 CommitDate: Fri Apr 8 20:51:13 2011 +0200 add pt_AO locale data (edited version of Mandrake's patch) Change-Id: Icd5f81d0a49462ad2514655742d6c05f069f55fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143354 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins