summaryrefslogtreecommitdiff
path: root/i18nutil
AgeCommit message (Collapse)Author
2024-11-01tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 438, 446 V1037 Two or more case-branches perform the same actions. Check lines: 442, 450 V1037 Two or more case-branches perform the same actions. Check lines: 483, 659 V1037 Two or more case-branches perform the same actions. Check lines: 492, 896 V1037 Two or more case-branches perform the same actions. Check lines: 501, 791, 944 V1037 Two or more case-branches perform the same actions. Check lines: 549, 725 V1037 Two or more case-branches perform the same actions. Check lines: 552, 842 V1037 Two or more case-branches perform the same actions. Check lines: 618, 642 V1037 Two or more case-branches perform the same actions. Check lines: 648, 734 V1037 Two or more case-branches perform the same actions. Check lines: 698, 854 V1037 Two or more case-branches perform the same actions. Check lines: 974, 977 Change-Id: Iadd03f3813deaffcebdb1a661489b86b83bf9d5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175219 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-18tdf#163215: Enable kashida justification for AAT fontsJonathan Clark
Currently, we use HarfBuzz-provided kashida insertion position information to decide on positions to insert kashida. This data is used both while ranking kashida insertion positions, and to avoid inserting kashida in positions that would break shaping on a per-font basis. Unfortunately, HarfBuzz cannot validate kashida insertion positions for AAT fonts. As a result, kashida were previously not inserted for text using AAT fonts. This change updates kashida justification to skip validation against HarfBuzz when AAT fonts are used. Change-Id: If0d31512b1db0f1f8155963f9b1031eb01bacc45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175165 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-10-05crashtesting: fix font-dependent infinite loop in kashida justificationJonathan Clark
Commit c3c29d31d77ff93aa50634cfd51c62d12dc0f6ec (tdf#140767 Implemented Syriac justification) indirectly introduced a font-dependent infinite loop in Writer layout by relaxing some restrictions on kashida candidate positions. The infinite loop was found in tdf97806-2.odt. This change fixes an underlying logic bug in Writer, which caused Writer to attempt to apply kashida justification to non-Arabic/Syriac CTL scripts. This change also reintroduces some of the previously-lifted restrictions on kashida candidate positions. Change-Id: I783bf327f4ef0f1f6a032f0d3dddbcfd60a026fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174503 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-09-27tdf#140767 Implemented Syriac justificationJonathan Clark
This change extends kashida justification to Syriac, using custom insertion rules. Change-Id: I7508d2c32e95abb12a098e989c7153828ba81c87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173990 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-09-26tdf#163105 Use HB data while selecting kashida insertion positionsJonathan Clark
Previously, Writer and Edit Engine would skip inserting kashida in words if the highest-priority candidate position is marked as invalid by HarfBuzz. This would happen even if the word contained multiple lower-ranked valid candidate positions. This change updates Writer and Edit Engine to pass HarfBuzz kashida position data to the selection algorithm. The algorithm has been updated to return the highest-priority valid position, if any. The algorithm has also been updated to use raw positions marked as valid by HarfBuzz as a fallback, if no better positions could be found. Change-Id: I40c6432c4607aee197e8767e5667db504469956a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173963 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-09-25tdf#163105 Require kashida after Seen, even before a final YehJonathan Clark
Small tweak to the kashida insertion rules to restore some previous behavior. Kashida should not be inserted after a final Yeh, but should be inserted after an initial or medial Seen, even if it is followed by a final Yeh. Change-Id: I1fef2d32961c6f55006b2df456827588f62af40b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173889 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-09-25tdf#163105 Restore some missing kashida opportunitiesJonathan Clark
This change partially reverts the fix for tdf#65344, to allow more candidate kashida insertion positions. The final position fallback from the original ruleset has been restored. Instead, tdf#65344 is now fixed by explicitly prohibiting kashida under a final-position Yeh. Change-Id: I9fe8c656768777c160205ad9892f2fe916a2a926 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173887 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-09-25tdf#163105 Consolidated duplicated kashida justification codeJonathan Clark
The kashida candidate position selection logic was copied-and-pasted from Writer into Edit Engine. This change consolidates the shared code into a library. This change also adds some minimal characteristic tests, which previously did not exist. Change-Id: I2bfbfa79858347803474b754566436f3e74d1a54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173883 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-09-12ICU: upgrade to 75.1Xisco Fauli
Downloaded from https://github.com/unicode-org/icu/releases/tag/release-75-1 Change-Id: I882c57bf5ab613dc71f7ae1c31305596e1ca791f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168750 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-08-28Drop newly unused ToggleUnicodeCodepoint::CharsToDeleteMike Kaganski
Change-Id: I25654d911b1cc11f8c0e7d0ef3e87898418c3408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172535 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-28tdf#162657: re-check the result of combining surrogatesMike Kaganski
They may constitute a combining mark, and require more characters to the left to be processed. Change-Id: Ie626badf66edaf44c56e0ba2d294304f139d2bca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172533 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-20loplugin:ostr in variousNoel Grandin
Change-Id: I9f399b3752da9df930e0647536ffcd4e82beb1ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-14use more string_view in i18nutil::PaperInfoNoel Grandin
Change-Id: I54e75c14b7dbfbfb03e827b5c6167f1256f2733e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167628 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-04-14Remove duplicate includeAndrea Gelmini
Change-Id: Ifc9b71acc50e2a53cee194801245c287079b62ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166069 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-04-14Use more o3tl::convertMike Kaganski
Change-Id: I281ff1be4663d752a4e1a7e4d38556cefb641bd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166060 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-06Use less boost_headers in low level librariesGabor Kelemen
Most of these don't use boost themselves, nor do they need it transitively since the use of boost::optional was removed Change-Id: Ic9dee1c4e160b313ec5b91677b02ffdea6c5779d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164440 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-30move IsFuzzing to comphelperCaolán McNamara
and try something a bit more generic Change-Id: I1d8256576cd02f0a589df350ba7b53059dd586a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161250 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-09tdf#158379 check if PageDesc's m_pPSName is a nullptrPatrick Luby
Change-Id: If9f6d695d40c1d55ee2dfbdf1e3523b33343d7ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160504 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-11-29Extended loplugin:ostr: i18nutilStephan Bergmann
Change-Id: I9d7ab34967229087e4fa52b6714b6b75d6c4d196 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160118 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-07-25i18nutil: Make unicode::getUnicodeType() take a UTF-32 code pointKhaled Hosny
Still need to fix call sites to handles surrogate pairs. Change-Id: I3ba896714fc6a90596c041148a3c9d965f60f4a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154874 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-25i18nutil: Fix ICU case folding of surrogate pairsKhaled Hosny
It can’t be easily made to work when mixing our case folding data (which seems to work on individual surrogates) and ICU functions, so port it over completely to ICU. Change-Id: I0e12b81b23a053a2a9a299e51908930a3d0b82d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154843 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-24i18nutil: Port unicode::getUnicodeType() to ICUKhaled Hosny
One-less Unicode data table to forget to update. Change-Id: Icf64e55ec322578b2eefb9065842c218d6f3e061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154873 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-24tdf#97152: Fix upper case mapping of lunate sigma (U+03F2)Khaled Hosny
It was mapped to uppercase sigma (U+03A3) while it should be mapped to uppercase lunate sigma (U+03F9). Fix by letting this slot fallback to ICU case folding. Change-Id: I14ffa0151c740779b67af14be8c7af8c51c3a1e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154845 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-24tdf#96343, tdf#134766, tdf#97152: Fallback to ICU for case mappingKhaled Hosny
If we are requested to case map a character not present in our case mapping data, fallback to ICU case mapping functions. We should switch completely to ICU at some point, but we need to evaluate our case mapping data and see if it differs from ICU and if there is a reason for it. Does not handle the case of U+03F2 turning into Sigma from tdf#97152. Change-Id: Icf13ac7aab6d07b2a90fc0ff5ef1c4f50c7a7f8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154803 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-26new loplugin:constexprliteralNoel Grandin
OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-21Require icu-i18n >= 66Khaled Hosny
We were requiring ICU 4.6 which was released in 2011, and ifdef'ing our way through newer ICU versions. ICU is a core dependency and it makes no sense to build LibreOffice with such ancient versions of it. This change requires ICU 66 (released in 2020), and removes all the ifdefs for older versions. There are more cleanups to do, but these will be done separately. Change-Id: I2e4f7608a08f4d531b0a4c74bbfdf91a451f833f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153387 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-21Fix script classification of USCRIPT_WARANG_CITIKhaled Hosny
When the original code was introduced in: commit d83e115bae521fcf193978496d62dbc677a1d6ef Author: Martin Hosken <martin_hosken@sil.org> Date: Fri Mar 4 19:57:29 2011 +0700 USCRIPT_CODE_LIMIT was set to 146 and that what the original code wanted to classify as ScriptType::WEAK. ICU changes USCRIPT_CODE_LIMIT as it adds new scripts, so it got re-assigned with newer ICU releases and USCRIPT_WARANG_CITI was unintentionally classified as ScriptType::WEAK. Change-Id: I5deb5f2050380968ea83b3af969ceae75b1c0070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153373 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-21tdf#114432: classify Tangut and Khitan Small Script as ScriptType::ASIANKhaled Hosny
They are CJK scripts so should not get spacing applied between them and other CJK scripts for instance. Change-Id: Iab88ff1490733e514fd37436cff937dc5fc8dce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153372 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-21Use switch statement in unicode::getScriptClassFromUScriptCode()Khaled Hosny
Makes it easier to tell which is script is given which class, and to extend it with newer scripts. Change-Id: I736e078b94f4d324dd5ceabeac5a2d11c25da3a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153371 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-05-29Remove recently unused CTLScriptType codeKhaled Hosny
This is now unused after: commit 98f7ec383db74a6491e925e30125d3fbf270afc2 Author: Khaled Hosny <khaled@libreoffice.org> Date: Sun May 28 16:28:52 2023 +0300 tdf#139863, tdf#155514: Don’t split COMPLEX text portions The code is also broken as it doesn’t handle surrogate pairs. The UNO API now throws an exception. Change-Id: I454ed741e3834e762a2731d671c21a3e73515da3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-03-30loplugin:stringadd in variousNoel Grandin
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I8cf6a47ad357ddc73e2c430d966be72d5efd1485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149767 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-30tdf#104597 related: restore the mirroring of Bidi_Mirrored charactersKevin Suo
The method PDFIProcessor::mirrorString() was removed, and ::comphelper::string::reverseString was used, by Kevin Suo in commit 69e9925ded584113e52f84ef0ed7c224079fa061. The old PDFIProcessor::mirrorString() did two things: 1) Reverse the code points in the string. However, due to its use of iterateCodePoints(&i) rather than iterateCodePoints(&i, -1) (i.e. iterating in forward rather than reversed order), the reverse was not functioning at all. 2) Use GetMirroredChar (i.e. the icu unicode u_charMirror() which was dropped in commit 720a093461aadff044ac0b1b7b45cf3d416b3785) to get the mirrored-image of characters with the Bidi_Mirrored properties. Stephan Bergmann restored the #1 in commit 50d73574b6c3d71f9a539c895a15d6fcda22390b (by introducing comphelper::string::reverseCodePoints). However, the #2 was not restored. I do not see a clear reason to drop #2 (at least this is an area I don't quite familiar with), so it's better to restore it as well, in *this* commit, named as SubstituteBidiMirrored. Change-Id: Ic263097938310e6e04f3b95bb12e4f4e834198f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143041 Tested-by: Jenkins Reviewed-by: Kevin Suo <suokunlong@126.com>
2022-10-25Update to ICU 72.1Eike Rathke
https://icu.unicode.org/download/72 Unicode 15 https://blog.unicode.org/2022/09/announcing-unicode-standard-version-150.html CLDR 42 https://blog.unicode.org/2022/10/unicode-cldr-v42-available.html New scripts: USCRIPT_KAWI USCRIPT_NAG_MUNDARI New Unicode blocks: UBLOCK_ARABIC_EXTENDED_C UBLOCK_CJK_UNIFIED_IDEOGRAPHS_EXTENSION_H UBLOCK_CYRILLIC_EXTENDED_D UBLOCK_DEVANAGARI_EXTENDED_A UBLOCK_KAKTOVIK_NUMERALS UBLOCK_KAWI UBLOCK_NAG_MUNDARI Change-Id: I8822791e914e6700358b817a1af94b7dcd16b26d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141788 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-05Introduce unicode::getScriptClassFromLanguageTag()Eike Rathke
Change-Id: Ifb932ff2aabc5767571433627314f0b29c35c471 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140953 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-22Related: tdf#151107 make "sloppy" paper fit up to 1.25ptCaolán McNamara
This reverts commit 0b6d45056ab6e1c47b4ed62eedaad02249439444. Change-Id: Ifbc0e286be4ab3dffd0d66228fd1abe2dfc0fde0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-22Revert "Related: tdf#151107 make "sloppy" paper fit up to 1.25pt"Caolán McNamara
mistook user verified +1 for jenkins +1 This reverts commit b15f7297a7f2bb3cb54f2a787d1c460adc2ac6fe. Change-Id: I5656a9a83d92a227efd249073ed746484b57171d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140438 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-22Related: tdf#151107 make "sloppy" paper fit up to 1.25ptCaolán McNamara
Change-Id: I7fe804732849c09659d8d3da41aa1d0650cefb26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140410 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-24Use o3tl::make_unsigned in some placesStephan Bergmann
...where a signed and an unsigned value are compared, and the signed value has just been proven to be non-negative here Change-Id: I20600d61a5d59d739bc1bee838c0038e4611aec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-26add o3tl::toUInt32Noel Grandin
Change-Id: I07f11bf12fbe1d1c2d812fa0965d6e632e1e1aba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133437 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-11use more string_viewNoel Grandin
found by tweaking the loplugin:stringview and making it whitelist getLength Change-Id: Ic41cd4e3026d93b70a76fe1279c6de3abbe6b4a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-27Recheck modules [i-l]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I758bb27e93779e3df21c463714e49354748f446f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128715 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-26Avoid OUStringBuffer::toString where possibleMike Kaganski
Change-Id: I99abbe97a48b2077e28d6221fb70036e5e412657 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127479 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-17Add script codes to standalone {mis} tagsEike Rathke
Also, mis-Medf is dmf-Medf. Change-Id: I5d0766d63effb985a94355a95cfb6c447362051f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125339 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-11-16Update to ICU 70.1Eike Rathke
Unicode 14, 5 new scripts, 12 new Unicode blocks. In i18npool/qa/cppunit/test_breakiterator.cxx TestBreakIterator::testLao() had to be disabled/adapted. Needs to be investigated, see comments there. As is, Lao script word break has regressions. Correct UBLOCK_TANGUT_SUPPLEMENT Unicode range endpoint to 0x18D7F, see https://www.unicode.org/versions/Unicode14.0.0/erratafixed.html for which ublock_getCode(0x18D8F) now returned UBLOCK_NO_BLOCK and thus luckily the assert in svx/source/dialog/charmap.cxx hit. Change-Id: I4bad16ecfab3f44be365b8f884c57f34af68218e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125322 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-11-11Resolves: tdf#110003 tdf#143128 handle lowercase ß vs uppercase ẞ foldingEike Rathke
Change lowercase ß U+00DF LATIN SMALL LETTER SHARP S from LowerToUpper, ToUpper: SS ToTitle: Ss FullFolding: ss to LowerToUpper, ToUpper: ẞ U+1E9E ToTitle: ẞ U+1E9E FullFolding: ss Add uppercase ẞ U+1E9E LATIN CAPITAL LETTER SHARP S UpperToLower, ToLower: ß U+00DF FullFolding: ss Adjust BASIC Collection test to new reality. Change-Id: I198e06985b81a71e5de94bf7fab7a0dbaf10baef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124988 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-11-10Change CaseMappingExtra commented hex offsets to four digits and uppercaseEike Rathke
... to be able to quickly find corresponding CaseMappingValue.value if CaseMappingValue.type is address, and vice versa. Change-Id: I54d86c8f484641af48b6245c17e1f5f8c164c277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124938 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-09-16speedup CharacterClassificationImpl::toUpperNoel Grandin
remove empty sequence creation in CharacterClassificationImpl::toUpper, rather pass a pointer, so it can be nullptr. Which results in a fair degree of cascading change. Change-Id: Ie56d49dc71480195c1807764b0d5124f0019f30b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-13Add PowerPoint compatible screen size for ImpressJun NOGATA
I realized that Impress does not have the same screen size as PowerPoint. tdf#142286, tdf#142288 When I load a PowerPoint slide into Impress, it was a custom size, but when I add this screen size, it shows up with the screen size name. And when I load a slide with the added screen size into PowerPoint, it also shows up with the PowerPoint preset screen size name and not the custom size. The screen sizes I have added are as follows * Widescreen (Current PowerPoint default) * On-scren Show (4:3) * On-scren Show (16:9) (Google slide defualt) * On-scren Show (16:10) Change-Id: I33e2bbc36b2c92ecbb85c610c864f735bf540d03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116374 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-28loplugin:indentation improve checks for brace alignmentNoel Grandin
Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21remove some unnecessary OUString::internNoel Grandin
Change-Id: Ia0f41dfc8a00c115ad544b8236d751e6b2dae5ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117577 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-11 00:45:32 +0000