summaryrefslogtreecommitdiff
path: root/idl
AgeCommit message (Collapse)Author
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12Don't allow O[U]StringBuffer in string concatenationStephan Bergmann
...as OStringBuffer b("foo"); b = "bar" + b; doesn't work as one might expect (see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-October/075464.html> "concat of OUStringBuffer". That feature was LIBO_INTERNAL_ONLY, anyway. And of the affected places, MethodDescriptor::getSignature (codemaker/source/javamaker/javatype.cxx) was the only one that would actually have benefitted. Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-30loplugin:constantparamNoel Grandin
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c Reviewed-on: https://gerrit.libreoffice.org/29321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16loplugin:singlevalfields in basic..idlNoel Grandin
Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-08remove IMAGEROTATION and IMAGEREFLECTION SfxSlotMode enums...Caolán McNamara
unused since... commit 7affe26a1291eef8c77e890228061f13e987bff1 Author: Maxim Monastirsky <momonasmon@gmail.com> Date: Mon Feb 22 18:47:15 2016 +0200 Kill sfx2 menu support Change-Id: I902957b8379be7c314f5357750aeba5a2fcc0a00 Reviewed-on: https://gerrit.libreoffice.org/28749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-30no point in these dtors being virtualCaolán McNamara
nothing inherits from these classes Change-Id: Ic887ac8a046b8697e310e19b6e7fdf9efae8f074
2016-08-30default assignment operator is fineCaolán McNamara
Change-Id: I0b63abbfe7d29c35cf7c7dd047527b20ad46c538
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in framework..lotuswordproNoel Grandin
Change-Id: I9833d85eb6543e996b0f357657c53b1c076ecde4 Reviewed-on: https://gerrit.libreoffice.org/27898 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30loplugin:unusedfieldsNoel Grandin
Change-Id: If06fffa8db050df0f9c1c7da6163575bf522382e Reviewed-on: https://gerrit.libreoffice.org/26754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu
Change-Id: Id3b9abd557f2b8dfc942589362452cbdb0232da9 Reviewed-on: https://gerrit.libreoffice.org/26546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-22move the attribute parsing code to SvParserNoel Grandin
and simplify considerably Change-Id: I2a4af15e77904b62abc81dad78a2990e2eab05f0
2016-06-22move the method param parsing code into SvParserNoel Grandin
Change-Id: I5718c309acd213f94e96efc2e9a98ab0344fe341
2016-06-22simplify parserNoel Grandin
Change-Id: If6b9ed2a0cb373c8bec5d3ff20488f5ee00231ff
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-03loplugin:constantparamsNoel Grandin
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02STREAM_STD_READ already includes StreamMode::NOCREATETakeshi Abe
Change-Id: Ib8c81056619a383cedc828b945c1802ff1ce42ca Reviewed-on: https://gerrit.libreoffice.org/25802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-30tdf#99589 tolower / toupper - dangerous to Turks ...apurvapriyadarshi
Converted toupper to toAsciiUpperCase Change-Id: I595e39bd00a15ede6fc9ea3da3c2a4b2a2322a82 Reviewed-on: https://gerrit.libreoffice.org/25566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-26loplugin:unusedreturntypesNoel Grandin
and clean up the python script Change-Id: I0a7068153290fbbb60bfeb4c8bda1c24d514500f Reviewed-on: https://gerrit.libreoffice.org/25439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-23loplugin:constantparam in idlNoel Grandin
Change-Id: I2fa4c74c9709d3a8495341f00d974ba960c18deb
2016-03-12Remove some unused include stdioJulien Nabet
Change-Id: Ifdb9d133237eecd3132dffb0f85c005beac169d2 Reviewed-on: https://gerrit.libreoffice.org/23174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09loplugin:constantparam in idlNoel Grandin
Change-Id: Icb5e64f17d9472320a79363b1e926e2b4ab05273
2016-03-07loplugin:write only fieldsNoel Grandin
Change-Id: Ia0fb487c5590e096659b81f76c4dc543e184c59c
2016-02-23methods in .SDI files don't use attributesNoel Grandin
so simplify the parser and drop the square brackets Change-Id: I3bab5f5b14e57d0cd1ed1a383fe21968f97b243a
2016-02-23cid#1353438 Logically dead codeNoel Grandin
Change-Id: Ib444a1941e2bec03394c4e8eb7a5a34adbe3f4f6
2016-02-23small cleanups in .SDI parserNoel Grandin
Change-Id: Ic7122e3ecfe2914e27945fd508199f7ec1d6bdab
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-22loplugin:write only fieldsNoel Grandin
Change-Id: I44f249a17d0a510ec63a488b656d57a1a392f821
2016-02-17cleanup the Read*() methods in SvIdlParserNoel Grandin
to be consistent about when they move to the next token Change-Id: I8f5b1eab497fb4a7cb2a2267e815668c3d363de7
2016-02-17move some more slot parsing to SvIdlParserNoel Grandin
Change-Id: I186e80ed0446585aceaf4d25f32ecca7e8ed396c
2016-02-17move parsing of method ags into SvIdlParserNoel Grandin
Change-Id: I2fb969529c0670ae93c3cba69bf207d2c87887dc
2016-02-16tighten up the attribute parsing, and drop some unused slotsNoel Grandin
Change-Id: I6f2ff99c919851b21ce120c40286c133bf65c778
2016-02-16parse shell/interface entries in SvIdlParserNoel Grandin
Change-Id: Ief68b26be0a0890ffdfa02a5904ba9d2cb364c65
2016-02-15cid#1352218 and cid#1352216 in .SDI parserNoel Grandin
Change-Id: I273d80b4e9fb45955c5496cf5559df5dd4b057b0
2016-02-15move interface/shell parsing to SvIdlParserNoel Grandin
Change-Id: I95cce21c6c9beb5637dd4f4a769f455eaacbec2b
2016-02-15move item and struct parsing into SvIdlParserNoel Grandin
Change-Id: I1ba88bca82b5b251ed34330ab5e0cb8bd88a5815
2016-02-15move include parsing into own methodNoel Grandin
Change-Id: Id3ce7ce651f541106cf60116f717e6ffd805db24
2016-02-12missing includeStephan Bergmann
Change-Id: If579fa4cb615a5d7d6ca5c5a864393324940582f
2016-02-12move parsing of enum into SvIdlParserNoel Grandin
Change-Id: I89eef20d62f92f7345750c48c34c9f3b7bca287e
2016-02-12move module parsing into SvIdlParser classNoel Grandin
Change-Id: I99937935a1d41fa5b0ff6c2f5e92bde3b4847e9f
2016-02-12move parsing of "import" into own methodNoel Grandin
Change-Id: Ib3b3fb6fea52b846ada6fb92478ae8f9f769a665
2016-02-12bIsModified in SvMetaModule is unusedNoel Grandin
Change-Id: Idc6effddce9923f0d48a111b2a04458efc11ebf9
2016-02-12rename Read()->ReadIf() and ReadDelimiter()->ReadIfDelimiter()Noel Grandin
Change-Id: I589dc0280c5bb587aa024b0f1dcf0b623d719aa4
2016-02-11fix dead code warning on WindowsNoel Grandin
Change-Id: I7b23442b34c7f2dcc2c44c33613fb66e6eb1b14b
2016-02-11use exceptions for error handling in .SDI parsingNoel Grandin
to simplify the normal control flow Change-Id: If325ec0507a51d8e2d3340fc5b628bb75a078a44