Age | Commit message (Collapse) | Author |
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
|
|
Change-Id: Id78de487b36a1c939dc3a4a5b38ab0b77999478c
|
|
...the generated .ilb, .lst, and .sid outputs requested by SdiTarget were
apparently unused.
Change-Id: I1abb2abc7945070451fce4a98a11d955515e3f63
|
|
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
|
|
to make it's intended purpose clearly distinguishable from AddNextRef
Change-Id: I5da780b48b19fd873667b648031bc394113f953b
Reviewed-on: https://gerrit.libreoffice.org/11763
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I31bbeb5f068754d6dc77c22d759058089b03c9b1
|
|
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
|
|
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
|
|
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
|
|
Change-Id: Icca5a0dee296fae1abeb78ea8ffa2f9e934bb111
|
|
Change-Id: I0758fd3117795ed68789385576aee5a885639104
|
|
Change-Id: Id440c165f6e98a7d0fe0c8c578e404db75416c48
|
|
Change-Id: Ie12862f8df701298db51ed45b5c24814a6f94def
|
|
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p
@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>
Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I5b16007b514169e2349c8c3a78d3c150c9d52d85
|
|
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: I98bb62bbcb7ffbd2896ddbcbaeea27fff0851653
|
|
Change-Id: I5c89f7291117d66ff07f7d686c7030396cb504df
|
|
Change-Id: Ieb7ee3f8eb192612e76d5ad928389445e82ef90e
|
|
Change-Id: I8b15c97b1fcc6acaf567e8b1d2d37cbc99687a9d
|
|
Change-Id: I665e901eb6f65308b8f130da1c6da95bc3255490
|
|
Change-Id: Idc26e03d51e37adbd23fb3c77d8ebe63ed8c3de3
|
|
Change-Id: Icd99fd2cd530f52b0acf5d91667eeec8142e8340
|
|
Change-Id: I61334b687c251ccc90f125e8bf95f8689028b8c3
|
|
Change-Id: I7c4902a4151f207d8a61b76d05fad74a4c8854d4
|
|
Change-Id: I91f6e861f6d0dbea1b57ac73857e0c706b27f681
|
|
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
|
|
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
|
|
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
|
|
This is working version of fc27a685d466dc380a8b68cd48f47db632ed3693
Change-Id: I48e861b5b7692ea051edf52d7ad9cc54ca989e22
|
|
Forgot to test properly on Windows :-(.
This reverts commit fc27a685d466dc380a8b68cd48f47db632ed3693.
|
|
Export these symbols from sfx library.
For cases when we link together more libraries, there are more symbols,
so I've kept __attribute__((__weak__)) hack there.
Change-Id: I8b7f6fc9bea479dca5062344c04b74c1f3eb36b2
|
|
Change-Id: Iee2bbba1e581364f72a73421ba8e799fa05a94e4
|
|
Change-Id: I0f09c42928d354bd26fa5137a2faa768560b1223
|
|
Change-Id: I03c835327eabc9bfdc9904abb2ba6a8f13bd7207
|
|
Change-Id: I73524c3e1911456ef14dcb07f073fed85f869524
|
|
Change-Id: I5c34f9bc96ee23fca6182740e3279de1485c61ea
|
|
In theory, it should not be used, we use it now to mark duplicated
symbols from sdi slots as weak. See idl/source/objects/types.cxx.
Change-Id: I3c6fccfb96884df6b9e6eb35b8615ba4d66ca208
|
|
in favour of ReadXXX methods.
Change-Id: Ic2c0a7b6b92ff4c236ae99b39d77f3d935b301e3
Reviewed-on: https://gerrit.libreoffice.org/7915
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Convert the template based read_lenPrefixed methods to regular
methods.
Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019
Reviewed-on: https://gerrit.libreoffice.org/7895
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I5e777801a7df934f61182f6df8f66fc18d00073c
|
|
Change-Id: Ib652a8a1f81dde1f5ac3b6b7b73376c73777247c
|
|
Change-Id: Ifdee50acbc72387812156af5cb8b078d97ebe5d1
|
|
.. and convert the last few places still using those methods.
Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.
Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
|
|
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.
Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
|