Age | Commit message (Collapse) | Author |
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
|
|
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
|
|
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
|
|
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
|
|
Change-Id: I10e5dd8ea4097892d2571304d982ab20ee230988
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I14c306132a8f12c6f7ecebe5b012984d04bf0d91
|
|
Change-Id: Ibd07b854bbcf9d9e83236669addfd61fe639882a
|
|
Change-Id: I68e8e6a564356bae620647b385e16279ff212d32
|
|
This has been supported by GCC and clang for a very long time.
Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
|
|
Change-Id: I0d64c9b2b7aeddfd70541a14c8a325fea9944c39
|
|
We don't like C-style casts in our nice C++ code
Change-Id: I94e7ec90de9275cd6e20c4146d4f3a74bed93c9d
Reviewed-on: https://gerrit.libreoffice.org/10367
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
to avoid problem with ucpp
(cherry picked from commit 6e370ddd6b532e7bf12df3aa52f93913f4ea8348)
Conflicts:
idlc/source/options.cxx
Change-Id: Ia8c7dc3a9a7df68a483dd106cd47c8624952aeae
|
|
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
|
|
Change-Id: I62da508151614277d59e831c7506c3ec715348f4
|
|
This reverts commit 5f5a981dd6df406b7bbddd88fa0b701b5a8d2246. Coverity warning
about mkstemp without umask appears to be bogus (cf.
<https://communities.coverity.com/message/6516> "Why are uses of mkstemp
'without securely setting umask first' being flagged?) and calling umask is not
MT-safe, see fdo#60338 "FILESAVE: Saved files have incorrect permissions on
linux."
|
|
Change-Id: I665e901eb6f65308b8f130da1c6da95bc3255490
|
|
Change-Id: I48990c044e4583e835f3e995527ba423e8c459fb
|
|
Change-Id: I513aeeabbb4d6fc48b6a95e034c311a454dd5ca7
|
|
Change-Id: I7c957419b72cc97dbec819c51acb521bcd716624
|
|
Change-Id: Ibeed903d73eb8b3fce7b8c6021c9107437a8c813
|
|
Change-Id: Ie5fc19fa223942e31899408324beb2e15c1d7bef
|
|
Change-Id: Iccd5a78b54620796cfde672388b70ad97d17b7a5
|
|
Change-Id: I0ec9d6ed41eddbc0177c26755b621f404cfd4703
|
|
Change-Id: I52c9e37ca4d3238b9018264b6542a9dcebca13f6
|
|
Change-Id: I1ca5e4d31ab203a0ddd5e98928f5046f5fffb485
|
|
Change-Id: Ia6799c852eb95d496fbc8dcfdabde62dffc263a6
Reviewed-on: https://gerrit.libreoffice.org/7066
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I76be464200d486efef9c8a7e957c310c9adae3b8
|
|
This is largely unnecessary when working with OUString
Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
|
|
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|
|
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
|
|
So there is no need to do this locally, too.
Change-Id: Ibc623235cae07a86dfd0dbc1d7672ca4273facec
|
|
Convert places that call
aStr[aStr.getLength()-1] == 'x'
to use the shorter form
aStr.endsWith("x")
Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
Change-Id: I861b85ac38a2881ff4b993047c1a15335308ba62
|
|
a bit of guesswork here I admit
Change-Id: I774da6f585e4b81a25660b7823d6bb150630f44f
|
|
Remove an odd {1} repeat count, and remove the "."{DIGIT}+ pattern that is
already covered by the following {DIGIT}*"."{DIGIT}+ pattern.
Change-Id: If99dfe10a5e37225355472bf4deceb34c0a92eb9
|
|
Change-Id: Id28fb53a98ff164cd14f8f9dcb4ebee7a71bfd1e
|
|
Change-Id: Ief0109289c6dc70b51193fa5f4432efe2b48c3fb
|
|
(note: object is of type 'AstTypeDef'); Clang -fsanitize=undefined
Change-Id: I1b11a7678f18557c8040af2118c1c0101913f086
|
|
(note: object is of type 'AstDeclaration'); Clang -fsanitize=undefined
Change-Id: I08eef7d3e8b298abd16b0c6d72cfb72b75190cd5
|
|
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
|
|
Change-Id: I78ba286be5aa4d731f734e5eb16adb77c686aad9
Reviewed-on: https://gerrit.libreoffice.org/4325
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
|
|
Change-Id: I0057b9174af6a83f3fde0e27c3a91a4aeca95873
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
lets try this hack, if it fails revert and I'll just
manually update the baseline with a newer flex than
flex-2.5.4a-41.fc6
Change-Id: If644489e80fc4e4cdba97808af0fe4d544d08646
|
|
Change-Id: Ic05de69951b28b9cc8d62f0a534b507c424e6b25
|