Age | Commit message (Collapse) | Author |
|
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
|
|
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
|
|
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
|
|
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
|
|
Change-Id: I10e5dd8ea4097892d2571304d982ab20ee230988
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I14c306132a8f12c6f7ecebe5b012984d04bf0d91
|
|
Change-Id: Ibd07b854bbcf9d9e83236669addfd61fe639882a
|
|
Change-Id: I68e8e6a564356bae620647b385e16279ff212d32
|
|
This has been supported by GCC and clang for a very long time.
Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
|
|
Change-Id: I0d64c9b2b7aeddfd70541a14c8a325fea9944c39
|
|
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
We don't like C-style casts in our nice C++ code
Change-Id: I94e7ec90de9275cd6e20c4146d4f3a74bed93c9d
Reviewed-on: https://gerrit.libreoffice.org/10367
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
|
|
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
to avoid problem with ucpp
(cherry picked from commit 6e370ddd6b532e7bf12df3aa52f93913f4ea8348)
Conflicts:
idlc/source/options.cxx
Change-Id: Ia8c7dc3a9a7df68a483dd106cd47c8624952aeae
|
|
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
|
|
Change-Id: I62da508151614277d59e831c7506c3ec715348f4
|
|
This reverts commit 5f5a981dd6df406b7bbddd88fa0b701b5a8d2246. Coverity warning
about mkstemp without umask appears to be bogus (cf.
<https://communities.coverity.com/message/6516> "Why are uses of mkstemp
'without securely setting umask first' being flagged?) and calling umask is not
MT-safe, see fdo#60338 "FILESAVE: Saved files have incorrect permissions on
linux."
|
|
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.
(cherry picked from commit 11a1ff6144521aeabb0c6db25c89a2ac31bedee0)
Conflicts:
external/libxmlsec/xmlsec1-customkeymanage.patch
hwpfilter/source/hwpeq.cxx
icc/README
icu/createmak.pl
idl/source/objects/object.cxx
idlc/inc/idlc/errorhandler.hxx
include/jvmfwk/framework.h
include/oox/helper/propertyset.hxx
instsetoo_native/inc_ure/windows/msi_templates/_Validat.idt
javainstaller2/src/JavaSetup/org/openoffice/setup/Controller/PrologueCtrl.java
javainstaller2/src/JavaSetup/org/openoffice/setup/Installer/LinuxInstaller.java
javainstaller2/src/JavaSetup/org/openoffice/setup/Installer/SolarisInstaller.java
javainstaller2/src/JavaSetup/org/openoffice/setup/InstallerHelper/LinuxHelper.java
javainstaller2/src/JavaSetup/org/openoffice/setup/SetupData/ProductDescription.java
javainstaller2/src/JavaSetup/org/openoffice/setup/Util/Controller.java
javainstaller2/src/JavaSetup/org/openoffice/setup/Util/ExecuteProcess.java
javaunohelper/com/sun/star/comp/helper/SharedLibraryLoader.java
javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java
jurt/com/sun/star/comp/servicemanager/ServiceManager.java
jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
jvmfwk/source/elements.cxx
jvmfwk/source/elements.hxx
l10ntools/inc/wtranode.hxx
l10ntools/inc/wtratree.hxx
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/Convert.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/ConverterException.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/FileMaker.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/GSIWriter.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/GSIandSDFMerger.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFReader.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFWriter.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/XLIFFWriter.java
l10ntools/scripts/localize.pl
l10ntools/scripts/localize_old.pl
l10ntools/source/cfgmerge.cxx
l10ntools/source/export.cxx
l10ntools/source/filter/merge/FCFGMerge.java
l10ntools/source/filter/merge/Merger.java
l10ntools/source/filter/utils/Cache.java
l10ntools/source/filter/utils/ConfigHelper.java
l10ntools/source/filter/utils/FileHelper.java
l10ntools/source/filter/utils/XMLHelper.java
l10ntools/source/merge.cxx
l10ntools/source/tagtest.cxx
l10ntools/source/xmlparse.cxx
l10ntools/source/xrmmerge.cxx
libtextcat/libtextcat-2.2.patch
libxml2/libxml2-long-path.patch
linguistic/inc/linguistic/misc.hxx
linguistic/source/lngsvcmgr.cxx
migrationanalysis/src/driver_docs/allstrings.ulf
migrationanalysis/src/driver_docs/sources/AnalysisDriver.bas
migrationanalysis/src/driver_docs/sources/CommonMigrationAnalyser.bas
migrationanalysis/src/driver_docs/sources/word/MigrationAnalyser.cls
migrationanalysis/src/msokill/msokill.cpp
migrationanalysis/src/wizard/Wizard.frm
odk/examples/DevelopersGuide/Accessibility/EventHandler.java
odk/examples/DevelopersGuide/Accessibility/EventListenerProxy.java
odk/examples/DevelopersGuide/Accessibility/GraphicalDisplay.java
odk/examples/DevelopersGuide/Forms/DataAwareness.java
odk/examples/DevelopersGuide/Forms/KeyGenerator.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/DocumentView.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/FunctionHelper.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/Interceptor.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/NativeView.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OnewayExecutor.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusView.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/ViewContainer.java
odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java
odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/FilterOptions.java
odk/examples/cpp/complextoolbarcontrols/Makefile
odk/setsdkenv_windows.template
offapi/com/sun/star/accessibility/AccessibleEventId.idl
offapi/com/sun/star/accessibility/AccessibleEventObject.idl
offapi/com/sun/star/accessibility/AccessibleRelationType.idl
offapi/com/sun/star/accessibility/XAccessible.idl
offapi/com/sun/star/accessibility/XAccessibleRelationSet.idl
offapi/com/sun/star/accessibility/XAccessibleStateSet.idl
offapi/com/sun/star/animations/Event.idl
offapi/com/sun/star/animations/XAnimationNode.idl
offapi/com/sun/star/awt/AccessibleListBoxList.idl
offapi/com/sun/star/awt/XLayoutFlow.idl
offapi/com/sun/star/awt/XMessageBoxFactory.idl
offapi/com/sun/star/awt/XPopupMenu.idl
offapi/com/sun/star/awt/grid/XGridColumn.idl
offapi/com/sun/star/chart/ChartAxis.idl
offapi/com/sun/star/chart2/data/TabularDataProviderArguments.idl
offapi/com/sun/star/chart2/data/XDatabaseDataProvider.idl
offapi/com/sun/star/configuration/AdministrationProvider.idl
offapi/com/sun/star/configuration/ConfigurationRegistry.idl
offapi/com/sun/star/configuration/backend/XBackendChangesNotifier.idl
offapi/com/sun/star/datatransfer/XDataFormatTranslator.idl
offapi/com/sun/star/datatransfer/clipboard/RenderingCapabilities.idl
offapi/com/sun/star/deployment/InvalidRemovedParameterException.idl
offapi/com/sun/star/document/DocumentInfo.idl
offapi/com/sun/star/document/EmptyUndoStackException.idl
offapi/com/sun/star/document/EventObject.idl
offapi/com/sun/star/document/ExtendedTypeDetection.idl
offapi/com/sun/star/document/ExtendedTypeDetectionFactory.idl
offapi/com/sun/star/document/FilterFactory.idl
offapi/com/sun/star/document/MediaDescriptor.idl
offapi/com/sun/star/document/NoSuchFilterRequest.idl
offapi/com/sun/star/document/OfficeDocument.idl
offapi/com/sun/star/document/TypeDetection.idl
offapi/com/sun/star/document/UndoContextNotClosedException.idl
offapi/com/sun/star/document/XExtendedFilterDetection.idl
offapi/com/sun/star/document/XFilter.idl
offapi/com/sun/star/document/XInteractionFilterSelect.idl
offapi/com/sun/star/document/XTypeDetection.idl
offapi/com/sun/star/drawing/Hatch.idl
offapi/com/sun/star/drawing/XDrawPages.idl
offapi/com/sun/star/drawing/XShapeBinder.idl
offapi/com/sun/star/drawing/framework/XConfigurationControllerRequestQueue.idl
offapi/com/sun/star/drawing/framework/XRelocatableResource.idl
offapi/com/sun/star/embed/ElementModes.idl
offapi/com/sun/star/embed/EntryInitModes.idl
offapi/com/sun/star/embed/Storage.idl
offapi/com/sun/star/embed/StorageFactory.idl
offapi/com/sun/star/embed/StorageStream.idl
offapi/com/sun/star/embed/XCommonEmbedPersist.idl
offapi/com/sun/star/embed/XEmbedObjectClipboardCreator.idl
offapi/com/sun/star/embed/XEmbeddedClient.idl
offapi/com/sun/star/embed/XInplaceClient.idl
offapi/com/sun/star/embed/XInplaceObject.idl
offapi/com/sun/star/embed/XInsertObjectDialog.idl
offapi/com/sun/star/embed/XPersistanceHolder.idl
offapi/com/sun/star/embed/XStorage.idl
offapi/com/sun/star/embed/XTransactionBroadcaster.idl
offapi/com/sun/star/embed/XTransactionListener.idl
offapi/com/sun/star/form/FormComponents.idl
offapi/com/sun/star/form/XSubmitListener.idl
offapi/com/sun/star/form/binding/BindableDataAwareControlModel.idl
offapi/com/sun/star/form/binding/BindableDatabaseListBox.idl
offapi/com/sun/star/form/component/DatabaseComboBox.idl
offapi/com/sun/star/form/component/DatabaseFormattedField.idl
offapi/com/sun/star/form/component/DatabasePatternField.idl
offapi/com/sun/star/form/component/DatabaseTextField.idl
offapi/com/sun/star/form/component/GridControl.idl
offapi/com/sun/star/frame/Components.idl
offapi/com/sun/star/frame/ContentHandler.idl
offapi/com/sun/star/frame/ContentHandlerFactory.idl
offapi/com/sun/star/frame/Desktop.idl
offapi/com/sun/star/frame/DispatchDescriptor.idl
offapi/com/sun/star/frame/DispatchProvider.idl
offapi/com/sun/star/frame/DispatchRecorder.idl
offapi/com/sun/star/frame/Frame.idl
offapi/com/sun/star/frame/FrameActionEvent.idl
offapi/com/sun/star/frame/FrameLoaderFactory.idl
offapi/com/sun/star/frame/ProtocolHandler.idl
offapi/com/sun/star/frame/XControlNotificationListener.idl
offapi/com/sun/star/frame/XDesktop.idl
offapi/com/sun/star/frame/XDispatchRecorderSupplier.idl
offapi/com/sun/star/frame/XDocumentTemplates.idl
offapi/com/sun/star/frame/XFrame.idl
offapi/com/sun/star/frame/XFrameLoader.idl
offapi/com/sun/star/frame/XInterceptorInfo.idl
offapi/com/sun/star/frame/XRecordableDispatch.idl
offapi/com/sun/star/frame/XStatusbarController.idl
offapi/com/sun/star/frame/XStorable2.idl
offapi/com/sun/star/frame/XSynchronousDispatch.idl
offapi/com/sun/star/frame/XTerminateListener2.idl
offapi/com/sun/star/graphic/GraphicObject.idl
offapi/com/sun/star/graphic/XGraphicObject.idl
offapi/com/sun/star/inspection/XNumericControl.idl
offapi/com/sun/star/inspection/XObjectInspectorModel.idl
offapi/com/sun/star/inspection/XPropertyHandler.idl
offapi/com/sun/star/installation/XProtocolHandlerCheck.idl
offapi/com/sun/star/installation/protocols.idl
offapi/com/sun/star/linguistic2/SpellFailure.idl
offapi/com/sun/star/linguistic2/XLinguServiceManager.idl
offapi/com/sun/star/mail/XMailServer.idl
offapi/com/sun/star/mozilla/XPluginInstance.idl
offapi/com/sun/star/mozilla/XPluginInstanceSyncPeer.idl
offapi/com/sun/star/packages/zip/ZipIOException.idl
offapi/com/sun/star/presentation/OutlineView.idl
offapi/com/sun/star/presentation/XPresentation2.idl
offapi/com/sun/star/presentation/XSlideShow.idl
offapi/com/sun/star/presentation/XSlideShowController.idl
offapi/com/sun/star/report/XFunction.idl
offapi/com/sun/star/report/XFunctionsSupplier.idl
offapi/com/sun/star/report/XReportComponent.idl
offapi/com/sun/star/report/XReportDefinition.idl
offapi/com/sun/star/report/meta/XFunctionManager.idl
offapi/com/sun/star/resource/XStringResourcePersistence.idl
offapi/com/sun/star/resource/XStringResourceWithLocation.idl
offapi/com/sun/star/resource/XStringResourceWithStorage.idl
offapi/com/sun/star/sdb/DataSettings.idl
offapi/com/sun/star/sdb/ErrorCondition.idl
offapi/com/sun/star/sdb/SQLContext.idl
offapi/com/sun/star/sdb/Table.idl
offapi/com/sun/star/sdb/XRowSetApproveListener.idl
offapi/com/sun/star/sdb/application/XDatabaseDocumentUI.idl
offapi/com/sun/star/sdb/tools/XConnectionTools.idl
offapi/com/sun/star/sdbc/DataType.idl
offapi/com/sun/star/sdbc/XDatabaseMetaData.idl
offapi/com/sun/star/sdbcx/Descriptor.idl
offapi/com/sun/star/security/DocumentSignatureInformation.idl
offapi/com/sun/star/sheet/AccessibleSpreadsheetDocumentView.idl
offapi/com/sun/star/sheet/AccessibleSpreadsheetPageView.idl
offapi/com/sun/star/sheet/DatabaseRange.idl
offapi/com/sun/star/smarttags/XSmartTagAction.idl
offapi/com/sun/star/table/AccessibleTableView.idl
offapi/com/sun/star/table/CellProperties.idl
offapi/com/sun/star/table/CellRangeListSource.idl
offapi/com/sun/star/table/CellValueBinding.idl
offapi/com/sun/star/table/XMergeableCellRange.idl
offapi/com/sun/star/task/DocumentPasswordRequest.idl
offapi/com/sun/star/task/JobExecutor.idl
offapi/com/sun/star/task/MasterPasswordRequest.idl
offapi/com/sun/star/task/PasswordRequest.idl
offapi/com/sun/star/task/XJob.idl
offapi/com/sun/star/text/AccessiblePageView.idl
offapi/com/sun/star/text/AccessibleTextDocumentView.idl
offapi/com/sun/star/text/LineNumberingProperties.idl
offapi/com/sun/star/text/NumberingRules.idl
offapi/com/sun/star/text/XRelativeTextContentRemove.idl
offapi/com/sun/star/text/textfield/Database.idl
offapi/com/sun/star/text/textfield/SetExpression.idl
offapi/com/sun/star/text/textfield/docinfo/Description.idl
offapi/com/sun/star/text/textfield/docinfo/Info0.idl
offapi/com/sun/star/text/textfield/docinfo/Info1.idl
offapi/com/sun/star/text/textfield/docinfo/Info2.idl
offapi/com/sun/star/text/textfield/docinfo/Info3.idl
offapi/com/sun/star/text/textfield/docinfo/Keywords.idl
offapi/com/sun/star/text/textfield/docinfo/Revision.idl
offapi/com/sun/star/text/textfield/docinfo/Subject.idl
offapi/com/sun/star/text/textfield/docinfo/Title.idl
offapi/com/sun/star/ucb/CommandFailedException.idl
offapi/com/sun/star/ucb/Content.idl
offapi/com/sun/star/ucb/ContentAction.idl
offapi/com/sun/star/ucb/FetchError.idl
offapi/com/sun/star/ucb/FetchResult.idl
offapi/com/sun/star/ucb/HierarchyDataSource.idl
offapi/com/sun/star/ucb/InteractiveFileIOException.idl
offapi/com/sun/star/ucb/SearchRecursion.idl
offapi/com/sun/star/ucb/UniversalContentBroker.idl
offapi/com/sun/star/ucb/XAnyCompare.idl
offapi/com/sun/star/ucb/XCachedContentResultSetFactory.idl
offapi/com/sun/star/ucb/XCachedDynamicResultSetFactory.idl
offapi/com/sun/star/ucb/XContentIdentifierMapping.idl
offapi/com/sun/star/ui/UIElementType.idl
offapi/com/sun/star/ui/dialogs/FilePicker.idl
offapi/com/sun/star/ui/dialogs/FolderPicker.idl
offapi/com/sun/star/util/PathSubstitution.idl
offapi/com/sun/star/util/XChangesNotifier.idl
offapi/com/sun/star/util/XCloseBroadcaster.idl
offapi/com/sun/star/util/XCloseListener.idl
offapi/com/sun/star/util/XCloseable.idl
offapi/com/sun/star/util/XStringSubstitution.idl
offapi/com/sun/star/util/XTextSearch.idl
offapi/com/sun/star/util/XURLTransformer.idl
offapi/com/sun/star/xforms/XModel.idl
offapi/com/sun/star/xml/sax/XFastAttributeList.idl
offapi/com/sun/star/xml/sax/XFastParser.idl
officecfg/registry/data/org/openoffice/Office/Labels.xcu
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
officecfg/registry/schema/org/openoffice/Office/Common.xcs
officecfg/registry/schema/org/openoffice/Office/Embedding.xcs
officecfg/registry/schema/org/openoffice/Office/ExtensionDependencies.xcs
officecfg/registry/schema/org/openoffice/Office/ExtensionManager.xcs
officecfg/registry/schema/org/openoffice/Office/Histories.xcs
officecfg/registry/schema/org/openoffice/Office/OptionsDialog.xcs
officecfg/registry/schema/org/openoffice/Office/Paths.xcs
officecfg/registry/schema/org/openoffice/Office/PresenterScreen.xcs
officecfg/registry/schema/org/openoffice/Office/TabBrowse.xcs
officecfg/registry/schema/org/openoffice/Office/UI.xcs
officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
officecfg/registry/schema/org/openoffice/Office/UI/WindowState.xcs
officecfg/registry/schema/org/openoffice/Office/WebWizard.xcs
officecfg/registry/schema/org/openoffice/Office/Writer.xcs
officecfg/registry/schema/org/openoffice/Setup.xcs
officecfg/registry/schema/org/openoffice/TypeDetection/Types.xcs
oox/source/xls/sheetdatabuffer.cxx
package/source/xstor/xstorage.cxx
padmin/source/padialog.src
postprocess/signing/signing.pl
pyuno/source/module/pyuno_module.cxx
Change-Id: I60c7b6d661ff803b5e9214ac7fefb32772ef19a7
|
|
Change-Id: I665e901eb6f65308b8f130da1c6da95bc3255490
|
|
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
|
|
Change-Id: I48990c044e4583e835f3e995527ba423e8c459fb
|
|
Change-Id: I513aeeabbb4d6fc48b6a95e034c311a454dd5ca7
|
|
Change-Id: I7c957419b72cc97dbec819c51acb521bcd716624
|
|
Change-Id: Ibeed903d73eb8b3fce7b8c6021c9107437a8c813
|
|
Change-Id: I5434402e372c4567b2c3f96f5c175618ba3e5cfb
|
|
Change-Id: Ie5fc19fa223942e31899408324beb2e15c1d7bef
|
|
Change-Id: Iccd5a78b54620796cfde672388b70ad97d17b7a5
|
|
Change-Id: I0ec9d6ed41eddbc0177c26755b621f404cfd4703
|
|
Change-Id: I52c9e37ca4d3238b9018264b6542a9dcebca13f6
|
|
Change-Id: I1ca5e4d31ab203a0ddd5e98928f5046f5fffb485
|
|
Change-Id: Ia6799c852eb95d496fbc8dcfdabde62dffc263a6
Reviewed-on: https://gerrit.libreoffice.org/7066
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I76be464200d486efef9c8a7e957c310c9adae3b8
|
|
Change-Id: Icd47d87f93641a0b24a96a4be8d3d120f0405f2d
|
|
Change-Id: I733cd478caabc6337af9705a57ebbaeedfb92bb0
|
|
...and enable tests shared with idlc
Change-Id: I422b16c9b2636835d276cc2085cb640073894c97
|
|
Change-Id: Ib7ee3188b87b9b4216214b65347e34970e1b92a5
|
|
Change-Id: I93b9fcc2b20ed7a7c160a9ef3294b6e578678f53
|
|
* byte only accepts singed literal values < 128 now
Change-Id: If557b5212e349fe115948f72b5558fee338db659
|
|
* global exception names no longer clash with local names
* repeating the same exception in a raises spec is caught now
Change-Id: I388aae4de59bddc1c69bf4c263297d0b92b47106
|
|
Change-Id: I653522d8ebaac3329f368c102d14041c6b49d41d
|
|
This is largely unnecessary when working with OUString
Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
|
|
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|
|
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
|
|
So there is no need to do this locally, too.
Change-Id: Ibc623235cae07a86dfd0dbc1d7672ca4273facec
|
|
Convert places that call
aStr[aStr.getLength()-1] == 'x'
to use the shorter form
aStr.endsWith("x")
Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
Change-Id: Id1e74f18c90e69d1a781c8f02e30dc3c005ed4fd
|