summaryrefslogtreecommitdiff
path: root/include/basic
AgeCommit message (Collapse)Author
2014-12-03fdo#84938 replace BASERR_REASON_ constants -> enumTobias Madl
Change-Id: I80fe0108c2d27b72d2fadc23032cf2b52c3193a6 Reviewed-on: https://gerrit.libreoffice.org/13268 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23basic: pimplify thatMichael Stahl
Change-Id: I0abe66ded0fd69a2720ad64e1a1426aafc7dfffb
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-08-26convert SBX flag bits to type-safe enumNoel Grandin
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817 Reviewed-on: https://gerrit.libreoffice.org/11070 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22Remove BasicManagerCleanerStephan Bergmann
Change-Id: I55eccc6367cf3255af05c075631945f47417d682
2014-07-29convert linked list to std::vector in SbxDimArrayNoel Grandin
Change-Id: I2640cfe1f9606d992f622b99ff3c607555771e23 Reviewed-on: https://gerrit.libreoffice.org/10298 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-25Remove this weird inheritance from smart-pointer-wrapped class.Kohei Yoshida
SbxVarEntry is now its own class. Change-Id: I5c5ce1990fa83930acced1d507f5b0de60bf221e
2014-06-25Use boost::optional to store alias name.Kohei Yoshida
Change-Id: I809b21ea156061a265c0d83d58534df10bc273bc
2014-06-25pData -> mpVarEntries.Kohei Yoshida
pData is a nightmare with grepping as it's too generic of a name. Change-Id: I01b3f1b503f21ee13c97733fa66804874a2cddc4
2014-06-25Remove this class that only derives from std::vector and not much else.Kohei Yoshida
Change-Id: Ibc584f4148cec49a9ac34a240cc2fa3e87daf443
2014-06-24new compilerplugin returnbyrefNoel Grandin
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-05-29Detach all DocBasicItem objects upon process termination.Kohei Yoshida
To prevent rogue DocBasicItem objects (which are global objects) from attempting to stop listening after the main app is dead. Change-Id: I68a667137ca4e0eff18278f4d2d5dd67466eaf34
2014-04-14typo: hierarchie -> hierarchyThomas Arnhold
2014-04-07Replace SV_DECL/IMPL_REF macros with SvRef templateStephan Bergmann
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
2014-04-04StarBASIC::ErrorHdl sal_Bool->boolNoel Grandin
Change-Id: I68cc6c6b63174ff16e5fda00f62172e1eaacbf0d
2014-04-04SbxObject::Call sal_Bool->boolNoel Grandin
Change-Id: I2e52ddf704679a118fbbc4efebb7cf9fb36f0c34
2014-04-04SbxObject::isClass sal_Bool->boolNoel Grandin
Change-Id: I71f7b3603df43924d7374969444b929e1eecca4e
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-28fdo#75280 Started cleaning up of sal_uIntPtr usage.Valentin Kettner
Converted wrong usage of sal_uIntPtr to appropriate other types in basic module. The bug is not fully fixed with this since many other occurences of sal_uIntPtr remain. Update due to code review comments: Fixed forgetting to change some declarations in iosys.cxx. Cleaned up the one remaining sal_uIntPtr in iosys.cxx Fixed adding a sal_uInt64 to a Date (uses long now instead) in methods.cxx Fixed the VarDecFromUI4 call in sbxdec.cxx from sal_uLong to ULONG . Conflicts: basic/source/runtime/iosys.cxx Change-Id: Ia6460be04967deb68b92eb62d945da8814fae605
2014-03-28Remove remaining DBG_CTOR etc. remnants from basicStephan Bergmann
Change-Id: Ia714029c2e32e28c1bb6f4f59d0c7f357eccc236
2014-03-27basic: sal_Bool->boolNoel Grandin
Change-Id: Icd78d21495f305c8f00280eee76e7262e542317d
2014-03-27basic: sal_Bool->boolNoel Grandin
Change-Id: Id4952b6f97f9e8f917fea5651dee91499d109e48
2014-03-27basic: sal_Bool->boolNoel Grandin
Change-Id: Idfe18863b2c6f60da5192d661f66e85a2bac09e5
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26Split TYPEINFO into plain and TYPEINFO_OVERRIDEStephan Bergmann
...where the latter contains SAL_OVERRIDE annotations Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
2014-03-13basic: prefer passing OUString and OString by referenceNoel Grandin
Change-Id: I8121204cdb37d4e1d8967397f3e45bdab6aaddad
2014-03-01Remove visual noise from includeAlexander Wilms
Conflicts: include/framework/preventduplicateinteraction.hxx include/sfx2/sfxbasecontroller.hxx include/sfx2/sfxbasemodel.hxx include/toolkit/awt/vclxtabpagemodel.hxx include/vcl/field.hxx include/vcl/settings.hxx Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2 Reviewed-on: https://gerrit.libreoffice.org/8272 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28remove unused code in basic/CodeCompleteDataCacheNoel Grandin
Specifically: CodeCompleteDataCache::GetVars() const CodeCompleteDataCache::SetVars(boost::unordered_map const&) CodeCompleteDataCache::print() const Change-Id: I59fb6f50ff47747c3cac959302bf6b7c4f4d79d3
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-01-30fdo#63154 Removed unused solar.h ref. in basic and formulaAlexandre Vicenzi
Change-Id: Ibf30f29653568929e65ebd897cef474a6838d5cc Reviewed-on: https://gerrit.libreoffice.org/7735 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-11sbxbase.hxx is private to basicTor Lillqvist
Change-Id: I108bd247a40ce2b46034cabe8b075fa4f5a396df
2013-12-11sbstdobj.hxx is private to basicTor Lillqvist
Change-Id: I131dfeded783edfea94208d1cf8d70a2090785fa
2013-12-11sbprop.hxx is private to basicTor Lillqvist
Change-Id: I1d7a28652ee7743b6823d78e1565338a324f0a6a
2013-12-11sbobjmod.hxx is private to basicTor Lillqvist
Change-Id: I4ad28b049de5f7268ee1ca2e8992e2f29ed05380
2013-12-11basic/global.hxx is private to basicTor Lillqvist
Change-Id: I90a28e34eb45819e240931cd751ac0a546ea6be8
2013-11-09fdo#65108 inter-module includes <>Norbert Thiebaud
Change-Id: I419a1288bc6120d978fc301f127d5d29298f3ede
2013-10-23fixincludeguards.sh: include/{basegfx,basic}Thomas Arnhold
Change-Id: Id18d3f4b4ed763b2ec9e718d66c3c3b9968fcac2
2013-09-26typo fixes in commentsAndras Timar
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-11Easier conversion between Basic Date and UNO Date/TimeLionel Elie Mamane
Utility functions to convert between Basic Date type and the representations of Date and Time in UNO, namely: - com.sun.star.util.Date - com.sun.star.util.Time - com.sun.star.util.DateTime Name of new functions: - CDateToUnoDate - CDateFromUnoDate - CDateToUnoTime - CDateFromUnoTime - CDateToUnoDateTime - CDateFromUnoDateTime Change-Id: I2b971df20df1c0351d071023e042169b548894f1 Reviewed-on: https://gerrit.libreoffice.org/5897 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-09-03completition->completion :)Ivan Timofeev
Change-Id: I7a5ae7cc0d6a253bbc27db076babedd65c89be1a
2013-09-02GSOC work, autocorrect procedures+variablesGergo Mocsi
Fixed some small issue with the right arrow key in the ListBox. Autocorrection now correct all variable types and procedure names. Change-Id: Iff1abaf10c621aef04772837faa272bb6f987e37
2013-09-02GSOC work, renaming + options fixGergo Mocsi
Options now work correctly: I've added the missing function. Rename: renamed some variables and methods to kep the consistence( Autocorrect keywords -> Autocorrect). Change-Id: I6b4914575f1a06eb3268c133b8b990364e3d24e4
2013-09-02GSOC work, behavior fixesGergo Mocsi
Code completition: left/right arrow keys handled. Left arrow dismisses the dialog when reaches the dot. Right arrow dismissed the dialog when reaches the next line. ListBox appearance fixed. TAB key can insert the first matching entry. Autocorrect: "Autocorrect Keywords" has been renamed to "Autcorrect" (in the UI, and the config file, after this patch a make dev-install is needed). Keyword case correction is not just capitalizing the first letter ( eg. Elseif -> ElseIf ). Autoclose procedures: cursor is being placed inside the preocedure. Change-Id: Ie7e9ae96b49bd94562db83f96e1c4ad63ab3f3d6
2013-09-02GSOC work, renaming for consistencyGergo Mocsi
Menu enrty was renamed to IDE Options under View. SID_BASICIDE_CODECOMPLETE was renamed to SID_BASICIDE_IDEOPTIONS. CodeCompleteDlg was rename to BasicIDEOptionDlg. Ui file was renamed to basicideoptionsdialog.ui. Checkbox for extended types is now independent from code complete one. Change-Id: Id862df0ee56cdf2aa81e19a34099fe679ad5d311