summaryrefslogtreecommitdiff
path: root/include/canvas/base
AgeCommit message (Collapse)Author
2019-07-16tdf#42949 Fix IWYU warnings in include/Gabor Kelemen
Recheck directories in include/ between vcl and svx in the module hierarchy Found with bin/find-unneeded-includes Only removal proposals are dealt with here. New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Change-Id: Ieab6083ee2aae33baf32d05943b07ad2de6f9d7f Reviewed-on: https://gerrit.libreoffice.org/75170 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-29Fix typoAndrea Gelmini
Change-Id: I01d85bf006ddbf0b04f32c160043aba2d1d7ae4a Reviewed-on: https://gerrit.libreoffice.org/74899 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-29Fix typoAndrea Gelmini
Change-Id: I5f9f109f32621404034e23df431f0630e498240b Reviewed-on: https://gerrit.libreoffice.org/74878 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-29Fix typoAndrea Gelmini
Change-Id: I0ed3e793b7a06a250d0d72a3664191258f7c526f Reviewed-on: https://gerrit.libreoffice.org/74889 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-25tdf#42949 Fix IWYU warnings in include/canvas/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I93d516146ba44d83f84cb245e712ef6d14634a18 Reviewed-on: https://gerrit.libreoffice.org/68035 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-13loplugin singlevalfields improvementNoel Grandin
checking for casting to void* turns out to mask useful stuff, so remove that and just deal with a few extra false+ Change-Id: Id9700d7ceda90ba8fdb38aa870f13a7ca3acb668 Reviewed-on: https://gerrit.libreoffice.org/63145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14loplugin:unusedmethodsNoel Grandin
Change-Id: I7c780be3e2740fd9b03c39ebe16935d61caf4f7e Reviewed-on: https://gerrit.libreoffice.org/51257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-12More loplugin:cstylecast: canvasStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I1054389bc292544a1ba302509175c8718dbec747
2017-12-19remove unused typedefsNoel Grandin
Change-Id: I6fd7a9fed3a80c91a3766fceefd43c5db0aa5275 Reviewed-on: https://gerrit.libreoffice.org/46763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15Fix typosAndrea Gelmini
Change-Id: I78653129638b25f16e0816b6fff11e02100c85e7 Reviewed-on: https://gerrit.libreoffice.org/42321 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-05-18Revert "Fix typos"Stephan Bergmann
This reverts commit 26a67002fcb9381b54de6cae1aaa37120d49066a. "Iff" is not a typo, see 2a65bf32ec270484dcea4d22d3c93552dc0c24dd "Revert 'Typo: iff->if'".
2017-05-18Fix typosAndrea Gelmini
Only replaced "iff" with "if" Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581 Reviewed-on: https://gerrit.libreoffice.org/37782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-07revert OSL_ASSERT changesChris Sherlock
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert most of canvas codebase away from OSL_ASSERT to assertChris Sherlock
Change-Id: Ie6a5942dcac62a0bc3b589ff0b82922b313f88a8
2017-03-03Fix typosAndrea Gelmini
Change-Id: I5e3c9683741ddc66283008c20794be5c2b2bc53f Reviewed-on: https://gerrit.libreoffice.org/34804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, canvasStephan Bergmann
Change-Id: I70b52921291da551da7cc970e82f38b319f0ded8
2016-12-07tdf#88206 replace cppu::WeakImplHelper* miscJochen Nitschke
also edited two examples in canvas comments Change-Id: Iac82b462168f869f995c33bb2c639f3dbe09cbd5 Reviewed-on: https://gerrit.libreoffice.org/31715 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-11loplugin:expandablemethods in avmedia..canvasNoel Grandin
Change-Id: Ic230f1ef6b1dbe796ac7862a1a7e6a718f9e4e54 Reviewed-on: https://gerrit.libreoffice.org/30753 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14loplugin:constantparam in chart2..connectivityNoel Grandin
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d Reviewed-on: https://gerrit.libreoffice.org/28834 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: Ie7f382fb47463d9bc315dc767c1d0550145ec935
2016-04-13loplugin:passstuffbyref in canvasNoel Grandin
Change-Id: Idde288ab4bb7935e5da2a84190fd4b398961d358
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-28canvas: replace BOOST_CURRENT_FUNCTION with OSL_THIS_FUNCMichael Stahl
Change-Id: Ib90ad48866718f69160f57e7b0db3a7f342eb7be Reviewed-on: https://gerrit.libreoffice.org/21882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-28Revert "canvas: replace BOOST_CURRENT_FUNCTION with __func__"Michael Stahl
This reverts commit d01f7db4b5f51d1be8ba210625f4ad1ebf5c6e8f. Revert "tools: replace BOOST_CURRENT_FUNCTION with __func__" This reverts commit 10303054067258016fbbae018ea848f74adc4964. Surprisingly MSVC 2013 does not support __func__ - need 2015. Change-Id: I7084d7b79784b34a8f40fb986d10ffefbabae7fb
2016-01-28canvas: replace BOOST_CURRENT_FUNCTION with __func__Michael Stahl
Change-Id: I384472894288081423ae9467cc439b10d637f6e0
2015-11-04remove remaining boost/noncopyable includes from /includeNoel Grandin
Change-Id: I2dfed038d97f91df9e86828620df1a46dd158292 Reviewed-on: https://gerrit.libreoffice.org/19773 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-26fix includes that are not stand-aloneNorbert Thiebaud
includes should be able to be included on their own fix some of the ones that do not respect that rule. Change-Id: Id161224a1978461d3cea43252f232f18888a4f61 Reviewed-on: https://gerrit.libreoffice.org/19612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-10-20com::sun::star->css in include/canvasNoel Grandin
Change-Id: Iacf28606e41f0b1345864762612cbb009066bfeb Reviewed-on: https://gerrit.libreoffice.org/19458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-07-10do not include boost/utility.hppMichael Stahl
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-09canvas: remove boost::bind from headersMichael Stahl
Change-Id: Ieaa8a74d59ee9c74fafe823e01db4a349c49821e
2015-06-23Revert "Typo: iff->if"Julien Nabet
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-16Fix typosAndrea Gelmini
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-03-19loplugin:constantfunction: canvasNoel Grandin
Change-Id: I2fb2c4ec0e9467d7ced05b0e815e0d5bd2ba74c3
2015-02-12coverity#1269584 Uncaught exceptionCaolán McNamara
and coverity#1269578 Uncaught exception Change-Id: I68ef6ada3521cb12e17c5fe2ccecd67ade4ed40b
2015-02-12coverity#1269586 Uncaught exceptionCaolán McNamara
and coverity#1269581 Uncaught exception Change-Id: I48d08e1361ac9cf4c7d6040c247c753366dab4c5
2015-02-12coverity#1269589 Uncaught exceptionCaolán McNamara
and coverity#1269587 Uncaught exception Change-Id: Ic532ed2dfe38e33bcf2d9cedd0edee2cf3869f17
2015-02-12coverity#1269591 Uncaught exceptionCaolán McNamara
and coverity#1269585 Uncaught exception Change-Id: I1ec46b1c3996cf95744c15351d2c26a47d079c77
2015-02-12coverity#1269592 Uncaught exceptionCaolán McNamara
and coverity#1269577 Uncaught exception Change-Id: Ib8a61f8738d35cf5cb7cfa32d91d241f5c8d52d4
2015-02-12coverity#1269593 Uncaught exceptionCaolán McNamara
and coverity#1269580 Uncaught exception Change-Id: I366d43d2c5fd51927a6cd07101051e7cf9614974
2015-02-12coverity#1269594 Uncaught exceptionCaolán McNamara
and coverity#1269588 Uncaught exception Change-Id: I9e36c9636b7783530973272229dfb5bbfed556e5
2015-02-12coverity#1269598 Uncaught exceptionCaolán McNamara
and coverity#1269595 Uncaught exception Change-Id: Ia32be45c93769de92ad649eb765a343b659ddc3f
2015-02-12coverity#1269599 Uncaught exceptionCaolán McNamara
and coverity#1269590 Uncaught exception Change-Id: I03394a827e8f04842a8a94f839f0439407926150
2015-02-12coverity#1269582 Uncaught exceptionCaolán McNamara
and coverity#1269600 Uncaught exception coverity#1269575 Uncaught exception coverity#1269579 Uncaught exception Change-Id: If8d5650a9de574d92912a53a5b560ddb03e937f1