Age | Commit message (Collapse) | Author |
|
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
|
|
Change-Id: Id6392d105bbc01bb38f5615621f4d852a94e5df9
|
|
Change-Id: Ie202c072ab10783c4030af280023795e498d2523
|
|
The comphelper::LibreOfficeKit bits. Also will need additions to the
libsofficeapp bits in desktop and then to the StatusIndicator implementation
in framework.
Change-Id: I15c2505bbf6439c07d1956685d0a6d2a22aefc58
|
|
Bin pointless '// predeclarations' or '// forward declarations' comments. If
a programmer doesn't know what a forward declaration is, well, why read C++
source code?
Also bin some pointless '// end of namespace foo' comments after namespace
blocks just a handful of lines long, and some superfluous vertical whitespace.
Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
|
|
Change-Id: I29b3d3e4e9261200b9fedace0c43f4f09d3ac129
|
|
Change-Id: I6464c5d1a46fadac2510700101f3c8cc29dd7995
|
|
...since 70626249cd247d9acdad417b8eaf252bae22c059 "API CHANGE a11y unpublishing
and add/removeListener rename."
Change-Id: I89d81326d97712abcac94c3436a13905954c55cf
|
|
Change-Id: I7ef85887de6bf4196d6dc0c141281d310787252c
|
|
Change-Id: I85da73dadfdb62c09b5ef5f59a0cf05a0235eaf5
|
|
Change-Id: I2b9dafd2a34d055dcd8b8c4d894be30dc821d3be
|
|
Change-Id: Id3a12ef9d56c30719f483e610c8a8b08caf05def
|
|
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
|
|
...and css::uno::makeAny<css::uno::Any>() was never meant to be used. Introduce
css::uno::toAny for the (template-code) cases that shall return an Any for both
Any and non-Any inputs.
Change-Id: Ifa977d73f1da71b2fedde7e8140b19497c4a0257
|
|
Change-Id: I138919fff6e78ab8f751c5363ff73d6830f40222
|
|
Let's see where it actually will be needed. Sal is a "picky" place for
new API, even inside LIBO_INTERNAL_ONLY.
Change-Id: Ia0c5ee8cfc6ee526c5ad34d2f8aab0b14b5f805b
|
|
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
|
|
[API CHANGE]: extends the css.configuration.XReadWriteAccess in an incompatible
way, but that is unpublished, has been commented as "still unpublished and
unstable," and was specifically introduced for internal use by the simplified
configuration access, so should not affect 3rd party code.
Change-Id: I99ce045f5bd8c598e689d46fb0d3626dfaa6d0a0
|
|
Change-Id: I8dd0e5c8837fe1615aa9d5f546c2fd1c0985f044
|
|
Change-Id: I062024d4768374e319b6c67ed8c7abcc89f9d552
|
|
Change-Id: Ic70fe69f407e49604b056cdcb92aa3d656e1aeaf
|
|
Change-Id: Icdb619101a992a740c71545e669e138cb5dc63a6
|
|
Genius suggestion from Tor Lillqvist, write a clang plugin that finds
methods that can be static.
Change-Id: Ie6684cc95d088e8750b300a028b49f763da00345
|
|
Change-Id: If88a5b1171ef0b586861dd071820bc993c4cf06e
|
|
after my commit 48bb2913a7459edb17a5f62c2f6e6fbc4f1051e2
"convert SFX_FILTER_ constants to enum class"
Change-Id: I4e8bbbbe04bb5b9f2493281826fb156fee51cf40
|
|
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
|
|
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
|
|
Change-Id: I8486933d57d42992e66be7f17443320cfc2ad629
|
|
(cherry picked from commit ffdf0ed4cd76188e780eceee4333f90a00217f9d)
Change-Id: Ia452487c0c8c66a35c4b9fba225348bdef1a27f7
|
|
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
|
|
Change-Id: I33a740af4ccbcaa9ed4e3ffd79c4f8cda9b37dc4
|
|
Change-Id: I151957e415eff793e3d054050526b7d6892d28d4
|
|
Change-Id: I45081f5f80c4a571af0abebd23a4fed6623498a0
|
|
Change-Id: I8b3b2b839c37b584e1a4036e49af7ff2737ea7f6
|
|
Change-Id: Ifa87783f68b0fab98f8a0f7cd6ed867202b4532f
|
|
Change-Id: I8371b942d915f777a29ca01cd0aed674db0ca853
|
|
Change-Id: I0f0ce96ee8209f711739952422d642a012252d1f
|
|
Change-Id: I44b208a2c5c5bf73ac025462c9f7bd499ed0a49b
|
|
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
|
|
Change-Id: I6a8af82e8612196f20143f4997eb95c80a2ca13d
|
|
Change-Id: I0aeba0c65b19c1107f617ed0af0028cced9bd434
|
|
Deprecated comphelper/sequenceasvector.hxx.
Rewritten code using it. Using instead the functions containerToSequence and
sequenceToContainer, found in include/comphelper/sequence.hxx.
One class that inherits from it (in framework/inc/stdtypes.h), and
the code using that has been left.
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Conflicts:
writerfilter/source/dmapper/DomainMapper.cxx
writerfilter/source/dmapper/TblStylePrHandler.hxx
writerfilter/source/dmapper/WrapPolygonHandler.hxx
Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
|
|
and boost:make_shared->std::make_shared
Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
|
|
Change-Id: I9286332d74c234007556a7f1d5193197ce547652
|
|
...in some places where it is obvious that it does not hurt that for an empty
vector the obtained pointer is not necessarily a nullptr.
Change-Id: Id5d66b1559ca8b8955d379bcdbfae6986ef46a51
|
|
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
The Itanium C++ ABI mandates that for a unique (complete) C++ type a single
unique symbol for the type's RTTI name is used across a process's dynamic
objects (so type equivalence can be determined via pointer comparison on the
RTTI names).
GCC nowadays deviates from that, using strcmp to determine equivalence, so it is
resilient to RTTI names being bound locally within dynamic objects (which has
performance benefits, but also makes it impossible to have unrelated types that
happen to have the same name "encapsulated" in individual dynamic objects---
whether or not that would violate the ODR would be open to interpretation of how
dynamic objects fit into the C++ Standard).
LLVM sticks to the Itanium ABI, which becomes notable in at least two places:
For one, libc++abi's __dynamic_cast uses strict checking. It still has a
_LIBCXX_DYNAMIC_FALLBACK for now that additionally uses strcmp checking and
syslogs visibility violations. Mac OS X uses libc++abi with
_LIBCXX_DYNAMIC_FALLBACK enabled, and running LO routinely logs dynamic_cast
errors to the Console there.
For another, RTTI-based UBSan checks unconditionally only use strict checking
(cf. isDerivedFromAtOffset in lib/ubsan/ubsan_type_hash.cc). This causes false
positives from Clang -fsanitize=function and -fsanitize=vptr even on Linux not
using libc++abi.
Therefore, introduce SAL_DLLPUBLIC_RTTI to mark types for which RTTI needs to
have default visibility under the Itanium/LLVM semantics. There is
unfortunately no way to mark only the (implicitly generated) RTTI symbols for
default visibility, but at least with the cases where SAL_DLLPUBLIC_RTTI is used
for now that is no real problem---any class type marked SAL_DLLPUBLIC_RTTI only
has inline (covered by -fvisibility-inlines-hidden) or undefined pure virtual
functions. It appears that even the vtables of those classes remain hidden, at
least with Mach-O on Mac OS X. (That also means there is no need for a
SAL_DLLPRIVATE_RTTI marker analoguous to the---also superfluous in retrospect---
CPPU_GCC_DLLPRIVATE one.)
Nevertheless, the number of exported symbols of course increases when
SAL_DLLPUBLIC_RTTI is "active." For a full-blown --enable-dbgutil build on Mac
OS X,
find instdir/LibreOffice.app/Contents -name \*.dylib\* -exec nm -gU {} \; \
wc -l
increased from 125541 to 139239. For Linux, an option might be to "activate"
SAL_DLLPUBLIC_RTTI only for __clang__ plus !ENABLE_RUNTIME_OPTIMIZATIONS.
The set of types marked SAL_DLLPUBLIC_RTTI with this patch (wholesale cppumaker-
generated UNO enum, struct, and interface types; plus some IEmbeddedHelper and
IUndoManager) is chosen so that a full "make check" on Mac OS X no longer
syslogs any dynamic_cast errors to the Console.
Change-Id: I42fa6ec01c2503ec24bcd9c0518abb112afa3235
|
|
Change-Id: Ia47c0bc3539ddf8f925cd053a2431c742c46d337
|
|
Change-Id: I6d3ffb195a7c9a3c44744d296fb9d9eca00115cd
|