summaryrefslogtreecommitdiff
path: root/include/cppuhelper
AgeCommit message (Collapse)Author
2024-01-22Revert "tdf#143148: Use pragma once instead of include guards"Stephan Bergmann
This reverts commit eb9e4e7a6c7d11698a64489e22974574daabe823, see the note in the original description of <https://bugs.documentfoundation.org/show_bug.cgi?id=143148#c0> "Use pragma once instead of include guards (Episode 2: Endgame)": "There are some source files containing include guards that are meant to also be processed by compilers other than LO's build baseline compilers: All URE include files [...] For those source files, it is probably better to conservatively stick with include guards than to replace them with #pragma once." Change-Id: I315aa935db8617fadd2fb807b6fa7da05f44359d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162288 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-01-21tdf#143148: Use pragma once instead of include guardsseturaj
Change-Id: Ia8a203d1e6a7446f43cc68d883e1ee4cd0a5814f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162341 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-09-08inline SC_QUERYINTERFACE macrosNoel Grandin
which means we need a few more cppu::queryInterface variants Change-Id: I5cf7805ab9576919bfd66a3b239917e48a7f8f61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-29Introduce cppu::getXWeak and cppu::OWeakObject::getXWeakMike Kaganski
To avoid explicit static casts when XWeak or XInterface is needed Change-Id: I0496a5b8dcd48743bceeef9f90904811acd556cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150807 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-24Drop redundant -Wnon-virtual-dtorStephan Bergmann
Inspired by <https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607102.html> "[PATCH] doc: -Wdelete-non-virtual-dtor supersedes -Wnon-virtual-dtor", drop explicitly enabling -Wnon-virtual-dtor in favor of -Wdelete-non-virtual-dtor, which is already enabled by -Wall. (-Wdelete-non-virtual-dtor first appeared in Clang 3.0, <https://github.com/llvm/llvm-project/commit/8bd428574c717e68a8274739d2ba0f6dc16fd0fb> "Add new warning that warns when invoking 'delete' on a polymorphic, non-final, class without a virtual destructor", and GCC 4.7, <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=014ab419efc12a59efebd2720d79e1c055675c85> "invoke.texi: Document -Wdelete-non-virtual-dtor. [...]") Dropping the explicit setting of -Wnon-virtual-dtor (and nowhere setting it implicitly via -Weffc++) means we can get rid of lots of places that either set -Wno-non-virtual-dtor or use some pragma to ignore -Wnon-virtual-dtor. (In various places across extensions/source/activex/ and winaccessibility/, the commits f26996bd3398afa789a5491968244563ccf70908 "Silence -Werror,-Wnon-virtual-dtor in generated so_activex.h (clang-cl)" and c6086ca6535692496fbd718d174d8eb5a5dea7c7 "Silence -Werror,-Wnon-virtual-dtor in generated UAccCOM.h (clang-cl)" had singled out some includes to wrap them in pragmas. Now that those pragmas are gone again, move those includes back to where they had been prior to being singled out. And the -Wno-non-virtual-dtor in external/firebird/macos-arm64.patch.0 appeared first in ccd0e5f445d4a7d0e7aca6c23c02c61bf14510b2 "Make firebird build for macOS on arm64", which, though it doesn't state it explicitly, apparently created that patch's builds/posix/prefix.darwin_arm64 as a copy of firebird's already existing builds/posix/prefix.* files, which routinely include that warning option too, so keep it there too even if it is probably irrelevant throughout.) Change-Id: I7e4fa9f2c07e267b2ed15607905027f6b78142f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143182 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-17Silence -Werror,-Wdeprecated-copy-with-user-provided-copy (clang-cl)Stephan Bergmann
> In file included from cppuhelper/source/access_control.cxx:21: > include\cppuhelper/access_control.hxx(58,5): error: definition of implicit copy assignment operator for 'AccessControl' is deprecated because it has a user-provided copy constructor [-Werror,-Wdeprecated-copy-with-user-provided-copy] > AccessControl( ::cppu::AccessControl const & ac ); > ^ > include\cppuhelper/access_control.hxx(37,44): note: in implicit copy assignment operator for 'cppu::AccessControl' first required here > class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC AccessControl > ^ > include\cppuhelper/access_control.hxx(37,23): note: due to 'AccessControl' being dllexported > class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC AccessControl > ^ > include\cppuhelper/cppuhelperdllapi.h(30,30): note: expanded from macro 'CPPUHELPER_DLLPUBLIC' > #define CPPUHELPER_DLLPUBLIC SAL_DLLPUBLIC_EXPORT > ^ > include\sal/types.h(208,47): note: expanded from macro 'SAL_DLLPUBLIC_EXPORT' > # define SAL_DLLPUBLIC_EXPORT __declspec(dllexport) Change-Id: I89b534b33c29fdc2d458087e1f3c2f4c958aa86c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140096 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-22Add XWeak constructor and operator= to uno::WeakReferenceNoel Grandin
which is faster since we can skip the UNO_QUERY. Change-Id: Id95ad9f3568213e974bd13659d92d4ea94dbfbd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-15remove not-so-useful move operator from uno::WeakReferenceNoel Grandin
I messed up when I added commit a0ebc6f898992dbc0da9f252911da867dfdfd741 Date: Sat Nov 9 08:47:48 2019 +0200 missing move operator= which is not a real move operator because it has the wrong type in it's parameter list, and doesn't actually do anything useful as a consequence. Change-Id: I7bd3d41d6ed98deecd143b1e1bb64870530dab03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-15LIBO_INTERNAL_ONLY stuff does not need to be SAL_CALLNoel Grandin
Change-Id: I9d7ccaab19ad20509601642745e3fdaea50304ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129818 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-01-15Let loplugin:nullptr look into template instantiationsStephan Bergmann
It missed some occurrences of 0 when only looking into uninstantiated template code, as Clang doesn't model them with an ImplicitCastExpr, even if the target is known to be a (dependent) pointer type. Looking into all template instantiations of course carries the risk that a given use of 0 is meant to be interpreted as a pointer in some and as an integer in other instantiations. But the only case where that happened in the current code base is RegistryValueList::getElement (include/registry/registry.hxx), where {} is arguably a better choice anyway. (And which would presumably also hold for any future such cases.) Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-10Fix typoAndrea Gelmini
Change-Id: I04ded03b3dd16627959a6451696a2e3392c17f36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128215 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-09Add TODO in include/cppuhelper about compbase.hxx and compbase<N>.hxxJulien Nabet
Change-Id: If046e624d6fe5a711aec803652800a4a3830ec74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128181 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-04Drop MSVC special-casing for OWeakObject ctorMike Kaganski
It was introduced in commit 0c38ca4412531adafdb9cbac9dfa7f6f8e0d9882 author Daniel Boelzle <dbo@openoffice.org> date Mon Nov 18 08:59:15 2002 +0000 #104560# outlining of msvc mapfile symbols cppuhelper/source/msvc_win32_intel.map was dropped in commit b222aa8fff63c803781703e72366ca203f3e6a76 author Matúš Kukan <matus.kukan@gmail.com> date Tue Aug 23 15:03:09 2011 +0200 cppuhelper: convert to gbuild The symbol '??0OWeakObject@cppu@@QEAA@XZ' is still exported from cppuhelper3MSC.dll (checked using dumpbin, that number and names of exported symbols are the same), thanks to the CPPUHELPER_DLLPUBLIC macro at the class, that expands to __declspec(dllexport) [1], [2]. Hence, this patch is expected to not cause an ABI change. [1] https://docs.microsoft.com/en-us/cpp/cpp/dllexport-dllimport [2] https://docs.microsoft.com/en-us/cpp/build/exporting-from-a-dll-using-declspec-dllexport Change-Id: I895c350970f0e4e0adc1ba90f60925f8d4ba3941 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127471 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-22loplugin:flatten in filter..includeNoel Grandin
Change-Id: I74c1ea8b9b490eaa9508a885758224063e39051b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127235 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-17Remove empty docpp doxygen comments around namespacesMiklos Vajna
I assume this was originally added to work around some broken doc generator, but we don't enforce comments for namespaces today, so this is no longer needed. Change-Id: Ia2311658516be84b26ae69e09362af560d793a7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126963 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 3 [API CHANGE]Mike Kaganski
- Replace all uses of OImplementationId in core with UnoIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> OImplementationId uses broken double checked locking; additionally, it uses it at the first call to getImplementationId, not when the object is constructed. This implementation can't be changed, cince it's part of published API; it can't rely on C++11, which would be required for use of thread-safe statics and move the initialization to ctor. The class has obsolete _bUseEthernetAddress member, that is unused and ignored since 4e9fa7e339a1cd6cb2fec643715991bcf5057cec. No need to implement it when replacing its uses to UnoIdInit. The deprecation is the API CHANGE. No published API is introduced to replace it; 3rd-party code should seek alternative solutions, or just keep using the deprecated functionality. TODO (in separate commits): - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: I8b6e684e5389bc0d5bb3b7f21f72a4c8f684107d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122077 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-19Remaining loplugin:noexcept in URE include filesStephan Bergmann
This file is only included from CppunitTest_odk_checkapi. As that is compiled with $(gb_CXX03FLAGS), loplugin:noexcept hasn't caught these on Linux or macOS (see the comment in Noexcept::run, compilerplugins/clang/noexcept.cxx). And while the plugin could have caught them with clang-cl on Windows (cf. 95d109fd5f254f694684c0effe447f133872f40d "Document that setting gb_CXX03FLAGS for clang-cl doesn't work", all the instances are in macro definitions that are never expanded by any LO code. Change-Id: Ia3f3a0cd89df15bee517cd3a91a2a12a15a7a279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115794 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-19loplugin:noexcept (clang-cl)Stephan Bergmann
Change-Id: Ife669f959358992b547b408ab5d1f6bf1c1d14bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115744 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-02throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-19Fix typo in commentStephan Bergmann
Change-Id: I6b670bca6c6f374dec97a27134fc24b40cb45d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112741 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-02tdf#130978 Added comment to all published APImsrijita18
Change-Id: I744788bde9778f85ccd9d7667e19d16842900a29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110248 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-21tdf#123936 Formatting files in module include with clang-formatPhilipp Hofer
Change-Id: I0507dd797cd5a35e0ae14f4b69ee4e172d08a71a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105681 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-09-12Replace remaining uses of sal_CharJulien Nabet
+ remove sal_Char check on compilerplugins Change-Id: I0f7da14e620f0c3d031d038aa8345ba4080fb3e9 Change-Id: Ia6dba4f27b47bc9e0c89159182ad80a5aee17166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-17Use std::vector in OInterfaceContainerHelper instead of SequenceNoel Grandin
instead of fighting the fact that Sequence is intended to be immutable getSequence() will become a little slower, but since getSequence() is called 5k times during 'make check', while add/remove are called 3M times, I think it's safe to say mutation is dominant. Change-Id: I23d127c93c589050d6c06c0da47871e1ebe7b52d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-11fix move operatorNoel Grandin
introduced in commit a0ebc6f898992dbc0da9f252911da867dfdfd741 Date: Sat Nov 9 08:47:48 2019 +0200 missing move operator= Change-Id: I0607ad1afbcb1f2a86d1c7e0736e2549a5562b64 Reviewed-on: https://gerrit.libreoffice.org/82441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-09missing move operator=Noel Grandin
Change-Id: Id184cbc88f41eda78c58898693285e185298a1e4 Reviewed-on: https://gerrit.libreoffice.org/82343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-30new loplugin:noexceptmoveNoel Grandin
idea from mike kaganski look for places where we can mark move operators as noexcept, which makes some STL operations more efficient Change-Id: Id732b89d1fcadd5ceb0ea2b9d159fed06136330f Reviewed-on: https://gerrit.libreoffice.org/78251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-09Fix typoAndrea Gelmini
"Inherting" Change-Id: Ib9b1fcfd9ef585149de5018ce650707c71d412c8 Reviewed-on: https://gerrit.libreoffice.org/77127 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-03Fix typoAndrea Gelmini
Change-Id: Ie5314891808a406dbccd970086726068524e1412 Reviewed-on: https://gerrit.libreoffice.org/75053 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-03Fix typoAndrea Gelmini
Change-Id: I0f1ea1046b5d160fbf23cf630eb0ec8b8bfce57e Reviewed-on: https://gerrit.libreoffice.org/75054 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-03Fix typoAndrea Gelmini
Change-Id: I54e2f1e63ed33121537e77e9a172575509d29adc Reviewed-on: https://gerrit.libreoffice.org/75021 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini
Change-Id: I4cfc98ab3be0c789274978ec6b26f981ad627494 Reviewed-on: https://gerrit.libreoffice.org/73634 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-10an uno -> a unoCaolán McNamara
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-08Fix @param documentation sectionsJulien Nabet
include/osl/thread.h:198: warning: argument 'name' from the argument list of osl_setThreadName has muliple @param documentation sections include/cppuhelper/propshlp.hxx:329: warning: argument 'bIgnoreRuntimeExceptionsWhileFiring' from the argument list of cppu::IEventNotificationHook::fireEvents has muliple @param documentation sections Change-Id: Ic1a2a7239596ec62c0d60c14480ea4a115eaaaa1 Reviewed-on: https://gerrit.libreoffice.org/68944 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-03Make additional OTypeCollection::getTypes overload LIBO_INTERNAL_ONLYStephan Bergmann
(added recently with d559c28e9e65f3be415ec2e36ee90aa147e65b84 "expand out IMPL_XTYPEPROVIDER_START macro"), for extra compatibility safety. (At least MSVC exports non-inline versions of such CPPUHELPER_DLLPUBLIC inline functions from the cppuhelper DLL.) The original getTypes (added back now with <https://gerrit.libreoffice.org/#/c/68549/> "revert ABI change from 'expand out IMPL_XTYPEPROVIDER_START macro'") had been a non-const member function ever since at least b525a3115f54576017a576ff842dede5e2e3545d "initial import", presumably by accident. (Whether or not to return a reference is an orthogonal issue. With the newly added overload being LIBO_INTERNAL_ONLY, it is presumably fine to have it return a reference for now and see whether that causes any issues with lifetimes of temporary OTypeCollection instances.) Change-Id: If6abcf53b46b972204598774fed7cdd34d78440b Reviewed-on: https://gerrit.libreoffice.org/68637 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-03revert ABI change from "expand out IMPL_XTYPEPROVIDER_START macro"Noel Grandin
in commit d559c28e9e65f3be415ec2e36ee90aa147e65b84, instead add a separate const method Change-Id: If156dd07e77da2efe72c92198960311399151a9d Reviewed-on: https://gerrit.libreoffice.org/68549 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-01expand out IMPL_XTYPEPROVIDER_START macroNoel Grandin
and make cppu::OTypeCollection::getTypes be const Change-Id: I2dd1c0bacb2e1872f8b7a0da72f73013b04bef3c Reviewed-on: https://gerrit.libreoffice.org/68536 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16Fix typosAndrea Gelmini
Change-Id: I63b3cdae2dfb4442d10430d9041145f892b31967 Reviewed-on: https://gerrit.libreoffice.org/63480 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-09-10tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-27cppuhelper: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc. (For LIBO_INTERNAL_ONLY.) Change-Id: I9da48559b083bdec9b1b4014634f6f3bfb1c3de3 Reviewed-on: https://gerrit.libreoffice.org/58107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-27cppuhelper: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by removing explicitly user-provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non-deleted in the future Change-Id: I2b7b6b8baa872addfb2adb0d551d78de1e31c896 Reviewed-on: https://gerrit.libreoffice.org/58106 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-29Fix indent in interfacecontainer.hxxJulien Nabet
Change-Id: I85ab503b52e9d5fa20fcc20b136c92ce5cb7b6cf Reviewed-on: https://gerrit.libreoffice.org/52078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01cppuhelper: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Ib097ea1764d275a3123d0dccf05d52315b4858a1 Reviewed-on: https://gerrit.libreoffice.org/48971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-12More loplugin:cstylecast: cppuhelperStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I3966d302241a52014aaad41f72924a2095ea6621
2017-10-23loplugin:includeform: UNO API include filesStephan Bergmann
Change these back to consistently use the "..." form to include other UNO API include files, for the benefit of external users of this API. Change-Id: I9c9188e895eb3495e20a71ad44abfa2f6061fa94
2017-09-27cppuhelper_detail_findSofficePath: use Unicode on WindowsMike Kaganski
On Windows, UTF-8 is never current locale encoding; so using 8-bit strings will always fail for paths containing characters outside of current codepage. Also fix leaks caused by failing to release its result: previously it could return either result of getenv (that shouldn't get freed), or an allocated string, but never got freed; now the result is always allocated and properly freed. Change-Id: I8b255dea20040eec0572de2b34280749fe8f071c Reviewed-on: https://gerrit.libreoffice.org/42743 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-02loplugin:casttovoid: cppuhelperStephan Bergmann
Change-Id: I70a8f00b5ec9d100185d2865bcf54ce96c93adc3
2017-06-06add COVERITY_NOEXCEPT_FALSECaolán McNamara
to markup dtors that coverity warns might throw exceptions which won't throw in practice, or where std::terminate is an acceptable response if they do Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4 Reviewed-on: https://gerrit.libreoffice.org/38318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-05Fix typosAndrea Gelmini
Change-Id: I9eb05432732a04e816946fbb13001df100a31f73 Reviewed-on: https://gerrit.libreoffice.org/38395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-05spelling instanciate -> instantiateNoel Grandin
Change-Id: Ic1393da64328c0dc7e2860334b204139bf537d81 Reviewed-on: https://gerrit.libreoffice.org/38401 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>