summaryrefslogtreecommitdiff
path: root/include/cppuhelper
AgeCommit message (Collapse)Author
2018-09-10tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-27cppuhelper: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc. (For LIBO_INTERNAL_ONLY.) Change-Id: I9da48559b083bdec9b1b4014634f6f3bfb1c3de3 Reviewed-on: https://gerrit.libreoffice.org/58107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-27cppuhelper: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by removing explicitly user-provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non-deleted in the future Change-Id: I2b7b6b8baa872addfb2adb0d551d78de1e31c896 Reviewed-on: https://gerrit.libreoffice.org/58106 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-29Fix indent in interfacecontainer.hxxJulien Nabet
Change-Id: I85ab503b52e9d5fa20fcc20b136c92ce5cb7b6cf Reviewed-on: https://gerrit.libreoffice.org/52078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01cppuhelper: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Ib097ea1764d275a3123d0dccf05d52315b4858a1 Reviewed-on: https://gerrit.libreoffice.org/48971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-12More loplugin:cstylecast: cppuhelperStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I3966d302241a52014aaad41f72924a2095ea6621
2017-10-23loplugin:includeform: UNO API include filesStephan Bergmann
Change these back to consistently use the "..." form to include other UNO API include files, for the benefit of external users of this API. Change-Id: I9c9188e895eb3495e20a71ad44abfa2f6061fa94
2017-09-27cppuhelper_detail_findSofficePath: use Unicode on WindowsMike Kaganski
On Windows, UTF-8 is never current locale encoding; so using 8-bit strings will always fail for paths containing characters outside of current codepage. Also fix leaks caused by failing to release its result: previously it could return either result of getenv (that shouldn't get freed), or an allocated string, but never got freed; now the result is always allocated and properly freed. Change-Id: I8b255dea20040eec0572de2b34280749fe8f071c Reviewed-on: https://gerrit.libreoffice.org/42743 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-02loplugin:casttovoid: cppuhelperStephan Bergmann
Change-Id: I70a8f00b5ec9d100185d2865bcf54ce96c93adc3
2017-06-06add COVERITY_NOEXCEPT_FALSECaolán McNamara
to markup dtors that coverity warns might throw exceptions which won't throw in practice, or where std::terminate is an acceptable response if they do Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4 Reviewed-on: https://gerrit.libreoffice.org/38318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-05Fix typosAndrea Gelmini
Change-Id: I9eb05432732a04e816946fbb13001df100a31f73 Reviewed-on: https://gerrit.libreoffice.org/38395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-05spelling instanciate -> instantiateNoel Grandin
Change-Id: Ic1393da64328c0dc7e2860334b204139bf537d81 Reviewed-on: https://gerrit.libreoffice.org/38401 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-18Revert "Fix typos"Stephan Bergmann
This reverts commit 26a67002fcb9381b54de6cae1aaa37120d49066a. "Iff" is not a typo, see 2a65bf32ec270484dcea4d22d3c93552dc0c24dd "Revert 'Typo: iff->if'".
2017-05-18Fix typosAndrea Gelmini
Only replaced "iff" with "if" Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581 Reviewed-on: https://gerrit.libreoffice.org/37782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03Fix typosAndrea Gelmini
Change-Id: I5e3c9683741ddc66283008c20794be5c2b2bc53f Reviewed-on: https://gerrit.libreoffice.org/34804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-10Remove MinGW supportStephan Bergmann
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-31a whole bunch of SAL_WARN_UNUSEDNoel Grandin
Change-Id: Iea28debc7d3abc58cca21bd3856cb65b321dc1e6 Reviewed-on: https://gerrit.libreoffice.org/33693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30tdf#44502 cppuhelper: fix doxygen warningMichael Stahl
Change-Id: If1bb3d7cc37449fc6be5467dc5d4380083d66211
2017-01-27Remove dynamic exception specifications from !LIBO_INTERNAL_ONLYStephan Bergmann
...only odk/examples/ remains to be clean up Change-Id: I875a1e8d6750b6b007bd75126b8010273e1f32d5
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, cppuhelperStephan Bergmann
Change-Id: I20b40d0d465cfe130e03f7a8f8da6f4dab404848
2017-01-05Don't exclude a var from loplugin:salbool merely because of use in >>=Stephan Bergmann
Change-Id: I1b8a3dfa1dc6b351ab0903a74eae19dfa6d0888d
2017-01-02Prefer prefix ++/-- operators for non-primitive types.Muhammet Kara
Change-Id: I9be657cd0b5ed964db8db2ca28fd2874ae5406aa cppcheck: performance Reviewed-on: https://gerrit.libreoffice.org/32431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-10-21Remove convertPropertyValue overload for OUStringStephan Bergmann
...it never did anything different than the generic template overload. Strictly speaking, removing that inline function overload could be considered an API change, but it shouldn't cause any issues in practice even when recompiling all code against the new include files. Change-Id: Icb0942f56ee0888f09d3478f34d568d44651c838
2016-10-21Some clean-upStephan Bergmann
Change-Id: I6a46af4e6ba42f1c104662e7a035b7ecfc404752 Reviewed-on: https://gerrit.libreoffice.org/30111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-20Revert "Some clean-up"Stephan Bergmann
This reverts commit 0b04e8f80ea1b0ae0603d79b2c80d669f16375d3, shuffling the code around started to cause some builds to complain with -Werror=maybe-uninitialized in places where they did not before. Needs a better fix.
2016-10-20Some clean-upStephan Bergmann
Change-Id: Ifd36b0f364dd1d5d38095d32409f8587b0662ace
2016-09-23TDE fix some clang plugin based warningsJan-Marek Glogowski
Change-Id: I3b44038e8a889e4c13126fd8d721e53e71ea9ec6
2016-09-20Mark new exported function as SAL_CALLStephan Bergmann
...for consistency with existing exported functions Change-Id: Ib513dc8ce4dbf4e614f5453f2bbd32dcac4b8666
2016-09-19cid#1371142: Move semantics for css::uno::WeakReferenceHelperStephan Bergmann
Change-Id: I442b2d8061bd7d50cbf832b345a7a63461e26224
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-07-11loplugin:salbool: Better heuristic to determine code shared between C and C++Stephan Bergmann
Change-Id: I09c9c57d5adeb665cc2508fad9727085a3289bfb
2016-06-20Clean up uses of Any::getValue() in cppuhelperStephan Bergmann
Change-Id: Ibe25c23a273db957905af972dcae64e3a0d3be8a
2016-06-20improper use of this/that just bugs meNoel Grandin
Change-Id: Ie05062cfe384971f5c358769ab16461a76f911cf
2016-06-17cppuhelper: WeakReference isn't thread-safeMichael Stahl
... but its documentation claims that it is, which is partially misleading, so fix both the documentation and the data race in WeakReferenceHelper::clear(). This actually crashed in clear() in the multi-threaded ZipPackage code on exporting the bugdoc from tdf#94212, presumably because clear() races against OWeakRefListener::dispose(). Change-Id: I85665c11b8157e90d15e8263758e24e66efeb86c
2016-06-08remove "object is disposed" warning in OBroadcastHelperVar::removeListenerNoel Grandin
doesn't add anything of value. Change-Id: Ie2dea7c43570640284771c992d0072ab61de425e Reviewed-on: https://gerrit.libreoffice.org/25871 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18add some spaces to make it easier to readMarkus Mohrhard
Change-Id: I2eb1c74bc0d91d3a12a66989b696fccbf1d2825e Reviewed-on: https://gerrit.libreoffice.org/25117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-04Add covertPropertyValue bool overloadStephan Bergmann
...as the behavior of the generic covertPropertyValue template instantiated for bool would be quite different from the behavior of the convertPropertyValue sal_Bool overload, leading to potential surprises. (Though it seems there were no uses yet of covertPropertyValue with bool, only with sal_Bool.) Change-Id: I107a0608fc4271e95464a7f9bdc340a9e6dc1336
2016-05-04Declaration of sal_Bool overload of convertPropertyValue had been missingStephan Bergmann
...ever since b525a3115f54576017a576ff842dede5e2e3545d "initial import" Change-Id: I0824b673d222b6376ca199ad37f916ccaf80aa58
2016-05-04Remove leftover declaration of convertPropertyValue overloadStephan Bergmann
...that had originally been introduced with a comment // This template is needed at least for msci4 compiler in b525a3115f54576017a576ff842dede5e2e3545d "initial import", and whose corresponding definition had been removed in 6231a9b4e926d5dc213f94ddf35b14bab411d77d "visual studio version 4 is long gone" Change-Id: I0cf4913a2c2c4701d41cf24d2f89c1de0bd86323
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: If965f73934c182a1c96d9fdca6f395c256f6b259
2016-03-04Silence -Werror,-Wnon-virtual-dtor (clang-cl)Stephan Bergmann
Change-Id: Icac0f029461c886ebb03aedcd54189116b66d8a3
2016-02-26Use an XInitialization-based channel to request service mgr pre-initStephan Bergmann
...instead of private cppu::preInitBootstrap function Change-Id: Id0e6fcf721b697c993e5acffaf7836452cfa9750 Reviewed-on: https://gerrit.libreoffice.org/22699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-02-15Re-work cppu::preInitBootstrap()Henry Castro
In the preinit stage, the preInitBootstrap is called to load implementations for each service registered by the service manager. All service requests are: initial Component Context and the process service factory is set. However, some services require that VCL is properly initialized. Change-Id: Ib116e3da172b860f2df4d672f6181b5de0b7e6b2
2016-02-15Introduce lok_preinit() to preload all registered UNO implementationsHenry Castro
Intended to be used from an application like the LibreOffice On-Line server so that it can be called in a process that then will call fork() several times, and much space consuming data will end up being shared. Change-Id: I65341c57d00308d246ec90deab8050b2c4bb3e61
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13cppuhelper: remove invalid doxygen markupChris Sherlock
Change-Id: I97e8757c1f5006bb1320b4a65da34745cc563e58 Reviewed-on: https://gerrit.libreoffice.org/21456 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-24add SAL_WARN_UNUSED to css::uno::WeakReference and SvCompatWeakRefNoel Grandin
Change-Id: Idb784d398ed22f2291f1beaffb82f68642d68bcd
generated by cgit (git 2.34.1) at 2025-01-06 09:55:28 +0000