summaryrefslogtreecommitdiff
path: root/include/editeng
AgeCommit message (Collapse)Author
2018-01-12More loplugin:cstylecast: editengStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I09a4d688e6f3c1ecbe05a7d27ebd955e8ba1eb65
2018-01-09RES_CHRATR_PROPORTIONALFONTSIZE and RES_CHRATR_NOLINEBREAK unusedNoel Grandin
but leave placeholders behind to avoid having to renumber items. Change-Id: Ifa1a9dc790a68d7486da7504c11b3c203a5fd3db Reviewed-on: https://gerrit.libreoffice.org/47580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-06remove unused definesNoel Grandin
In particular, the STR_SVT_MIMETYPE defines are dead since commit 1b694dad643334ec1bab3f823dcd68f44a05ebe3 Date: Thu Aug 24 22:14:27 2017 +0200 loplugin:unusedmethods Change-Id: I641ec0a14efedc55c9d6a4de4a28784c273602e9 Reviewed-on: https://gerrit.libreoffice.org/47464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-05remove dead eeitemid.hxxNoel Grandin
and inline the couple of constants still in use from it Change-Id: Icb9f5690b5649140bc0503a8917e6a0f764e3d9c Reviewed-on: https://gerrit.libreoffice.org/47404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04de-duplicate some defines in hrc filesNoel Grandin
and rename SID_INSERTSYMBOL -> SID_INSERTSPECIAL in starmath to make it unique Change-Id: I0eeefe25e0e9374871c73793a31cb3e6cc445f73 Reviewed-on: https://gerrit.libreoffice.org/47369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-03loplugin:passstuffbyref more return improvementsNoel Grandin
slightly less restrictive check when calling functions Change-Id: I35e268ac611797b1daa83777cda02288a635aa32 Reviewed-on: https://gerrit.libreoffice.org/47259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-28loplugin:passstuffbyref improved return in editengNoel Grandin
Change-Id: I6aba5b79e588f28529052ddb30ad51807d73cfe5 Reviewed-on: https://gerrit.libreoffice.org/47120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-25various coverity exception warningsCaolán McNamara
Change-Id: I7b3588ad42e17f2f363b6a247e318f23c95e578e Reviewed-on: https://gerrit.libreoffice.org/46961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-22lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky
This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19loplugin:unusedenumconstantsNoel Grandin
Change-Id: I9dc4b369872a7c6c076ae9be1dcdf2f8385af8a7 Reviewed-on: https://gerrit.libreoffice.org/46684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18convert EEHorizontalTextDirection to scoped enumNoel Grandin
Change-Id: Icb7298742ae80fa17d5e6f6a3a09a6bb30892b6d Reviewed-on: https://gerrit.libreoffice.org/46590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16convert EETextFormat to scoped enumNoel Grandin
and drop unused BIN constant Change-Id: I4ecda96f39147f7e9bceb11ecdb4f0ffe42d2053 Reviewed-on: https://gerrit.libreoffice.org/46589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-14No need to keep these whitelisted functions decorated with SAL_CALLStephan Bergmann
The only effect SAL_CALL effectively has on LO-internal code is to change non- static member functions from __thiscall to __cdecl in MSVC (where all other functions are __cdecl by default, anyway). (For 3rd-party code, it could be argued that SAL_CALL is useful on function declarations in the URE stable interface other than non-static member functions, too, in case 3rd-party code uses a compiler switch to change the default calling convention to something other than __cdecl. But loplugin:salcall exempts the URE stable interface, anyway.) One could argue that SAL_CALL, even if today it effectively only affects non- static member functions in MSVC, could be extended in the future to affect more functions on more platforms. However, the current code would already not support that. For example, 3af500580b1c82eabd60335c9ebc458a3f68850c "loplugin:salcall fix functions" changed FrameControl_createInstance in UnoControls/source/base/registercontrols.cxx to no longer be SAL_CALL, even though its address (in ctl_component_getFacrory, in the same file) is passed to cppuhelper::createSingleFactory as an argument of type cppu::ComponentInstantiation, which is a pointer to SAL_CALL function. Change-Id: I3acbf7314a3d7868ed70e35bb5c47bc11a0b7ff6 Reviewed-on: https://gerrit.libreoffice.org/46436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05loplugin:countusersofdefaultparams in editeng..packageNoel Grandin
Change-Id: I4c20235a04d9ab5ea5edbb6b1b2413677b18a305 Reviewed-on: https://gerrit.libreoffice.org/45795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-30loplugin:unusedmethodsNoel Grandin
Change-Id: I9188f4579900d7eec375754aa94d21ac4e8456e2 Reviewed-on: https://gerrit.libreoffice.org/45504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-29loplugin:unusedmethodsNoel Grandin
Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1 Reviewed-on: https://gerrit.libreoffice.org/45386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-28tdf#83877 OOXML Roundtrip of SignatureLine propertiesSamuel Mehrbrodt
Change-Id: I521e5f35663c5ab3c2702f1416fcec872f2f5e3f Reviewed-on: https://gerrit.libreoffice.org/44683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-18RotateFlyFrame3: add support for AutoContourArmin Le Grand
For transformed FlyFrames with no Border and no Padding it would be nice to immediately start using AutoContour, added first implementation to do so. Added several conditions for AutoContour, need to work on reaction on changes to these. Corrected needed transform adaptions to Contour(s) Change-Id: Ia3d7845fd5d50c8a413d592ae07ce2041ccc91b9
2017-11-17TypedWhichId for EE_CHAR* constantsNoel Grandin
Change-Id: I261f8a949ddd858dee196118bb42993a101a2a28 Reviewed-on: https://gerrit.libreoffice.org/44829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17TypedWhichId for EE_PARA* constantsNoel Grandin
Change-Id: I64d1765336f39c3e3ded4d58ebdee80e97624276 Reviewed-on: https://gerrit.libreoffice.org/44799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-16use implict conversion operator in TypedWhichIdNoel Grandin
instead of spreading calls to Which() everywhere. Change-Id: Ie32d106e44f5cb583908eeebe254ab8b8168ae61 Reviewed-on: https://gerrit.libreoffice.org/44760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15TypedWhichIdNoel Grandin
use a strong-typedef template to give which IDs a type, which we can carry around to do a (a) little bit more convenience when Get()'ing them and (b) a little bit of enforcement of which PoolItem subclass each ID uses Fix a bug in casting EE_PARA_BULLETSTATE to the wrong subclass in AccessibleEditableTextPara::_correctValues Change-Id: I015ce8b3b0f6d21308af182afa3caf122c877a5b Reviewed-on: https://gerrit.libreoffice.org/44587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-13clang-tidy modernize-use-equals-default in editengJochen Nitschke
remove default-able copy constructors/assignments and a non-virtual default dtor. Change-Id: I3fcc23a480031a9ede00ea22ae8f5ac5e892fd9c Reviewed-on: https://gerrit.libreoffice.org/44657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-11tdf#111738: Duplicated numbering alignment option on numbering dialogTamás Zolnai
Change-Id: Ifb18d5da84cc47da59448549f3c617e8040c246c Reviewed-on: https://gerrit.libreoffice.org/44636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-10loplugin:unusedmethodsNoel Grandin
Change-Id: I543b0943f0bc918d59debc8ee051f88c29d18454 Reviewed-on: https://gerrit.libreoffice.org/44553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-08tdf#107554 New default table styleYousuf Philips
Change-Id: I7811ac11c0a92f85698fc5cd43016d85f4661b98 Reviewed-on: https://gerrit.libreoffice.org/44363 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-11-06convert GetNumStr from sal_uLong->sal_Int32Noel Grandin
the code was truncating the param to sal_Int32 anyway Change-Id: I743b60097df937c16c995e2e6deacc12cf12e5e9 Reviewed-on: https://gerrit.libreoffice.org/44341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-06loplugin:finalclasses in editengNoel Grandin
Change-Id: I3cf074d101311e516ee1ce23ad032225780f3e25 Reviewed-on: https://gerrit.libreoffice.org/44314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-04loplugin:constparams in various(1)Noel Grandin
Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b Reviewed-on: https://gerrit.libreoffice.org/44261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-01TSCP: Support DocInfo.Custom field for ODP file formatTomaž Vajngerl
Impress has a limited support for fields - this includes support for DocInfo.Custom field, which shows the user defined custom fields that are used in TSCP. This commit adds minimal support (only what is needed for TSCP) for DocInfo.Custom field but only supports string fields for now. It is not possible to add the field manually, at least not until the full support is added. Change-Id: Ib3b73ab22fd4fe65ab6fb5173fe035a3359deea5 Reviewed-on: https://gerrit.libreoffice.org/44041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-31loplugin:constantparam in editengNoel Grandin
Change-Id: I0a07326d5b63e82ef16e02f75fd8523e3b73e1f4 Reviewed-on: https://gerrit.libreoffice.org/44096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23tscp: advanced classification dialog for impressTomaž Vajngerl
Change-Id: I76c81e6f84de8160c20f1614d7676f2f2c3fb155 Reviewed-on: https://gerrit.libreoffice.org/43361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-16editeng: add function to insert parargaph break to the EditViewTomaž Vajngerl
Change-Id: I06ab56967f25e6f9170cfbeb391110b55ddb18f6 Reviewed-on: https://gerrit.libreoffice.org/43359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-08Make Color a forward declarationChris Sherlock
Change-Id: Ib28833555661b119de8e967b05e3c8691fca826a Reviewed-on: https://gerrit.libreoffice.org/43227 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-10-05tdf#112817 editeng,svx: fix SvxUnderlineItem/SvxOverlineItem SDIMichael Stahl
This was asserting because the superclass SvxTextLineItem was instantiated instead of the specific subclasses. Change-Id: If26847b8fa96dbf00062ba8372fe58e58c786782
2017-10-04Fix typosAndrea Gelmini
Change-Id: I7f6dbb170b88cc1717d08651d4ddd3aace0a7933 Reviewed-on: https://gerrit.libreoffice.org/43141 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-29rename SvxTabStop::IsEqual to operator==Noel Grandin
Change-Id: I98f8db6e80d6a5dc30826ec755deb9432f809e92 Reviewed-on: https://gerrit.libreoffice.org/42907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-29convert IsEqual/etc methods on ESelection to operatorsNoel Grandin
Change-Id: Ia8424e701b6f22d0536ee7f3bdb0ecaaed94a3b9 Reviewed-on: https://gerrit.libreoffice.org/42904 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-18unused m_xAccInfo in AccessibleEditableTextParaNoel Grandin
since commit c23ab5eaed57cc3fb5860e26c591c73c5b22687b Date: Tue Nov 26 14:25:22 2013 +0000 Integrate branch of IAccessible2 Change-Id: Id068fb0a49f5a1e79ca17fe66885cda558abe275
2017-09-18remove unused aLocale from SvxNumRuleNoel Grandin
and fix usage site, regression from commit 41956321ceefb5836feb2c119b66de7bb557740f Date: Sat Nov 24 18:54:09 2012 +0100 get rid of Svx...Locale...() double conversion nonsense Change-Id: Ic70abf5f52dce1db9cffd9c819e57f1a6c2a3df3
2017-09-18convert SvxDateFormat to scoped enumNoel Grandin
And simplify the code in sd/headerfooterdlg, no need for the complex encoding of date and time when we can just index into a static array. Change-Id: I677400bf1f956c81eba665b71dbda9183b63f55c Reviewed-on: https://gerrit.libreoffice.org/42346 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxTimeFormat to scoped enumNoel Grandin
and make the numerators look more like our internal formatting codes Change-Id: I3b3d448cec913e72c7ffb6cc3e7754241af36d93 Reviewed-on: https://gerrit.libreoffice.org/42345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxTimeType to scoped enumNoel Grandin
Change-Id: Ic5ca8c50ccd74837cd0521a13e1f5eaa8e326ff3 Reviewed-on: https://gerrit.libreoffice.org/42344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxURLFormat to scoped enumNoel Grandin
Change-Id: Ie2199cf0bcfb6d649f8aa33325ab645b18e7c000 Reviewed-on: https://gerrit.libreoffice.org/42343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxFileType to scoped enumNoel Grandin
Change-Id: Iec1c67f7f0f9b2244b1d6ef52921ddd09f944fbb Reviewed-on: https://gerrit.libreoffice.org/42314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxFileFormat to scoped enumNoel Grandin
Change-Id: Ia75c86a89c89bb22759e1d588ce603701cb7fad5 Reviewed-on: https://gerrit.libreoffice.org/42313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxAuthorType to scoped enumNoel Grandin
Change-Id: I990eb35c883ddd417751487435556f584e956374 Reviewed-on: https://gerrit.libreoffice.org/42312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxAuthorFormat to scoped enumNoel Grandin
Change-Id: I5553ea640a4483c98ec5f5240594e30a72c968f8 Reviewed-on: https://gerrit.libreoffice.org/42311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-18 08:25:19 +0000