summaryrefslogtreecommitdiff
path: root/include/editeng
AgeCommit message (Collapse)Author
2016-03-10coverity#1355507 uninitialized scalar fieldCaolán McNamara
I think commit b2fb84499e1f75735e8fd90bc2eece3fed9af5f6 Author: Noel Grandin <noel@peralex.com> Date: Mon Mar 7 14:19:22 2016 +0200 loplugin:write only fields wrong wrong and took out this param along with the unused nIndex beside it Change-Id: Idc34e03b5d59d4b0017fff456b79c807fda2535f
2016-03-10loplugin:constantparam in editengNoel Grandin
Change-Id: I078061c502c09bccf515151d3a5bdcd1176e64fb
2016-03-07loplugin:write only fieldsNoel Grandin
Change-Id: Ia0fb487c5590e096659b81f76c4dc543e184c59c
2016-03-07loplugin:unuseddefaultparam in editengNoel Grandin
Change-Id: Ifd86b0f6cca5d5d30daeee1c087c0124f2f18f3c Reviewed-on: https://gerrit.libreoffice.org/22899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-06bIsExpanding is unusedCaolán McNamara
Change-Id: I187ca7dc0e9e1a99e82145f4bcdce6abaac68278
2016-03-03loplugin:unuseddefaultparams in editengNoel Grandin
Change-Id: I1dc0ba262c06bd69cf92aae20b344fe23f460f55
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-19editeng: remove never read mpLibreOfficeKitCallbackMiklos Vajna
As all callback invocations happen with SdrModel's callback pointer. Change-Id: I0111040c501b7927332f88cc4797b8ebab2bc57a
2016-02-18Fix SdrModel::libreOfficeKitCallback() vs ImpEditView duplicationMiklos Vajna
It's better if ImpEditView doesn't have a copy of the event types which should be ignored during searching. Change-Id: I9044b9a6af4e3f8e5bf75973e1f975fb45ec72cf
2016-02-09Use rtl::Reference<CppType> instead of HardCppRef<UnoType,CppType>Stephan Bergmann
Change-Id: I089b5caca5e05726105f78aeb00db1869d0a17f4
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08Fix typosAndrea Gelmini
Change-Id: I4586168d3af81f047a4ded59fc6d257f17554885 Reviewed-on: https://gerrit.libreoffice.org/22194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-02tdf#84843 Stop using PseudoSlots for drawing slotsMaxim Monastirsky
Instead of fighting with this obsolete thing, let's just kill it. This fixes disabling in read-only doc, as well as pressed/unpressed states. Change-Id: I4d06ba3395024ffd09d77c6d22653a2c5e227115 Reviewed-on: https://gerrit.libreoffice.org/22010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-01-31tools: rename FontUnderline to FontLineStyleChris Sherlock
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca Reviewed-on: https://gerrit.libreoffice.org/21892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-22new loplugin sfxpoolitemNoel Grandin
generates a warning about subclasses that add members but do not override operator==() Change-Id: If6df1a2cbd115f17bcca22f9b7995181dcf55c03 Reviewed-on: https://gerrit.libreoffice.org/20468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-22editeng: ImpEditView::mbTiledRendering is never readMiklos Vajna
Change-Id: Ie8e33d075f0cedbb9f7148717c4318f4494ed419
2016-01-22loplugin:overrideStephan Bergmann
after 6517141b6233c5f9667031bc92f66109fddf5b76 "tdf#42788: FORMATTING - Numbering/ordered list" made SvxNumberType::SetNumberingType virtual. Change-Id: I856a521b88940b6c2a8f3ebbae9ec4066e14ea78
2016-01-21tdf#42788: FORMATTING - Numbering/ordered listNusaiba Al-Kindi
I changed the default numbering alignment of the Roman(upper/ lower) numbers list to the right instead of left with out any changes in the default alignment of other numbring type lists. In addition, numbering alignment can be changed by the user and any new list created will not be affected by the user choice (using the default settings for the new list). Change-Id: I7a6b7fb31bf40e26910e90538cd336e767f4c056 Reviewed-on: https://gerrit.libreoffice.org/21439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-14editeng: handle SdrModel::isTiledSearching()Miklos Vajna
Given that the edit/outliner views can come and go, avoid the lifecycle problems with just passing a pointer to the sdr model to editeng, and then it'll always have the up to date "are we searching" information. editeng can't depend on svx, so provide an interface class SdrModel can implement. Change-Id: I3b98011593b00ac0fab05b6b9c591dd20d94c579
2016-01-13loplugin:unusedmethods unused return value in include/svlNoel Grandin
Change-Id: I759fe8769daccea07c2157bfb5912df8ba285534
2016-01-12Mark some classes as finalStephan Bergmann
...namely exactly those for which fa91dd31f39a24329d288d4e1cda28db3a16af0d "5th step to remove tools/rtti.hxx" (which is assumed the culprit in tdf#96067 "Crash on undo row inserts") had replaced exact-type checks of the form v->Type() == TYPE(X) with type-or-subtype-of checks of the form dynamic_cast<X *>(v) != nullptr which is only sound if X is a final class. (Except for one case already handled differently in 791ad3e170bcb5a2daedac77932dc9822f7f1092 "Stick to exact-type check.") Change-Id: Ia822c55c7c0e982d42c6a97589307e577721e324
2016-01-12loplugin:unusedmethods unused return value in include/editengNoel Grandin
Change-Id: I1314480950b0d3a3e5ed066d71c175604dd41970 Reviewed-on: https://gerrit.libreoffice.org/21361 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-07svx: fix windows build, rename SvxEscapementItem::GetProp()Michael Stahl
90e07dd6f5d64a0d0041361c1592a6cd93ff2ac0 introduced a new unit test which calls SvxEscapementItem::GetProp(), and apparently the unit test also #includes windows.h somehow, so GetProp macro is defined to GetPropA and that fails to link since SvxEscapementItem doesn't have this member function. Thank you, C preprocessor, you barbarous relic. Change-Id: I6fd8e9d832ed5e1ce1a4fa7f1516c55d51a3283b
2015-12-24Remove unneeded bitfieldDaniel Robertson
Remove unecessary bitfield from editeng::SvxLRSpaceItem Change-Id: I255d3cd7d28e470ea59187c9e488d0a4a9350d3d Reviewed-on: https://gerrit.libreoffice.org/19786 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2015-12-23loplugin:unusedfields in /includeNoel Grandin
Change-Id: Ia406e727890a365cc89831c96140cad8240f9b61
2015-12-18editeng: clean up no longer necessary isTiledRendering() member functionsMiklos Vajna
Change-Id: I4bf3e9bd9cbf2b32d79cebd5ba0a818b1f4970c2
2015-12-10loplugin:nullptr: More NULL -> nullptr automatic rewriteStephan Bergmann
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-07tdf#34449 : ability of deleting borders of a cell from adjacent cellDennis Francis
Change-Id: Ieb13a9ea88faa220d1ee352b0e47268a7fda5f38 Reviewed-on: https://gerrit.libreoffice.org/19715 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-12-07Let LIBO_INTERNAL_ONLY imply LOK_USE_UNSTABLE_APIMiklos Vajna
Change-Id: Ifbed5e534ba79d32b7188bb7fb7108338b6e124d
2015-11-26Avoid implicitly declared members of EDITENG_DLLPUBLIC classStephan Bergmann
...implicit definitions of which, under the MSVC ABI, would need to be emitted into every editeng .cxx that happens to include this file, but which would fail for the VclPtr<vcl::Window> pWin; member wherever vcl::Window happens to be incomplete. Change-Id: I0a1cc61af086f3a3235a995c34834bc131531b84
2015-11-24loplugin:unusedfields in include/comphelper,include/editengNoel Grandin
Change-Id: I619c2cf1765df97159fc52ee84e0e9e8d16a22fe
2015-11-18use unique_ptr for pImpl in editeng/Noel Grandin
Change-Id: I43ae9f706db15594b3a0c5cba41436d009588393
2015-11-115th step to remove tools/rtti.hxxOliver Specht
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I9fe00eef7ddcd4a3c87e497a8d62f98e71a0d6d8
2015-11-04remove remaining boost/noncopyable includes from /includeNoel Grandin
Change-Id: I2dfed038d97f91df9e86828620df1a46dd158292 Reviewed-on: https://gerrit.libreoffice.org/19773 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-04editeng: Eliminate unecessary padding in classesDaniel Robertson
Edit the order of SvxLRSpaceItem and PaintFirstLineInfo members to remove unecessary padding due to data alignment. Change-Id: Icf2c92ef86a32384e51d1cb6f1a079b10995dfd5 Reviewed-on: https://gerrit.libreoffice.org/19763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-10-27Reduce scope of #include <tools/stream.hxx>Matteo Casalin
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
2015-10-27loplugin:unusedmethodsNoel Grandin
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-26fix includes that are not stand-aloneNorbert Thiebaud
includes should be able to be included on their own fix some of the ones that do not respect that rule. Change-Id: Id161224a1978461d3cea43252f232f18888a4f61 Reviewed-on: https://gerrit.libreoffice.org/19612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-10-21more removal of com::sun::star typedefsNoel Grandin
Change-Id: Ia73f1b4f1dcfa3f0936359e744afe76e02dcd2eb
2015-10-21com::sun::star->css in include/editengNoel Grandin
Change-Id: I2a46f2128ef86ea0d692240b968ea52ab8e09dcc Reviewed-on: https://gerrit.libreoffice.org/19489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-13editeng: add EditView::GetSelectionRectangles()Miklos Vajna
This gives sd access to the selection rectangles as well (as opposed only to the document model positions of selections). Change-Id: Icb903e91f9e868573403b360bbe839705ddf2916
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-07loplugin:mergeclassesNoel Grandin
Change-Id: I0ac98a6fafb48b2be00973ae9fd34f4bc756cd7f
2015-10-07loplugin:mergeclassesNoel Grandin
Change-Id: Icf1731dfbd16d85decd2aaf80be4841ac37007fd
2015-10-06loplugin:unusedmethodsNoel Grandin
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
2015-10-06 tdf#94559: 4th step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
generated by cgit (git 2.34.1) at 2024-07-05 10:08:33 +0000