summaryrefslogtreecommitdiff
path: root/include/editeng
AgeCommit message (Collapse)Author
2016-06-01remove unused SID constants and associated codeNoel Grandin
found with a python script that looks like: process = subprocess.Popen( "git ls-files *.hrc | xargs grep -hE '#define +SID_' | cut -d ' ' -f 2 | sort -u", shell=True, stdout=subprocess.PIPE) for line in iter(process.stdout.readline, b''): line = line.strip() if line.startswith("//"): continue if line.startswith("sfx"): continue if len(line) < 10: continue i = subprocess.check_output("git grep -nP \"#define +" + line + " \"", shell=True) if i.count("#define") < 2: continue print line + " " + i Change-Id: I40eac2569c2b5b129d9459cb723a9d6f26d09264 Reviewed-on: https://gerrit.libreoffice.org/25715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30editeng: rename misleading SvxBoxItem::GetDistance()/SetDistance()Michael Stahl
Change-Id: Iea61f2de2b907974bbb05c66abf6cdaeab87b8b2
2016-05-30Convert FontRelief to scoped enumNoel Grandin
Change-Id: I545c83d742db27f1a004b66e5eb1ef768f62e011 Reviewed-on: https://gerrit.libreoffice.org/25626 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25tdf#89329: use unique_ptr for pImpl in xmlcnitmXisco Fauli
Change-Id: Iec37e509b78e58e90591bad26735ff31462eaf5c Reviewed-on: https://gerrit.libreoffice.org/25328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18Resolves: tdf#99930 SetReplaceLeadingSingleQuotationMark(false) for CalcEike Rathke
Change-Id: I29906de6a4075b7de82bd6e16560b56b9b648e91
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert OUTLINER_MODE to scoped enumNoel Grandin
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909 Reviewed-on: https://gerrit.libreoffice.org/24789 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin
Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04No need to explicitly delete ctor the compiler wouldn't implicitly declareStephan Bergmann
Change-Id: Idd0e764765bd76e1f6a2d8ec6e18ebac27b91ec6
2016-05-03C++11: disable ctors with delete in include/Jochen Nitschke
replace the old declare and don't implement pattern with C++11 delete keyword no need to hide this design choice behind access restrictions Change-Id: I7e8430a07189aa48514a4613c3a8c2950b230f49 Reviewed-on: https://gerrit.libreoffice.org/24495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13loplugin:passstuffbyref in editengNoel Grandin
Change-Id: I11deb7c73a1c160d587d74c9851ff10c875c972b
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I12118ad040d1791c7afa517081040961cc7e4677
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I8adf61a63e6e6102a44cd18652192fde0a89287a
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11clang-tidy performance-unnecessary-value-param in editengNoel Grandin
Change-Id: Idfebcc36c756023e491baf2c4259bd580785dd44
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I0505cf418688d568c0c110bc70b2552e2fb8265c
2016-04-06Avoid reserved identifierStephan Bergmann
Change-Id: I87a6afeffaf7c87c6037a416783f1f22015b2fbf
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I2c83911433a8f89e7366d9f7711ca4879e44bae9
2016-04-05loplugin:constantparam in editengNoel Grandin
Change-Id: If8342112e0657014266133954269b9396085a27d Reviewed-on: https://gerrit.libreoffice.org/23807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-18loplugin:constantfunction in editengNoel Grandin
Change-Id: I8f8414b4867d3248e6d836ed8037de4da41b97f1 Reviewed-on: https://gerrit.libreoffice.org/23331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15loplugin:constantparamNoel Grandin
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-10coverity#1355507 uninitialized scalar fieldCaolán McNamara
I think commit b2fb84499e1f75735e8fd90bc2eece3fed9af5f6 Author: Noel Grandin <noel@peralex.com> Date: Mon Mar 7 14:19:22 2016 +0200 loplugin:write only fields wrong wrong and took out this param along with the unused nIndex beside it Change-Id: Idc34e03b5d59d4b0017fff456b79c807fda2535f
2016-03-10loplugin:constantparam in editengNoel Grandin
Change-Id: I078061c502c09bccf515151d3a5bdcd1176e64fb
2016-03-07loplugin:write only fieldsNoel Grandin
Change-Id: Ia0fb487c5590e096659b81f76c4dc543e184c59c
2016-03-07loplugin:unuseddefaultparam in editengNoel Grandin
Change-Id: Ifd86b0f6cca5d5d30daeee1c087c0124f2f18f3c Reviewed-on: https://gerrit.libreoffice.org/22899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-06bIsExpanding is unusedCaolán McNamara
Change-Id: I187ca7dc0e9e1a99e82145f4bcdce6abaac68278
2016-03-03loplugin:unuseddefaultparams in editengNoel Grandin
Change-Id: I1dc0ba262c06bd69cf92aae20b344fe23f460f55
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-19editeng: remove never read mpLibreOfficeKitCallbackMiklos Vajna
As all callback invocations happen with SdrModel's callback pointer. Change-Id: I0111040c501b7927332f88cc4797b8ebab2bc57a
2016-02-18Fix SdrModel::libreOfficeKitCallback() vs ImpEditView duplicationMiklos Vajna
It's better if ImpEditView doesn't have a copy of the event types which should be ignored during searching. Change-Id: I9044b9a6af4e3f8e5bf75973e1f975fb45ec72cf
2016-02-09Use rtl::Reference<CppType> instead of HardCppRef<UnoType,CppType>Stephan Bergmann
Change-Id: I089b5caca5e05726105f78aeb00db1869d0a17f4
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08Fix typosAndrea Gelmini
Change-Id: I4586168d3af81f047a4ded59fc6d257f17554885 Reviewed-on: https://gerrit.libreoffice.org/22194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-02tdf#84843 Stop using PseudoSlots for drawing slotsMaxim Monastirsky
Instead of fighting with this obsolete thing, let's just kill it. This fixes disabling in read-only doc, as well as pressed/unpressed states. Change-Id: I4d06ba3395024ffd09d77c6d22653a2c5e227115 Reviewed-on: https://gerrit.libreoffice.org/22010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-01-31tools: rename FontUnderline to FontLineStyleChris Sherlock
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca Reviewed-on: https://gerrit.libreoffice.org/21892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-22new loplugin sfxpoolitemNoel Grandin
generates a warning about subclasses that add members but do not override operator==() Change-Id: If6df1a2cbd115f17bcca22f9b7995181dcf55c03 Reviewed-on: https://gerrit.libreoffice.org/20468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-22editeng: ImpEditView::mbTiledRendering is never readMiklos Vajna
Change-Id: Ie8e33d075f0cedbb9f7148717c4318f4494ed419
2016-01-22loplugin:overrideStephan Bergmann
after 6517141b6233c5f9667031bc92f66109fddf5b76 "tdf#42788: FORMATTING - Numbering/ordered list" made SvxNumberType::SetNumberingType virtual. Change-Id: I856a521b88940b6c2a8f3ebbae9ec4066e14ea78
2016-01-21tdf#42788: FORMATTING - Numbering/ordered listNusaiba Al-Kindi
I changed the default numbering alignment of the Roman(upper/ lower) numbers list to the right instead of left with out any changes in the default alignment of other numbring type lists. In addition, numbering alignment can be changed by the user and any new list created will not be affected by the user choice (using the default settings for the new list). Change-Id: I7a6b7fb31bf40e26910e90538cd336e767f4c056 Reviewed-on: https://gerrit.libreoffice.org/21439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-14editeng: handle SdrModel::isTiledSearching()Miklos Vajna
Given that the edit/outliner views can come and go, avoid the lifecycle problems with just passing a pointer to the sdr model to editeng, and then it'll always have the up to date "are we searching" information. editeng can't depend on svx, so provide an interface class SdrModel can implement. Change-Id: I3b98011593b00ac0fab05b6b9c591dd20d94c579
2016-01-13loplugin:unusedmethods unused return value in include/svlNoel Grandin
Change-Id: I759fe8769daccea07c2157bfb5912df8ba285534
2016-01-12Mark some classes as finalStephan Bergmann
...namely exactly those for which fa91dd31f39a24329d288d4e1cda28db3a16af0d "5th step to remove tools/rtti.hxx" (which is assumed the culprit in tdf#96067 "Crash on undo row inserts") had replaced exact-type checks of the form v->Type() == TYPE(X) with type-or-subtype-of checks of the form dynamic_cast<X *>(v) != nullptr which is only sound if X is a final class. (Except for one case already handled differently in 791ad3e170bcb5a2daedac77932dc9822f7f1092 "Stick to exact-type check.") Change-Id: Ia822c55c7c0e982d42c6a97589307e577721e324
2016-01-12loplugin:unusedmethods unused return value in include/editengNoel Grandin
Change-Id: I1314480950b0d3a3e5ed066d71c175604dd41970 Reviewed-on: https://gerrit.libreoffice.org/21361 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-07svx: fix windows build, rename SvxEscapementItem::GetProp()Michael Stahl
90e07dd6f5d64a0d0041361c1592a6cd93ff2ac0 introduced a new unit test which calls SvxEscapementItem::GetProp(), and apparently the unit test also #includes windows.h somehow, so GetProp macro is defined to GetPropA and that fails to link since SvxEscapementItem doesn't have this member function. Thank you, C preprocessor, you barbarous relic. Change-Id: I6fd8e9d832ed5e1ce1a4fa7f1516c55d51a3283b
2015-12-24Remove unneeded bitfieldDaniel Robertson
Remove unecessary bitfield from editeng::SvxLRSpaceItem Change-Id: I255d3cd7d28e470ea59187c9e488d0a4a9350d3d Reviewed-on: https://gerrit.libreoffice.org/19786 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2015-12-23loplugin:unusedfields in /includeNoel Grandin
Change-Id: Ia406e727890a365cc89831c96140cad8240f9b61
2015-12-18editeng: clean up no longer necessary isTiledRendering() member functionsMiklos Vajna
Change-Id: I4bf3e9bd9cbf2b32d79cebd5ba0a818b1f4970c2
2015-12-10loplugin:nullptr: More NULL -> nullptr automatic rewriteStephan Bergmann
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
generated by cgit (git 2.34.1) at 2024-12-26 22:01:10 +0000