summaryrefslogtreecommitdiff
path: root/include/filter
AgeCommit message (Collapse)Author
2016-11-21convert inventorId to scoped enumNoel Grandin
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26try and silence coverity#1374267 Out-of-bounds accessCaolán McNamara
Change-Id: Ib7a8866dc4acdc243e7bfa975e760afde3bb43a6
2016-10-21loplugin:expandablemethodds in include/filterNoel Grandin
Change-Id: I92f0e19845e921701eb139e19493effa47908b39
2016-10-21implement CryptoAPI RC4+SHA1 encryption scheme for xls importCaolán McNamara
there might be other variants out there in practice, but this works for default encrypted xls of excel 2013 Change-Id: I91c0e1d1d95fbd1c68966650e7ac7d23276bcbe3
2016-10-21split MSCodec_Std97 into a baseclass MSCodec97Caolán McNamara
Change-Id: Ia3c41a048169c78684800def94e53fc9f3201e30
2016-10-21rework things in light of now available documentationCaolán McNamara
Change-Id: If5f75e27191017a8c6a3929e2a70d21840f157c6
2016-10-21move some useful header information to mscodec for reuseCaolán McNamara
Change-Id: Ic7adf3ed3c8279cc93a06975d6fb337210d1af87
2016-10-13loplugin:mergeclasses ImplEESdrWriter with ImplEscherExSdrNoel Grandin
Change-Id: Iea2241d9fc44b92e18101b3f367a643f03729183
2016-09-30loplugin:constantparamNoel Grandin
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c Reviewed-on: https://gerrit.libreoffice.org/29321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-19loplugin:unusedenumvaluesNoel Grandin
Change-Id: I9dcc9f73af6db5b4f7cc946bc28931e5c230b34c Reviewed-on: https://gerrit.libreoffice.org/29012 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16loplogin:singlevalfields in include/Noel Grandin
Change-Id: I27842162fcf82120ecb811ee8e89e187430931fc Reviewed-on: https://gerrit.libreoffice.org/28931 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-25new loplugin: countusersofdefaultparamsNoel Grandin
Change-Id: I79e2c690f3e664c14af12cf763dd5a8ac20d6b04 Reviewed-on: https://gerrit.libreoffice.org/28353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11loplugin:constantparamNoel Grandin
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-15tdf#62525 vcl: use cow_wrapper for PPTCharPropSetXisco Fauli
Change-Id: I506688a495ac145a25d2094be48ea53497d1e8a8 Reviewed-on: https://gerrit.libreoffice.org/25914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-15tdf#42949: clean up includes in include/filter with iwyuJorenz Paragas
Change-Id: Id08a999764bfeeff3bb3409b46f48b278009ccbe Reviewed-on: https://gerrit.libreoffice.org/26238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06filter: PPT import: PptPlaceholder is 1 byte largeMichael Stahl
The array of 8 bytes corresponds to 8 enum values and is read directly in ReadPptSlideLayoutAto(); this was wrongly converted to enum. (regression from e5a03da8eb02c333502d6b427625e7bf554ff203) Change-Id: I5757e06459467b3c84c4a404493fa3be23e4e9a0
2016-06-03loplugin:constantparamsNoel Grandin
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13convert TSS_TYPE to scoped enumNoel Grandin
Change-Id: Ic76d7bfcfe4015c6a02dc5989f8300e5ddde706e Reviewed-on: https://gerrit.libreoffice.org/24896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-07tdf#84394: xls load: delay cell-anchoring of object groupsGiuseppe Bilotta
When cell-anchored object groups are loaded, their anchoring must be delayed until all nested objects have been loaded, lest the invalid rectangle dimensions lead to incorrect positioning of the object. To achieve this, we keep track of the DffObjectData of the pending group, and move the anchoring to a FinalizeObj() method. Since DffObjectData has a const reference to a DffRecordHeader (which we need when setting the object anchoring) whose scope has closed by the time we call FinalizeObj() on the parent object, the stack of pending DffObjectData has references to clones of the original DffRecordHeader held in shared pointers. (This is to minimize the invasiveness of this patch wrt the Import* API.) Change-Id: Id23f5549dbc82306271cc02afc750f37eeea3ca2 Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/24292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-13loplugin:passstuffbyref in filterNoel Grandin
Change-Id: I68e69620d4725aac66ded11e7d316caf03098249
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I6c8565653ece37251a98103f71408ace2a0946a8
2016-04-05tdf#91794 OSL_DEBUG_LEVEL > 1 removed in libo/filter moduleRohan Kumar
I replaced the occurences of OSL_DEBUG_LEVEL > 1 with the debug macro DEBUG_{module}_{area}. Change-Id: Ibbf7345d3dc43354ff80a8ceafb4a812749513c7 Reviewed-on: https://gerrit.libreoffice.org/22355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-04loplugin:unuseddefaultparam in filterNoel Grandin
Change-Id: Ieaad3145c01dc4ea7b3e7eb7859db89ebd1d7fe1
2016-03-03loplugin:unuseddefaultparams in filterNoel Grandin
Change-Id: Ife21ac3fc2ede30694a1c7e2f9296105aa548218
2016-02-22loplugin:write only fieldsNoel Grandin
Change-Id: I45895e9845a9037da207f001fece427452ed499f
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-13Fix memory leakStephan Bergmann
Change-Id: I9e271c3b7ff49d33f4f6f3f8c50b70ac5ce1541e
2016-01-12loplugin:unusedmethods unused return value in include/filterNoel Grandin
Change-Id: Ibd7d701b6991ae76d0cba0bfbb9cb79150c90c72 Reviewed-on: https://gerrit.libreoffice.org/21362 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-23loplugin:unusedfields in /includeNoel Grandin
Change-Id: Ia406e727890a365cc89831c96140cad8240f9b61
2015-12-15filter: add BaseURL parameter to SvxMSDffManager::ImportOLE()Michael Stahl
... mainly for the (unlikely) case of ODF embedded objects in MSO binary files, which can be created by toggling the Tools->Options->Load/Save->Microsoft Office export settings. Change-Id: I270f1516b70b20ec0b60cfbd17c2c327c3d9efd0
2015-12-08consolidate MSO format ClassID magic numbers in msfilter/classids.hxxMichael Stahl
Change-Id: I673eeaa4168f769cb002995c43d986ee5f2030b2
2015-12-05Remove typedef only being used onceJulien Nabet
Change-Id: I8f29df2c67e6c4cd9535629edbba4ff1f1a2e632
2015-11-30loplugin:unusedfieldsNoel Grandin
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-28Remove unused ESCHER_ShadeTypeStephan Bergmann
...apparently a copy of MSO_ShadeType removed with e336d7f80fd9f7ada4b12c37f9434df411d28466 "Remove unused MSO_ShadeType" and equally unused Change-Id: If1660faa45c1445c302ac0c9a1a160674691c15d
2015-11-24loplugin:unusedfields in include/filter/Noel Grandin
Change-Id: Id79bc51ba273746873a1381243b2c1d32711bbb4
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I61e494952df8cc40fff3ccad0936adf06035dbeb
2015-10-29remove boost::noncopyable from /includeNoel Grandin
Change-Id: I9fa22b06fabf79043ebc68be7afebc6e810f4db1
2015-10-27Reduce scope of #include <tools/stream.hxx>Matteo Casalin
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
2015-10-27sal_uLong to ErrCodeMatteo Casalin
Change-Id: I2b4b2673aa27de664f6c6780e67c70559ec61971
2015-10-26fix includes that are not stand-aloneNorbert Thiebaud
includes should be able to be included on their own fix some of the ones that do not respect that rule. Change-Id: Id161224a1978461d3cea43252f232f18888a4f61 Reviewed-on: https://gerrit.libreoffice.org/19612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-10-26TBBase::indent_printf() only #if OSL_DEBUG_LEVEL > 1Eike Rathke
... so the next unusedcode round doesn't remove it again. Change-Id: I3bcbafb0461f09fcfbb0e14f4f1a1713a540b5a3
2015-10-26reintroduce TBBase::indent_printf()Eike Rathke
This partly reverts a90c6eb99c8c2167c4b1ec75a21a30a344bfea43 which erroneously removed the method as unused because it is used only with OSL_DEBUG_LEVEL > 2 Change-Id: I6fa52775b6a013c0086ba9d7ae21720a9ab8aa01
2015-10-22com::sun::star->css in include/filterNoel Grandin
Change-Id: I05c314b6eb460cfcbaa7d13cae21360ce6824624 Reviewed-on: https://gerrit.libreoffice.org/19492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>