summaryrefslogtreecommitdiff
path: root/include/framework
AgeCommit message (Collapse)Author
2016-10-03Fix typosAndrea Gelmini
Change-Id: I7000efdb7276053c16de992fa8f9a4e614ecb3e2 Reviewed-on: https://gerrit.libreoffice.org/29434 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20loplugin:unusedfieldsNoel Grandin
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-07framework: cleanup redundant commentsThorsten Behrens
Change-Id: Id4cb444a1e21ec0ee94a2604c15bc43220a7b571
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-08Related: tdf#100713 fix more recent bug to try and see older bug...Caolán McNamara
at the moment AddonsOptions::Notify is called with a null this which crashes during adding an extension regression from... commit 3bdc5063f942b9ea3b6e39e707926fbc516c19f9 Date: Wed Jun 22 02:30:43 2016 +0200 tdf#89329: use shared_ptr for pImpl in addonsoptions Change-Id: Ic28951e56bb8beca2a01ef2a1864eadcf3864e5b
2016-06-28tdf#89329: use shared_ptr for pImpl in addonsoptionsXisco Fauli
Change-Id: I159ba04fa70f324d2a7f5b3c592337b92c7f097d Reviewed-on: https://gerrit.libreoffice.org/26560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08tdf#99815 use XNotifyingDispatch in sfx2Juergen Funk
- move DispatchHelper somewhere public - use it from generic dispatcher call sites in sfx2 - return result of dispatcher calls (conveyed via XDispatchResultListener) to calling code, instead of faking it Change-Id: Ie8041133e99dd99e45819f98798829b96532b9e6 Reviewed-on: https://gerrit.libreoffice.org/24953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-06remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f Reviewed-on: https://gerrit.libreoffice.org/25806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03loplugin:refcounting (RequestFilterSelect_Impl derives from XInterface)Stephan Bergmann
Change-Id: Iabf9b94626b599b4fe799523b3523e18df5203c5
2016-06-03tdf#89329: use unique_ptr for pImpl in interactionXisco Fauli
Change-Id: I21ad7278f7978e7eebf6962fdf1fac2d3cb2bddb Reviewed-on: https://gerrit.libreoffice.org/25637 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Revert "remove some manual ref-counting"Noel Grandin
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01sequence->vector in frameworkNoel Grandin
Change-Id: I457c3da4f4a31f58d688dcd96a2ccfc36518490d Reviewed-on: https://gerrit.libreoffice.org/23692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11framework: Kill BmkMenuMaxim Monastirsky
Change-Id: I182e752f5602d946f27206a1bb744c5d2248bdf8
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-12GetImageFromURL/SetImageProducer unusedNoel Grandin
looks like these have been abandoned recently in the toolbar manager update Change-Id: I5556833dfef0db5958a5779bdb32482c18a46a5f
2015-12-17Remove unused ToolPanel (aka TaskPane)Samuel Mehrbrodt
Superseded by the Sidebar Change-Id: I54970d71cd9d42de4f47b223e50dd9474b40632a Reviewed-on: https://gerrit.libreoffice.org/20724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-24loplugin:unusedfields in include/framework/Noel Grandin
Change-Id: I04603a3b78b0611fcca4974b00e2da06045308d1
2015-11-03Support of popupmenu resource typeMaxim Monastirsky
Reusing the same xml format as the menubar, except that a popup menu use menu:menupopup as the root element. Change-Id: I2987af0dc698b09aeeb757cff828617515bc3009
2015-10-27Reduce scope of #include <tools/stream.hxx>Matteo Casalin
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
2015-10-22com::sun::star->css in include/frameworkNoel Grandin
Change-Id: I60874ab8d3cc9adaea8757d6888e341accce2083 Reviewed-on: https://gerrit.libreoffice.org/19494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-08-28make PostUserEvent Link<> typedNoel Grandin
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-14framework: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I6acff50f23bcbac58c689caf2a7f07dbd5404e57 Reviewed-on: https://gerrit.libreoffice.org/17734 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15loplugin:unusedmethods frameworkNoel Grandin
Change-Id: Ibfeb0ef753a083f458c84f446f0729f05c73e2d6 Reviewed-on: https://gerrit.libreoffice.org/17060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-14oops, forgot to add new header fileMichael Stahl
Change-Id: I83ce7cb1b06ad69250aee48e9a8c1167ae7ef239
2015-07-08Fix typosAndrea Gelmini
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-03Fix typosAndrea Gelmini
Change-Id: Ie2bbe020fc6e3a4a4f913208c245f395849bb9ee Reviewed-on: https://gerrit.libreoffice.org/16708 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-30Fix typosAndrea Gelmini
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-05-19remove the last of the OUString #defines in header filesNoel Grandin
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-22Update to XDocumentEventBroadcaster et alStephan Bergmann
Change-Id: I11633dc1629eac6a1ba79e4b45972a1e4f5fc833
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I8de9f20ba2d19631da111f11cfe85225039e30f6
2015-02-04rename MenuConfiguration::Attributes->MenuAttributesCaolán McNamara
Change-Id: I2ada1394c4cbee7c27b02f241ee4a254597a5dd8
2015-02-04fix leak from framework::AddonMenuManager::BuildMenuCaolán McNamara
provide a callback when a menu item gets deleted Change-Id: I5b5f1a181fb10f53f6b1fe7b5637d385e1517530
2015-01-28remove unused typedefsNoel Grandin
found with some minor modifications to find/find-unused-defines.sh Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd Reviewed-on: https://gerrit.libreoffice.org/14194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-18framework: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I5da5cd3254102c742021b3e7b4e1f907ca897ca5
2014-12-05fdo#84938: removed unused definesJennifer Liebel
Change-Id: I8ce6621ad9e1971a0d586e324d49e9a209857057 Reviewed-on: https://gerrit.libreoffice.org/13307 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2014-08-01typo: more then -> more thanTakeshi Abe
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-07-23AmbigousFilterRequest is only ever extracted, never createdCaolán McNamara
Change-Id: I79c669c1635192199d6ef135e1ab9b48a9e7e63a
2014-06-04coverity#737167 Uncaught exceptionCaolán McNamara
Change-Id: I9ac3ffbecf8c9efc0b69ad4606c61dbf8fa5a0e9
2014-05-24coverity#983680 Uncaught exceptionCaolán McNamara
Change-Id: I62baf5b8809d915a4fe6a32788868072d55258e0
2014-05-19Resolves: #i86528# use the module manager to identify the context...Tsutomu Uchino
for addons menu merging (cherry picked from commit 2aac0070dbef6c1ad7eeccf7d4015cdcbffe067e) Conflicts: framework/source/classes/menumanager.cxx framework/source/fwe/classes/addonmenu.cxx framework/source/uielement/menubarmanager.cxx include/framework/addonmenu.hxx Change-Id: I3b606671db3a4c6ba8ed2b850e01e1ac91db7581
generated by cgit (git 2.34.1) at 2025-01-29 23:00:30 +0000