Age | Commit message (Collapse) | Author |
|
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c
Reviewed-on: https://gerrit.libreoffice.org/29321
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
|
|
Change-Id: Ia34ac1496e534c4fcb91dbb0e3b05734dfeede7b
|
|
...and fix the many compiler errors that occurred as a result.
Change-Id: I497c326272b2f02737ca3765720d6815b735423b
Reviewed-on: https://gerrit.libreoffice.org/24735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
used in loops, rewrite to range based loop
oox/source/drawingml/color.cxx has some mappings in plain arrays
make them arrays of pairs which can be used in range based loops
Change-Id: Ib6693197d890f595c27ca24b9f9b4e0763747f4c
Reviewed-on: https://gerrit.libreoffice.org/24809
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
|
|
Change-Id: Iec989e9060c77dd5b010224b37633179cee4f7e9
|
|
Change-Id: I1ac86906ea21c00f8d77834c94583be7d9e9974e
|
|
Change-Id: If6aab00a5b2283376a04b70580df6c1c4e5304a2
|
|
Change-Id: Ia26cf182ddc7c903d86bf74a8175858adb88121c
|
|
Change-Id: If05662102e161d3dd56bbb6ed3964e63ba853cf9
|
|
Change-Id: I11241c8653194fdb0a85727fef85f2963f9e8228
Reviewed-on: https://gerrit.libreoffice.org/22602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
A ridiculously fast way of doing this is:
for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
--exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
perl -0777 -i -pe 's/^
{3,}/
/gm' $i
done
Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
<sberg> noelgrandin, just happen to look at b14224fe again; looks a bit scary to remove == or != from cases where both where declared
<noelgrandin> sberg, ok, I can revert that part
<sberg> noelgrandin, I guess that would be safer (there could be cases where now a different overload could kick in)
Change-Id: I5dc41c05dc4439d5adee0e5b3e0a9e1dfb9de3af
Reviewed-on: https://gerrit.libreoffice.org/22211
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
using an idea from dtardon:
<dtardon> noelgrandin, hi. could you try to run the unusedmethods clang
plugin with "make build-nocheck"? that would catch functions that are
only used in tests. e.g., i just removed the whole o3tl::range class,
which has not been used in many years, but htere was a test for it...
<noelgrandin> dtardon, interesting idea! Sure, I can do that.
Change-Id: I5653953a426a2186a1e43017212d87ffce520387
Reviewed-on: https://gerrit.libreoffice.org/22041
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ic402cfd6900cdf1741264b409f6fbe8f2db7e17a
|
|
Change-Id: I83beda380dc35544b9bc6fd5b1c7359546f8c8c5
|
|
Change-Id: Iee410ec4d256eb5b663d88e048d5bf6200845256
Reviewed-on: https://gerrit.libreoffice.org/20959
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
fallout from the wide char changes
<sberg> noelgrandin, _rene_, ah, yeah, that's something that broke with 0b07406f7147b9abbb2095d9e038b13293cb8b10
<IZBot> core - Use C++11 char16_t for sal_Unicode - http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b07406f7147b9abbb2095d9e038b13293cb8b10
Change-Id: If4303bd1d8577612250b1857b809b022d13759e4
Reviewed-on: https://gerrit.libreoffice.org/20433
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I62a20b440064aca6f102e61cb3984bb95e739a4f
|
|
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f
Reviewed-on: https://gerrit.libreoffice.org/19636
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ie5a3cddd6fcf9d1a763284c1aea0fca579da4f8d
|
|
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861
Reviewed-on: https://gerrit.libreoffice.org/19231
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Id69e293fda98ee6cf2cc3d3296a0cd2e06bd847e
Reviewed-on: https://gerrit.libreoffice.org/19527
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
|
|
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
|
|
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
|
|
where we don't need to share the data
Change-Id: I0edc9d62186d96095ee67e3c93f5cf186dffcb71
|
|
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
|
|
The member is inherited from a nonpublic virtual base class or
structure.
Declaring copy ctor and assignment operator as deleted in derived
class solved the problem.
Change-Id: Ic509f7e7311fd896656ecff80df3ece4503c3a65
Reviewed-on: https://gerrit.libreoffice.org/18328
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>
|
|
Change-Id: I5381e0da0efc1f951e248cfcfb35fc680ace94e4
Reviewed-on: https://gerrit.libreoffice.org/17225
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I26d52d4ba49216dd9c3d402dbd5480865e5351e1
|
|
Change-Id: I4ec0cd4781aaa905f734b15ba4eff7819ca01082
|
|
Change-Id: I3f1fa86f62c2b2e32768a8d1e17793161339dad8
|
|
Change-Id: Ifab0f5ad300882b1a014f6420094e5db503105e3
|
|
Change-Id: Icae6b6f07ad8dbd287fdfc689739187883a07775
|
|
Change-Id: Iee7fea0f55cf54d43a349b6cc0ffa25995069e40
|
|
Change-Id: I37eb6c976779aeec829d312920ab1d18884c0f2f
|
|
and we can include a few less headers
Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
|
|
found with some minor modifications to find/find-unused-defines.sh
Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
in favour of ReadXXX/WriteXXX methods
Change-Id: I75fcb04cb9e2981a10146a96de27916ca7f6bc57
|
|
in favour of ReadXXX/WriteXXX methods
Change-Id: I849fd10c689fb9834ae9974e430dc337adc68755
|
|
in favour of ReadXXX/WriteXXX methods
Change-Id: I69eebee3a8ce5b40301db7940a1d85915c0bf6f4
|
|
Btw, th unanounced byte-swapping of valuse in the input array in
writeArray seems a bit dubious to me... It could too easily cause
unintentional memory damage. I just hope it is always called either with
data that is not used after that anymore or with a copy of the data.
Change-Id: Ica0e9ea16cd101fe87d7e0a8fa696911769e0654
|
|
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
|
|
Charts in docx and xlsx OTOH use solid white as the default fill style.
Change-Id: Ic4351fe65cabc12d60214b67c7026a317841f2c7
|
|
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
|
|
Change-Id: I8cf274902bb5fda9fa70ab2af9e399db82d85d1d
|
|
Change-Id: I673a76ef85038b1f304ea85faeed5b4a462cb144
|