summaryrefslogtreecommitdiff
path: root/include/oox
AgeCommit message (Collapse)Author
2016-04-29tdf#99030: PPTX import: Fixed lost slide background colorMatus Uzak
Regression from commit f3d1ac7 Change-Id: I5cb9fe1bb6c753c34b49e72194a9fbe4c10c1654 Reviewed-on: https://gerrit.libreoffice.org/23930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-04-28tdf#42949: prefer including Reference.hxx over Reference.h...Jorenz Paragas
...and so on for Any.hxx and Sequence.hxx. This commit follows up on two of my previous commits, which are 6a4a15c87c03feffb90cc416ce22d2819e41442d and 474eca1f9b42749665bbf69f6dc62c66ea4ad7fd. Many non-static inline functions that are declared in Reference.h and similar files are not defined in the .h file, but their definitions are in the corresponding .hxx files instead. Thus, let's prefer including the .hxx files over the .h one so that we don't include inline functions without their definitions. In practice, the corresponding .hxx file is included transitively from many other places, but it's better not to rely on that. Change-Id: I3bada39eb879ae736c0360f435b16cd5a61adba8 Reviewed-on: https://gerrit.libreoffice.org/24456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-26tdf#42949: clean up includes in include/oox/crypto with iwyuJorenz Paragas
The includes in CryptTools.hxx that are within #if/#endif directives are not altered. iwyu suggested replacing the includes for nss.h, pk11pub.h, and sechash.h with hasht.h, pkcs11t.h, seccomon.h, and secmodt.h. I decided not to because it might make CryptTools.hxx harder to refactor in exchange for little gain. Before creating this commit, I ran 'make check' after passing --with-tls=openssl to ./autogen.sh to ensure that building with either OpenSSL or NSS (the default except on iOS and Android) works. Change-Id: I20260d18f073ffd8077bbcc597e7a8e4954e2ec5 Reviewed-on: https://gerrit.libreoffice.org/24386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-25tdf#42949: clean up includes in include/oox/core using iwyuJorenz Paragas
This allows the headers in that folder to stand on their own and not depend on any transitively included headers. All changes to other files are needed to fix compiler errors related to missing includes that occurred afterwards. Change-Id: I2083b30763f0b2c1aacdff00226e5f567ae52db4 Reviewed-on: https://gerrit.libreoffice.org/24355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-22Avoid reserved identifiersStephan Bergmann
Change-Id: Ie1664e06dc02f7070e4ef77155e6541c70b2f8e8
2016-04-13loplugin:passstuffbyref in ooxNoel Grandin
Change-Id: Iec989e9060c77dd5b010224b37633179cee4f7e9
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I9d36c79e73d061689b6f9b9ddc5f5a99f8a2d2ab
2016-04-12tdf#99135 VML import: handle image cropMiklos Vajna
The spec says in theory a % suffix could be also supported, but let's wait till that is seen in a real-world document. Change-Id: Ie026915e38dcb03c99085a1740075364b00e1c8d
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11clang-tidy performance-unnecessary-value-param in ooxNoel Grandin
Change-Id: I1ac86906ea21c00f8d77834c94583be7d9e9974e
2016-04-09valgrind: use of uninitialized data on load of ooo98646-1.docCaolán McNamara
Change-Id: If6aab00a5b2283376a04b70580df6c1c4e5304a2
2016-03-23tdf#93868: PPTX import: Incorrect inheritance of shape fill propertiesMatus Uzak
DrawingML: The useBgFill attribute specifies that the shape fill should be set to that of the slide background. Change-Id: I8b568e730f00326d51e7b604579f4ff990b26f8a Reviewed-on: https://gerrit.libreoffice.org/23039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-14inline some use-once macrosNoel Grandin
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04loplugin:unuseddefaultparam in oox/reportdesign/sdNoel Grandin
Change-Id: Ia26cf182ddc7c903d86bf74a8175858adb88121c
2016-03-03loplugin:unuseddefaultparams in ooxNoel Grandin
Change-Id: If05662102e161d3dd56bbb6ed3964e63ba853cf9
2016-02-22WaE vs2015 unreacheable codeNorbert Thiebaud
Change-Id: I11241c8653194fdb0a85727fef85f2963f9e8228 Reviewed-on: https://gerrit.libreoffice.org/22602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-22loplugin:write only fieldsNoel Grandin
Change-Id: I45895e9845a9037da207f001fece427452ed499f
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08revert part of "loplugin:unusedmethods"Noel Grandin
<sberg> noelgrandin, just happen to look at b14224fe again; looks a bit scary to remove == or != from cases where both where declared <noelgrandin> sberg, ok, I can revert that part <sberg> noelgrandin, I guess that would be safer (there could be cases where now a different overload could kick in) Change-Id: I5dc41c05dc4439d5adee0e5b3e0a9e1dfb9de3af Reviewed-on: https://gerrit.libreoffice.org/22211 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-29oox: replace boost::bind with std::bindMichael Stahl
Change-Id: Ic402cfd6900cdf1741264b409f6fbe8f2db7e17a
2016-01-21oox: import Math objects from PPTX filesMichael Stahl
This is quite hacky and limited: in OOXML these are not OLE objects but occur inside text boxes, and PPT 2010 allows inserting multiple Math objects into one text box but Impress does not have as-character anchored objects, so we can't import that properly; for now only import Math if there is nothing else in the text box. Also for now only import them as children of TextParagraphContext (a:p); it's not clear what the possible parent elements could be since the OOXML standard only lists WordProcessingML parent elements :( Change-Id: I847f810084c9ddae4b60f93896fb73a742683cc2
2016-01-15oox: export Math objects to PPTX filesMichael Stahl
These hit the assert in lcl_StoreOwnAsOOXML now so better implement some export. Change-Id: I10c005a547e8a85f2a82198a49f9a03fc46a61d7
2016-01-15starmath: only use WordProcessingML elements in DOCX filesMichael Stahl
Change-Id: I1b0f6d67bd0db0796756fd920ab92303a7ee7d79
2016-01-15oox: move enum DocumentType out of drawingml.hxxMichael Stahl
... which has nasty dependencies. Change-Id: I84ba0302142ade6e15291b782453dbe3bac753dd
2016-01-14-Werror=misleading-indentation (GCC 6)Stephan Bergmann
Change-Id: I83beda380dc35544b9bc6fd5b1c7359546f8c8c5
2016-01-14fix the MSVC 2013 --enable-lto buildMichael Stahl
... by sacrificing the appropriate number of chickens to the template dllexport gods. Change-Id: I27fb6a1f0a8a32c9bdc67574b3a2f3ec9f27b00f Reviewed-on: https://gerrit.libreoffice.org/21442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-12loplugin:unusedmethods unused return value in include/ooxNoel Grandin
Change-Id: I22acb6b94774c5944d8276827c53a419f0803f83
2016-01-11oox: deterministic oleObject stream numberingMichael Stahl
... like in sw. Change-Id: I4ba5d404c4160e907330832b7710c1d96430badf
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-04these fields can be static constantsNoel Grandin
Change-Id: Id56e219782d7f858cdeb26232c7aabd4f643c9d9 Reviewed-on: https://gerrit.libreoffice.org/21020 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-26oox: change instances of maName to more descriptive namesChris Sherlock
Change-Id: Iee410ec4d256eb5b663d88e048d5bf6200845256 Reviewed-on: https://gerrit.libreoffice.org/20959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-23loplugin:unusedfields in /includeNoel Grandin
Change-Id: Ia406e727890a365cc89831c96140cad8240f9b61
2015-12-21loplugin:unusedmethodsNoel Grandin
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
2015-12-20Move silly DBG macro to the only file where it is usedTor Lillqvist
Change-Id: Ie0da09ffccba5ca92f629f38befa56370315feb7
2015-12-20oox: save ProgId on import, and use it in ShapeExport::WriteOLE2Shape()Michael Stahl
Uses the same approach as DOCX import to preserve the ProgID; it would be much better if the MediaType of the stream were preserved instead and the other things derived from that, but this here was rather quick to do... This makes the round-tripping of OOXML OLEs in PPTX work again, which was broken by an earlier commit. Change-Id: Ic7d0362f0c14bf0e522185713666bcd58db2cf64
2015-12-20move saveInteropProperties from writerfilter to ooxMichael Stahl
Change-Id: I4f9769ad496198d2d002775dee4ee0a2f08d6f3b
2015-12-20factor out oox::GetOLEObjectStream() without sw dependenciesMichael Stahl
Change-Id: I32fa4b6b6d755b613b46b32d3b5961976335c76e
2015-12-20oox: disable obnoxious debugging spewMichael Stahl
Clearly the amount of noise here is at the SAL_INFO level, don't enable this by default on --enable-debug. Change-Id: Ifb8944132716c71cd3132892c1920a31286154cc
2015-12-07fix powerpc buildNoel Grandin
fallout from the wide char changes <sberg> noelgrandin, _rene_, ah, yeah, that's something that broke with 0b07406f7147b9abbb2095d9e038b13293cb8b10 <IZBot> core - Use C++11 char16_t for sal_Unicode - http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b07406f7147b9abbb2095d9e038b13293cb8b10 Change-Id: If4303bd1d8577612250b1857b809b022d13759e4 Reviewed-on: https://gerrit.libreoffice.org/20433 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-24loplugin:unusedfields in include/oox/Noel Grandin
Change-Id: Ie7a53f3ecc05d1d4f6f71aa8165315f9155c60dc
2015-11-18remove unused typedefs and inline use-once typedefsNoel Grandin
and improve the script a little Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84 Reviewed-on: https://gerrit.libreoffice.org/20033 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I62a20b440064aca6f102e61cb3984bb95e739a4f
2015-11-09loplugin:passstuffbyrefStephan Bergmann
Change-Id: Ibcab688c042e32a81b936573503c4a9066244161
2015-11-09pptx: "fall" transition, which needed p15 namespaceTomaž Vajngerl
Added p15 namespace which is present in MSO 2013+ documents. It adds a "prstTrans" element with a string "prst" attribute which is a name of the transition to be performed. This was added to support "fall" transition which translates to "fallOver" preset transition. Change-Id: I429bb106a12c1b99cce756502508e917720daef3
2015-11-05Reduce scope of #include <tools/poly.hxx>Matteo Casalin
Change-Id: I0d64393c029d27c8e6f3b6d360d2509dad16d860
2015-11-04boost::array->std::array in include/ooxNoel Grandin
Change-Id: I9c33a42d037c50dc05915f889a0f3a31bb8f0fb9 Reviewed-on: https://gerrit.libreoffice.org/19777 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30loplugin:unusedmethodsNoel Grandin
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-29Too much copy pasta is not good for youTor Lillqvist
Change-Id: Ie5a3cddd6fcf9d1a763284c1aea0fca579da4f8d