summaryrefslogtreecommitdiff
path: root/include/osl
AgeCommit message (Collapse)Author
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: UNO API include filesStephan Bergmann
Change these back to consistently use the "..." form to include other UNO API include files, for the benefit of external users of this API. Change-Id: I9c9188e895eb3495e20a71ad44abfa2f6061fa94
2017-09-19sal: fix numerous doxygen warningsMichael Stahl
Change-Id: I2fd3fb7b67a62d349ff917466b08c75c19dcbff6
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-30osl: partial cleanup of socket_decl.hxx doxygen commentsChris Sherlock
Change-Id: Ie7de4fb82a6e5162bb1732baaa742f1943559ce6
2017-08-28osl: rearrange socket.h sectionsChris Sherlock
Change-Id: I4a288699f2b313d7519554d7a66dc5f591c8767b Reviewed-on: https://gerrit.libreoffice.org/41613 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-08-27Fix typosAndrea Gelmini
Change-Id: I3097ef16912f72b59f0759d8826068cbb9b00ec2 Reviewed-on: https://gerrit.libreoffice.org/41606 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-28osl: fix socket.h doxygen paramChris Sherlock
Change-Id: I4299433ec30ee5d102750b41e8cc6e82e4530a59
2017-08-27osl: document socket enumsChris Sherlock
Change-Id: I6f4904d415a44ba20ec0a9bfea9876c50eedb968
2017-08-27osl: cleanup socket.hChris Sherlock
Change-Id: I0f7889db570717e9606425b51a418c499bd3a40a
2017-08-27osl: clarify osl_scheduleThread() documentationChris Sherlock
Change-Id: If9990acd06f5395c07d44fc462292ccae795abe1
2017-08-27osl: thread doxygen updateChris Sherlock
Change-Id: I345fdc1facd3eb38e2304f313c1eb67dc32b3608
2017-08-18loplugin:unnecessaryparenNoel Grandin
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Fix typosAndrea Gelmini
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-19osl: remove comment cruft osl/socket.hChris Sherlock
Change-Id: I785cc08e5450530f885b1bf38b50517029d6fb92
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-06-27Fix typosAndrea Gelmini
Change-Id: If4373f47fdf0ccfcbd490299f8b8d09e17bf92cd Reviewed-on: https://gerrit.libreoffice.org/39272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-25osl: document pipe functionalityChris Sherlock
Change-Id: I1b2fa0db88bf9b25283ff532f9634eb4605775c3 Reviewed-on: https://gerrit.libreoffice.org/39221 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-06-25osl: variety of doxygen fixesChris Sherlock
Change-Id: I48e4bcce447a1efdb37d6dca9e5808ec8d73492b
2017-06-25osl: document and group code via doxygenChris Sherlock
Change-Id: I9945df95e14fbca47f7cea80b1d4097d00a3eb54
2017-06-25osl: doxygen parblockChris Sherlock
Change-Id: Ica1b604484c855a94c9a21fab04d62c2f5952fe7
2017-06-25osl: remove @relates Condition, not relevantChris Sherlock
Change-Id: Ifabb961817b8c3cc326264bb9d9bb1c3a4e7e461
2017-06-25osl: the addr parameter of osl_mapFile is [in,out]Chris Sherlock
Change-Id: I29992bfecf50b5e6a185257b3df404bb474dd225
2017-06-23Fix typosAndrea Gelmini
Change-Id: I1348be80d3150966124a7f62134ecf3df01c659e Reviewed-on: https://gerrit.libreoffice.org/39158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-23osl: doxygen fixes for headersChris Sherlock
Change-Id: I3f30b5ab985c2ff709116568905b941c5d50fd1a
2017-06-23osl: document osl_mapFile parameters and return valuesChris Sherlock
Change-Id: I307662ef0d8360da3cbc7edc96890575715bbf07
2017-06-23osl: typo from last commitChris Sherlock
Change-Id: I3dce45da77c6ab21be5a999d4ea5b7944a07bbd7
2017-06-22osl: File map flag constants documentedChris Sherlock
Change-Id: I8f02cfdcaa1a5d2ce981b5de1b9754da36760649 Reviewed-on: https://gerrit.libreoffice.org/39124 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-06-12Fix typosAndrea Gelmini
Change-Id: Ib2ba32d48d3df16b0b20deea84416fe15a2d7176 Reviewed-on: https://gerrit.libreoffice.org/38650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-06add COVERITY_NOEXCEPT_FALSECaolán McNamara
to markup dtors that coverity warns might throw exceptions which won't throw in practice, or where std::terminate is an acceptable response if they do Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4 Reviewed-on: https://gerrit.libreoffice.org/38318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06Fix order of includes againStephan Bergmann
...after bfb978334cea775b8ae5c40ceea050ea0660d80a "osl: conditin.h and conditin.hxx doxygen updates" Change-Id: I63b6fefd2ed9a1c338e01f16c1efc1b6304103bc
2017-06-03osl: explain why in file.h a memory mapped file is "shared"Chris Sherlock
The original comment reads: Don't know what the "shared" is supposed to mean there? Also, obviously this API can be used to map *part* of a file into memory, and different parts can be mapped separately even. That's because memory mapped files can be used as a form of IPC that allows multiple processes to share data. Change-Id: I3cb34fcdb0a93233b22ac888712f9c1d650b30ea Reviewed-on: https://gerrit.libreoffice.org/38348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-06-01Fix typosAndrea Gelmini
Change-Id: I3cd50e374c45bc1c400b24c8fffd6d8f5cd1de56 Reviewed-on: https://gerrit.libreoffice.org/38208 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-29osl: conditin.h and conditin.hxx doxygen updatesChris Sherlock
Change-Id: Ibdfa34d2b3b93ba0b5d5211dd4f843d849375e64 Reviewed-on: https://gerrit.libreoffice.org/38100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-28osl: doxygen comment fixChris Sherlock
Change-Id: I6c3b732bd9abe5cab44347adf0d8bc19588f31b5 Reviewed-on: https://gerrit.libreoffice.org/38101 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-27osl: file.h comments clarification and minor formatting cleanupChris Sherlock
Change-Id: I1011665787ccec2500efc4492a9f19e53de3bf12 Reviewed-on: https://gerrit.libreoffice.org/38033 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-27osl: osl_setFilePos uHow and uPos parameter desc. are amazingly inaccurate!Chris Sherlock
Change-Id: Ie96f31b24b4f23ef72f12adee14dfe4092fc8e2b Reviewed-on: https://gerrit.libreoffice.org/37873 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-21osl: include/osl/file.h typo in commentChris Sherlock
Change-Id: I18b875e868706deaee2f50148233ec7219f89e07 Reviewed-on: https://gerrit.libreoffice.org/37863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-16Try to fix loplugin:comparisonwithconstant's rewrite-with-macros issueStephan Bergmann
...that had plagued 2e293a731c1559c9869dfcb32491bc600fc18e4e "new loplugin/rewriter comparisonwithconstant" (in sal/osl/unx/pipe.cxx), and auto-rewrite the remaining occurrences in sal (that the mentioned commit had failed to address, for whatever reason) Change-Id: I3dc3bae8dd92ba8bf576f6e06e7c9ee21f883661
2017-05-14osl: document file.hxx, swap order of E_ROFS and E_SPIPE to match file.hChris Sherlock
Change-Id: I085852e7c9fed285117f426e775f7ca2c123e4c0 Reviewed-on: https://gerrit.libreoffice.org/37594 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-12osl: document oslFileError enumerationChris Sherlock
Change-Id: I870ea69135ae293b00b9ae52f254d3f7f205a109 Reviewed-on: https://gerrit.libreoffice.org/37524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-12osl: file header comment clarificationChris Sherlock
Change-Id: I07aa1d2452dcdd891782707ae6928027e03f00e8 Reviewed-on: https://gerrit.libreoffice.org/37523 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-07osl: small fixes to file.h initial commentChris Sherlock
Change-Id: I51eeed1a9afc392c33e60d5cad784136adf28384
2017-05-03remove empty commentsNoel Grandin
found with: git ls-files | xargs grep -Pzl '/\*\* (\*|\s| )*\*/' Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597 Reviewed-on: https://gerrit.libreoffice.org/37159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I998e9b2ad8ebdcc983239192cb61f6689e378ad9 Reviewed-on: https://gerrit.libreoffice.org/35633 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-22Don't actually change OS-level locale with (unused) osl_setSystemLocaleStephan Bergmann
osl_setSystemLocale was introduced with af2938348bb539ccb27c92fe286b768d4143f662 "#88460# added osl_getProcessLocale and osl_setProcessLocale" but never actually used. So mark it as deprecated and, in the sal/osl/unx/ case, don't make it set the OS-level locale via imp_setProcessLocale (calling setlocale or setting the LC_ALL/LC_CTYPE/LANG env vars), same as in the sal/osl/w32/ case. Change-Id: I33348dba5de8ca80ca6fca210043286c0cfa9145
2017-03-19vcl: have AcquaSalInstance use osl::Condition instead of oslConditionChris Sherlock
Condition is deprecated already, but there is no need for the AcquaSalInstance class to use the low-level C-API, when in fact there is a C++ fascade that calls on this via the C++ abstraction, osl::Condition. This will make it much easier to switch to using std::condition_variable in the future. Change-Id: Ic495c4120a59480bf50a8c5b73608874fc4228ea Reviewed-on: https://gerrit.libreoffice.org/35392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-18Typo: sucess->success + "adminsitrator" fixJulien Nabet
Change-Id: I42fdb0a60b987af92e0433e7ff0e5754bc1da748 Reviewed-on: https://gerrit.libreoffice.org/35412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18osl: removed extraneous <BR> tag from conditn.hChris Sherlock
Change-Id: I7cfcef8b825ab1f0cc2fcd55bda19b2981a972d5