Age | Commit message (Collapse) | Author |
|
...which had been left out because "lots of our code uses this style, which I'm
loathe to bulk-fix as yet", but now in
<https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have
caused an otherwise innocent-looking code change to trigger a
loplugin:unnecessaryparen warning for
pFormat = (pGrfObj)
? ...
(barring a change to ignoreAllImplicit in
compilerplugins/clang/unnecessaryparen.cxx similar to that in
<https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in
loplugin:simplifybool consistent", which should also have caused the warning to
disappear for the modified code, IIUC).
Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2
Reviewed-on: https://gerrit.libreoffice.org/45088
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0
Reviewed-on: https://gerrit.libreoffice.org/44944
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change these back to consistently use the "..." form to include other UNO API
include files, for the benefit of external users of this API.
Change-Id: I9c9188e895eb3495e20a71ad44abfa2f6061fa94
|
|
Change-Id: I2fd3fb7b67a62d349ff917466b08c75c19dcbff6
|
|
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb
Reviewed-on: https://gerrit.libreoffice.org/41874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ie7de4fb82a6e5162bb1732baaa742f1943559ce6
|
|
Change-Id: I4a288699f2b313d7519554d7a66dc5f591c8767b
Reviewed-on: https://gerrit.libreoffice.org/41613
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I3097ef16912f72b59f0759d8826068cbb9b00ec2
Reviewed-on: https://gerrit.libreoffice.org/41606
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I4299433ec30ee5d102750b41e8cc6e82e4530a59
|
|
Change-Id: I6f4904d415a44ba20ec0a9bfea9876c50eedb968
|
|
Change-Id: I0f7889db570717e9606425b51a418c499bd3a40a
|
|
Change-Id: If9990acd06f5395c07d44fc462292ccae795abe1
|
|
Change-Id: I345fdc1facd3eb38e2304f313c1eb67dc32b3608
|
|
look for statements like
return (function());
Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3
Reviewed-on: https://gerrit.libreoffice.org/41260
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3
Reviewed-on: https://gerrit.libreoffice.org/41194
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I785cc08e5450530f885b1bf38b50517029d6fb92
|
|
std::unary_function is deprecated since C++11 and removed in C++17
90% done with regexp magic.
removed obsolete <functional> includes.
The std::unary_function base class was used in 3 places:
* chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole
is used in a std::not1 function helper who uses the members
return_type and argument_type.
- replace deprecated std::not1 with a lambda
* chart2/source/tools/ModifyListenerHelper.cxx:
lcl_weakReferenceToSame used the argument_type member in the
operator() parameter.
- inline the parameter type.
* xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement
used result_type and argument_type in operator().
- inline the types
Also fix compile error with gcc about finding std::for_each.
Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f
Reviewed-on: https://gerrit.libreoffice.org/39358
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: If4373f47fdf0ccfcbd490299f8b8d09e17bf92cd
Reviewed-on: https://gerrit.libreoffice.org/39272
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I1b2fa0db88bf9b25283ff532f9634eb4605775c3
Reviewed-on: https://gerrit.libreoffice.org/39221
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I48e4bcce447a1efdb37d6dca9e5808ec8d73492b
|
|
Change-Id: I9945df95e14fbca47f7cea80b1d4097d00a3eb54
|
|
Change-Id: Ica1b604484c855a94c9a21fab04d62c2f5952fe7
|
|
Change-Id: Ifabb961817b8c3cc326264bb9d9bb1c3a4e7e461
|
|
Change-Id: I29992bfecf50b5e6a185257b3df404bb474dd225
|
|
Change-Id: I1348be80d3150966124a7f62134ecf3df01c659e
Reviewed-on: https://gerrit.libreoffice.org/39158
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I3f30b5ab985c2ff709116568905b941c5d50fd1a
|
|
Change-Id: I307662ef0d8360da3cbc7edc96890575715bbf07
|
|
Change-Id: I3dce45da77c6ab21be5a999d4ea5b7944a07bbd7
|
|
Change-Id: I8f02cfdcaa1a5d2ce981b5de1b9754da36760649
Reviewed-on: https://gerrit.libreoffice.org/39124
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: Ib2ba32d48d3df16b0b20deea84416fe15a2d7176
Reviewed-on: https://gerrit.libreoffice.org/38650
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
to markup dtors that coverity warns might throw exceptions
which won't throw in practice, or where std::terminate is
an acceptable response if they do
Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4
Reviewed-on: https://gerrit.libreoffice.org/38318
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...after bfb978334cea775b8ae5c40ceea050ea0660d80a "osl: conditin.h and
conditin.hxx doxygen updates"
Change-Id: I63b6fefd2ed9a1c338e01f16c1efc1b6304103bc
|
|
The original comment reads:
Don't know what the "shared" is supposed to mean there? Also,
obviously this API can be used to map *part* of a file into
memory, and different parts can be mapped separately even.
That's because memory mapped files can be used as a form of IPC
that allows multiple processes to share data.
Change-Id: I3cb34fcdb0a93233b22ac888712f9c1d650b30ea
Reviewed-on: https://gerrit.libreoffice.org/38348
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I3cd50e374c45bc1c400b24c8fffd6d8f5cd1de56
Reviewed-on: https://gerrit.libreoffice.org/38208
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ibdfa34d2b3b93ba0b5d5211dd4f843d849375e64
Reviewed-on: https://gerrit.libreoffice.org/38100
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I6c3b732bd9abe5cab44347adf0d8bc19588f31b5
Reviewed-on: https://gerrit.libreoffice.org/38101
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I1011665787ccec2500efc4492a9f19e53de3bf12
Reviewed-on: https://gerrit.libreoffice.org/38033
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ie96f31b24b4f23ef72f12adee14dfe4092fc8e2b
Reviewed-on: https://gerrit.libreoffice.org/37873
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I18b875e868706deaee2f50148233ec7219f89e07
Reviewed-on: https://gerrit.libreoffice.org/37863
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
...that had plagued 2e293a731c1559c9869dfcb32491bc600fc18e4e "new
loplugin/rewriter comparisonwithconstant" (in sal/osl/unx/pipe.cxx), and
auto-rewrite the remaining occurrences in sal (that the mentioned commit had
failed to address, for whatever reason)
Change-Id: I3dc3bae8dd92ba8bf576f6e06e7c9ee21f883661
|
|
Change-Id: I085852e7c9fed285117f426e775f7ca2c123e4c0
Reviewed-on: https://gerrit.libreoffice.org/37594
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I870ea69135ae293b00b9ae52f254d3f7f205a109
Reviewed-on: https://gerrit.libreoffice.org/37524
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I07aa1d2452dcdd891782707ae6928027e03f00e8
Reviewed-on: https://gerrit.libreoffice.org/37523
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I51eeed1a9afc392c33e60d5cad784136adf28384
|
|
found with:
git ls-files | xargs grep -Pzl '/\*\*
(\*|\s|
)*\*/'
Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597
Reviewed-on: https://gerrit.libreoffice.org/37159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I998e9b2ad8ebdcc983239192cb61f6689e378ad9
Reviewed-on: https://gerrit.libreoffice.org/35633
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
osl_setSystemLocale was introduced with af2938348bb539ccb27c92fe286b768d4143f662
"#88460# added osl_getProcessLocale and osl_setProcessLocale" but never actually
used. So mark it as deprecated and, in the sal/osl/unx/ case, don't make it
set the OS-level locale via imp_setProcessLocale (calling setlocale or setting
the LC_ALL/LC_CTYPE/LANG env vars), same as in the sal/osl/w32/ case.
Change-Id: I33348dba5de8ca80ca6fca210043286c0cfa9145
|
|
Condition is deprecated already, but there is no need for the
AcquaSalInstance class to use the low-level C-API, when in fact there
is a C++ fascade that calls on this via the C++ abstraction,
osl::Condition.
This will make it much easier to switch to using std::condition_variable
in the future.
Change-Id: Ic495c4120a59480bf50a8c5b73608874fc4228ea
Reviewed-on: https://gerrit.libreoffice.org/35392
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I42fdb0a60b987af92e0433e7ff0e5754bc1da748
Reviewed-on: https://gerrit.libreoffice.org/35412
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I7cfcef8b825ab1f0cc2fcd55bda19b2981a972d5
|