summaryrefslogtreecommitdiff
path: root/include/sal
AgeCommit message (Collapse)Author
2017-04-07tdf#106237 sw: do some basic sanity checking on layout-cacheMichael Stahl
The bugdoc, with claimed generator AOO4.1.1 on Windows, contains a bogus layout-cache: debug:26706:1: nType P nIndex 29 2147483647 debug:26706:1: nType P nIndex 66 2147483647 debug:26706:1: nType P nIndex 105 2147483647 debug:26706:1: nType P nIndex 142 2147483647 debug:26706:1: nType P nIndex 178 2147483647 debug:26706:1: nType P nIndex 205 2147483647 debug:26706:1: nType P nIndex 229 2147483647 debug:26706:1: nType T nIndex 314 65535 Due to a loop-control this causes incorrect pagination if CalcLayout() is called only once. It should look like this: debug:26765:1: nType T nIndex 382 65535 debug:26765:1: nType T nIndex 790 65535 In this case we can easily detect that the indexes and types in the layout-cache are bogus by checking against the node types, so do that in SwLayHelper::SwLayHelper(). (cherry picked from commit 8a5374f2fdbd1e15c107133f55930cbc431edbd5) sw: [loplugin:sallogareas] (cherry picked from commit 282b3e8c4d45aacae57e3542b872cdbfebcc7195) loplugin:loopvartoosmall (cherry picked from commit dbaab58c1442e7f62ef0732376fe5a49840e9fd6) Change-Id: I7091af49a8c29bf0a11ceff0be9ba84b1f710fdb Reviewed-on: https://gerrit.libreoffice.org/36046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 137ad218db262fb3531215adbc88b7093b4999c7)
2017-04-04LOK - Calc: row/column headers are updated fasterMarco Cecchetti
Now the computation of the row/column headers data exploits the cached row/col positions in HeightHelper/WidthHelper. That makes updating row/column headers at the bottom of the document as fast as at the top even for very big spreadsheets. Change-Id: Ida0ed8d8885b71fe3206efbdaa62a0bb95153ed7
2017-04-04LOK - Calc: document size as sum of row heights/col widths in pixelMarco Cecchetti
Grid lines, cursor overlay, row/col headers are all computed by summing up row heights / col widths converted to pixels. On the contrary the document size was converted to pixel only at the end after having summed up heights/widths in twips. All that lead to have a document height/width greater than the position of the last row/col, with the scrolling in online going unplesantly far beyond the last row/column. This patch change the way the document size is computed, so that the spreadsheet height/width matches the position of the last row/column. Moreover it exploits the cache-like structure for row/col positions introduced in a previous commit. Change-Id: I2e7b0e9601653856f88d1e5f9791aaec271592dc
2017-04-04LOK - Calc: a cache-like structure for row/col positions in the documentMarco Cecchetti
ScPositionHelper provides the ability to insert (and remove) row- position pairs where the position is in pixel and related to the spreadsheet top. In this way one can compute a new row position by starting from the nearest row presents in this cache-like structure. It offers also the ability to invalidate the cache by removing all cached data below a given row or position. This data structure can be used for columns, too. Change-Id: I89c62b81fe9ae685ee84c33a128893c960ebd27e
2017-02-01ofz: tidy up eps preview importCaolán McNamara
a) check that the remaining stream length is >= the 14 bytes that are unconditionally skipped b) make the initial security count the min of the arbitrary 100 and the remaining stream len less that 14 bytes c) tweak ImplGetNumber not to reduce nSecurityCount if its already 0 Change-Id: Ifffa6d02d492affd578fb48007704457ad635b39 (cherry picked from commit 94ffb720b889c51665ebb789d84aee3b3bacb456) ofz: check eps seeks are sane and succeeded Change-Id: I0eb45e1c1ffd91682ed0ce6a6a74eab54666d715 (cherry picked from commit f85fb724d52a0fff9c64365cd202ae8975492c05) ofz: check if the stream is able to meet the eps len claim before reading Change-Id: I65407bffb67449e203b8ead23554a4e88387d214 (cherry picked from commit e17a34e957c21a8cd2977b1b0e1c9a427c244aed) ofz: check if the stream is able to meet the eps len claim before reading Change-Id: I440c7f38d6588c570a411f2a97c0164e5d7d646f (cherry picked from commit d1f31681623696e99b0bd9e98570cb1ebac518cc) make this a little more readable Change-Id: I83b6b0bd636b639ce0892f22f216410ce79dee03 (cherry picked from commit cf06348d9d4be8b8460d202cebf0d995fd4f6abf) move deref inside (laughable) nSecurityCount check Change-Id: Idf9a83ffa80137967d8c77d7a9b5133529fc2858 (cherry picked from commit 521723b1180a32c02a88ed47137d4242c06eaca7) Reviewed-on: https://gerrit.libreoffice.org/33634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-01safemode: Add option to disable H/W accelerationSamuel Mehrbrodt
Change-Id: Ic6751717c14d317b5a4bc64c4fd1cf2b2f5efabf Reviewed-on: https://gerrit.libreoffice.org/30112 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-28Various loplugin warnings in --enable-telepathyStephan Bergmann
Change-Id: I4c437491466c3029f2a9c93fb630c7b5a8d2ff21
2016-10-16clang-cl loplugin: dtransStephan Bergmann
Change-Id: I1d55f3e7ecbde486f318d5175b1570f0caa33255 Reviewed-on: https://gerrit.libreoffice.org/29870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-12xmlsecurity: add initial Executable_pdfverifyMiklos Vajna
We have code to verify ODF and OOXML signatures, this adds initial support for verifying a PDF signature. Initially this is a standalone executable, need to turn this into a unit test + hook it into sfx2 in follow-up commits. Change-Id: Ideb5ec63f761c74fd4527cf1766b0aa739e275ee
2016-10-04clang-cl loplugin: salStephan Bergmann
Change-Id: If04d3f07dc8bffac8887773b5424c09848cd8f1a Reviewed-on: https://gerrit.libreoffice.org/29404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-20[API CHANGE] Remove HAVE_GCC_VISIBILITY_FEATURE, always trueStephan Bergmann
* GCC documents -fvisibility at least as far back as the GCC 4.0 online documentation at <https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>. * For external code, odk/settings/settings.mk unconditionally set HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows. Make this a fatal configure error for now. The check should be removed completely after LO 5.3 branch-off. Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112 Reviewed-on: https://gerrit.libreoffice.org/29073 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-05tdf#43157 - Clean up OSL_ASSERT, DBG_ASSERT, etc.Gökhan Gurbetoğlu
Change-Id: I8114e338451b5b2e79b2318f558cbd075f024f08 Reviewed-on: https://gerrit.libreoffice.org/28584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-29Add SAL_INFOs to dump the SwPageFrame lifecycleJan-Marek Glogowski
Debug area name is "sw.pageframe". Change-Id: I136cc8192137a8c682900a6ce2c557f6b6b3a6cd
2016-08-18If no WARN in SAL_LOG, use the INFO selection for WARNs, tooTor Lillqvist
Often the choice whether some particular message is displayed with SAL_INFO or SAL_WARN has not necessarily been that well thought through. Many SAL_WARNs are not actually warnings but purely informative. If you want to see the INFOs for an area it makes sense to want to see also the WARNs for it. So make it so, unless a specific WARN selection is specified. Change-Id: I6286c5f856b29e68bedb7f20efadf56953f94b72
2016-08-18Add handling of a +RELATIVETIMER flag in the SAL_LOG environment variableTor Lillqvist
Outputs a timestamp in decimal seconds (with millisecond accuracy). Simplified the handling of SAL_LOG if no "level" is specified. Now just a totally unset (or empty) SAL_LOG causes the default of "+WARN" to be used. Given how the code works, it would have become too unwieldy to check for all combinations of TIMESTAMP and RELATIVETIMER but no WARN or INFO. Change-Id: I7bb5bb665d4e764e7eee447e93486f6467042e97
2016-08-18Mention what negative or multiply specified flags mean (nothing special)Tor Lillqvist
Change-Id: I8ac1839aab3438aa685aa8cdab2e972447352599
2016-08-18Add handling of a +TIMESTAMP flag in the SAL_LOG environment variableTor Lillqvist
Change-Id: I9bdcd8b2d7b46a087d7f5461b6f7c3d9f02ec084
2016-07-13Remove unused log-areaStephan Bergmann
Change-Id: I4a11f040bb56de0bc761b185395dc87533c3bf01
2016-07-13Sort listsStephan Bergmann
Change-Id: I5bfbc8dbba63531ddb05e40e94f626aa5c86071d
2016-07-07GSoC Writer Table Styles ImportJakub Trzebiatowski
This patch is implementing import of table styles (table-template). Modified shared code: Added "background" to the cell styles export. To make cell export properties map accessible by both export and import code, moved from xmloff/source/table/XMLTableExport.cxx to xmloff/txtprmap.hxx. To avoid export of default valued properties implemented XPropertyState for SwXTextCellStyle Change-Id: I8b4f12e4b51f478f8ce8fde1203cd4611d7ae852 Reviewed-on: https://gerrit.libreoffice.org/26721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-27Bin unused log areaTor Lillqvist
Change-Id: I40f2364bd4941941a8766bc492e303e56c9e4256
2016-06-23Remove unused SfxObjectShell::libreOfficeKitCallback()Miklos Vajna
All clients have been converted to use SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: I793dad5194769f331037b12a1b1afba96ddea4ba Reviewed-on: https://gerrit.libreoffice.org/26584 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-18uitest: loplugin:sallogareasMarkus Mohrhard
Change-Id: Ieb01166fbb0b07d1218072ae8bb953a36582361c
2016-06-18uitest: plugin:sallogareasMarkus Mohrhard
Change-Id: Ib0ebd774542129f8a7c68e276f1f03cc46f32fb8
2016-06-13loplugin:sallogareasNoel Grandin
Change-Id: I6ce045db236b81aa8bc7bce2a0e20c4132c5931f
2016-06-13loplugin:sallogareasStephan Bergmann
Change-Id: Ib28e76ed6947431c6466d11aaadca8d95abfc275
2016-06-06loplugin:sallogareasMichael Stahl
Change-Id: Id9204f2499bd995f36c5962da56a6d486fe4ca59
2016-06-06Revert "loplugin:sallogareas"Stephan Bergmann
This reverts commit 94e6d9d0667781fc733bd18d7cf2b81d4a5366cb, which wasn't necessary after 69c997428b748357918994ae1b0e2dbd052687d0 "loplugin:sallogareas".
2016-06-06loplugin:sallogareasNoel Grandin
Change-Id: Id285f7b7f100f7bfd21ca786ef260243aad35825
2016-05-30use the existing URL to path toolsMarkus Mohrhard
Change-Id: I20aa47556205f5efc70f8f5ea39c63009110f986 Reviewed-on: https://gerrit.libreoffice.org/25646 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-08Updated file path.Andrea Gelmini
Since commit 6c7659b584ea7ed3652ca4eb9a2297f36310c365 the new path is include/sal/types.h Change-Id: I742ea2f6df06ff7345f3bbed0c90af13acafdbd7 Reviewed-on: https://gerrit.libreoffice.org/24718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-06loplugin:sallogareasTor Lillqvist
Change-Id: I4ca21392f38d1ab567e87d6f231641993c0e862c
2016-05-03Trivially improve sal/types.h code indentationStephan Bergmann
...to trigger rebuilding of PCH on Windows after e16fa715c43dcdf836ce8c400b6d54eae87b627d "Handle wchar_t as native C++11 type on windows" Change-Id: Ia1cafb8a2f207f34b6fb1cb53fbaf23d90e6b296
2016-04-27Improve documentationStephan Bergmann
Change-Id: I13683f971bf56f6c5e226d749e60ccb25af559a5
2016-04-14loplugin:sallogareasStephan Bergmann
Change-Id: I220735e76174438d18929a9a92e289933c12fb0c
2016-04-07tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I disentangled my previous patch and converted fprintf statements to SAL_INFOs Change-Id: I4b993e00f82bdf904586ab5e7c954c4ee3ff1bac Reviewed-on: https://gerrit.libreoffice.org/22925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-11tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 and made sure that it doesn't break the build Change-Id: I9febeed949a24d7bc5afb13dedde03fd812b5b20 Reviewed-on: https://gerrit.libreoffice.org/23077 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-08tdf#91794: Remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
Updates pointed by sberg Change-Id: Ie12548dfa9ad3a6836efbfe64153bc075f138fc6 Reviewed-on: https://gerrit.libreoffice.org/22622 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08Keep entries sorted (and no need for a @section here)Stephan Bergmann
Change-Id: I356a6bde62d883adf4cfa9e34e87791eee9668ca
2016-03-08tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I removed the fprintf statements and replaced them with SAL_WARN statements. Change-Id: Id75e310e3a95b249fdf92a4dd5a9bcf1b7fb9be6 Reviewed-on: https://gerrit.libreoffice.org/22984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-04clang-cl: Enable more warnings etc. (like in the Clang/GCC case)Stephan Bergmann
Change-Id: Ia1fb09b89d3ccc3c7f4a11799f0d8eac99c6c7a9
2016-03-04Use existing "sal.osl" log areaStephan Bergmann
Change-Id: I7d48c1543b0d3239c8e646ca0765421f933cfecc
2016-03-04sal/test/testbootstrap.cxx is dead test codeStephan Bergmann
...so no need to add dead log areas here (as questionably introduced with f59136a2ed1e3eb01cc5b62c5a7da07c34cbdfae "tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals") Change-Id: Id0544a76f9c426bc06e327f0f2ec2d421da1fa50
2016-03-04This is test code, OK to unconditionally print to stdoutStephan Bergmann
...and where appropriate use CPPUNIT_ASSERT_EQUAL to have no need to always print out certain values Change-Id: Iad2ccb235b09852fffd3f010cf069c45b36e2d4b
2016-03-04This is test code, OK to unconditionally print to stdoutStephan Bergmann
Change-Id: I419aba8728b3a65fca69c82a4f950daaf4815187
2016-03-03tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
Change-Id: If329cf8257684e7bd2936641b8f14ec3e9b9f733 Reviewed-on: https://gerrit.libreoffice.org/22647 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-02-25sw: new sw.a11y log areaMichael Stahl
Change-Id: I43b6b60ac91c7934d4045b8df618dc6592c0e688
2016-02-23Various loplugin warningsStephan Bergmann
Change-Id: I6489043ee629e1f411f303c1c43a00975aacf5c4
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-06-13 09:58:10 +0000