summaryrefslogtreecommitdiff
path: root/include/sfx2/sidebar
AgeCommit message (Collapse)Author
2018-03-27tdf#115786: Fix reopening undocked sidebarKatarina Behrens
while trying hard to keep tdf#88241 fixed. Had to introduce yet another bool variable as now that previously active sidebar deck is remembered (= it is visible when floating window opens) it's impossible to tell whether sidebar was already opened or not Change-Id: If2c9edfa2f9beb400537b106d3094f256b0cc183 Reviewed-on: https://gerrit.libreoffice.org/51866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-19tdf#115806: Remember last active deck also on context switchKatarina Behrens
within 1 application Change-Id: Icab6dea9f9a7895732c41e6d96b9d4546cf0001f Reviewed-on: https://gerrit.libreoffice.org/51530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-05tdf#115434 Fix key press misbehaviors in sidebarJim Raykowski
This patch also is for tdf#98505 and tdf#84657 Change-Id: I6bc125ace035b2c8126f013a63bcc9498b06e08c Reviewed-on: https://gerrit.libreoffice.org/49219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-03loplugin:passstuffbyref more return improvementsNoel Grandin
slightly less restrictive check when calling functions Change-Id: I35e268ac611797b1daa83777cda02288a635aa32 Reviewed-on: https://gerrit.libreoffice.org/47259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-27loplugin:passstuffbyref improved return in xmloff,sfx2Noel Grandin
Change-Id: I7161dfca77f944027bd20614616e22d6acfa27cd Reviewed-on: https://gerrit.libreoffice.org/47081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-10tdf#113725: Sidebar: Controls are crammed in Slide content panelTamás Zolnai
Need to trigger a layouting to get the right panel size after we show / hode context related items. Change-Id: I791921ecb491bb65c53a4fe9562207d47f66a88a Reviewed-on: https://gerrit.libreoffice.org/44565 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-24loplugin:finalclasses in sfx2..svlNoel Grandin
Change-Id: I71b78135b3d0259657438c4401340bb35ab5c6e0 Reviewed-on: https://gerrit.libreoffice.org/43742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: sfx2Stephan Bergmann
Change-Id: I5e9a7a2580a710880023288f5ed3584708c4769d
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-21tdf#67770: Read/writer LastActiveDeck bitsKatarina Behrens
Change-Id: Id5e3c3cb4144b9fc56ab5e4a4e49f1fc69e70023 Reviewed-on: https://gerrit.libreoffice.org/43493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-16Make include/sfx2 include files found through global -IincludeStephan Bergmann
...instead of implicitly next to the including file, in preparation of loplugin:includeform Change-Id: If5025f2a91bf6f1ef5482a57dbfe4f02327cbdbc
2017-10-08Make Color a forward declarationChris Sherlock
Change-Id: Ib28833555661b119de8e967b05e3c8691fca826a Reviewed-on: https://gerrit.libreoffice.org/43227 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-09-18msCommandName in ControllerItem is unusedNoel Grandin
ever since commit 1c5cae479bebd2d325182adc2c9821fd948fd1bd Date: Thu Apr 20 08:44:33 2017 +0200 loplugin:unusedmethods Change-Id: I7c02e8bf0ef377303dedf4e6690fd937f52a3605
2017-07-21loplugin:constparams in sfx2Noel Grandin
Change-Id: Id982c8fb5654433e9db10e2da6a86a6c8d90b9b4 Reviewed-on: https://gerrit.libreoffice.org/40261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12cleanup unused css/frame/* includesJochen Nitschke
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03remove unused includesJochen Nitschke
from <com/sun/star/frame/XFrame.hpp> we only use <.../XComponent.hpp> Change-Id: I5e3daf848e52cff62e10f9b5e91106894e16a175 Reviewed-on: https://gerrit.libreoffice.org/37160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28loplugin:unusedfieldsNoel Grandin
Change-Id: I67a0372d6982648717651f736c51e447d0b7d6a2 Reviewed-on: https://gerrit.libreoffice.org/37047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26loplugin:unusedmethodsNoel Grandin
Change-Id: If2e1241bbe8a3d17859e3ca076b0f55f25c48ea5 Reviewed-on: https://gerrit.libreoffice.org/36983 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-02-15Related: tdf#105672 Load toolbar properties from .uiMaxim Monastirsky
- Supports toolbar-style, icon-size, orientation. - Defaults are: toolbar-style = icons only icon-size = what's set in Tools > Options... for Sidebar/Notebookbar orientation = horizontal - Remove no longer needed BigToolBox (use toolbar-style=both + icon-size=3 instead). Change-Id: I185388255a351dfd6719a363b7e399bf36b0b25d Reviewed-on: https://gerrit.libreoffice.org/34281 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-07tdf#104870 - keep reference on the TitleBar while setting title.Michael Meeks
Unlikely to fix the issue, but may help. Change-Id: I3c319f550e86f2ab731b072d86d258dca12d34fa Reviewed-on: https://gerrit.libreoffice.org/33998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-01-31Resolves: tdf#104884 print preview replaces the frame controllerCaolán McNamara
so the sidebar is listening to the old controller which has been disposed[1] so when print preview exits and yet another controller replaces the print preview one then the sidebar still doesn't listen to the current one. framework broadcasts COMPONENT_DETACHING/COMPONENT_REATTACHED around these changes, so if we listen to them we can keep attached to whatever is the current component [1] note that ContextChangeEventMultipler doesn't inform clients that the controller has been disposed, this remains unchanged here Change-Id: I141509d4a262307afd7dcfc3d77de6cdd6dbfa5f Reviewed-on: https://gerrit.libreoffice.org/33758 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor sfx2..storeNoel Grandin
Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf Reviewed-on: https://gerrit.libreoffice.org/33514 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21ODR violation (base class must be the same across compilation units)Stephan Bergmann
Change-Id: I2aa5fefad978f50f5166d75bbcfb25d88780d03d
2016-12-20Don't use 'this' in ctorStephan Bergmann
Change-Id: I405160743609aae92a37b2359bea5aa42ee66519
2016-12-20ODR violationStephan Bergmann
Change-Id: Ia56bd463c83c0aedcc7f4e9cf1b65c57104d78f2
2016-12-06cleanup unused includes (related to tdf#88206)Jochen Nitschke
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only implbase*.hxx stuff is used. Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995 Reviewed-on: https://gerrit.libreoffice.org/31686 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-22loplugin:countusersofdefaultparams in include/sfx2Noel Grandin
Change-Id: I8b5e3ebbfb715d0b6aec2c4137f0ff524b63227e Reviewed-on: https://gerrit.libreoffice.org/31065 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-07we don't need the code, but we need the images in the src fileCaolán McNamara
apparently so they can be found at postprocess time and inserted into the image zips for the use of the pngs by other consumers Change-Id: Ib45834da69462109fdf7502176a6f4721057d980
2016-10-07Revert "SidebarResource doesn't do anything useful"Caolán McNamara
This reverts commit e9886d32923e5fa3995f44701f27148f59df5c0f.
2016-10-06SidebarResource doesn't do anything usefulCaolán McNamara
Change-Id: Id716c9f9caa1a1e4f8ae0e7e05837bebdec4335a
2016-10-06drop now unused sfx2/sidebar/ResourceDefinitions.hrcCaolán McNamara
Change-Id: I151a37a37435a44e7331d957bd9d36f84cdf8677
2016-10-05drop unused heipids and resourcesCaolán McNamara
Change-Id: I354f960e52d2d0345669600726c49e30641392e4
2016-10-05remove various unused hrc defines and headersCaolán McNamara
Change-Id: If0b47fbe1f01d84697a0c25b82ca031c32fca66e
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-29tdf#88206 replace cppu::WeakImplHelper* in sfx2 and svlJochen Nitschke
some fallout in include/editeng/unotext.hxx which uses WeakAggImplHelper1 from implbase1.hxx Change-Id: I7237c46c1eb17752c63eeddc6a3aee41788fbbd2 Reviewed-on: https://gerrit.libreoffice.org/29374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22loplugin:unusedmethods in chart2..svxNoel Grandin
Change-Id: Ifb6045885049733415895f58cdd911256f48323c Reviewed-on: https://gerrit.libreoffice.org/29187 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15loplugin:countusersofdefaultparams in vclNoel Grandin
Change-Id: I046e6f16c5b171a06e2be2da2f72340634f3e979 Reviewed-on: https://gerrit.libreoffice.org/28891 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-05convert ToolBoxButtonSize to scoped enumNoel Grandin
Change-Id: I365b0e34361eb339b04e5f4792f54eff5bf582a5
2016-08-31loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I697b9081424acdc61107709392baa8af8ce29028 Reviewed-on: https://gerrit.libreoffice.org/28497 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-22GSoC: tdf#101249 Toolbar Mode switchingSzymon Kłos
+ added registry entry for storing current toolbar mode for each application + registry entries to store toolbar mode configuration, remember additional visible toolbars activated by user + changing toolbar mode hides and shows suitable toolbars + added menu controller for toolbar mode + notebookbar implementation entries are disabled when notebookbar mode is not active + each mode can open/collapse the sidebar Change-Id: I2b03f87c6dce53190d12102892d9ad30fbfd3bf6 Reviewed-on: https://gerrit.libreoffice.org/27991 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2016-08-17GSoC notebookbar: BigToolBoxSzymon Kłos
+ New container: sfxlo-BigToolBox + Writer: Paste button with dropdown menu Change-Id: I8fa9ff2cbf594078cc2347bef790b8647ce4e6ea Reviewed-on: https://gerrit.libreoffice.org/28156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2016-08-16GSoC notebookbar: icon size switchingSzymon Kłos
+ added entry in the Options > View + changed sfxlo-SidebarToolBox to sfxlo-NotebookbarToolBox in the Notebookbar ui files Change-Id: Id5719953be9830b650af96d54e63936c553cda74 Reviewed-on: https://gerrit.libreoffice.org/28169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>