summaryrefslogtreecommitdiff
path: root/include/sfx2
AgeCommit message (Collapse)Author
2021-10-11Related: tdf#145033 don't print "There is no implementation..." warningCaolán McNamara
don't output "There is no implementation for QueryValue for this item!" for SfxObjectItem Change-Id: Ib4b944efa7e9d152d662ed447d8c02ec24d58391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123392 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-11loplugin:moveparam in sfx2Noel Grandin
Change-Id: I5408e47d6e2179bc34170c1728aa16e327ffbe56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123380 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-01loplugin:constmethodNoel Grandin
Change-Id: I3ed657c5c5e6840e38e3c8505505b4b372125df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122910 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-30loplugin:constparams improve handling of pointer paramsNoel Grandin
Change-Id: I4c0002e72703eded435bfe4985f5b0121bf8524b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-28vcl: rename OutDevState to StackChris Sherlock
I have moved the header file to include/vcl/rendercontext as this will eventually be part of the RenderContext split from OutputDevice. State and associated enums have also been moved to the vcl namespace. I have also moved ComplexTextLayoutFlags into the vcl::text namespace. Change-Id: I0abbf560e75b45a272854b267e948c240cd69091 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121524 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-23Removed duplicated includeAndrea Gelmini
Change-Id: Ifa2276fae35818f759f51a22b5c873130d885459 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122495 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-22Extend loplugin:stringviewparam to starts/endsWith: sfx2Stephan Bergmann
Change-Id: Icac2c5877059208ed348aa824071803e415f374f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122482 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-22Improve UX writing on Start CenterAdolfo Jayme Barrientos
Good UX writing shouldn’t try too much to explain an UI, and directional language like “from the left side” doesn’t make sense for users of RTL languages or screen readers. Change-Id: Ibc5b6982d4686248de09ec1b2ad2a94b9b012f67
2021-09-20clean up ambiguous confusing rectangle APIs like IsInside()Luboš Luňák
Reading 'rectA.IsInside( rectB )' kind of suggests that the code checks whether 'rectA is inside rectB', but it's actually the other way around. Rename IsInside() -> Contains(), IsOver() -> Overlaps(), which should make it clear which way the logic goes. Change-Id: I9347450fe7dc34c96df6d636a4e3e660de1801ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122271 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2021-09-15loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ia7617a0fd4413cbaafaae8fbfee2b2ea819fde8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-13sw: prefix members of SwChapterNumRules, SwDBConfig, SwGlossaryList and ...Miklos Vajna
... SwModule See tdf#94879 for motivation. Change-Id: I0bf6d2cf5fdaed76eadc801d654a2cea7700f046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122018 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-09-12Typo: SAVE_SUCCESSFULL->SAVE_SUCCESSFULJulien Nabet
Change-Id: I4b50e1f5ca55e756f1fd0028287eeb0c9b96439a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121962 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-11clang:optin.performance.Padding in sfx2Noel Grandin
Excessive padding in 'class SfxControllerItem' (10 padding bytes, where 2 is optimal). Excessive padding in 'struct SfxChildWinInfo' (11 padding bytes, where 3 is optimal). Excessive padding in 'struct SfxChildWinFactory' (12 padding bytes, where 4 is optimal). Excessive padding in 'class SfxChildWindow' (10 padding bytes, where 2 is optimal). Change-Id: I435cfcf8a199bcab4612d671e1900ba659b8e383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09merge ThumbnailView and ThumbnailViewBaseCaolán McNamara
only ThumbnailView inherits directly from ThumbnailViewBase and it will simplify a11y if ThumbnailView instead of ThumbnailViewBase is available Change-Id: I715faa3f9b2cec68c1de07479b7d1dbbd9ddbcc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-07vcl: rename PrinterOptions to vcl::printer::OptionsChris Sherlock
Move Options to own source and header files. Options moved to own source and header files, however also put Options into vcl::printer namespace. I have renamed and moved PrinterOptions into the vcl::printer namespace because the word "Printer" is redundant, and we want to organize the vcl namespace better. Change-Id: I2ef188af381dd65907d48f7b190e4ab69417606d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121389 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-09-02unused definesNoel Grandin
Change-Id: I494e64c69decb9fb3d5b13ffc2f18d99f6b7749f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-01tdf#142458 minimal width not including extra width needed by scrolledwindowCaolán McNamara
its only including the width of the panels and not the extra space possibly required by the container window. Which is 2x the m_nBorderWidth of 1pixel of VclScrolledWindow in this case. Change-Id: I56775c7183d7a8b87af263ddc8bb17373779e9ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121390 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31flatten SfxObjectShellArr_ImplNoel Grandin
Change-Id: I97e3ea18ce17c63ae95d7755a32c602b88373370 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31flatten SfxViewShellArr_ImplNoel Grandin
Change-Id: I781f877b0c94fdd667b4fd00342e68b35b127867 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31flatten SfxViewFrameArr_ImplNoel Grandin
Change-Id: I1d9b0e117a08ddafe56546a58e536b76529966fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31flatten SfxTbxCtrlFactArr_ImplNoel Grandin
Change-Id: I422aeeb446a49fa4449eabe0c3643f125856db12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121330 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31flatten SfxStbCtrlFactArr_ImplNoel Grandin
Change-Id: I1d92a41f0f1a2610930e48b5eeaa689ac47ab7fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121329 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31flatten SfxChildWinFactArr_ImpNoel Grandin
it's just a vector with no additional intelligence Change-Id: I91d014783e79130689b4f6eadb3ef6d8486227e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-24remove one of the pimpls in SvBaseLinkNoel Grandin
two pimpl's and some internal fields seems a little messy Change-Id: I24f5a8e264dd98f8f74ab904ace85be1e9ff7acb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120939 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-24tdf#144025 Change LibreOffice to %PRODUCTNAMERoman Kuznetsov
Change-Id: Ia5bd44cb32818a71743f6a6e028cd9f0eba9aff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120882 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2021-08-19loplugin:constmethodsNoel Grandin
Change-Id: I786096b989daa6004a6527aafbe825b6f0a22d90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18tdf#143353 defer tip of the day until impress template dialog is goneCaolán McNamara
wait until that dialog is dismissed before showing the tip dialog Change-Id: Id0e7e28f09c5a9727e10eda55e468adb56bfda70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18loplugin:constparamsNoel Grandin
Change-Id: Ic7410f836e584df45101e78e345c8b3c8d355e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18loplugin:passstuffbyrefNoel Grandin
Change-Id: I4f01eb3842ef198f02af274f54afb2760c820a4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18Don't crash on SidebarController dispose when app is closingSzymon Kłos
When app is closing it is possible SfxGetpApp() will return null. So GetCurrentTheme() cannot return reference to correct theme. Remember which theme has registered SidebarController to unregister when disposing. Change-Id: If223233f621601f445472b0413a56e9c51e59673 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118970 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120630 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-17Fix typoAndrea Gelmini
Change-Id: I05739d1b82ec872cd8c7d68d3945893c9e6c3648 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120597 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-16LOK: introduced Freemium LOK APIPranam Lashkari
also block the uno commands from deny list Change-Id: Iee994411891b73b865e6496403682f996d5e9321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116384 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120482 Tested-by: Jenkins
2021-08-13split SvNumberFormatter into it's own headerNoel Grandin
so I can make changes without running into cyclic dependencies between header files Change-Id: I98a91c7cc66002ba745cdb8239e5cc267922a45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-10add some --disable-scripting fixesCaolán McNamara
Change-Id: I45f08bce8e067ead82f4c73c8150b7027c083172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-10Missing includeStephan Bergmann
(for std::unique_ptr, with recent libstdc++ 12 trunk) Change-Id: I61b7823dd740ea7cdfe0d7403a50ac73b24d1c4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-06tdf#139647 refresh renamed itemsVert D
*Update templates names after rename (faster than reload). *Fix some warnings. Change-Id: I47387af91964afae8de8753289d49d19e6080863 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-05improve LOK notifyInvalidationNoel Grandin
(*) tweak buffer in SfxLokHelper::notifyInvalidation to be a bit larger, so we avoid the cost of a resize&copy (*) use our optimised OString concatentation instead of going via std::stringstream (*) pass down a pointer to rectangle, instead of a string. later we will use this to avoid doing the stringify until later Change-Id: Ia3e3042bc919d9b9cb80e47a93704eb236438605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119994 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120072 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-05drop unneeded forward declareCaolán McNamara
Change-Id: I858d4a43690bd37385eb6f48945c05dd9c2a6182 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120031 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-05Pass context and resource string down to boost::locale separatelyNoel Grandin
because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Change-Id: Ia36047209368ca53431178c2e8723a18cfe8260a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-29lok sidebar: remove unused codeSzymon Kłos
Change-Id: I88325246d4997d44b4a1ca681627ca00ade1f030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118285 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119664 Tested-by: Jenkins
2021-07-29Fix --enable-mergelibs `make check`Stephan Bergmann
> LNK] CppunitTest/libtest_basegfx.so > include/basegfx/tuple/b3dtuple.hxx:92: error: undefined reference to 'basegfx::B3DTuple::getEmptyTuple()' and > [LNK] CppunitTest/libtest_svx_removewhichrange.so > svx/source/core/extedit.cxx:65: error: undefined reference to 'FileChangedChecker::FileChangedChecker(rtl::OUString const&, std::function<void ()> const&)' > svx/source/engine3d/scene3d.cxx:221: error: undefined reference to 'B3dTransformationSet::SetDeviceRectangle(double, double, double, double)' > include/tools/b3dtrans.hxx:120: error: undefined reference to 'B3dTransformationSet::SetViewportRectangle(tools::Rectangle const&, tools::Rectangle const&)' > svx/source/engine3d/scene3d.cxx:175: error: undefined reference to 'B3dCamera::B3dCamera(basegfx::B3DPoint const&, basegfx::B3DVector const&, double, double)' > svx/source/engine3d/scene3d.cxx:243: error: undefined reference to 'B3dCamera::~B3dCamera()' > svx/source/engine3d/scene3d.cxx:355: error: undefined reference to 'B3dTransformationSet::SetRatio(double)' > svx/source/engine3d/scene3d.cxx:364: error: undefined reference to 'B3dViewport::SetViewportValues(basegfx::B3DPoint const&, basegfx::B3DVector const&, basegfx::B3DVector const&)' > svx/source/engine3d/scene3d.cxx:367: error: undefined reference to 'B3dTransformationSet::SetPerspective(bool)' > include/tools/b3dtrans.hxx:120: error: undefined reference to 'B3dTransformationSet::SetViewportRectangle(tools::Rectangle const&, tools::Rectangle const&)' > include/tools/b3dtrans.hxx:120: error: undefined reference to 'B3dTransformationSet::SetViewportRectangle(tools::Rectangle const&, tools::Rectangle const&)' > svx/source/engine3d/scene3d.cxx:186: error: undefined reference to 'B3dCamera::B3dCamera(basegfx::B3DPoint const&, basegfx::B3DVector const&, double, double)' > svx/source/engine3d/scene3d.cxx:179: error: undefined reference to 'B3dCamera::~B3dCamera()' > svx/source/engine3d/scene3d.cxx:210: error: undefined reference to 'B3dCamera::~B3dCamera()' > svx/source/gallery2/galctrl.cxx:213: error: undefined reference to 'avmedia::MediaFloater::setURL(rtl::OUString const&, rtl::OUString const&, bool)' > svx/source/gallery2/galtheme.cxx:745: error: undefined reference to 'VersionCompatRead::VersionCompatRead(SvStream&)' > svx/source/gallery2/galtheme.cxx:757: error: undefined reference to 'VersionCompatRead::~VersionCompatRead()' > svx/source/gallery2/galtheme.cxx:757: error: undefined reference to 'VersionCompatRead::~VersionCompatRead()' > svx/source/gallery2/gallerybinaryengine.cxx:774: error: undefined reference to 'VersionCompatWrite::VersionCompatWrite(SvStream&, unsigned short)' > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'VersionCompatWrite::~VersionCompatWrite()' > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'VersionCompatWrite::~VersionCompatWrite()' > svx/source/gallery2/gallerybinaryengineentry.cxx:115: error: undefined reference to 'VersionCompatRead::VersionCompatRead(SvStream&)' > svx/source/gallery2/gallerybinaryengineentry.cxx:123: error: undefined reference to 'VersionCompatRead::~VersionCompatRead()' > svx/source/gallery2/gallerybinaryengineentry.cxx:123: error: undefined reference to 'VersionCompatRead::~VersionCompatRead()' > include/editeng/editund2.hxx:29: error: undefined reference to 'vtable for EditUndoManager' > /usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function > include/editeng/editund2.hxx:29: error: undefined reference to 'vtable for EditUndoManager' > /usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function > svx/source/svdraw/sdrundomanager.cxx:30: error: undefined reference to 'EditUndoManager::EditUndoManager(unsigned short)' > svx/source/svdraw/sdrundomanager.cxx:72: error: undefined reference to 'EditUndoManager::Redo()' > svx/source/svdraw/sdrundomanager.cxx:46: error: undefined reference to 'EditUndoManager::Undo()' > workdir/CxxObject/svx/source/svdraw/sdrundomanager.o:sdrundomanager.cxx:typeinfo for SdrUndoManager: error: undefined reference to 'typeinfo for EditUndoManager' > svx/source/svdraw/svdedxv.cxx:97: error: undefined reference to 'EditViewCallbacks::~EditViewCallbacks()' > svx/source/svdraw/svdedxv.cxx:87: error: undefined reference to 'EditViewCallbacks::~EditViewCallbacks()' > workdir/CxxObject/svx/source/svdraw/svdedxv.o:svdedxv.cxx:typeinfo for SdrObjEditView: error: undefined reference to 'typeinfo for EditViewCallbacks' > svx/source/svdraw/svdfmtf.cxx:1206: error: undefined reference to 'MetaMapModeAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.cxx:1239: error: undefined reference to 'typeinfo for MetaGradientExAction' > svx/source/svdraw/svdfmtf.hxx:139: error: undefined reference to 'MetaLayoutModeAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:136: error: undefined reference to 'MetaTextLineColorAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:135: error: undefined reference to 'MetaRefPointAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:115: error: undefined reference to 'MetaRasterOpAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:117: error: undefined reference to 'MetaPopAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:116: error: undefined reference to 'MetaPushAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:112: error: undefined reference to 'MetaFontAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.cxx:1206: error: undefined reference to 'MetaMapModeAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:113: error: undefined reference to 'MetaTextAlignAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:111: error: undefined reference to 'MetaTextFillColorAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:110: error: undefined reference to 'MetaTextColorAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:118: error: undefined reference to 'MetaMoveClipRegionAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:120: error: undefined reference to 'MetaISectRegionClipRegionAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:119: error: undefined reference to 'MetaISectRectClipRegionAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:114: error: undefined reference to 'MetaClipRegionAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:140: error: undefined reference to 'MetaTextLanguageAction::Execute(OutputDevice*)' > svx/source/svdraw/svdfmtf.hxx:141: error: undefined reference to 'MetaOverlineColorAction::Execute(OutputDevice*)' > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'OFlowChainedText::~OFlowChainedText()' > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'OFlowChainedText::~OFlowChainedText()' > svx/source/svdraw/textchainflow.cxx:274: error: undefined reference to 'OFlowChainedText::RemoveOverflowingText(Outliner*)' > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'OFlowChainedText::~OFlowChainedText()' > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'OFlowChainedText::~OFlowChainedText()' > svx/source/svdraw/textchainflow.cxx:101: error: undefined reference to 'UFlowChainedText::UFlowChainedText(Outliner const*, bool)' > svx/source/svdraw/textchainflow.cxx:96: error: undefined reference to 'OFlowChainedText::OFlowChainedText(Outliner const*, bool)' > svx/source/svdraw/textchainflow.cxx:123: error: undefined reference to 'OFlowChainedText::GetOverflowPointSel() const' > svx/source/svdraw/textchainflow.cxx:123: error: undefined reference to 'OFlowChainedText::GetOverflowPointSel() const' > svx/source/svdraw/textchainflow.cxx:159: error: undefined reference to 'UFlowChainedText::CreateMergedUnderflowParaObject(Outliner*, OutlinerParaObject const*)' > svx/source/svdraw/textchainflow.cxx:202: error: undefined reference to 'OFlowChainedText::RemoveOverflowingText(Outliner*)' > svx/source/svdraw/textchainflow.cxx:227: error: undefined reference to 'OFlowChainedText::InsertOverflowingText(Outliner*, OutlinerParaObject const*)' > svx/source/svdraw/textchainflow.cxx:239: error: undefined reference to 'OFlowChainedText::IsLastParaInterrupted() const' > svx/source/svdraw/textchainflow.cxx:235: error: undefined reference to 'OFlowChainedText::IsLastParaInterrupted() const' > svx/source/svdraw/textchainflow.cxx:235: error: undefined reference to 'OFlowChainedText::IsLastParaInterrupted() const' > svx/source/tbxctrls/tbcontrl.cxx:2747: error: undefined reference to 'SfxStatusListener::ReBind()' > include/svx/tbcontrl.hxx:175: error: undefined reference to 'SfxStatusListener::ReBind()' > svx/source/tbxctrls/tbcontrl.cxx:2697: error: undefined reference to 'SfxStatusListener::UnBind()' > svx/source/tbxctrls/tbcontrl.cxx:2493: error: undefined reference to 'SfxStatusListener::SfxStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, unsigned short, rtl::OUString const&)' > svx/source/tbxctrls/tbcontrl.cxx:2493: error: undefined reference to 'SfxStatusListener::SfxStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, unsigned short, rtl::OUString const&)' > svx/source/tbxctrls/tbcontrl.cxx:815: error: undefined reference to 'SfxStatusListener::~SfxStatusListener()' > svx/source/tbxctrls/tbcontrl.cxx:815: error: undefined reference to 'SfxStatusListener::~SfxStatusListener()' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:typeinfo for SfxStyleControllerItem_Impl: error: undefined reference to 'typeinfo for SfxStatusListener' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'SfxStatusListener::dispose()' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'SfxStatusListener::addEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'SfxStatusListener::removeEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'SfxStatusListener::disposing(com::sun::star::lang::EventObject const&)' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'SfxStatusListener::statusChanged(com::sun::star::frame::FeatureStateEvent const&)' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'non-virtual thunk to SfxStatusListener::disposing(com::sun::star::lang::EventObject const&)' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'non-virtual thunk to SfxStatusListener::statusChanged(com::sun::star::frame::FeatureStateEvent const&)' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'non-virtual thunk to SfxStatusListener::dispose()' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'non-virtual thunk to SfxStatusListener::addEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)' > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'non-virtual thunk to SfxStatusListener::removeEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)' > svx/source/tbxctrls/StylesPreviewWindow.cxx:63: error: undefined reference to 'SfxStatusListener::SfxStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, unsigned short, rtl::OUString const&)' > svx/source/tbxctrls/StylesPreviewWindow.cxx:65: error: undefined reference to 'SfxStatusListener::ReBind()' > svx/source/tbxctrls/StylesPreviewWindow.cxx:409: error: undefined reference to 'SfxStatusListener::UnBind()' > svx/source/tbxctrls/StylesPreviewWindow.cxx:413: error: undefined reference to 'SfxStatusListener::dispose()' > svx/source/inc/StylesPreviewWindow.hxx:32: error: undefined reference to 'SfxStatusListener::~SfxStatusListener()' > svx/source/inc/StylesPreviewWindow.hxx:32: error: undefined reference to 'SfxStatusListener::~SfxStatusListener()' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:typeinfo for StyleStatusListener: error: undefined reference to 'typeinfo for SfxStatusListener' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'SfxStatusListener::dispose()' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'SfxStatusListener::addEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'SfxStatusListener::removeEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'SfxStatusListener::disposing(com::sun::star::lang::EventObject const&)' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'SfxStatusListener::statusChanged(com::sun::star::frame::FeatureStateEvent const&)' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'non-virtual thunk to SfxStatusListener::disposing(com::sun::star::lang::EventObject const&)' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'non-virtual thunk to SfxStatusListener::statusChanged(com::sun::star::frame::FeatureStateEvent const&)' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'non-virtual thunk to SfxStatusListener::dispose()' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'non-virtual thunk to SfxStatusListener::addEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)' > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'non-virtual thunk to SfxStatusListener::removeEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)' > svx/source/unodraw/unoshap3.cxx:324: error: undefined reference to 'B3dViewport::SetViewportValues(basegfx::B3DPoint const&, basegfx::B3DVector const&, basegfx::B3DVector const&)' > svx/source/xml/xmlxtexp.cxx:92: error: undefined reference to 'XMLMarkerStyleExport::~XMLMarkerStyleExport()' > svx/source/xml/xmlxtexp.cxx:102: error: undefined reference to 'XMLDashStyleExport::~XMLDashStyleExport()' > svx/source/xml/xmlxtexp.cxx:113: error: undefined reference to 'XMLHatchStyleExport::~XMLHatchStyleExport()' > svx/source/xml/xmlxtexp.cxx:123: error: undefined reference to 'XMLGradientStyleExport::~XMLGradientStyleExport()' > svx/source/xml/xmlxtexp.cxx:454: error: undefined reference to 'XMLHatchStyleExport::XMLHatchStyleExport(SvXMLExport&)' > svx/source/xml/xmlxtexp.cxx:432: error: undefined reference to 'XMLMarkerStyleExport::XMLMarkerStyleExport(SvXMLExport&)' > svx/source/xml/xmlxtexp.cxx:443: error: undefined reference to 'XMLDashStyleExport::XMLDashStyleExport(SvXMLExport&)' > svx/source/xml/xmlxtexp.cxx:465: error: undefined reference to 'XMLGradientStyleExport::XMLGradientStyleExport(SvXMLExport&)' > svx/source/xml/xmlxtexp.cxx:438: error: undefined reference to 'XMLMarkerStyleExport::exportXML(rtl::OUString const&, com::sun::star::uno::Any const&)' > svx/source/xml/xmlxtexp.cxx:92: error: undefined reference to 'XMLMarkerStyleExport::~XMLMarkerStyleExport()' > svx/source/xml/xmlxtexp.cxx:449: error: undefined reference to 'XMLDashStyleExport::exportXML(rtl::OUString const&, com::sun::star::uno::Any const&)' > svx/source/xml/xmlxtexp.cxx:102: error: undefined reference to 'XMLDashStyleExport::~XMLDashStyleExport()' > svx/source/xml/xmlxtexp.cxx:460: error: undefined reference to 'XMLHatchStyleExport::exportXML(rtl::OUString const&, com::sun::star::uno::Any const&)' > svx/source/xml/xmlxtexp.cxx:113: error: undefined reference to 'XMLHatchStyleExport::~XMLHatchStyleExport()' > svx/source/xml/xmlxtexp.cxx:471: error: undefined reference to 'XMLGradientStyleExport::exportXML(rtl::OUString const&, com::sun::star::uno::Any const&)' > svx/source/xml/xmlxtexp.cxx:123: error: undefined reference to 'XMLGradientStyleExport::~XMLGradientStyleExport()' > svx/source/xml/xmlxtexp.cxx:482: error: undefined reference to 'XMLImageStyle::exportXML(rtl::OUString const&, com::sun::star::uno::Any const&, SvXMLExport&)' > svx/source/xml/xmlxtimp.cxx:220: error: undefined reference to 'XMLMarkerStyleImport::XMLMarkerStyleImport(SvXMLImport&)' > svx/source/xml/xmlxtimp.cxx:221: error: undefined reference to 'XMLMarkerStyleImport::importXML(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&, com::sun::star::uno::Any&, rtl::OUString&)' > svx/source/xml/xmlxtimp.cxx:222: error: undefined reference to 'XMLMarkerStyleImport::~XMLMarkerStyleImport()' > svx/source/xml/xmlxtimp.cxx:233: error: undefined reference to 'XMLDashStyleImport::XMLDashStyleImport(SvXMLImport&)' > svx/source/xml/xmlxtimp.cxx:234: error: undefined reference to 'XMLDashStyleImport::importXML(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&, com::sun::star::uno::Any&, rtl::OUString&)' > svx/source/xml/xmlxtimp.cxx:235: error: undefined reference to 'XMLDashStyleImport::~XMLDashStyleImport()' > svx/source/xml/xmlxtimp.cxx:259: error: undefined reference to 'XMLGradientStyleImport::XMLGradientStyleImport(SvXMLImport&)' > svx/source/xml/xmlxtimp.cxx:260: error: undefined reference to 'XMLGradientStyleImport::importXML(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&, com::sun::star::uno::Any&, rtl::OUString&)' > svx/source/xml/xmlxtimp.cxx:261: error: undefined reference to 'XMLGradientStyleImport::~XMLGradientStyleImport()' > svx/source/xml/xmlxtimp.cxx:246: error: undefined reference to 'XMLHatchStyleImport::XMLHatchStyleImport(SvXMLImport&)' > svx/source/xml/xmlxtimp.cxx:247: error: undefined reference to 'XMLHatchStyleImport::importXML(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&, com::sun::star::uno::Any&, rtl::OUString&)' > svx/source/xml/xmlxtimp.cxx:248: error: undefined reference to 'XMLHatchStyleImport::~XMLHatchStyleImport()' > svx/source/xml/xmlxtimp.cxx:273: error: undefined reference to 'XMLImageStyle::importXML(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&, com::sun::star::uno::Any&, rtl::OUString&, SvXMLImport&)' > svx/source/xml/xmlxtimp.cxx:222: error: undefined reference to 'XMLMarkerStyleImport::~XMLMarkerStyleImport()' > svx/source/xml/xmlxtimp.cxx:235: error: undefined reference to 'XMLDashStyleImport::~XMLDashStyleImport()' > svx/source/xml/xmlxtimp.cxx:248: error: undefined reference to 'XMLHatchStyleImport::~XMLHatchStyleImport()' > svx/source/xml/xmlxtimp.cxx:261: error: undefined reference to 'XMLGradientStyleImport::~XMLGradientStyleImport()' > include/vcl/vclptr.hxx:129: error: undefined reference to 'svt::MultiLineTextCell::MultiLineTextCell(BrowserDataWin*)' > include/vcl/vclptr.hxx:129: error: undefined reference to 'svt::MultiLineTextCell::MultiLineTextCell(BrowserDataWin*)' > include/svtools/editbrowsebox.hxx:246: error: undefined reference to 'svt::IEditImplementation::~IEditImplementation()' > include/svtools/editbrowsebox.hxx:246: error: undefined reference to 'svt::IEditImplementation::~IEditImplementation()' > include/svtools/editbrowsebox.hxx:246: error: undefined reference to 'svt::IEditImplementation::~IEditImplementation()' > include/svtools/editbrowsebox.hxx:234: error: undefined reference to 'svt::IEditImplementation::~IEditImplementation()' > svx/source/form/fmshimp.cxx:3919: error: undefined reference to 'comphelper::IndexAccessIterator::IndexAccessIterator(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)' > svx/source/form/fmshimp.cxx:3919: error: undefined reference to 'comphelper::IndexAccessIterator::IndexAccessIterator(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)' > svx/source/form/fmshimp.cxx:2342: error: undefined reference to 'comphelper::IndexAccessIterator::Next()' > svx/source/form/fmshimp.cxx:2437: error: undefined reference to 'comphelper::IndexAccessIterator::Next()' > svx/source/inc/fmshimp.hxx:544: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()' > svx/source/inc/fmshimp.hxx:100: error: undefined reference to 'comphelper::IndexAccessIterator::IndexAccessIterator(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)' > svx/source/form/fmshimp.cxx:3092: error: undefined reference to 'comphelper::IndexAccessIterator::Next()' > svx/source/inc/fmshimp.hxx:97: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()' > svx/source/inc/fmshimp.hxx:97: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()' > svx/source/inc/fmshimp.hxx:100: error: undefined reference to 'comphelper::IndexAccessIterator::IndexAccessIterator(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)' > svx/source/form/fmshimp.cxx:3212: error: undefined reference to 'comphelper::IndexAccessIterator::Next()' > svx/source/inc/fmshimp.hxx:97: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()' > svx/source/form/fmshimp.cxx:1636: error: undefined reference to 'comphelper::IndexAccessIterator::IndexAccessIterator(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)' > svx/source/form/fmshimp.cxx:1636: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()' > svx/source/form/fmshimp.cxx:1636: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()' > workdir/CxxObject/svx/source/form/fmshimp.o:fmshimp.cxx:typeinfo for FmXBoundFormFieldIterator: error: undefined reference to 'typeinfo for comphelper::IndexAccessIterator' > workdir/CxxObject/svx/source/form/fmshimp.o:fmshimp.cxx:typeinfo for SearchableControlIterator: error: undefined reference to 'typeinfo for comphelper::IndexAccessIterator' Change-Id: I9911219083676cd10f5ccfc067655252eb172a3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119676 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-07-29Intialize the VCL test dialog directly instead of dispatching commandhomeboy445
Change-Id: Ia24c97b12266dac3a6f315993558f3cdac8a4652 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118124 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-27jsdialog: sidebar: remove code for tunneled oneSzymon Kłos
Change-Id: Idb60fdfc03729dd3755d5ef1ba61b2f9376e9556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116965 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119542 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-27drop SvtLanguageOptions classNoel Grandin
since it is just a wrapper over SvtCJKOptions and SvtCTLOptions. Later I will replace those two with the equivalent officecfg calls Change-Id: I61c5667a05f75d42643175f2c28c29d7a590b15c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-23use officecfg to retrieve SidebarIconSizeNoel Grandin
Change-Id: Id1cc4b8e3e28d942b44deacafbc514bbcd95874c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119411 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-22do not use delayed layout in TitledDockingWindowLuboš Luňák
The layout is only performed in Paint(), so if something uses geometry before that happens (may happen with tiled rendering), then is not up to date. I don't see why delay it anyway, there seems to be usually just one resize, and only during init I see two of them, which can presumably be fixed if needed. Change-Id: I7133f3c6be41bc6480f86d1053b455d42c40b9ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116529 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-07-21pass SfxChildWinFactory around by valueNoel Grandin
no need to allocate on heap Change-Id: I7410a6c9cb434b18ed6f7ae1dc0ccea34151921c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119331 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-21can pass SfxItemSet around by value in SfxShellNoel Grandin
Change-Id: I80ee25c56da437d778e11f2dab3d07845ebd9597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119274 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-15WhichRangesContainer, reduce malloc in SfxItemSetNoel Grandin
SfxItemSet shows up in perf profiles frequently, and the hottest part is the malloc of the two arrays we need. But most of the time, one of those arrays is a compile-time constant. So this change introduces (*) WhichRangesContainer, which manages whether the SfxItemSet owns the array it points at or not. (*) a static const member in svl::Items (idea from mkaganski) to store the data. Change-Id: Icb8cdbc4d54fd76739565c575e16a744515e5355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118703 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-14Fix typo in codeAndrea Gelmini
Change-Id: I9e92dcee5f49f81aeadf9e2baa504a247bece33b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118948 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins