summaryrefslogtreecommitdiff
path: root/include/sfx2
AgeCommit message (Collapse)Author
2014-12-06Forward-declare SfxInPlaceClientList and remove <vector> include.Kohei Yoshida
Change-Id: I4e611820a4dae4341f971a545578048b52d7e37c
2014-12-05Remove unused header include esp when it's an STL header.Kohei Yoshida
Change-Id: I03c93862378ff3bddcf415b2ad3aa183ec5da030
2014-12-05Broken castStephan Bergmann
All the way back since 2001 (ed53aaf5842e82f9a8d4d053b39e7db61c6d62ce "#89611# react for (Beamer!)Frame->dispose() from outside," adding member SfxChildWindow_Impl::xListener), that MyStruct hack was not in sync with SfxChildWindow_Impl, so ((MyStruct*)pImp)->bVisible = false; probably corrputed pFact rather than change bVisible. The origin of that MyStruct hack is lost to history, but probably stems from an ancient time when changes across modules where prohibitively expensive, esp. when some feature had to be crammed in shortly before release... Change-Id: I13dc30c96ef70b2cc09dc117231c021910e0ce1e
2014-12-04callcatcher: update unused codeCaolán McNamara
Change-Id: Ia25b857738bb7b6c3baf18c68ef0d1bc0b3e142e
2014-11-26fix 'Childwindow slot missing' warningCaolán McNamara
and rename SID_INFOBARCONTAINER to SID_INFOBAR Change-Id: Ibe8a2925f62b43bd96d1092c98e500c8d433ac80
2014-11-25all these ids and their associated resources were unnecessaryCaolán McNamara
Change-Id: I3f538668c9c5f1727b8cf49ab72fd5879e12f156
2014-11-25We now only need one bit of information hereCaolán McNamara
whether there *is* an id, or whether there is not an id. An id of 0 seems to be used as a flag that an interface is some sort of superclass which can be subclassed by something else and have its toolbars etc reused. Convert this to a bool so we don't need an a resource id for each one and just drop the third arg for the normal "final" case and use a different define for the inheritable case Change-Id: I98380f03d73d57bf8cba02d339097e384518abaa
2014-11-25only use of SfxInterface::GetName is for debugging infoCaolán McNamara
where GetClasName is good enough Change-Id: I242d5792d3ce1323da59a354cae47933cf90569b
2014-11-24SfxModule has GetResMgr so SfxShell and SfxInterface don't need GetResMgrCaolán McNamara
Change-Id: I6160f8b396ac5e5fb799ee03c5b0181fb088cb54
2014-11-24so GetOffResManager_Impl is unusedCaolán McNamara
which makes sense, because all that's left in ofa.res is error strings Change-Id: Ieedcbd5c9c723ac1a89035add11a61d41b2381a9
2014-11-24so these ResIds are only being used for the numerical valueCaolán McNamara
Change-Id: I21c67b56424de59d7231f8420055775cd5f67aae
2014-11-24ResId return from GetObjectBarResId is only used for its numerical idCaolán McNamara
Change-Id: I173d20d68b25a614e25b1c933cc5f18f7116ab9c
2014-11-24in passing RegisterChildWindow already never used its pStr argCaolán McNamara
Change-Id: I506581507f078a87088c85867724f1c446ea76d5
2014-11-24so RegisterObjectBar's pStr arg is never usedCaolán McNamara
Change-Id: Idf0642255490583fa20a05d2c834b941eb696918
2014-11-24so SfxInterface::GetObjectBarName is now unusedCaolán McNamara
Change-Id: I88f5c84386216339d617589ba6a7e0de1235a9e9
2014-11-24no use is made of _pResMgrCaolán McNamara
so the relevant ctor argument is useless Change-Id: I32f733cc12820f311656b7e140a36c50e504c739
2014-11-24show that GetImageManager never has a NULL moduleCaolán McNamara
and remove resulting dead branches Change-Id: I969c943b9ff7e56d22efb4eff5bee644f9792676
2014-11-24move RID_APPTITLE to desktop where its usedCaolán McNamara
rename the other ones and remove the unused ones Change-Id: I0e636cd5d1799e0f9cb815a4bfa20b16039ecb3f
2014-11-23Forward-declare SfxFrameArr_Impl in sfx2/frame.hxx.Kohei Yoshida
Change-Id: I49f0a16655114bf212ffec957bc6560075115e5c
2014-11-23Forward-declare SfxModuleArr_Impl in sfx2/module.hxx.Kohei Yoshida
This is only used within sfx2. Change-Id: I40d850bcf82ba39dc7cf7d1a5b70c90add4e75c0
2014-11-23fdo#39468 translate German commentsMichael Weghorn
Change-Id: Ic385faed251970c0c686b099023af9efca10a121 Reviewed-on: https://gerrit.libreoffice.org/13040 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-22ptr_vector is not used in this header. Remove it.Kohei Yoshida
Change-Id: I5f884819f777201ddfec60bdac3e503584ead649
2014-11-21Same with SfxUnoControllerArr_Impl.Kohei Yoshida
Change-Id: I927621de8f4c486ef0f77ec6c8da336f36b38b3e
2014-11-21Forward declare SfxFoundCacheArr_Impl and SfxFoundCache_Impl in bindings.hxx.Kohei Yoshida
And remove #include <boost/ptr_container/ptr_vector.hpp> from here. Change-Id: I7624444b60ee19f0b5b19e7a7aab0210ddf90d7c
2014-11-21Forward declare all the std::vector based impl container classes.Kohei Yoshida
Now #include <vector> is a goner... Change-Id: Ia2da27bae5fadfa3f6f633e55fcedce405281b67
2014-11-21Forward declare SfxTbxCtrlFactArr_Impl and SfxStbCtrlFactArr_Impl in app.hxx.Kohei Yoshida
Now we can finally remove ptr_vector include from this header. Change-Id: I7aeaa520e10b4eacb1a24ad666086739821e56b0
2014-11-21Forward declare SfxMenuCtrlFactArr_Impl in sfx2/app.hxx public header.Kohei Yoshida
Change-Id: Iaf287912a52eb8785c687a13536fc170094425c7
2014-11-21Forward declare SfxChildWinFactArr_Impl in sfx2/app.hxx.Kohei Yoshida
Change-Id: I52128b405e861551a933d9c1625d7741b43ad2b6
2014-11-20Forgot to check this in. This should have been a part of the last commit.Kohei Yoshida
Change-Id: Id2b75e6e64b11c523ffa862f2d99bf02c2adedc5
2014-11-20Remove ptr_vector header exposure from sfx2/childwin.hxx public header.Kohei Yoshida
Change-Id: I4060c8987a0da387d02f8468229854612a230db3
2014-11-20Make the ctor and dtor bodies non-inline.Kohei Yoshida
Change-Id: Ie36e3dfa808aec96c080f981a5ad9f09a0720c2c
2014-11-17fdo#85478 Avoid destroying bitmaps after VCL is shut downMatthew J. Francis
Change-Id: I1ece738e7f60b6bbbdc802339f8b9deec9396e1b Reviewed-on: https://gerrit.libreoffice.org/12469 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-16vcl: let the ModalDialog ctor take an OUStringMiklos Vajna
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
2014-11-16vcl: let the ModelessDialog ctor take an OUStringMiklos Vajna
Change-Id: Iae88a9889c674337fb999a23a799d8730d2793d5
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-09SfxTabDialog ctors: take an OUStringMiklos Vajna
Change-Id: I91b9b2ffd19b2412ac01dd12429d6460b4c4812c
2014-10-29Resolves: fdo#85111 put a border around the custom properties boxCaolán McNamara
Change-Id: Ibdbfb4a88c1c75aaf5d33672d8639a9ea55afbac
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "do not forward-declare templates"Jan Holesovsky
This reverts commit 091742e86aeb5287f7236f666fee48946ab4c67b.
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-22callcatcher: update unused codeCaolán McNamara
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
2014-10-21The only SID supported by PropExec/State_Impl is SID_ATTR_UNDO_COUNTStephan Bergmann
...apparently, given that the SID_ATTR_UNDO_COUNT entry in sfx2/sdi/appslots.sdi is the only place that mentions those functions. That reveals that all the other SIDs mentioned there are completely unused. (Also, there seems to be no need to wrap the remaining PropExec/State_Impl functionality in #ifndef DISABLE_SCRIPTING.) Change-Id: Iea7a41aa323b7876d316794cebe962e6e086236d
2014-10-21Remove unused SfxInterface::GetResManager_ImplStephan Bergmann
Change-Id: Ia9ad8072b07f0121af18377445c90480ff7c2600
2014-10-21Remove unused pSfxFormalArgs_ImplStephan Bergmann
Change-Id: I0c1e8c42fd03bd861323cbff172031f5405c1597
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17SID_TOGGLE_MENUBAR (aka slot:6661, .uno:MenuBarVisible) is deadStephan Bergmann
...since introduction of XLayoutManager's private:resource/menubar/menubar in 3fb2acf5b77bff59909f616c44c7de17048b64d7 "INTEGRATION: CWS layoutmanager (1.52.10); FILE MERGED" etc. and final removal of SID_TOGGLE_MENUBAR bits in f605b16e395e8ccc3d1aba7907b0792039016f69 "INTEGRATION: CWS sfxcleanup (1.119.8); FILE MERGED" etc. What still needs fixing are extensions/source/activex/SOActiveX.cxx odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/CustomizeView.java odk/examples/OLE/activex/SOActiveX.cpp in a similar way as e.g. 0273d3d81d29d5c1f6c387cca633cd99722c100e "INTEGRATION: CWS jl18 (1.6.8); FILE MERGED." Change-Id: I52a43fc7186a4f60929ab6246a2da2e715be7510
2014-10-17Remove some completely unused SID_sStephan Bergmann
Change-Id: I1a259f9af77bbbffc4f0bc85beb7945e3d74ff77
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15coverity#735333 flush out pointless calls to IsRemote and IsOpenCaolán McNamara
etc. Change-Id: I588d4486071b1e31897d4e6468a2c634d6856832
2014-10-15SfxMedium::IsRemote can be made constCaolán McNamara
Change-Id: Id6b14366d11c15ec1440482cfb725e497807fa2e