summaryrefslogtreecommitdiff
path: root/include/sfx2
AgeCommit message (Collapse)Author
2017-10-24loplugin:finalclasses in sfx2..svlNoel Grandin
Change-Id: I71b78135b3d0259657438c4401340bb35ab5c6e0 Reviewed-on: https://gerrit.libreoffice.org/43742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: sfx2Stephan Bergmann
Change-Id: I5e9a7a2580a710880023288f5ed3584708c4769d
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-22TSCP: support abbreviated classification namesAshod Nakashian
Change-Id: Ib7edc491d2f8a69c48f1515ba29d79e09c88c3b7 Reviewed-on: https://gerrit.libreoffice.org/43627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-21tdf#67770: Read/writer LastActiveDeck bitsKatarina Behrens
Change-Id: Id5e3c3cb4144b9fc56ab5e4a4e49f1fc69e70023 Reviewed-on: https://gerrit.libreoffice.org/43493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-16Make include/sfx2 include files found through global -IincludeStephan Bergmann
...instead of implicitly next to the including file, in preparation of loplugin:includeform Change-Id: If5025f2a91bf6f1ef5482a57dbfe4f02327cbdbc
2017-10-16tscp: move getting the current policy type to class. helperTomaž Vajngerl
Change-Id: I54afcca1c1fc1a27458c75ab9fd3405d6f7e9239 Reviewed-on: https://gerrit.libreoffice.org/43360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-08Make Color a forward declarationChris Sherlock
Change-Id: Ib28833555661b119de8e967b05e3c8691fca826a Reviewed-on: https://gerrit.libreoffice.org/43227 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-10-06Related: tdf#107569 Remove useless slotsMaxim Monastirsky
With the current implementation of MenuBarManager, there is no need to have sdi slots for menu items with submenus, and moreover they have no effect at all. Note that SID_PICKLIST was also (mis)used as an argument to avoid adding a document to the recent list (which isn't related to its mapping to .uno:PickList). But there seem to be only read attempts, nothing actually sets it, so I think this usage can be removed too. (For information, at least in OOo 1.0.3 sources, there were 2 places where it was used as an argument for SID_SAVEASDOC, although it was not present there in the SID_SAVEASDOC def. in sfx.sdi.) Change-Id: I18b0afe106f858406e13188bbc004ac99a3a0246 Reviewed-on: https://gerrit.libreoffice.org/43184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-10-04clang-tidy modernize-use-equals-default in sfx2Jochen Nitschke
SfxPoolItem has a copy constructor and its copy assignment operator is deleted. Derived classes have a implicit defined copy constructor too, if all members are copy constructible. This patch removes default-able copy constructors and destructors on such items. Change-Id: I214dfc016f02617e39a69177aa2233573dfe5f28 Reviewed-on: https://gerrit.libreoffice.org/43039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03SfxDetectFilter typedef is unusedNoel Grandin
since it was added in commit 0d8c293fa426bc9f6f9f71393ce6de752a2087d8 Date: Wed Apr 11 20:20:32 2007 +0000 INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED Change-Id: Ie3b9ba6c4010306b26df9a142c784c00e3f1ae0e Reviewed-on: https://gerrit.libreoffice.org/43075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-02Change CB_DIALOG_INVALIDATE to CB_DIALOGPranav Kant
We can specify whether it is an invalidation or something else in the payload. Change-Id: I95c5fc0a0a88b5277eaa93c8d1f9b937bddce7b3
2017-10-02lokdialog: Support for rendering floating window dialog widgetsPranav Kant
Now gtktiledviewer can show floating window dialog widgets when user clicks any of such widget in the dialog. Change-Id: I13d756f236379bc8b2041ed41cb7b502f7fd9b24
2017-10-02lokdialog: Register IDIalogRenderable with vcl::DialogPranav Kant
Change-Id: I344f5a9c7167abfde15dcd21c747819cc79b12b1
2017-10-02lokdialog: Dialog invalidation supportPranav Kant
For now, just invalidate the whole dialog whenever any of the controls in the dialog get invalidated. Since during dialog painting, many such invalidations are triggered, don't listen to them when we are painting. Change-Id: Ia8fc12cf9469691d60e91ef770d687e5ff01a7ef
2017-10-01Wayland: Make various popups work in the overflow toolbarMaxim Monastirsky
Were failing to show, with this warning: Gdk-WARNING **: Tried to map a popup with a non-top most parent Change-Id: Ib68b5fc9b3edb3d25a23b66397c13833a4d080ac Reviewed-on: https://gerrit.libreoffice.org/42936 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-09-25Rename GetSelectEntryCount -> GetSelectedEntryCountSamuel Mehrbrodt
Change-Id: I405b347b404ed0acb3b6a0204e0b914a7698ce25 Reviewed-on: https://gerrit.libreoffice.org/42284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21EPUB export: add uno command to bypass options dialogMiklos Vajna
Similarly how this is possible with PDF. The toolbar button is hidden by default in Writer, though. Change-Id: Iaf3b61ac2160578f7eaabd194ce8932792575c29 Reviewed-on: https://gerrit.libreoffice.org/42554 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21TSCP: add advanced classification dialogTomaž Vajngerl
This adds a advanced classification dialog, which enables the user to manually construct a header/footer message from classification properties in cases where the user needs more control. All the text is inserted as fields into the end document and can be changed by changing the document properties. The simple classification still functions as it did before, which is what most users will want to use in this case. The BAF policy has been extended with new xml extension elements: - loext:Marking - loext:IntellectualPropertyPart - loext:IntellectualPropertyPartNumber They are used to fill the values in the advanced classification dialog. Change-Id: Ie2d638d69b8a9b0799cff9c2b785eb789f8af1d5 Reviewed-on: https://gerrit.libreoffice.org/42474 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-09-20EPUB export: add uno command to trigger the filterMiklos Vajna
This is quite similar to PDF, except that by default the File menu doesn't advertise this command. Possible to add it via Tools -> Customize -> Menus -> Search -> EPUB. (Reasoning for having a dedicated UNO command for EPUB is an increasing amount of users look at EPUB as the new PDF, given how non-reflowable PDF is hard to read on mobile devices, while EPUB is primarily reflowable.) Change-Id: Ib80f784a630a192f5b6ffbbfc60cb565fda7ed37
2017-09-18make fuzzer workCaolán McNamara
Change-Id: I798558260f5f975f92b702ecf6f4504738ffbbfb Reviewed-on: https://gerrit.libreoffice.org/42422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-18msCommandName in ControllerItem is unusedNoel Grandin
ever since commit 1c5cae479bebd2d325182adc2c9821fd948fd1bd Date: Thu Apr 20 08:44:33 2017 +0200 loplugin:unusedmethods Change-Id: I7c02e8bf0ef377303dedf4e6690fd937f52a3605
2017-09-11long->sal_Int32 in various Get/SetVersionNoel Grandin
sal_Int32 appears to be the widest type we need here Change-Id: I1859936dbe7b6a95840c638c8ca5d4148849e12d Reviewed-on: https://gerrit.libreoffice.org/42154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08set parent for file dialog helperCaolán McNamara
Change-Id: I3994ee48dcb5b2732cb27cb9ccb54926abf0828a Reviewed-on: https://gerrit.libreoffice.org/42048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-08loplugin:unusedmethodsNoel Grandin
Change-Id: Idba437cf35606e782e94c020c8ac3bb265703d00 Reviewed-on: https://gerrit.libreoffice.org/42091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08loplugin:unusedfieldsNoel Grandin
Change-Id: Ie26c52090d984c40cc108c9f20eb2ba31a866796 Reviewed-on: https://gerrit.libreoffice.org/42090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-06const correctness in o3tl::array_viewNoel Grandin
Change-Id: I44c1ace97ae44069c5a0c6a247aa8a0b49896ad3 Reviewed-on: https://gerrit.libreoffice.org/41985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-05tdf#109202: pass arg of --convert-images-to to (f)odt filterKatarina Behrens
Tunelling 1 piece of information through 20 layers of abstraction Advanced tunelling all the way to sfx2 Exhausted beyond recognition arrived to [Flat]ODF filter Change-Id: I0597c20c28f5cf8e2c60c4398622b36bda83abd0 Reviewed-on: https://gerrit.libreoffice.org/41777 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-02set parent for open file dialogCaolán McNamara
Change-Id: Ic823085567afde211b3991ebb60199dd336f562d Reviewed-on: https://gerrit.libreoffice.org/41819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-02always use a systemwindow for file dialog parentCaolán McNamara
cause the native dialogs can only be a parent of a "real" system window Change-Id: I6d06bda25c74b9a25f71e405027d3fb31711e136 Reviewed-on: https://gerrit.libreoffice.org/41812 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-01bump FileDialogHelper to XFilePicker3Caolán McNamara
Change-Id: I726676aaa8944bc3b6418abe305ad03f8ec96c59 Reviewed-on: https://gerrit.libreoffice.org/41783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-30Resolves: tdf#95960 improve custom properties pageCaolán McNamara
wrt widget heights and positions and other flakiness take the natural combobox height as the line height, use a vclgrid element for each row to get everything set to the same height move the positioning code into Resize, etc. Change-Id: I22de98ef91e39d1e7e45bbe62f68496d55c0c1cb Reviewed-on: https://gerrit.libreoffice.org/41734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-30gpg4libre: Add flag for filters that support GPG encryptionKatarina Behrens
Change-Id: I48518f26a3ccbe430d36fb6657bdeff0943492d3 Reviewed-on: https://gerrit.libreoffice.org/41263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-20drop unused SfxSpellCheckItemJochen Nitschke
last getter went with commit 215207f480258b37864a88e1b831055e148adf65 Date: Thu Mar 6 16:42:24 2014 +0000 coverity#708784 Unused pointer value don't put the item in any item sets anymore. delete SID_ATTR_SPELL and adjust SfxItemSet ranges. narrow ranges in OfaTreeOptionsDialog::CreateItemSet to actually used items. Change-Id: Ia5cc91fc62a0fccf87b2fd380e6bb2bef1f6f3e7 Reviewed-on: https://gerrit.libreoffice.org/41335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19templatelocnames.src no more existsAndrea Gelmini
I guess the content now is in sfx2/inc/strings.hxx Change-Id: Ie41f150f95d5da80ed82f09760b812910ac2ab8a Reviewed-on: https://gerrit.libreoffice.org/41316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-08-17implementing callback for ruler invalidationAditya Dewan
adding commands to fetch and changee ruler state '.uno:RulerState' and '.uno:RulerStateChange' Change-Id: I66107039a7ae5893691feb45c8ab2e4aa476ea76 Reviewed-on: https://gerrit.libreoffice.org/40727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-08-15tdf#100864 Assign a tooltip to the button to close paneTakeshi Abe
which appears at the top-right corner of both Impress's Slide Pane and Draw's Page Pane. Change-Id: Ida52ccc35e42546cd6260001e22335b04608034d Reviewed-on: https://gerrit.libreoffice.org/40803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-08-08loplugin:unusedmethodsNoel Grandin
Change-Id: Id66cf12e3a59aeed1b9a7a111b841e30b248635b Reviewed-on: https://gerrit.libreoffice.org/40876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08tdf#109208 Clear the list of recently used charactersAkshay Deep
Change-Id: I57a3417b95d38e490e160fe48a57c2cbfc32a5d3 Reviewed-on: https://gerrit.libreoffice.org/40874 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2017-08-08loplugin:constantparamNoel Grandin
Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e Reviewed-on: https://gerrit.libreoffice.org/40843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-07Removing unused SfxItemPool serialisation from sfx2Varun Dhall
Change-Id: Ibb14fcd656f401cb9d2ad57ab63f6cfecf49807d Reviewed-on: https://gerrit.libreoffice.org/40814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-03lok - add support for in place chart editingMarco Cecchetti
This commit add a minimal support for editing chart embedded in a spreadsheet or a text document or a presentation. Graphic objects can be moved and resized, text objects can be edited. Change-Id: I8e637dabf328a94bd6bb0e309a245302cff421d8 Reviewed-on: https://gerrit.libreoffice.org/39342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-08-02tdf#110448: Remove "Memory" page from Options dialogMike Kaganski
The relevant caches settings are still available under Expert Configuration: /org.openoffice.Office.Common/Cache/GraphicManager/TotalCacheSize /org.openoffice.Office.Common/Cache/GraphicManager/ObjectCacheSize /org.openoffice.Office.Common/Cache/GraphicManager/ObjectReleaseTime /org.openoffice.Office.Common/Cache/DrawingEngine/OLE_Objects /org.openoffice.Office.Common/Cache/Writer/OLE_Objects Change-Id: I7692fd94a873ba7220a21d51ff8a943598c6a9fc Reviewed-on: https://gerrit.libreoffice.org/40640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-02normalize resource locale ctor construction mechanismsCaolán McNamara
make them all the same and share std::locales more various OModuleClient, etc, classes go away Change-Id: I7e3ff01a69332eeacd22e3078f66a60318de62d5 Reviewed-on: https://gerrit.libreoffice.org/40634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-31make IntlWrapper arg to GetPresentation non-implicit and non-optionalCaolán McNamara
which requires explicitly adding null in 1) SdrItemBrowserControl::SetAttributes(const SfxItemSet* pSet, const SfxItemSet* p2ndSet) where SdrItemBrowserControl is only used by SdrItemBrowser and the only use of that is within DBG_UTIL in SdrPaintView 2) SwCursorShell::GetContentAtPos( const Point& rPt, within a #ifdef DBG_UTIL block in 3) SvxSearchDialog::BuildAttrText_Impl( OUString& rStr, bool bSrchFlag ) const where the other branch uses SvxResId 4) SfxPoolItem::dumpAsXml(xmlTextWriterPtr pWriter) const 5) XFillStyleItem::dumpAsXml(xmlTextWriterPtr pWriter) const looks very much like all uses (outside the dumpers) are intended to be in the ui locale results in that INetContentTypes::GetPresentation always called with UI Locale Change-Id: I5a110c107838b4db3c355476426d6532f2b6ce52 Reviewed-on: https://gerrit.libreoffice.org/40538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-28loplugin:constparams handle constructorsNoel Grandin
had to change the structure of the plugin considerably, was too messy to structure it to do the calculations on a per-function basis Change-Id: I4edee7735f726101105c607368124a08dba21086 Reviewed-on: https://gerrit.libreoffice.org/40516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28sfx2 lokhelper: indentation fixesMiklos Vajna
These files had a consistent style before, let's keep them that way. Change-Id: I8a05a8fbbc193373e0815f27d2cd9ff1272ba0eb
2017-07-26convert SfxGroupId to scoped enumNoel Grandin
in the process I had to teach the idl compiler to cope with identifiers like SfxGroupID::Math, which has the side effect of requiring a space before a ':' in some of the .sdi files. Change-Id: If256599cb8aa1dfc0a33642c5070c5560702f3ba Reviewed-on: https://gerrit.libreoffice.org/40441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26loplugin:unusedfieldsNoel Grandin
Change-Id: I21e538b8e9c7a5f0fb233019efac37a3555e3c93 Reviewed-on: https://gerrit.libreoffice.org/40438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>