summaryrefslogtreecommitdiff
path: root/include/sfx2
AgeCommit message (Collapse)Author
2016-06-30LOK: change back type of view ids to intMiklos Vajna
Commit 45c2410041c48c22bd860efb42d4daadad7869b0 (LOK: change type of view ids to uintptr_t, 2016-06-17) fixed the problem of view IDs being reused for the price of random IDs, which makes debugging harder. Implement a simple shellToView() function that makes sure view IDs are not reused, and stop exposing view shell pointer addresses, which allows reverting the LOK API change. Change-Id: I63089e6de08ee7e1c7706757d43a11f6cf4d6e06 Reviewed-on: https://gerrit.libreoffice.org/26773 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-29Reinstate: tdf#99729: fix text alignment (no autofit & no full width)Caolán McNamara
with extra disposes to shutdown the test thingies in the right order This reverts commit a4780b3c8b45261e59ed3cbb34c4463d58ad8079. Change-Id: I13282d6bc54a0dceb3ed91a04cd438a9011154fe Reviewed-on: https://gerrit.libreoffice.org/26756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29Revert "tdf#99729: fix text alignment (no autofit & no full width)"Miklos Vajna
This reverts commit 0cb200d000fad8ba31c7400e08cd031823f27308. Even if it was verified by Jenkins, it broke CppunitTest_sd_import_tests on a number of tinderboxes. Need to at least find out how to reliably trigger the crash and fix it before it goes in again. Change-Id: I7ed52cae559648ec101b7a343046a7d74a7c48d3
2016-06-28tdf#99729: fix text alignment (no autofit & no full width)Mike Kaganski
If TextBox contained text that is larger than the box, and autofit was off, and autosize was off, and full width was off, then text always aligned to box's left top corner, regardless of text anchor setting. Related problem (i103454) was fixed in 2009 by Armin Le Grand, but only for full width text. This patch extends the scope of that fix to correctly process other cases. The fix introduces a new compatibility flag: AnchoredTextOverflowLegacy If it is true, then old behaviour is retained. It is always false for new documents and imported documents. When opening existing ODF documents, it's true by default, unless it is explicitly set in settings.xml. Unfortunately, I couldn't find a way to access the document model from any of SfxBaseModel::load() or SfxObjectShell::DoLoad, where it could enable setting the compatibility flag universally when loading own format. Instead, I had to do it individually in each of SfxObjectShell::Load() implementations. Unit test is included. Change-Id: Ifad79d546739daafff59fb6c7fb0dce51babc53d Reviewed-on: https://gerrit.libreoffice.org/26737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-28IsOwnStorageFormat can apparently be a private helper functionStephan Bergmann
Change-Id: I5b36d48749faaab7c1280b5d086bf0d65a313469
2016-06-28loplugin:staticmethodsStephan Bergmann
Change-Id: I3f94a493822b8f6f83473578cd133a54ecc6be30
2016-06-28notebookbar: added slide transition tabSzymon Kłos
- created VclVBox control which creates SlideTransitionPane - SlideTransitionPane extended with second constructor which loads ui in horizontal mode - introduced CloseMethod for NotebookBar to kill widgets in right order Change-Id: Ic3ba35cb7734aa744a4804c5b670fed7c1bec204 Reviewed-on: https://gerrit.libreoffice.org/25844 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-28tdf#99729 related: make SfxObjectShell::IsOwnStorageFormat acccessibleMike Kaganski
This patch removes SAL_DLLPRIVATE attribute and renames SfxObjectShell::IsOwnStorageFormat_impl() to SfxObjectShell::IsOwnStorageFormat() to allow unsing in derived classes in other modules. Change-Id: I24650ad4624adc117d08b0e747c05ff050b4046d Reviewed-on: https://gerrit.libreoffice.org/26732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-27GSoC notebookbar: switching tabs depending on contextSzymon Kłos
+ sfx2::sidebar::EnumContext moved to the vcl module + TabPage contains vector with context values + vcl builder reads control's contexts from the "class" mark + ContextTabControl shows tabs depending on context Change-Id: I661b0d3f35d46ace2a2e8eb1d374148f0c60017d Reviewed-on: https://gerrit.libreoffice.org/26447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-27SfxProgress::SetState always returns trueStephan Bergmann
Change-Id: Ib606b0391f814ea9ff4383397a40a8a692563fa3
2016-06-27GSoC: Remove TemplateRemoteView from Template ManagerAkshay Deep
Conflicts: include/sfx2/templatedlg.hxx sfx2/source/doc/templatedlg.cxx Change-Id: Ia0623707e452c79346d92b5a5ab75a4063928c20 Reviewed-on: https://gerrit.libreoffice.org/26658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-24loplugin:singlevalfields in sfx2Noel Grandin
Change-Id: Ice6d47ccbc3ebf8971887b8b64c0d6860c76eec8 Reviewed-on: https://gerrit.libreoffice.org/26602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23Remove unused SfxObjectShell::libreOfficeKitCallback()Miklos Vajna
All clients have been converted to use SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: I793dad5194769f331037b12a1b1afba96ddea4ba Reviewed-on: https://gerrit.libreoffice.org/26584 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-21sw lok: add LOK_CALLBACK_TEXT_VIEW_SELECTIONMiklos Vajna
So a view can be aware where selections of other views are. Change-Id: I5026b1ff2b99a4eedfd0bde32a05ceb8e2f424bc Reviewed-on: https://gerrit.libreoffice.org/26542 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-21sfx2 lok: fix missing view cursors in a new viewMiklos Vajna
When a new view was created, the old views got the position of the new view, but not the other way around. Make sure that the old views notify the new one right after registering the callback. Change-Id: If26edbd57aa939e453d95f4907a0e5722329dd65 Reviewed-on: https://gerrit.libreoffice.org/26523 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20sw lok: add LOK_CALLBACK_INVALIDATE_VIEW_CURSORMiklos Vajna
So a view can be aware where cursors of other views are. Change-Id: I6133fb55aa2869843c0284b7d76264bab3b3d5da Reviewed-on: https://gerrit.libreoffice.org/26513 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-18uitest: support selecting different tab pages in tab dialogMarkus Mohrhard
Change-Id: I541f83a87f5f3d459b2baf4587b76cb2fce5d5fc
2016-06-18uitest: a slightly better approach for the factory problem in the ui testingMarkus Mohrhard
Change-Id: I15dbf2446791c4be9be4e18e63c0d03104d8d405
2016-06-17LOK: change type of view ids to uintptr_tMiklos Vajna
This fixes the following problem: - createView() = 1 - createView() = 2 - destroyView(1) and then view #2 was renumbered to 1. Instead expose the pointer address of the SfxViewShell as the ID, which is not changing in such a situation. Note that the SfxViewShell <-> ID mapping is an implementation detail of SfxLokHelper, and only pointers are converted to IDs, user-supplied IDs are never converted back to pointers. Change-Id: If79ef8b99ba391011b5d82b219ad13447d44cd5a Reviewed-on: https://gerrit.libreoffice.org/26423 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16tdf#100068: ScreenshotId for tab dialogsKatarina Behrens
Change-Id: I80ec2cef190d106bb45455424a6a0ed901590221 Reviewed-on: https://gerrit.libreoffice.org/26155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-15sfx2: bring the view shell's LOK callback up to date with SdrModelMiklos Vajna
This fixes CppunitTest_sw_tiledrendering in the LOK_VIEW_CALLBACK=1 case. Change-Id: Ib79e57908c3edda0154341baba8279ede4281a42 Reviewed-on: https://gerrit.libreoffice.org/26313 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10editeng: implement per-view LOK_CALLBACK_INVALIDATE_VISIBLE_CURSORMiklos Vajna
Given that the per-view callback is in SfxViewShell, and editeng doesn't depend on sfx2, add an interface class in editeng to invert the dependency. With this, gtktiledviewer no longer crashes when starting editeng text edit with per-view callbacks. Change-Id: I783cdc646b890a6b597000f1d88428c8042417cf Reviewed-on: https://gerrit.libreoffice.org/26169 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10Move accessibility relations to .ui files, Part 8: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. Change-Id: I04244b360b4bb32ccbbe5bde4756a9166ae1fcaf Reviewed-on: https://gerrit.libreoffice.org/26018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-10sfx2: implement per-view LOK_CALLBACK_STATE_CHANGEDMiklos Vajna
With this, bindings updates ("cursor moved into a bold area", etc) are correctly sent to (and only to) the matching view. Change-Id: If10ff46dd0243cfc2f1c5566c53a7e81efa635b4 Reviewed-on: https://gerrit.libreoffice.org/26145 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10GSoC: Template Manager: Enable Keyboard shortcutsAkshay Deep
delete key: delete operation shift-f10 and contextmenu: create context-menu ctrl + A: select all Conflicts: sfx2/source/control/templateabstractview.cxx Change-Id: I97486c050c5dbb88b8551aa8a9bb9ba4285ad003 Reviewed-on: https://gerrit.libreoffice.org/26044 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-09Templates: Display titles and category as tooltipsAkshay Deep
Tooltip text: 1. Template Manager: All Categories: Title + Category Category: Title 2. Start center: Title Conflicts: sfx2/source/doc/doc.hrc Conflicts: sfx2/source/doc/templatedlg.cxx Change-Id: I0bfd5e78120f13338f88c1b0617df3a057cce02f Reviewed-on: https://gerrit.libreoffice.org/26040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-09tdf#100260 Template Manager: Cannot open context menu without mouseAkshay Deep
Change-Id: I900cc79e2834c1942840ee9fb1a8ab680b646c92 Reviewed-on: https://gerrit.libreoffice.org/26082 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08Disable multiselection in Impress Template SelectionAkshay Deep
Added possibility to select single item in ThumbnailView. Then, used it in Template Selection dialog. Change-Id: I39b2ea83479ae1536285d4037fb1d24455a52ddc Reviewed-on: https://gerrit.libreoffice.org/25998 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08tdf#96099 Remove SfxInterfaceArr_Impl typedefMark Page
Added comment in SfxModule with warning about using smart pointers Change-Id: I1997d41a0a77c7e82e486bcdaee0ea876fdc61ad Reviewed-on: https://gerrit.libreoffice.org/25999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-07Missing selected + hover state in Template ManagerAkshay Deep
Change-Id: I35c91cea34953a5c4a78031eb809001e902197f1 Reviewed-on: https://gerrit.libreoffice.org/26013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-07Reset Default in Context Menu for default templatesAkshay Deep
Change-Id: Ifedb4f5b4dada0e9e0ac40ffcaed4c2821df501d Reviewed-on: https://gerrit.libreoffice.org/25995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-06Revert "Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule ↵Noel Grandin
flag"" This reverts commit abde31a2bc68302e1afafe1fcc3f5d85369010f8. Since my analysis was completely incorrect, and the bug was elsewhere.
2016-06-06tdf#89329: use rtl::Reference for pImpl in querystatusXisco Fauli
Change-Id: Iebc26867ebca7b61c0c54eb36bef035f4c9fc28a Reviewed-on: https://gerrit.libreoffice.org/25909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06Improve Impress Template Selection DialogAkshay Deep
1. Hide controls: export, move, action menu, repository menu, Online Button 2. Checkbox to easily hide the dialog Change-Id: Id2899edb9ba280c9a714d09fa534f975600b05af Reviewed-on: https://gerrit.libreoffice.org/25913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-06Hitting return in search field should not open a templateAkshay Deep
Change-Id: I85d8096489debdbda1b3883f9335dd1218e567ec Reviewed-on: https://gerrit.libreoffice.org/25915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-06tdf#94131 Easier access to set a default template when saving a templateAkshay Deep
Change-Id: I2a3732a178f47ce49c77089a6e0865b609efd499 Reviewed-on: https://gerrit.libreoffice.org/25916 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-06Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flag"Noel Grandin
This reverts commit e319ef1171dab61fff2201f5c1470ca09894c395. Apparently, at some point, someone added a 'bool bDummy' param to SfxModule, but only updated 2 of the 5 callsites. Since we're passing in pointers here, at the other call sites, the bDummy param evaluated to 'true'.
2016-06-06Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flagMark Page
The SfxModuleArr_Impl is a static container of SfxModule, since this is private to the SfxModule class it does not require wrapping. The bDummy flag is unused, and complicates the class Change-Id: Ib03b215543a0c37d4edf20b2d0fc141a783e115e Reviewed-on: https://gerrit.libreoffice.org/25859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06loplugin:staticmethodsTor Lillqvist
Change-Id: I1c178eedb1443372cdc474e36133400c0ad476ba
2016-06-06loplugin:passstuffbyrefTor Lillqvist
Change-Id: Ie1cd7d63aaf2963137138def86cf5f4e141569b2
2016-06-06tdf#89329: use unique_ptr for pImpl in objshXisco Fauli
Change-Id: I572436af608821c3f6fad4deb66ebe2598a2df8a Reviewed-on: https://gerrit.libreoffice.org/25912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in prnmonXisco Fauli
Change-Id: I73fe5dc51f2352c5def618ad4011b436f15230a2 Reviewed-on: https://gerrit.libreoffice.org/25900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in viewfrmXisco Fauli
Change-Id: I330b3910e3e551ce43c2772fc63777de27901e0d Reviewed-on: https://gerrit.libreoffice.org/25910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in unoctitmXisco Fauli
Change-Id: I580c6c9999b35137ae883a84898b9d03fd7cb056 Reviewed-on: https://gerrit.libreoffice.org/25899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in appXisco Fauli
Change-Id: Ia4e53f6e2973c1dd439e22bd93329bfc6e21ba75 Reviewed-on: https://gerrit.libreoffice.org/25908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in mailmodelapiXisco Fauli
Change-Id: I12a6cb23b938f0d9151fb90437956ddb9d63d66f Reviewed-on: https://gerrit.libreoffice.org/25907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in viewshXisco Fauli
Change-Id: I8847b734c90adf2710f5481af41883eb5017c44a Reviewed-on: https://gerrit.libreoffice.org/25911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-07 02:16:55 +0000