Age | Commit message (Collapse) | Author |
|
and put an assert in SfxPoolItem::SetWhich() so nothing new
creeps in.
Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df
Reviewed-on: https://gerrit.libreoffice.org/24324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0
Reviewed-on: https://gerrit.libreoffice.org/22900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ifc82563c8930332d460df4d97935ba6e9946689f
|
|
Change-Id: Ib2dc804f55d1a96ae01f2cf31b7d55956040a72e
Reviewed-on: https://gerrit.libreoffice.org/21603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I759fe8769daccea07c2157bfb5912df8ba285534
|
|
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
|
|
tools/rtti.hxx removed
completed the interface of some Sdr.* Items
and removed pseudo items
Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
|
|
Change-Id: I0f2f81dae91f62639e79799b1bed1b2df1fd79ab
|
|
Change-Id: I61326bc52a5da527930810ff4516c707c31d1fde
|
|
And introduce the appropriate assert() in the templatized version instead.
Change-Id: I3e5b01e5e5ee49049fa6f35e3d05ef65a1890dc1
|
|
Change-Id: I110a4f25646eb3f0fa93673c84dc67cf64a3b7a0
|
|
Change-Id: I1e0f96dce2b9cf9da32f4f577cf76e1d8824d37a
|
|
Change-Id: I821622fc1f8415f2ddd14744f33b46fa76f00039
|
|
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
|
|
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
|
|
Change-Id: Icf3e09318677655897f4a5308f066829982b9520
|
|
Change-Id: I801aaa8ad9a4ff08dedd2f92b09d98c870c725b8
|
|
Change-Id: I30cb1a3c99ad5116cc2d014a7bbb1048fe8cb9f8
|
|
Change-Id: Id4f2e6cd7d689ac0b4688d92780b48d51427307a
|
|
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I011a0eae37d01606d28c00f8ab3839f20bf309ce
|
|
after commit 039b887c54fd7e8cd8a4964d1633fdfc300e938e
"loplugin: cstylecast"
Change-Id: If567653833a1f164a72bd9a5a6c0fcf651e9d3c0
|
|
Change-Id: I4a230f45e91773fca7d537e91c9e9fb54773cf10
|
|
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState")
Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I893adbd54916c337fa23aaccb2865f56d076cdb8
Reviewed-on: https://gerrit.libreoffice.org/11347
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
This was apparently disabled before the MI_HATS_REPARIERT check was
removed in f03a3edf2523c208948059861e0df48567834d0d, and then yesterday
something in the header inclusions changed to enable the DBG macros that
still used the removed stuff, but _only_ on Windows... now clean this up.
Change-Id: I4222db252f4a886b3497ca0c22dbec26eaa6c994
|
|
Change-Id: I9143e7fffef6e99d25a0fd87712ed26d2d42116e
|
|
Change-Id: Id523ae3f50147fd778a1576c2851d01e1ea8c3ae
|
|
Change-Id: I6938314a08d061d2b07d9129742d74a989bd1385
|
|
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
|
|
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
|
|
8f8bc0dcf3bc253ae49159d52db049767f476ced "Move string hash function into String
class" had introduced a new getHash64 that, besides returning sal_uInt64 instead
of just sal_Int32, didn't do sampling of only a handful of characters, but
always computed the hash over all characters (as the usage in SfxItemSet and
SdPage appears to require for either performance or approximated correctness).
However, it would be advantageous to keep the stable URE interface as small as
possible. Now, O(1) sampling was apparently considered state of the art when
the rtl string classes were first created, closely copying java.lang.String,
which at that time demanded sampling for hashCode(), too---but never sampling
more than 15 characters, with the obvious (in hindsight, at least) performance
catastrophes, so they changed it to O(n) somewhere along the way.
Based on that, this commit changes the existing hash functions to not do
sampling any more, and removes the newly introduced -64 variants again. (Where
the extended value range of sal_uInt64 compared to sal_Int32 was hopefully not
vital to the existing uses.)
The old implementation used sampling only for strings of length >= 256, so I did
a "make check" build with an instrumented hash function that flagged all uses
with inputs of length >= 256, and grepped workdir/{Cppunit,Junit,Python}Test for
hits. Of the 2849 hits encountered, 2845 where in the range from 256 to 295
characters, and only the remaining four where of 2472 characters. Those four
were from CppunitTest_sc_subsequent_filters_test, importing long text into a
cell, causing ScDocumentImport::setStringCell to call
svl::SharedStringPool::intern, which internally uses an unordered_set. These
results appear to justify the change.
Change-Id: I78fcc3b0f07389bdf36a21701b95a1ff0a0d970f
|
|
While copying slides to different slide decks,
styles were not being copied if there is already one
with the same name. This patch renames and copies those
to keep the formatting intact.
Change-Id: I66f71493f1fd658eed43e39aa7ae7ee7b5463b34
|
|
...and need not be virtual
Change-Id: I8cf38c4942526c6ca66595fdc3297be750ec09a0
|
|
Change-Id: I0452b1fa83c52a7466a025259b086e82ec1dba83
Reviewed-on: https://gerrit.libreoffice.org/7734
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Make inherited overloads visible via "using" in SfxAllItemSet.
* The overload with SfxItemSet argument:
** need not be virtual (verified by temporarily marking it SAL_FINAL);
** should apparently return bool.
Change-Id: I5c57ec3d757d3d32a3e23be12964e7ebb81e6211
|
|
Change-Id: Icb38319f1307e94ce5c6d43b999a08db1fc38d85
|
|
Has part feature of getting hashes of SdPages.
(Misses hashing text, images, etc).
|
|
Change-Id: I8b28f3c6df5d11112aff732159c913b4ffb1cc6f
|
|
Change-Id: I57fcfd442d2b5815e7c07a9cbd660f3698168dee
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details
Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
|