Age | Commit message (Collapse) | Author |
|
Change-Id: I2b9d379e56e0af655aa06afb5391140de952b9d6
|
|
Change-Id: I675c488742219cc19624a21d1fc8e5033e7cbefa
|
|
.. in favour of just using the underlying constants from
css::util::NumberFormat
Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
|
|
Change-Id: I412137e7e7b9b2b87f401bc140a9499d1fc012c6
|
|
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
|
|
Change-Id: I7cb0b7977b221438e4359c5c96c174f7401f9857
Reviewed-on: https://gerrit.libreoffice.org/14496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I30cb1a3c99ad5116cc2d014a7bbb1048fe8cb9f8
|
|
Change-Id: Id4f2e6cd7d689ac0b4688d92780b48d51427307a
|
|
Change-Id: I8ed7028f865bd4a6425859ab3b57ed8e928a78e4
|
|
Change-Id: Ic031b63641e0fd0fbd1524657082188d9ce78fcf
|
|
Change-Id: I7ec2071150c03b61f3f681dbd26968ae3c535742
|
|
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
|
|
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
The primary benefit of this is that it's no longer necessary to manually
downcast to each and every subclass in sw.
Change-Id: I5742d5744836eef192eef2d4f7ad180da67eb914
|
|
The Itanium C++ ABI mandates that for a unique (complete) C++ type a single
unique symbol for the type's RTTI name is used across a process's dynamic
objects (so type equivalence can be determined via pointer comparison on the
RTTI names).
GCC nowadays deviates from that, using strcmp to determine equivalence, so it is
resilient to RTTI names being bound locally within dynamic objects (which has
performance benefits, but also makes it impossible to have unrelated types that
happen to have the same name "encapsulated" in individual dynamic objects---
whether or not that would violate the ODR would be open to interpretation of how
dynamic objects fit into the C++ Standard).
LLVM sticks to the Itanium ABI, which becomes notable in at least two places:
For one, libc++abi's __dynamic_cast uses strict checking. It still has a
_LIBCXX_DYNAMIC_FALLBACK for now that additionally uses strcmp checking and
syslogs visibility violations. Mac OS X uses libc++abi with
_LIBCXX_DYNAMIC_FALLBACK enabled, and running LO routinely logs dynamic_cast
errors to the Console there.
For another, RTTI-based UBSan checks unconditionally only use strict checking
(cf. isDerivedFromAtOffset in lib/ubsan/ubsan_type_hash.cc). This causes false
positives from Clang -fsanitize=function and -fsanitize=vptr even on Linux not
using libc++abi.
Therefore, introduce SAL_DLLPUBLIC_RTTI to mark types for which RTTI needs to
have default visibility under the Itanium/LLVM semantics. There is
unfortunately no way to mark only the (implicitly generated) RTTI symbols for
default visibility, but at least with the cases where SAL_DLLPUBLIC_RTTI is used
for now that is no real problem---any class type marked SAL_DLLPUBLIC_RTTI only
has inline (covered by -fvisibility-inlines-hidden) or undefined pure virtual
functions. It appears that even the vtables of those classes remain hidden, at
least with Mach-O on Mac OS X. (That also means there is no need for a
SAL_DLLPRIVATE_RTTI marker analoguous to the---also superfluous in retrospect---
CPPU_GCC_DLLPRIVATE one.)
Nevertheless, the number of exported symbols of course increases when
SAL_DLLPUBLIC_RTTI is "active." For a full-blown --enable-dbgutil build on Mac
OS X,
find instdir/LibreOffice.app/Contents -name \*.dylib\* -exec nm -gU {} \; \
wc -l
increased from 125541 to 139239. For Linux, an option might be to "activate"
SAL_DLLPUBLIC_RTTI only for __clang__ plus !ENABLE_RUNTIME_OPTIMIZATIONS.
The set of types marked SAL_DLLPUBLIC_RTTI with this patch (wholesale cppumaker-
generated UNO enum, struct, and interface types; plus some IEmbeddedHelper and
IUndoManager) is chosen so that a full "make check" on Mac OS X no longer
syslogs any dynamic_cast errors to the Console.
Change-Id: I42fa6ec01c2503ec24bcd9c0518abb112afa3235
|
|
Change-Id: If218d83297bfdd39471d5502c0639248c96af9c6
|
|
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
|
|
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
|
|
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
|
|
Change-Id: I62e49fbf27364bd244099a9bb247452d5a691119
|
|
Change-Id: Ibcd2199db171c531018301631d76ec56924da23a
Reviewed-on: https://gerrit.libreoffice.org/13511
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ia58bed9c4a0be4b909789e8bdcd64f06230c0f43
|
|
so code isn't generated for it unless the new_clone is required,
which it isn't under gcc.
Change-Id: I07e0b3e4b2e07625509b51ba7d37e24440f56cfe
|
|
doing so means code is not generated for it seeing as its not used, moving it
out means code is generated for it and its detected as unused code
Change-Id: I72edc89446bdfac50069e0b509fc7f90540e0d4a
|
|
Change-Id: I8d8528c74bae3de67a0a9bdd727cd0d8c8304d3e
|
|
And remove #include <vector> which wasn't really used.
Change-Id: I05bbc7848c753795f859f80725be6332d8e5ce46
|
|
Change-Id: Ie2f07ae8c7b6cdf4ee3f49847b6fbf79895780db
|
|
Change-Id: I1c36077cada47bacfb8436cf3fb659e47d02da60
|
|
Change-Id: Ic82755788df237c455c802a039881a9d056f4df2
|
|
Change-Id: I35ef457111f4cf8b811a4ee8bb676421746e1d9d
|
|
Change-Id: I98262000956f10dc3b3da069b6bc286fec314a45
|
|
Change-Id: Ia25b857738bb7b6c3baf18c68ef0d1bc0b3e142e
|
|
Change-Id: I0d1d73402f11cc61ea9e7629bea34e24c22f5beb
|
|
Change-Id: Ie9d42f15e2881f1f4bb78147d0250a174d9542c1
|
|
When undoing row deletion (and possibly other similar undo's). And
write test for it.
Change-Id: I04b4fd9932f4236f124dcd25967355c6055dec33
|
|
Change-Id: Ia69463f1466349af879da02a23b58702732011c6
|
|
Change-Id: Id4e0852f6d204b3a1d2a7f5ce281730f5fcad8fd
|
|
Change-Id: Id2e35c19bf2efb73e6a0939cccf37c92ca30c0aa
|
|
Change-Id: Ic385faed251970c0c686b099023af9efca10a121
Reviewed-on: https://gerrit.libreoffice.org/13040
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
This fixes Windows build breakage.
Change-Id: I188e38b20674700132c7d7c78304f58748540556
|
|
Change-Id: I17b52c277ab6ec8b15e88729feee0a269b75087d
|
|
This is a high-impact header, included by hundred's of source files.
Change-Id: I2b7f1c9e8ffe81ddccd1a541e3474ca302a27e90
|
|
Change-Id: I351505f0c1cb25c47897e0cfffdb258f8e87081f
|
|
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
|
|
Change-Id: I8c175dcaaa51e2b05895226907697b070a2e2f77
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
this unloved streaming format is internal only now and used
for editengine c&p and (reportedly) autotable format storage.
So we shouldn't encounter version 1 files anymore
coverity#1242764 Untrusted loop bound
Change-Id: If8e5717e997cf915f45f6e9484bb97d472e4dc2f
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I56d18dec48ccccab637ed3d818f4dd757c6f873b
|