summaryrefslogtreecommitdiff
path: root/include/svl
AgeCommit message (Collapse)Author
2015-03-02convert SVX_SEARCHAPP_ constants to enum classNoel Grandin
Change-Id: I2b9d379e56e0af655aa06afb5391140de952b9d6
2015-03-02replace SVX_SEARCHCMD_ constants with enum classNoel Grandin
Change-Id: I675c488742219cc19624a21d1fc8e5033e7cbefa
2015-02-25remove NUMBERFORMAT_ constantsNoel Grandin
.. in favour of just using the underlying constants from css::util::NumberFormat Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
2015-02-18boost->stdCaolán McNamara
Change-Id: I412137e7e7b9b2b87f401bc140a9499d1fc012c6
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-16Document SfxItemStateUrsache Vladimir
Change-Id: I7cb0b7977b221438e4359c5c96c174f7401f9857 Reviewed-on: https://gerrit.libreoffice.org/14496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-08Extract SfxItemSet::dumpAsXml() from swMiklos Vajna
Change-Id: I30cb1a3c99ad5116cc2d014a7bbb1048fe8cb9f8
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: Id4f2e6cd7d689ac0b4688d92780b48d51427307a
2015-02-03callcatcher: shave off some moreCaolán McNamara
Change-Id: I8ed7028f865bd4a6425859ab3b57ed8e928a78e4
2015-02-01Extract SfxUndoManager::dumpAsXml() from swMiklos Vajna
Change-Id: Ic031b63641e0fd0fbd1524657082188d9ce78fcf
2015-01-31Extract SfxUndoAction::dumpAsXml() from swMiklos Vajna
Change-Id: I7ec2071150c03b61f3f681dbd26968ae3c535742
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-23Factor out SfxPoolItem::dumpAsXml() from swMiklos Vajna
The primary benefit of this is that it's no longer necessary to manually downcast to each and every subclass in sw. Change-Id: I5742d5744836eef192eef2d4f7ad180da67eb914
2015-01-22SAL_DLLPUBLIC_RTTI for proper RTTI visibility for LLVMStephan Bergmann
The Itanium C++ ABI mandates that for a unique (complete) C++ type a single unique symbol for the type's RTTI name is used across a process's dynamic objects (so type equivalence can be determined via pointer comparison on the RTTI names). GCC nowadays deviates from that, using strcmp to determine equivalence, so it is resilient to RTTI names being bound locally within dynamic objects (which has performance benefits, but also makes it impossible to have unrelated types that happen to have the same name "encapsulated" in individual dynamic objects--- whether or not that would violate the ODR would be open to interpretation of how dynamic objects fit into the C++ Standard). LLVM sticks to the Itanium ABI, which becomes notable in at least two places: For one, libc++abi's __dynamic_cast uses strict checking. It still has a _LIBCXX_DYNAMIC_FALLBACK for now that additionally uses strcmp checking and syslogs visibility violations. Mac OS X uses libc++abi with _LIBCXX_DYNAMIC_FALLBACK enabled, and running LO routinely logs dynamic_cast errors to the Console there. For another, RTTI-based UBSan checks unconditionally only use strict checking (cf. isDerivedFromAtOffset in lib/ubsan/ubsan_type_hash.cc). This causes false positives from Clang -fsanitize=function and -fsanitize=vptr even on Linux not using libc++abi. Therefore, introduce SAL_DLLPUBLIC_RTTI to mark types for which RTTI needs to have default visibility under the Itanium/LLVM semantics. There is unfortunately no way to mark only the (implicitly generated) RTTI symbols for default visibility, but at least with the cases where SAL_DLLPUBLIC_RTTI is used for now that is no real problem---any class type marked SAL_DLLPUBLIC_RTTI only has inline (covered by -fvisibility-inlines-hidden) or undefined pure virtual functions. It appears that even the vtables of those classes remain hidden, at least with Mach-O on Mac OS X. (That also means there is no need for a SAL_DLLPRIVATE_RTTI marker analoguous to the---also superfluous in retrospect--- CPPU_GCC_DLLPRIVATE one.) Nevertheless, the number of exported symbols of course increases when SAL_DLLPUBLIC_RTTI is "active." For a full-blown --enable-dbgutil build on Mac OS X, find instdir/LibreOffice.app/Contents -name \*.dylib\* -exec nm -gU {} \; \ wc -l increased from 125541 to 139239. For Linux, an option might be to "activate" SAL_DLLPUBLIC_RTTI only for __clang__ plus !ENABLE_RUNTIME_OPTIMIZATIONS. The set of types marked SAL_DLLPUBLIC_RTTI with this patch (wholesale cppumaker- generated UNO enum, struct, and interface types; plus some IEmbeddedHelper and IUndoManager) is chosen so that a full "make check" on Mac OS X no longer syslogs any dynamic_cast errors to the Console. Change-Id: I42fa6ec01c2503ec24bcd9c0518abb112afa3235
2015-01-22Factor out SfxStringItem::dumpAsXml() from swMiklos Vajna
Change-Id: If218d83297bfdd39471d5502c0639248c96af9c6
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-22callcatcher: update unused codeCaolán McNamara
Change-Id: I62e49fbf27364bd244099a9bb247452d5a691119
2014-12-18fdo#39468 translate German commentsMichael Weghorn
Change-Id: Ibcd2199db171c531018301631d76ec56924da23a Reviewed-on: https://gerrit.libreoffice.org/13511 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-14Factor out SfxUInt16Item::dumpAsXml() from swMiklos Vajna
Change-Id: Ia58bed9c4a0be4b909789e8bdcd64f06230c0f43
2014-12-12leave this Clone as inlineCaolán McNamara
so code isn't generated for it unless the new_clone is required, which it isn't under gcc. Change-Id: I07e0b3e4b2e07625509b51ba7d37e24440f56cfe
2014-12-12leave the deliberately unused, not-for-use method inlineCaolán McNamara
doing so means code is not generated for it seeing as its not used, moving it out means code is generated for it and its detected as unused code Change-Id: I72edc89446bdfac50069e0b509fc7f90540e0d4a
2014-12-12svl: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I8d8528c74bae3de67a0a9bdd727cd0d8c8304d3e
2014-12-08Move IndexedStyleSheets to the Imp(l) class.Kohei Yoshida
And remove #include <vector> which wasn't really used. Change-Id: I05bbc7848c753795f859f80725be6332d8e5ce46
2014-12-07WaE: overriding destructor declaration not explicitly marked 'virtual'Tor Lillqvist
Change-Id: Ie2f07ae8c7b6cdf4ee3f49847b6fbf79895780db
2014-12-07Forward-declare MarkedUndoAction.Kohei Yoshida
Change-Id: I1c36077cada47bacfb8436cf3fb659e47d02da60
2014-12-07Pimplize SfxListUndoAction.Kohei Yoshida
Change-Id: Ic82755788df237c455c802a039881a9d056f4df2
2014-12-07Pimplize SfxUndoActions.Kohei Yoshida
Change-Id: I35ef457111f4cf8b811a4ee8bb676421746e1d9d
2014-12-04Putting this back in to fix Windows build.Kohei Yoshida
Change-Id: I98262000956f10dc3b3da069b6bc286fec314a45
2014-12-04callcatcher: update unused codeCaolán McNamara
Change-Id: Ia25b857738bb7b6c3baf18c68ef0d1bc0b3e142e
2014-12-04pIimplize SfxBroadcaster and SfxListener.Kohei Yoshida
Change-Id: I0d1d73402f11cc61ea9e7629bea34e24c22f5beb
2014-12-02Remove unused header includes from public header.Kohei Yoshida
Change-Id: Ie9d42f15e2881f1f4bb78147d0250a174d9542c1
2014-11-25Adjust ref undo to ensure group area listeners are used.Kohei Yoshida
When undoing row deletion (and possibly other similar undo's). And write test for it. Change-Id: I04b4fd9932f4236f124dcd25967355c6055dec33
2014-11-24svl: Internalize strmadpt.hxx headerMatúš Kukan
Change-Id: Ia69463f1466349af879da02a23b58702732011c6
2014-11-24Remove not used SvLockBytesInputStreamMatúš Kukan
Change-Id: Id4e0852f6d204b3a1d2a7f5ce281730f5fcad8fd
2014-11-24svl: just make SfxItemPool::GetMasterPool() always availableMichael Stahl
Change-Id: Id2e35c19bf2efb73e6a0939cccf37c92ca30c0aa
2014-11-23fdo#39468 translate German commentsMichael Weghorn
Change-Id: Ic385faed251970c0c686b099023af9efca10a121 Reviewed-on: https://gerrit.libreoffice.org/13040 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-22ptr_container sometimes requires new_clone function.Kohei Yoshida
This fixes Windows build breakage. Change-Id: I188e38b20674700132c7d7c78304f58748540556
2014-11-22Make NfCurrencyTable a separate header & forward-declare it in zforlist.hxx.Kohei Yoshida
Change-Id: I17b52c277ab6ec8b15e88729feee0a269b75087d
2014-11-22Make SvNumberFormatter's methods non-inline.Kohei Yoshida
This is a high-impact header, included by hundred's of source files. Change-Id: I2b7f1c9e8ffe81ddccd1a541e3474ca302a27e90
2014-11-18Apply pimpl to svl::SharedStringPool.Kohei Yoshida
Change-Id: I351505f0c1cb25c47897e0cfffdb258f8e87081f
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18Make these non-inline and add the const version of the getter.Kohei Yoshida
Change-Id: I8c175dcaaa51e2b05895226907697b070a2e2f77
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-12drop pool ver 1 import supportCaolán McNamara
this unloved streaming format is internal only now and used for editengine c&p and (reportedly) autotable format storage. So we shouldn't encounter version 1 files anymore coverity#1242764 Untrusted loop bound Change-Id: If8e5717e997cf915f45f6e9484bb97d472e4dc2f
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-07wrong place I guessCaolán McNamara
Change-Id: I56d18dec48ccccab637ed3d818f4dd757c6f873b