summaryrefslogtreecommitdiff
path: root/include/svl
AgeCommit message (Collapse)Author
2014-03-15fdo#71491: Adjust reference during undo of drag-n-drop of cell range.Kohei Yoshida
Also with this commit, the signature of SvtListener::Notify() changes, by dropping the first argument which nobody uses. This change was necessary in order to call it directly without needing to pass any broadcaster instance. Change-Id: I6a1e97f0fb1e070d1d8f7db614690b04c9e8024e
2014-03-13sfx2,svl: prefer passing OUString and OString by referenceNoel Grandin
Change-Id: I9833265f6e635a057cea2c4a945cc73809b1e2ef
2014-03-12coverity#708189 Uninitialized scalar fieldCaolán McNamara
Change-Id: I558cda577595d6807d85bb41ac93500d02d461a6
2014-03-11svl: fix bogus visibility annotation on IndexedStyleSheetsMichael Stahl
Change-Id: I01cd75d01cb28a3bcef330ebabdd02e2c4458275
2014-03-11fdo#39468 Translate German commentsTobias Lippert
Change-Id: I051092f2ffb76a6ef400acd51514189ff20dad7d Reviewed-on: https://gerrit.libreoffice.org/8486 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-11fdo#30770 - Speed up xslx importTobias Lippert
Conflicts: include/svl/style.hxx Change-Id: Ie3d855923c651b6e05c0054c8e30155218279045 Reviewed-on: https://gerrit.libreoffice.org/8485 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-11callcatcher: update unused codeCaolán McNamara
Change-Id: Ie7acb237728af27df27d87c3f46a3eaa9cd14654
2014-03-10Add comment to StyleSheetIteratorTobias Lippert
Change-Id: I06db79b9c497d9dac4c4c8cff1f3ed3b36f0023f Reviewed-on: https://gerrit.libreoffice.org/8487 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-05remove unused code SfxGrabBagItem::SetGrabBagNoel Grandin
Change-Id: If41ef729da5799ebaa4ea238c6d2c4f1087ac487
2014-03-05debug only code SfxItemPool::GetMasterPool() constNoel Grandin
Change-Id: Ia3c53e64f6e39618b4cc85fae5f213e67041a725
2014-03-03remove unused code svl::SharedStringPool::SharedStringPool()Noel Grandin
Change-Id: I497cb89d0b204b9de9c31f86837664d107e55033
2014-03-01Set the default cell border line width to 0.75 pt in Calc.Kohei Yoshida
0.75 pt provides a better interop with Excel documents. Change-Id: Ic1d2cbbe4e35dc0793a0e35d3836261d91138f7c
2014-03-01Remove visual noise from includeAlexander Wilms
Conflicts: include/framework/preventduplicateinteraction.hxx include/sfx2/sfxbasecontroller.hxx include/sfx2/sfxbasemodel.hxx include/toolkit/awt/vclxtabpagemodel.hxx include/vcl/field.hxx include/vcl/settings.hxx Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2 Reviewed-on: https://gerrit.libreoffice.org/8272 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-18Stick to a single O[U]String hash functionStephan Bergmann
8f8bc0dcf3bc253ae49159d52db049767f476ced "Move string hash function into String class" had introduced a new getHash64 that, besides returning sal_uInt64 instead of just sal_Int32, didn't do sampling of only a handful of characters, but always computed the hash over all characters (as the usage in SfxItemSet and SdPage appears to require for either performance or approximated correctness). However, it would be advantageous to keep the stable URE interface as small as possible. Now, O(1) sampling was apparently considered state of the art when the rtl string classes were first created, closely copying java.lang.String, which at that time demanded sampling for hashCode(), too---but never sampling more than 15 characters, with the obvious (in hindsight, at least) performance catastrophes, so they changed it to O(n) somewhere along the way. Based on that, this commit changes the existing hash functions to not do sampling any more, and removes the newly introduced -64 variants again. (Where the extended value range of sal_uInt64 compared to sal_Int32 was hopefully not vital to the existing uses.) The old implementation used sampling only for strings of length >= 256, so I did a "make check" build with an instrumented hash function that flagged all uses with inputs of length >= 256, and grepped workdir/{Cppunit,Junit,Python}Test for hits. Of the 2849 hits encountered, 2845 where in the range from 256 to 295 characters, and only the remaining four where of 2472 characters. Those four were from CppunitTest_sc_subsequent_filters_test, importing long text into a cell, causing ScDocumentImport::setStringCell to call svl::SharedStringPool::intern, which internally uses an unordered_set. These results appear to justify the change. Change-Id: I78fcc3b0f07389bdf36a21701b95a1ff0a0d970f
2014-02-13n#757432: Styles (rename &) copy to different decks.Muthu Subramanian
While copying slides to different slide decks, styles were not being copied if there is already one with the same name. This patch renames and copies those to keep the formatting intact. Change-Id: I66f71493f1fd658eed43e39aa7ae7ee7b5463b34
2014-02-05SfxItemSet::operator == should return boolStephan Bergmann
...and need not be virtual Change-Id: I8cf38c4942526c6ca66595fdc3297be750ec09a0
2014-01-30fdo#63154 Removed unused solar.h ref. in svlAlexandre Vicenzi
Change-Id: I0452b1fa83c52a7466a025259b086e82ec1dba83 Reviewed-on: https://gerrit.libreoffice.org/7734 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-28bool improvementsStephan Bergmann
Change-Id: I6cf511b92383f3cd60923620518b9233b82850c0
2014-01-24coverity#708952 Non-virtual destructorCaolán McNamara
Change-Id: I4b09b3d6e11225d616a7a6f84eff6626a2490cd0
2014-01-22remove SvStream::operator<< methodsNoel Grandin
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22Clean up SfxItemSet::PutStephan Bergmann
* Make inherited overloads visible via "using" in SfxAllItemSet. * The overload with SfxItemSet argument: ** need not be virtual (verified by temporarily marking it SAL_FINAL); ** should apparently return bool. Change-Id: I5c57ec3d757d3d32a3e23be12964e7ebb81e6211
2014-01-10Use boolStephan Bergmann
Change-Id: I38f7ec288b907e889c71821cfbfac46a9688ba0c
2014-01-10Use proper bool operationsStephan Bergmann
Change-Id: I5b4af4fbd9d286393d8553b9346ad7e74f690a85
2014-01-10SfxItemSet::Set should return boolStephan Bergmann
Change-Id: Icb38319f1307e94ce5c6d43b999a08db1fc38d85
2014-01-10SfxPoolItem::operator ==, != should return boolStephan Bergmann
...and SfxEnumItemInterface::HasBoolValue, too. Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
2013-12-21Make the broadcasting work even when about to destruct.Jan Holesovsky
Change-Id: Idba9302e1ec5234d3d472cda047c09ba52afd328
2013-12-21Don't call EndListening() on already destructed listeners.Jan Holesovsky
Change-Id: I9bda35f2246de9d37077dda33c710b89ee008e5a
2013-12-21Speedup destruction of sheets with too many listeners & broadcasters.Jan Holesovsky
Listeners and broadcasters are M:N relationship. If you want to destruct them, you easily end up in O(M*N) situation; where for every listener, you iterate all broadcasters, to remove that one listener. To avoid that, announce to the broadcasters that they are going to die, and the listeners do not have to bother with removing themselves from the broadcaster. The broadcaster will not broadcast anything after the PrepareForDesctruction() call anyway. Change-Id: I68d78b23e73bcbb944de9139448b2c20dfa14f62
2013-12-19svl: whitespace fixes in grabbagitemMiklos Vajna
Change-Id: I363e8c0f1a51a18bf0ad0ac4f931107137fd1c58
2013-12-12Get rid of MAP_CHAR_LEN macroStephan Bergmann
Change-Id: I0c8af0f3acdae7eb5167ea1dd4e0e4abf0357bb2
2013-12-12Don't hold css::uno::Type instances by pointerStephan Bergmann
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-11Revert "Don't hold css::uno::Type instances by pointer"Stephan Bergmann
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now: Ach, old GCC doesn't like plain string literals to initialize members of OUString type... Change-Id: I50563a00406259bb5d41831e2a2796762450d097
2013-12-11Don't hold css::uno::Type instances by pointerStephan Bergmann
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-10svl: remove SfxDateTimeItem, which is actually unusedMichael Stahl
... since 2f44516d6c3fce6ebe372214ce4bfa11875bd3d1 Change-Id: I25905a69464a43e12fcbb4770c8b0e171ab3271b
2013-12-10n#753460: Copying slides having same master page name.Muthu Subramanian
Has part feature of getting hashes of SdPages. (Misses hashing text, images, etc).
2013-11-26Resolves: #i123753# WaE: fix unoedhlp.hxx declaration of 'nId'...Herbert Dürr
shadowing a member of SimpleHint Happy new times: Now even simple compiler warning fixes need their own issue. (cherry picked from commit 5cd09cc74da93da4c91c665822b6ab9a0d704a7a) Conflicts: svl/inc/svl/smplhint.hxx svl/source/notify/smplhint.cxx Change-Id: I445126425a22778cf7aaf33d3a34977903e59f84
2013-11-21fdo#39468: Translate German comments (first part)Philipp Riemer
Change-Id: I8cd558c558a369ba2715ccdc0baf58d637e79a38
2013-11-14Optimize SvtBroadcaster for insertion.Kohei Yoshida
This helps file load performance at the slight overhead during editing. That said, the overhead during editing is only in theory (not measured) and shouldn't be that much even in theory. Change-Id: If22ea34acb0cda311575ac3ed8ce1a8eb69ae33a
2013-11-14No need to individually remove listeners when being destroyed.Kohei Yoshida
Otherwise a crash would ensue. Change-Id: I9a52524cc205765d059745e9f7e914b636667cb6
2013-11-14Rework SvtListener and SvtBroadcaster internals.Kohei Yoshida
The old code was simply awkward. Change-Id: I1a58a9af86c100be238d306570b40f70c5100314
2013-11-09fdo#65108 inter-module includes <> include/svlNorbert Thiebaud
Change-Id: I8b28f3c6df5d11112aff732159c913b4ffb1cc6f
2013-11-06Add mutex to guard the shared string pool content.Kohei Yoshida
Change-Id: I0eb97d0fbeaefd8a1c86d240ed8bd7f208fb662e
2013-10-23fixincludeguards.sh: include/s*Thomas Arnhold
Change-Id: I57fcfd442d2b5815e7c07a9cbd660f3698168dee
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-21post String conversion cleanupThomas Arnhold
Change-Id: I9747817edc76973af4a4ffdbf542b8d1467d7f08
2013-10-11Formula tokens, formula cells and formula interpreters to use shared strings.Kohei Yoshida
Change-Id: I5da99869fc7f61ce698180fa5daa9be9db9ac132
2013-10-11Import shared formulas from xlsx without crashing.Kohei Yoshida
The key here is to only use the shared formula ID's and ignore the ref range. The ref ranges are not correct half the time. Change-Id: If65f9b1b44ab6239db37977b6dfe3f822a9cf67e
2013-10-11Add isEmpty() to SharedString. This simplies a lot of its call sites.Kohei Yoshida
Change-Id: I0ebc43abe59ac317c053a4f606dbe376d85c03b0
generated by cgit (git 2.34.1) at 2025-01-02 19:21:20 +0000