summaryrefslogtreecommitdiff
path: root/include/svtools/editbrowsebox.hxx
AgeCommit message (Collapse)Author
2021-02-23reportdesigner focus out handler clobbering the preexisting handlerCaolán McNamara
set by the databrowser, so chain one after the other Change-Id: I5aa16635031be425b9354e5a2d6b891a81d54e55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-18update DataBrowser has-focus when child widget loses focusCaolán McNamara
similar to tdf#135641 case, focus-out becomes an issue with the bibliography editor if focus-in is seen on clicking in a cell, then click in a GtkEntry and tab around in a circle. Without this lose-focus support focus will be grabbed back to the cell of the initial click on a circuit of the focus-cycle Change-Id: I36288ed21dc4357c077f8dee55b55abf2457c2a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111157 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-22tdf#135550 ListBox should triger an event when changed non-interactivelyCaolán McNamara
not just when changed by the user Change-Id: If2238341ff8465fee6375dad1ea9b4d7ec0110e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15tdf#135641 update DataBrowser has-focus when child widget gains focusCaolán McNamara
Change-Id: Ic5e618b50c31ebeffa1b2cc59857582804874747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109369 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-19tdf#124176 use pragma once instead of include guardsRoman Kuznetsov
in /core/include/svtools/ Change-Id: Ic8614f77dfde02f4c1fc4cceccd1de4ff5a05f72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106006 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-30convert some tools::Long->sal_Int32Noel
in places where it is obvious we only need a sal_Int32, because we are dealing with rows and columns, and not even calc needs more than 32 bits for that. Change-Id: I114417e639c224d45bfd9fc6838122ab195eefa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19use tools::Long in svtoolsNoel
Change-Id: I2b26da23e625e643dc2bb5393abff3671c457884 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16tdf#135550 make XComboBox Item status changed event work againCaolán McNamara
Change-Id: I323a114d3b71a74267ee7a89c5fb29821611e57e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-14tdf#135550 make XListBox Item status changed event work againCaolán McNamara
Change-Id: I9a5fe6a097c5d06e3ac3ab6c4c77cbe082d1a17d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-10tdf#135529 today/none only used by DateControlCaolán McNamara
Change-Id: Id8987e65ef3fae9c009af59d3a1f9d0e83726648 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29move SetReadOnly into ControlBase as SetEditableReadOnlyCaolán McNamara
and cast to that instead of "Edit" and override the Editable controls impls to do something suitable when called Change-Id: I24cc02b603e9551df4e3eb39f6cb4839883db777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99709 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-27drop unused SVTOOLS_IN_EDITBROWSEBOX_HXX defineCaolán McNamara
Change-Id: I7d0944c7772562c8da8ce1ee668434ae8cf7e9c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99515 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22move useful parts of ControlBase down hierarchyCaolán McNamara
Change-Id: I4116a3532b21f6066468bd3905efef1020ace101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99233 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22weld PatternControlCaolán McNamara
Change-Id: Ie84778c2f127a6b393edbfa08e61b135ec3bcbc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-21weld OSQLNameEditCaolán McNamara
Change-Id: I79c79e17c28c8dd22dbb0f41ded30488c4924ce8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99153 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-21weld DateControlCaolán McNamara
replace SpinButton when WB_SPINBUTTON is set on a date field to always use a popover with a calendar in it to make it possible to integrate this with native widgets Change-Id: I36a26599a154bddf9aec9b50b6570e13477a1f63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-16loplugin:unusedmethodsNoel Grandin
Change-Id: Ibc1ec64cba8eb083aaff28848a42337cc597ea19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-15weld TimeControlCaolán McNamara
Change-Id: Idb19639eb39bc83fb8bdc7c2181bf63e9c522d18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98670 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-15weld LongCurrencyControlCaolán McNamara
Change-Id: I700329aeee53f8ce91ce22a3b50fe59e3d19c063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98613 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-13don't grab focus if focus is already in a subcontrolCaolán McNamara
Change-Id: I3bc377e9d9ee1ad7b6066b7a1c2d27ddd7bb6b7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12clarify what WantMouseEvent is forCaolán McNamara
and add tristate machine support that we also need WantMouseEvent is if the first click in a browse cell that activates it should be passed to the control that appears on click as if it was itself clicked on primarily for the the CheckBoxController to toggle it immediately. Rework to explicitly toggle the checkbox in that implementation rather than rely on passing fake mouse click/release/tracking events. seeing as the main dbaccess table design view doesn't auto-launch its listboxes on clicking in a cell, but the sub create index dialog does, drop the auto-launch in the index dialog to match the main table design rathern than add a feature to weld::ComboBox to auto-launch the popup for that one solitary case Change-Id: Ie3d3f2ecf55d3d5b0b02b85ca09a6ca64bb800e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98603 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12weld CheckBoxControlCaolán McNamara
Change-Id: Iea057189ab17c1fdaf6663f1c328b9d288d97a18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11use an aux modify handler instead of listening for VclEventId::EditModifyCaolán McNamara
Change-Id: Ie35ad08a24b8b0c989806c4739bfe925fd9ab746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-10weld MultiLineTextCellCaolán McNamara
Change-Id: Ib230720371552738a8c6152a98a84d31b900d062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98209 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-07make some symbols privateNoel Grandin
Change-Id: I224831ad18e754fd67d9b16510cd286a5397f1f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-06weld DbNumericField itemCaolán McNamara
Change-Id: I96b7945cdf9f00c3d0a4e043ee77666e19c8a072 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-06split off key processingCaolán McNamara
so we can explicitly call it rather than let implicit PreNotify process it Change-Id: I5f27b8c34a0be7239303307a2d5e93e5de4f4c2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-06clarify that the parent is always a BrowserDataWinCaolán McNamara
Change-Id: I64aac74902c631e41fd54d7e198276885e2c4378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03rename FormattedEntry to EntryFormatterCaolán McNamara
Change-Id: I96079720f60b789f0b8d5483973150cb050e87e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97859 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03change FormattedEntry to not own the Entry it operates onCaolán McNamara
Change-Id: I5b5753312a5bbfed3dbcdc47cc1781cbcf168750 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03drop some unnecessary includes and forward declaresCaolán McNamara
Change-Id: I05bf82e3fc295d6f3f42287763c53b8e21da4b67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97824 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02weld FormattedControlCaolán McNamara
by using the newly split out Formatter to do the number formatting but input/output to/from a weld::Entry Change-Id: Ic9e619dc5d1ed2fae87e2d89a40dc51f3881468f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01weld EditControl for browseboxCaolán McNamara
Change-Id: I8f21c12f7ee10e1b9ba883a8ff01bb5252429f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-28decouple IEditImplementation from Edit moreCaolán McNamara
Change-Id: Ie01373ca40d519c179485bd1a4b6616d5929fa5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22move InterimItemWindow to vclCaolán McNamara
Change-Id: If0a4a14708810c44d087b51961f2ecb3fda4df23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22remove Size arg from Window::Draw and depend on GetSizePixelCaolán McNamara
90% of cases pass GetSizePixel as the Size arg already and this aligns Window::Draw with how Window::PaintToDevice works Change-Id: If5b024179a4b7a3b099177c2f6d4b1fb006b95ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21weld ListBoxControlCaolán McNamara
Change-Id: I5a8c7d68e4c147eb938b0217dc6368c832e465c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-20weld ComboBoxControlCaolán McNamara
Change-Id: Ie862bb782b4c3e203af88d45c850ce0cab60f2e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-23make more classes private in mergedlibs modeNoel Grandin
Change-Id: I486922d0652f26fa7ee56f5fe308e19fe5ff137e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Revert "loplugin:constfields in svtools"Noel Grandin
This reverts commit 07c4aa4298f062cee1894b80ef82e76d5ffcf4c7. Change-Id: Ic3f639581b9aca373f82c011f15be60d117b1943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara
Change-Id: Ibacffee0520d7525d552820713f3d4d620e1f156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use fwd decl of SpinFieldCaolán McNamara
Change-Id: Ifea23e791ec53448a8591583f283b87430ef38c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use forward decls to reduce including unnecessary headersCaolán McNamara
Change-Id: Iaa25ac1ac99e0dcf09bce21f4bad8cb9b5568a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22inline some construction methodsNoel Grandin
only called from one constructor Change-Id: I082cf3b459c936b79a6df695fffac5e3cf43705b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-30loplugin:finalclasses svtoolsNoel Grandin
Change-Id: I17f4fd3960a23132916ea64b21cc8869a94eaed4 Reviewed-on: https://gerrit.libreoffice.org/81704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-20Fix typosAndrea Gelmini
Change-Id: I8561dc27229a2430bfdfd8ac806139b4450496c7 Reviewed-on: https://gerrit.libreoffice.org/76026 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-05-29Fix typoAndrea Gelmini
Change-Id: I677f7d50d6b93993f6e3d47426434eb570965b7c Reviewed-on: https://gerrit.libreoffice.org/73129 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-05re-land "new loplugin typedefparam""Noel Grandin
This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>