summaryrefslogtreecommitdiff
path: root/include/svtools
AgeCommit message (Collapse)Author
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-09loplugin:unnecessaryvirtualsNoel Grandin
Improve the plugin a little. Create a python script to process the output. Run it again. Change-Id: I05c21d8a21c8f4243af739c412fda0a521f9b5f0
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I0df3b3737e02e6467fc9d71bc948a58797582173
2015-06-08tdf#90804 remove SfxFieldUnit enumAndras Timar
b78d881520f2eb658180e2c90ffee3d30a80f0ae removed unused values from SfxFieldUnit enum. This broke the mapping between SfxFieldUnit and FieldUnit. In fact SfxFieldUnit was redundant. Change-Id: I13c7e7d708c6eeab0de192f4cd110b0a23989a31 Reviewed-on: https://gerrit.libreoffice.org/16150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-03tdf#91677 fix flickering rulerTomaž Vajngerl
Change-Id: Ia14be98fbfd46871b2ac9bd42a07951d86722a8a
2015-05-28Resolves: tdf#91673 wrong bit mask for BrowserModeCaolán McNamara
Change-Id: Iecd1d9d743fb3d7a02b31d2bee001de5092be7e0
2015-05-28convert GETFOCUS constants to scoped enumNoel Grandin
Change-Id: I7c324bb6358be28c119592850eb7607479279f09
2015-05-27convert WINDOW_DRAW flags to scoped enumNoel Grandin
Change-Id: I9400a286fab18d683b4c109007961685f01b6da3
2015-05-26convert SCROLL constants to scoped enumNoel Grandin
Change-Id: I5696fa39b2d032735cea7abe039349d4f83cf68d
2015-05-26convert INVALIDATE constants to scoped enumNoel Grandin
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the IDL docs for XWindowPeer Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-25related tdf#90127: Simplify setting of the 'auto' icon theme.Jan Holesovsky
Change-Id: I9aedfd0b7943517b5444195b63140132dd728d57
2015-05-24callcatcher: update unused codeCaolán McNamara
Change-Id: I1f2a94cdcd4329af68d946ff0a74ddec4ac1c590
2015-05-22convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-20bin/rename-sw-abbreviations.shlibreoffice-5-0-branch-pointChristian Lohmaier
renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-20mbHasInsertTab is not needed anymoreTomaž Vajngerl
Change-Id: Icc7eb914a16d6492146879967a6dc8b634d50b6e
2015-05-19check for and handle missing base in mail merge (related: fdo#33266)Bjoern Michaelsen
Change-Id: I3e362a873c28026cbecf005c07def1295aa920e0
2015-05-18callcatcher: update unused codeCaolán McNamara
Change-Id: I43dd399368953c629916dad8104a296f837a6344
2015-05-18-Werror,-Winconsistent-missing-overrideStephan Bergmann
Change-Id: I1dff459a5f08e4fd8462e2dababab3baaa0fe84e
2015-05-18-Werror,-Winconsistent-missing-overrideStephan Bergmann
Change-Id: Ie71f97ddb84d97a816a51e095fb6fb81180baf0a
2015-05-18pass RenderContext to PreparePaint in TreeListBoxTomaž Vajngerl
Change-Id: I32961f5cd511b9ecc756e99ca95e4e9ddbc6b795
2015-05-18refactor how font, fg. and bg. are applied in widgets/controlsTomaž Vajngerl
- Move vcl::RenderContext to outdev. - Change some methods on vcl::Window to accept RenderContext as parameter. - Add ApplySettings to vcl::Window - This method is called before painting. Refactor existing classes that use InitSettings to have ApplySettings or mark the classes to be refactored later. - Add RenderSettings for adding defered settings to rendering. This is similar to ApplySettings but for more ad-hoc calls. Change-Id: I4ea58461f3b6b08ccfa3e0ddd1a4a3e04f8c4f45
2015-05-17tabbar: use a button for adding of tabs, move button before tabsTomaž Vajngerl
Change-Id: I89fcf7427694ea6fc9468220bae639b221d9ec28
2015-05-13tdf#91125 - unwind horrendous SvTreeListBox drag&drop code.Michael Meeks
This removes a horrible mess of shoving various process pointers into byte arrays and (potentially) pushing them across a process boundary in a gross fashion. Killed the SvLBoxDDInfo struct, and its many un-used members. Instead use the existing (also non-ideal) global variable to track the relevant state. Change-Id: I0b694bd530e7019042d22e46db831b5a4aae0e23
2015-05-13convert FRAME_DRAW constants to scoped enumNoel Grandin
Change-Id: I98e52aa56ec063ecc8f3d10baef65eb293c726bf
2015-05-13refactor ToolBarMenu to use RenderContextTomaž Vajngerl
Change-Id: I26c5ad18445faeb55961030edc9f1daab2edab59
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann
Change-Id: I3abfd98f165e2f3951cacc83fa578d442779107e
2015-05-11refactor ValueSet to use RenderContextTomaž Vajngerl
Change-Id: I3985804f8cfd1b6807bc02bef5af3e24e5cb3cbf
2015-05-11refactor TabBar to use RenderContextTomaž Vajngerl
Change-Id: Id29cbf407fe96fceb326b1197991baf4698e5177
2015-05-11refactor Ruler to use RenderContextTomaž Vajngerl
Change-Id: Ic4c57e161419a9b185b2c5ee8e8b79d3da9e4a7e
2015-05-11refactor HeadBar to use RenderContextTomaž Vajngerl
Change-Id: Ica05591754633fc64216aecbdf8010800133dfd4
2015-05-11refactor "Calendar" control to use RenderContextTomaž Vajngerl
Change-Id: I41aea2e62bb8c034d07825bd4b8776e718cd0920
2015-05-11refactor TreeListBox to use RenderContextTomaž Vajngerl
Change-Id: I901a1f1f9732fb66718dca34c698a851e5b0d87f
2015-05-11refactor BrowseBox, IconChoice to use RenderContextTomaž Vajngerl
Change-Id: I7bc3982895fa118616330ee9df88abae96abbe14
2015-05-10Replace IMPL_STATIC_LINK[_TYPED] with more useful variantsStephan Bergmann
Change-Id: I344ba9d22adada82170d45a4cf723af6a286b883
2015-05-09VclPtr: fix crash on loading kde86727-1.htmlCaolán McNamara
and all the other html crashtest loading failures I believe Change-Id: I38d3e1ad283efc08f468d9062e520149663e3e84
2015-05-08lopluign:staticmethods: Handle DECL_LINKStephan Bergmann
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-07Remove unnecessary includes of sot/storage.hxx from include/Stephan Bergmann
Change-Id: I242cd126814bbebdb99ea38d9e66513189c313d9
2015-05-07Unwind SotStorageStreamRef typedefStephan Bergmann
Change-Id: If7652a7c0251b741660365848a717c06954ca419
2015-05-06convert BMP_MIRROR constants to scoped enumNoel Grandin
and fix bug in svx/source/xoutdev/_xoutbmp.cxx,XOutBitmap::MirrorGraphic where it was not correctly translating between different flags types. Change-Id: I78b4965544da2aa54b67ec18307fa54c8ffc3aee
2015-05-05vcl: rename other members of StateChangedType for consistencyMichael Stahl
Change-Id: Ifd3339813e5d3dfb54566fd226aaf2d2a199d59a
2015-05-05Use typed Idle::SetIdleHdl LinkStephan Bergmann
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-05Use typed Timer::SetTimeoutHdl LinkStephan Bergmann
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30Get rid of the initial :: for the vcl namespaceTor Lillqvist
We used it all over the place without leading :: already anyway, even in many files in include. So let's be consistent. In the majority of cases, prefer the easier-on-the-eyes choice, not the "safe" one. In those files in include where *all* existing uses of ::vcl:: indeed used the :: prefix, there let's keep it for consistency. Change-Id: If99cb41d3bf290d38c601d91125c3c8d935e61d0
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-29Clean up tools/link.hxxStephan Bergmann
Change-Id: I44e4abb228394f99109f7d7e005cfeb26e4b95c1
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29convert WZB_ constants to scoped enumNoel Grandin
Change-Id: If2f12ea54b57f32df23fc22fb8be0aa3c6f2e76e
2015-04-29mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&)Tomaž Vajngerl
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
2015-04-28Merge remote-tracking branch 'origin/feature/vclptrmerge2'Michael Meeks