summaryrefslogtreecommitdiff
path: root/include/svx/srchdlg.hxx
AgeCommit message (Collapse)Author
2020-06-17tdf#133807 re-present search dialog after a short timeoutCaolán McNamara
Change-Id: Icc6016b3a9e3f25fd4c9e065e9f2d9570ad040c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-28Resolves: tdf#133411 drop CONTENT_FLOWS_TO from dialog to search resultsCaolán McNamara
in the document, looks like only the calc one actually works, and when it works on large quantities of results calc grinds to a complete halt This was introduced with: commit b41332475783c31136673fb44cf4c411bb0148f8 Date: Mon Dec 2 15:54:29 2013 +0000 Integrate branch of IAccessible2 and has been a problem on and off with calc's potentially ~infinite grid There is the on-by-default search results dialog in calc (which has a limit on how many it shows) which provides an alternative route to iterate through the results Change-Id: I2685e480d2d15220be0bddbc83baad3992e7d5d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-28Related: tdf#133411 SetDocWin is using the previous search success stateCaolán McNamara
not the new state The order of calls probably didn't matter in the past where the use of the flag was deferred until the Accessibility data was queried which would happen in another event loop. This makes it more clear that it appears that only calc actually does anything productive here. I think this flow-to has created more trouble that its worth and I'll remove it but if we need to restore it, then this, I think, it the working state to restore to. Change-Id: Id6fbb483c081f6d5142100d70c1b29705dcb6452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-13tdf#115600 Fix navigate by reminder wrap messagesJim Raykowski
Navigating by reminders is done in the order which reminders are set. This patch corrects wrap messages displayed when first and last reminders are reached and continued from the last and first reminder. Change-Id: Iaea1965df149a029b4b1e2df059a8d73306f901c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86629 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-10-30loplugin:finalclasses svxNoel Grandin
Change-Id: If55e51b8627083ba3ece2b3270adb47668b25e9d Reviewed-on: https://gerrit.libreoffice.org/81705 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-23Resolves: tdf#128313 disambiguate flow-to search resultsCaolán McNamara
for a11y between find/replace where our result is a single thing, and find-all/replace-all where the result is potentially many things, which allows that searching in a selected calc column will flow-to the current cell, not the entire ~infinite set of cells in the column Change-Id: Ib3e56fceb90d869f157427f090cdffe986a5a588 Reviewed-on: https://gerrit.libreoffice.org/81396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-03loplugin:constmethod in svxNoel Grandin
Change-Id: I6ae7c04479e3ea8ecd7535c33224a5e7095b64bb Reviewed-on: https://gerrit.libreoffice.org/78396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-03tdf#42949 Fix IWYU warnings in include/svx/x*Gabor Kelemen
New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I5b91a82d25601041b73444f602d033ef62484ba8 Reviewed-on: https://gerrit.libreoffice.org/74563 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-11tdf#42949 Fix IWYU warnings in include/svx/[sS][v-Z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie2a4122d67d2d40732e6fd00b584f33edd802c5b Reviewed-on: https://gerrit.libreoffice.org/73476 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-18tdf#106723 Improve visibility of not found search termRasmus Jonsson
Move SetSearchLabel definition to srchdlg.cxx Set control foreground to red on failed search and reset on text input modification. For the find & replace dialog, use set_entry_error for the same. Reset "not found" search label on modification of search term. Change-Id: Ia89d2e8d3ca35e2c184d5b7048af8267b57f2c17 Reviewed-on: https://gerrit.libreoffice.org/70662 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-04-01drop unnecessary includesCaolán McNamara
Change-Id: I12c02a03202d778d9c2d7bf41022db64af492e04 Reviewed-on: https://gerrit.libreoffice.org/70075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-26weld SvxRubyDialogCaolán McNamara
Change-Id: I32f26b9d3e495e64a38cd8a56e532374dd4891f1 Reviewed-on: https://gerrit.libreoffice.org/69651 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-25ubsan detect null derefCaolán McNamara
Change-Id: I78a8c91f2c7493a12f5acb325c3f79efbbfbffcc Reviewed-on: https://gerrit.libreoffice.org/69650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-25tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4 Reviewed-on: https://gerrit.libreoffice.org/69481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-24weld SvxSearchDialogCaolán McNamara
I have to use the other way to specify an a11y role, both are implemented in the vcl parser, but in my gtk3-3.24.7 the role tag crashes the gtk parser, while the other route works fine. The CONTENT_FLOWS_TO accessibility relation is another additional complexity over the norm Change-Id: Ia096bcbe9f00f9944e4e4d5ad9bb1a52d19c7b3f Reviewed-on: https://gerrit.libreoffice.org/69569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-18Resolves tdf#122322 - Modifying max number of saved word searchesheiko tietze
Expert configuration Common::Misc::FindReplaceRememberedSearches defaulting to 10 introduced Change-Id: Id51bb78ee1f5ad9e73fa56e5f2d07773c528f9a7 Reviewed-on: https://gerrit.libreoffice.org/67614 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-29Avoid SvxSearchController::StateChanged during SvxSearchDialog sub-dialogStephan Bergmann
UITest_findReplace occasionally fails (esp. in slowly-executing builds like the ASan+UBSan one, e.g., <https://ci.libreoffice.org/job/lo_ubsan/1084/>) because the "Find" edit is re-filled with old content while the "Format..." sub-dialog is executing: The SfxBindings::NextJob timer fires from the main thread's Application::Yield, calls SvxSearchController::StateChanged -> SvxSearchDialog::SetItem_Impl -> SvxSearchDialog::Init_Impl, which goes into the > else if (!aSearchStrings.empty()) > { > bool bAttributes = > ( ( pSearchList && pSearchList->Count() ) || > ( pReplaceList && pReplaceList->Count() ) ); > > if ( bSetSearch && !bAttributes ) > m_pSearchLB->SetText(aSearchStrings[0]); code re-filling the "Find" edit (despite it having been cleared programatically), because bAttributes is false because the "Format..." sub- dialog has not yet completed, so pSearchList has not yet been filled (as is done by the handle_format_dlg code in test_find_writer in sw/qa/uitest/findReplace/findReplace.py). (This issue can be triggered rather reliably by adding a sleep > @@ -94,6 +94,7 @@ class findReplace(UITestCase): > xSizeFont.executeAction("BACKSPACE", tuple()) > xSizeFont.executeAction("TYPE", mkPropertyValues({"TEXT":"16"})) #set font size 16 > xOkBtn = dialog.getChild("ok") > + time.sleep(1) > self.ui_test.close_dialog_through_button(xOkBtn) > > self.ui_test.execute_blocking_action(format.executeAction, args=('CLICK', ()), to sw/qa/uitest/findReplace/findReplace.py.) So suppress executing SvxSearchController::StateChanged -> SvxSearchDialog::SetItem_Impl while an SvxSearchDialog sub-dialog is in progress. The open TODO question is whether those state changes should be saved and executed once the sub-dialog has been executed, or whether it is OK to just throw them away (as happens now). Change-Id: I20fb8c8d88c3d3fe8b604718bb289a7421471aa7 Reviewed-on: https://gerrit.libreoffice.org/62489 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-14drop unnecessary vcl/group.hxx includesCaolán McNamara
Change-Id: I09d86ee7e156ac71d7c1f9fd58d43751037d2629 Reviewed-on: https://gerrit.libreoffice.org/61761 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-04loplugin:useuniqueptr in SvxSearchDialogNoel Grandin
Change-Id: I9f3dbe393844e4fca5637f23d3da5ddf591e487c Reviewed-on: https://gerrit.libreoffice.org/55235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-21tdf#98544 Other Options remain expanded if any checkbox is checked.manujvashist
Change-Id: I2de79da0f0a6295d4d3c294d7cf6c123fca914bc Reviewed-on: https://gerrit.libreoffice.org/51190 Reviewed-by: Manuj Vashist <manujvashist@gmail.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-06svx: remove comment cruftChris Sherlock
Change-Id: I8f55407d75bba49b3ebeab80dd7a49d6224959d6 Reviewed-on: https://gerrit.libreoffice.org/53899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-14tdf#115600 Display messages in Findbar for Table navigationJim Raykowski
...and make Table navigation wrap Change-Id: Iac645cb7db65517519cfb791ca1eb26f2567ee7c Reviewed-on: https://gerrit.libreoffice.org/52865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-09tdf#115600 Display messages in Findbar for Headings navigationJim Raykowski
...and make Headings navigation wrap Change-Id: Ia06caba9b93064c63750c54c1061d781811ed62a Reviewed-on: https://gerrit.libreoffice.org/52139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-27tdf#81925 Make messages show in Findbar searchlabel overflow toolbarJim Raykowski
...and add a bit more horizontal space for messages Change-Id: I4a310d7a4a649860a36ce12b775bb6b275cd6ef5 Reviewed-on: https://gerrit.libreoffice.org/51523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-26tdf#111846 Find & Replace: Rename diacritics and kashida optionsJim Raykowski
Change-Id: I1657b84d613b28d5762057954069d2a2fe2e3ab2 Reviewed-on: https://gerrit.libreoffice.org/43103 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-07-29loplugin:constparams in svxNoel Grandin
Change-Id: Icc388182b9b7b6a6617793be09217f06bed7332d Reviewed-on: https://gerrit.libreoffice.org/40527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27loplugin:constparams in svxNoel Grandin
and fix a bug in the plugin itself when calling operator's like the one on std::function<> Change-Id: I1617607107eeff06785c1841f69e13ad2926218e Reviewed-on: https://gerrit.libreoffice.org/40446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03loplugin:unusedfields in svxNoel Grandin
Change-Id: I027b70ee92ab07eb68452457c3ee45de3ad22c8b Reviewed-on: https://gerrit.libreoffice.org/39412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-01typesafe wrappers for css::i18nutil::TransliterationModulesNoel Grandin
and related css::util::SearchOptions2 The TransliterationModules enum has it's constants spread over multiple UNO enum/constant-collections - TransliterationModules and TransliterationModulesExtra, which means that most code simply uses sal_Int32. Wrap them up into a better bundle so that only the lowest layer needs to deal directly with the UNO constants. Change-Id: I1edeab79fcc7817a4a97c933ef84ab7015bb849b Reviewed-on: https://gerrit.libreoffice.org/34582 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07Related: tdf#105371 we can do this with a sizegroupCaolán McNamara
Change-Id: Ie37a3d960ec244033f2b05e7a902c7a23ba9b94d
2017-02-03tdf#105371, tdf#99456 Alignment in find & replace dialogheiko tietze
Fix width of labels removed and code added to define it on runtime Fix height of buttons commented out Resizable flag unset Change-Id: I3ffb38b5c9b23447ac914dc8c13fa95072897ced Reviewed-on: https://gerrit.libreoffice.org/33370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2016-11-25convert MODIFY constants to o3tl::typed_flagsNoel Grandin
Change-Id: I230469605b1b3a2a639f51917c23f1a82ec519b5
2016-10-05convert the last two lonely FixedInfos to FixedTextCaolán McNamara
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-13chmod 644 some source filesStephan Bergmann
Change-Id: Icd8821278635c1bd27b5185cddf5dc25dfba7eb4
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-23convert SearchLabel to scoped enumNoel Grandin
Change-Id: I0c62a3166b9284895f119c600776dc2c7d6d1078
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20tdf#89329: use unique_ptr for pImpl in svx/Xisco Fauli
Change-Id: I6c252272feb9915b580b3525a606c26c19cbe773 Reviewed-on: https://gerrit.libreoffice.org/25114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#98417, tdf#98539: DIALOG: Improvements to the Find & Replace dialog.Akshay Deep
Added Find Previous Button. Replaced backward checkbox with 'Replace Backward' from other options. Modified Dialog Layout as per the attachment in bug report. Removed vertical spacing in parent_container_box to reduce height of the dialog. Removed InfoBox from ReplaceAll functionality in writer, shifted it to SearchLabel. Attribute labels only show up when attribues are used in search, else they remain hidden. Change-Id: I0e9ded854fc2601524d6fc2a0ba5e9cb602e11a4 Reviewed-on: https://gerrit.libreoffice.org/23057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-01loplugin:unuseddefaultparam in svx (part2)Noel Grandin
Change-Id: I99e3d6137ec17e3fc782253c85e5fa4f1da4cec4
2016-02-26add Wildcards to Find&Replace dialogEike Rathke
Enabled only for Calc. Writer needs to be adapted to support wildcards. The global escape character is '\' set in SvxSearchItem ctor. Change-Id: I1af78f296deff81e023ee9f0e936f5f506f80c83
2015-11-25loplugin:unusedfields in include/svxNoel Grandin
Change-Id: I946c64d103f3666e5bbff16d95a5c8e65a3750dc
2015-10-23com::sun::star->css in include/sot to include/typelibNoel Grandin
Change-Id: I9cd92b53370a6b6018d2f7c648890f9c014a27de
2015-10-23tdf#48456 : when searching for a number, consider formattingDennis Francis
Change-Id: I4a1e3e269a269bb37e88aa8810a46d0f4ecfc518 Reviewed-on: https://gerrit.libreoffice.org/19420 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-16convert Link<> to typedNoel Grandin
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12convert Link<> to typedNoel Grandin
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-24convert Link<> to typedNoel Grandin
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b Reviewed-on: https://gerrit.libreoffice.org/18825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-17 23:51:48 +0000