summaryrefslogtreecommitdiff
path: root/include/svx
AgeCommit message (Collapse)Author
2016-12-12tdf#104405 Clone Formatting ignores vertical text alignmentNoel Grandin
I removed the unit test, since it depends on some other changes to the dumpAsXml code that are not in this branch. Reviewed-on: https://gerrit.libreoffice.org/31623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit d36aa2ba3132ce62a370b7260ca620642cbf7dbf) Reviewed-on: https://gerrit.libreoffice.org/31746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit a7d13674bc2271e6f191e8ecda78151a47d413f6) Change-Id: I56cce69ddb21f7f9336b8f59e181e91306e92019 Reviewed-on: https://gerrit.libreoffice.org/31896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-10-18tdf#100180: Band-aid fix for non-editable chart sidebarKatarina Behrens
no way should sfx2 sidebar controller be used in a base class, it just wreaks havoc in chart which inherits from this class, but uses its own controller. Since those NotifyResize calls were introduced to prevent cropped widgets on switching between different shape fills, try to make up for that with other means in .ui file (cherry picked from commit 70eac30606402fe6ec628038041433c0e107a87e) Change-Id: I5a40e4d413b583b1de1e3f751493d65d41ff8465 Reviewed-on: https://gerrit.libreoffice.org/30000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-18tdf#101827 - mend busy contour dialog.Michael Meeks
Previous impl. had an un-necessary timeout to update the screen constantly. Change-Id: I28ba50166530d516d299b9c873cf59577043bf82 Reviewed-on: https://gerrit.libreoffice.org/29392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 1498c4f631e9c90b11dbdb18e8b094b90e143466) Reviewed-on: https://gerrit.libreoffice.org/29673 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-05Resolves: tdf#101711 revert attempt to drop unused bg imagesCaolán McNamara
for 5-2/5-1 simply revert the effort Revert "Related: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if..." This reverts commit 914d72ee1edb351e4975a516240a38696f619217. Revert "Resolves: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if..." This reverts commit de4908eb4d2f1f2ce38a37eea18a9efc4a0073b1. Revert "use unique_ptr" This reverts commit ee4f35090657fdce572c5bc6238aceb4098a6e4e. Revert "fix typo" This reverts commit a084962e8c3deaeb3c1b6b9119215b48cf27e76e. Revert "rbhz#1326602 avoid exp. bg bitmaps from deleted slides" This reverts commit b876bbe2cacce8af379b10d82da6c7e7d229b361. Change-Id: I65a2f50d1087d6f8bb94d8bb73d54d3f378c6800 Reviewed-on: https://gerrit.libreoffice.org/29490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-09-16disable generation of ole previews in ODF format until after loadCaolán McNamara
so the user update links dialog can control their generation SdrEmbedObjectLink becomes exposed to calc so it can detect if the link dialog needs to be used to update ole links. Reviewed-on: https://gerrit.libreoffice.org/28879 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 74844277cc2194c9e43f5bd7a6f78a9603da32f3) Change-Id: Id1dd7ea17342140eab9307d546528747e3a98090 detangle gadzillion checks into something readable no logic change intended Change-Id: Ib6af93afc1f80b7fc36239c96d5e0a71fcbcb789 (cherry picked from commit fad9786b06d188ba6e354620f57176f3d94a6637) Unmodified default SdrOle2Obj size is 101x101 svx/source/unodraw/unoshape.cxx sets a css::awt::Size maSize to 100, 100 svx/source/unodraw/unopage.cxx increases that by 1, 1 awt::Size aSize = xShape->getSize(); aSize.Width += 1; aSize.Height += 1; to call SdrObjFactory::MakeNewObject with 101, 101 so default size is 101x101 (getWidth() vs GetWidth() confusion ?) Change-Id: I4d4375dff64d7b8e236d1a24322e749e04ee530f Reviewed-on: https://gerrit.libreoffice.org/28895 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7f0a219c9ad38ae33b51ff69d545f69659691c1e) Reviewed-on: https://gerrit.libreoffice.org/28926 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-08Resolves: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if...Caolán McNamara
the master page is not the sole owner. Which happens when copying and pasting slides which bring along a duplicate master page to an already existing one, and the attempt to remove the duplicate strips the fill properties from the shared stylesheet in use by the other regression from... commit b876bbe2cacce8af379b10d82da6c7e7d229b361 Author: David Tardon <dtardon@redhat.com> Date: Tue Apr 26 09:17:11 2016 +0200 rbhz#1326602 avoid exp. bg bitmaps from deleted slides Change-Id: I91fb8f622a0e35741ecc37cef14fc93199bb730b (cherry picked from commit de4908eb4d2f1f2ce38a37eea18a9efc4a0073b1) Reviewed-on: https://gerrit.libreoffice.org/26975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-06-16Resolves: tdf#82532 parent mutex dtored before child dtor uses itCaolán McNamara
Mutex belonged to DisposeListenerGridBridge which inherits from FmXDisposeListener, FmXDisposeListener dtor accesses a reference to the parent mutex in its dtor, but the mutex has been destroyed at this point. Move the mutex from parent to child. FWIW these classes are on the candidate list to merge. (cherry picked from commit e841ed93d6c6d817be1f7fdc18ff971325c861cc) Change-Id: Ic639eaed97c2b0625c368ed249f09920af37f94e
2016-06-08tdf#100269 svx: fix undo of table column resizeMiklos Vajna
SdrTableObjImpl::LayoutTable() assumed no re-layout is needed in case the total width of the table and the number of columns is the same, but undo of resize is a situation where we also need to check the individual widths of the columns, otherwise layout won't be up to date. (cherry picked from commits a106165e7fd39215c4717e1486aef05f6af9180f and 9cea9137b2534da4056f72d3c8a07f85a02f85be) Change-Id: Ia5ebb05af79dda1c0d8c5bb10e7f37f81ee1d035 Reviewed-on: https://gerrit.libreoffice.org/26071 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-30tdf#100115: _nColId is sal_uInt16Julien Nabet
like the other methods, so fix it in canCopyCellText + copyCellText Change-Id: I3395f8823602f0a1791908945e3dec5034d3d612 Reviewed-on: https://gerrit.libreoffice.org/25605 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> (cherry picked from commit 634fd0016ef7396a782d28272852302841f37201) Reviewed-on: https://gerrit.libreoffice.org/25620 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-05-25sd bccu#1840: .uno: commands for inserting rows / columns in Impress.Jan Holesovsky
Change-Id: Ic07722c3e1f75d909ec8f123919a1898dfde05b0
2016-05-22tdf#89329: use unique_ptr for pImpl in pszctrlXisco Fauli
Change-Id: I60d129df8eebfed3996d491379fa9d69aa3fe097 Reviewed-on: https://gerrit.libreoffice.org/25315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22Convert HYPERDLG_EVENT to scoped enumNoel Grandin
Change-Id: I8a0248bb91ee67596aa44d11ca862d2e127a65ad Reviewed-on: https://gerrit.libreoffice.org/25197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22Convert XOUTBMP to scoped enumNoel Grandin
Change-Id: I8d10cdc78ca73d86bdc9aa08fca591f6eb85eb9e Reviewed-on: https://gerrit.libreoffice.org/25196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20loplugin:refcountingNoel Grandin
Change-Id: I5cb9297c44b076dfca2a37f234ba823ba217b507
2016-05-20tdf#89329: use unique_ptr for pImpl in svx/Xisco Fauli
Change-Id: I6c252272feb9915b580b3525a606c26c19cbe773 Reviewed-on: https://gerrit.libreoffice.org/25114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20tdf#87668 Add control to show or hide "Original Size" option.Gulsah Kose
Change-Id: I022ff86af2e480b061023aac50ff9f79fc6dbf9e Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/24263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in svxNoel Grandin
Change-Id: Ia22e8b55d263224dbb85169b6165a5c116e163aa Reviewed-on: https://gerrit.libreoffice.org/25088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18convert TAB to scoped enumNoel Grandin
and rename the SID constant to something more meaningful Change-Id: Ic07888936df3d537158fd2fb671b0df11350d676 Reviewed-on: https://gerrit.libreoffice.org/24986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11tdf#89466: SvxFillTypeBox::Selected needs to be calledKatarina Behrens
when something is selected in order to flag that its an acceptable value and should not be reset to the previous value on losing focus Have to use SvxFillTypeBox instead of base ListBox to achieve that and so SvxFillTypeBox has to then be SVX_DLLPUBLIC Change-Id: I92f6264cc9cc0a9c7c8c0b5c3c73517fe456d13e Reviewed-on: https://gerrit.libreoffice.org/24858 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-09convert OUTLINER_MODE to scoped enumNoel Grandin
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909 Reviewed-on: https://gerrit.libreoffice.org/24789 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04tdf#89466: Slide Background tabRishabh Kumar
Change-Id: Ic3ba6b47a1e5fcaeec76c4e4ff0ba6128653af86 Reviewed-on: https://gerrit.libreoffice.org/17007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-04No need to explicitly delete ctor the compiler wouldn't implicitly declareStephan Bergmann
Change-Id: Idd0e764765bd76e1f6a2d8ec6e18ebac27b91ec6
2016-05-04underline popup control possible to use outside sidebarSzymon Kłos
Change-Id: I48097007c7dc0439b33233939c1d73902dfeb679 Reviewed-on: https://gerrit.libreoffice.org/24491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-05-03C++11: disable ctors with delete in include/Jochen Nitschke
replace the old declare and don't implement pattern with C++11 delete keyword no need to hide this design choice behind access restrictions Change-Id: I7e8430a07189aa48514a4613c3a8c2950b230f49 Reviewed-on: https://gerrit.libreoffice.org/24495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-02rbhz#1326602 avoid exp. bg bitmaps from deleted slidesDavid Tardon
ODF export uses SvxUnoBitmapTable (impl. of com.sun.star.drawing.BitmapTable) to create fill bitmap styles. That returns all XATTR_FILLBITMAP items that are in the document's pool. So we ensure that bitmaps that are only used on deleted (either explicitly or by undoing their insertion) slides are not in the pool. Change-Id: I54c594a94989158f22b156fe660c1e716b988b3e
2016-04-25tdf#99452 svx: fix undo of table row edge dragMiklos Vajna
The problem as seen by the user: if you have a table of 2 rows and 1 column, and the separator line is dragged upwards by the mouse, then undo doesn't restore the original situation. Two items are created on the undo stack: sd::UndoGeoObject and sdr::table::TableRowUndo. Let's say the table height is 8000 mm100 and the two cell heights are 4000 and 4000. If the user resizes the first cell, so that its height is 2000, then the new table height will be 6000. The problem is that when undo is executed, first sd::UndoGeoObject resizes the table, distributing the newly available 2000 between the existing rows, and then sdr::table::TableRowUndo sets the row height of the first row: the height of the second cell will be larger than expected. Fix the problem by not doing a relayout during sd::UndoGeoObject, but doing a relayout after sdr::table::TableRowUndo in this case. This is done by: 1) Adding a new SdrDragStat::mbEndDragChangesLayout, so that SdrTableObj::applySpecialDrag() can inform SdrDragObjOwn::EndSdrDrag() that TableRowUndo will do the layout instead of UndoGeoObject. (This is done only in case a row edge is dragged, as otherwise it's not guaranteed that a TableRowUndo will follow the UndoGeoObject on the undo stack.) 2) Adding a new SdrUndoGeoObj::mbSkipChangeLayout, so that SdrTableObj::applySpecialDrag() can let SdrUndoGeoObj::Undo() not do the layout. 3) Adding a sdr::table::SdrTableObjImpl::mbSkipChangeLayout, so that SdrUndoGeoObj::Undo() can let SdrTableObj::NbcSetLogicRect() not do the layout. 4) Marking the table model as modified in TableRowUndo::setData(), so it does the layout at the end of the undo group. Change-Id: I8adde3cdad5741e6fcb420e333ce336e18c77cf1 Reviewed-on: https://gerrit.libreoffice.org/24363 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-20tdf#99396 SdrTableObj::EndTextEdit: restore cell format undo itemsMiklos Vajna
As seen by the user: after finishing the text edit of an Impress table cell, the text changes are still on the undo stack, but the table ones (like background color or vertical alignment) get lost. This happens as SdrUndoManager::SetEndTextEditHdl() removes all undo items from the stack which are created after the start of the text edit, and creates a single item, but that doesn't include the table changes, just the text ones. Fix the problem by creating a copy of the CellUndo objects when it text edit mode, and pushing them to the undo stack in SdrTableObj::EndTextEdit(), which already writes the undo stack and runs after the undo manager cleared the text edit items from the undo stack. Change-Id: I7d2768c86b5b262e98be1d09d7fa08d581430bb5 Reviewed-on: https://gerrit.libreoffice.org/24264 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-20character spacing control possible to use outside sidebarSzymon Kłos
Change-Id: Ic0c6458268b529bd0107d6ed5a35f49241cfb833 Reviewed-on: https://gerrit.libreoffice.org/24146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-04-18Avoid reserved identifier (_CreateShape -> CreateShape)Stephan Bergmann
Change-Id: Idcdd35302e60392fae9f63de1828e1a41ab89610
2016-04-18Avoid reserved identifier (_CreateSdrObject -> CreateSdrObject_)Stephan Bergmann
Change-Id: Iee63999e4953a083783cb5c9811640150616472d
2016-04-15svx: Remove unused stringsSamuel Mehrbrodt
Change-Id: Ib5e2ae7ba7ca543f0f03ce4296b60ce4bddf75b9 Reviewed-on: https://gerrit.libreoffice.org/24102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-14loplugin:passstuffbyref in svxNoel Grandin
Change-Id: I7d405830785cb12aaceb65d6ed03dda04aa90fd8
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I85135c3fa5e6fe823491739c3c1ab601505f0626
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11clang-tidy performance-unnecessary-value-param in svxNoel Grandin
Change-Id: I3e8cd7cedb3e7b7ef05760d21b10994ce615324b
2016-04-11loplugin:constantparamNoel Grandin
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-07Prevent MSVC from emitting special member functions of dllexport classStephan Bergmann
...that fail instantiation when ToolBox is incomplete (which is normally hidden by --enable-pch). Change-Id: I49ea33cecae9f44dfcd9c7bd8bf0f00f3548ed94
2016-04-07Avoid reserved identifiersStephan Bergmann
Change-Id: I63ab4de02702c6f74caa3a65f7d297e2a95a65cd
2016-04-05convert src line width popup to .ui formatCaolán McNamara
Change-Id: I39e8bfd89538c36c97afb3e4e86c3ba9156274e0
2016-04-04loplugin:constantparam in svxNoel Grandin
Change-Id: Ib3c1262d5488e3e348ae985f53ff8c63f2175555 Reviewed-on: https://gerrit.libreoffice.org/23724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#98417, tdf#98539: DIALOG: Improvements to the Find & Replace dialog.Akshay Deep
Added Find Previous Button. Replaced backward checkbox with 'Replace Backward' from other options. Modified Dialog Layout as per the attachment in bug report. Removed vertical spacing in parent_container_box to reduce height of the dialog. Removed InfoBox from ReplaceAll functionality in writer, shifted it to SearchLabel. Attribute labels only show up when attribues are used in search, else they remain hidden. Change-Id: I0e9ded854fc2601524d6fc2a0ba5e9cb602e11a4 Reviewed-on: https://gerrit.libreoffice.org/23057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-23tdf#82641 Changes to currency drop-down listMohammed Abdul Azeem
Common codes have been shared in a static function. Now the list shows complete set of currency options. Change-Id: I17639b3123d2fd86c5a414df927ef5f07e37d845 Reviewed-on: https://gerrit.libreoffice.org/23444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-23svx: extend SvxNumType with BITMAP and CHARS_UPPER_LETTER_NMiklos Vajna
With abaf6bde4ee91c628bd55a7ec2e876a5d0ecff6e (tdf#65642 RTF filter: import \pgnrestart and \pgnucltr, 2016-03-22), CppunitTest_sw_rtfimport causes an SvxPageItem::eNumType (of type enum SvxNumType, with values 0--7) to contain a value 9 (which suspiciously is css.style.NumberingType.CHARS_UPPER_LETTER_N), which is undefined behavior. Extend the internal enum (which is supposed to be a prefix ot the UNO API one) to contain two more items. Should fix the problem pointed out at <http://ci.libreoffice.org/job/lo_ubsan/212/console>. Change-Id: I91b8c38de357ceee9e8691e15f885cdfbc0ef7ca
2016-03-19tdf#82641 Currency drop-down listMohammed Abdul Azeem
Currency drop-down list has been added. It retains the position of selected entry. Clicking on button toggles between the previously selected currency and number formats. Change-Id: I0dea8fc2773497bfaababa418f119d0a5e76cb03 Reviewed-on: https://gerrit.libreoffice.org/22958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-18convert SvLBoxButtonKind to scoped enumNoel Grandin
Change-Id: Ia8e19473132cf95837acc499c5831b5ca8786a68
2016-03-18drop unused params from SvLBoxItem and all it's subclassesNoel Grandin
looks like this is fallout from commit ac7acb0a "Merged SvTreeListBox and SvLBox." (in year 2012) Change-Id: Iaebeae64fc7cd3ba11f5f45b53bcb65bf906e906
2016-03-17loplugin:constantparam in sfx2Noel Grandin
Change-Id: I53e690ab8d50fb3ce43ba633fc018e7b66e591cd Reviewed-on: https://gerrit.libreoffice.org/23321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in svxNoel Grandin
Change-Id: I50fa7e4c7525d2f8107a11d8203957a47680eb80 Reviewed-on: https://gerrit.libreoffice.org/23303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-12 14:33:01 +0000