summaryrefslogtreecommitdiff
path: root/include/svx
AgeCommit message (Collapse)Author
2014-11-03Related: fdo#84844 Get rid of ColorControl and ColorPopupMaxim Monastirsky
Change-Id: Ie2d00cfbccefd69c8e46381b712620def655a798
2014-11-03Related: fdo#84844 Prepare border color status updateMaxim Monastirsky
The Sidebar button handles also the color of diagonal lines. Change-Id: I26d75472a8c9ca482274797127994d4546b1b3e8
2014-11-01Unindent.Kohei Yoshida
Change-Id: I911de1c7b47768233bdd9580361b8cf430b3684e
2014-10-29coverity#1242433 SdrMakeOutliner alway derefs pModCaolán McNamara
so change from a pointer to a reference Change-Id: I81eb2c9e4df8353fbbdad7058c6ca7ea22286e62
2014-10-28Rename loadColorVector to addEntriesForColorVectorMaxim Monastirsky
So it will be similar to addEntriesForXColorList Change-Id: Ie352e0cf05fa6875ed76e69478131a57293b39a1
2014-10-28Move these headers from include to svx; they are not used outside svx.Kohei Yoshida
Change-Id: I8685b451a39e890250a3309ddb70346bac4084b2
2014-10-27fdo#84844 Sidebar: Use SvxColorToolBoxControl for fill colorMaxim Monastirsky
Change-Id: I0aa9dbef960391334097b68c980064724435db38
2014-10-26fdo#84844 Sidebar: Use SvxColorToolBoxControl for line colorMaxim Monastirsky
Change-Id: I266cfd8c80088f698ec36662357477bb456a96fe
2014-10-24Forgot to update this commentMaxim Monastirsky
Change-Id: I3922bcf22b7efe43fd42c937d88251b230d6384a
2014-10-24Related: fdo#84844 Support fill color in SvxColorToolBoxControlMaxim Monastirsky
Change-Id: I6ccc1d4e71a9fe76cd16dd957f626722aaba543c
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "do not forward-declare templates"Jan Holesovsky
This reverts commit 091742e86aeb5287f7236f666fee48946ab4c67b.
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-22Describe text animation types.Kohei Yoshida
Change-Id: I4f878eff707e318fa80b7d3c19833bf724e4bcef
2014-10-22Method descriptions.Kohei Yoshida
Change-Id: Iece61424e09fc36768889fde2c848ed2b0722701
2014-10-22fdo#84844 Sidebar: Use SvxColorToolBoxControl for paragraph colorMaxim Monastirsky
Change-Id: I0231a52288ca9a8a2a5e5cdb13fdff772b989640
2014-10-22Related: fdo#84844 Support of Sidebar wide buttons in SvxColorToolBoxControlMaxim Monastirsky
The end goal is to convert the Sidebar to use SvxColorToolBoxControl, and get rid of the Sidebar specific color popup, so we don't need to maintain two popups. Change-Id: I42e5bcb611acae25f16dfe9623d19727fc39ea07
2014-10-22callcatcher: update unused codeCaolán McNamara
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
2014-10-21nShearWink -> nShearAngleMiklos Vajna
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9
2014-10-19-Werror=shadowMiklos Vajna
Change-Id: I940661c947307dc5dea371e5e6f9a9aedbfc904d
2014-10-17Resolves: fdo#62682 crash on second export of svgCaolán McNamara
because the first export has left "dangling" CalcFieldValueHdl Links in Outliners that got created based on the Drawing Outliner while it had a temporary CalcFieldValueHdl installed, and didn't get the old CalcFieldValueHdl installed when the old Drawing Outliner one was re-installed. Change-Id: I064a154ece488c9a4c3467b753451df7e73ae883
2014-10-17coverity#1247643 Uncaught exceptionCaolán McNamara
Change-Id: I0da9140bf1f76a92c95c042c5039f7cfdbde6c34
2014-10-17coverity#1247638 Uncaught exceptionCaolán McNamara
Change-Id: Ibdda31c2a8d8c3314173f381b60800ccfbcc25f7
2014-10-17coverity#1247629 Uncaught exceptionCaolán McNamara
Change-Id: Ib0f0555ba5630b225a4a5fbc64394becdeb9f7dd
2014-10-17Consistency around SdrAngleItem in svx/sxciaitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15loplugin: cstylecastNoel Grandin
Change-Id: I0ccdd2ce18336afea67a3f296b26b2de50f14808
2014-10-15nDrehWink -> nRotationAngleMiklos Vajna
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-14do not forward-declare templatesDavid Tardon
Change-Id: I3b0a145f70406f0c8a12b6c4b7876c4148f76e93
2014-10-14Make -1 a valid value of enum MSO_SPTStephan Bergmann
...as e.g. CppunitTest_sw_filters_test under -fsanitize=undefined complains > svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx:304:13: runtime error: load of value 4294967295, which is not a valid value for type 'const MSO_SPT' > EnhancedCustomShapeTypeNames::Get(MSO_SPT) svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx:304:5 > SdrObjCustomShape::MergeDefaultAttributes(rtl::OUString const*) svx/source/svdraw/svdoashp.cxx:873:26 > SvxCustomShape::createCustomShapeDefaults(rtl::OUString const&) svx/source/unodraw/unoshap2.cxx:1933:26 > non-virtual thunk to SvxCustomShape::createCustomShapeDefaults(rtl::OUString const&) svx/source/unodraw/unoshap2.cxx:1934:1 > oox::vml::CustomShape::implConvertAndInsert(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::awt::Rectangle const&) const oox/source/vml/vmlshape.cxx:976:9 > oox::vml::ComplexShape::implConvertAndInsert(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::awt::Rectangle const&) const oox/source/vml/vmlshape.cxx:1073:12 > oox::vml::ShapeBase::convertAndInsert(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, oox::vml::ShapeParentAnchor const*) const oox/source/vml/vmlshape.cxx:307:22 > oox::shape::ShapeContextHandler::getShape() oox/source/shape/ShapeContextHandler.cxx:432:27 > non-virtual thunk to oox::shape::ShapeContextHandler::getShape() oox/source/shape/ShapeContextHandler.cxx:545:1 > writerfilter::ooxml::OOXMLFastContextHandlerShape::sendShape(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1742:48 > writerfilter::ooxml::OOXMLFastContextHandlerShape::lcl_endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1769:9 > writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:249:9 > non-virtual thunk to writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:250:1 > (anonymous namespace)::Entity::endElement() sax/source/fastparser/fastparser.cxx:484:13 > sax_fastparser::FastSaxParserImpl::callbackEndElement(char const*) sax/source/fastparser/fastparser.cxx:1216:9 > (anonymous namespace)::call_callbackEndElement(void*, char const*) sax/source/fastparser/fastparser.cxx:295:5 > doContent (instdir/program/libexpwraplo.so+0x369381) > contentProcessor (instdir/program/libexpwraplo.so+0x34d9ee) > doProlog (instdir/program/libexpwraplo.so+0x330991) > prologProcessor (instdir/program/libexpwraplo.so+0x32a1f6) > prologInitProcessor (instdir/program/libexpwraplo.so+0x38d185) > XML_ParseBuffer (instdir/program/libexpwraplo.so+0x31359b) > XML_Parse (instdir/program/libexpwraplo.so+0x30f34e) > sax_fastparser::FastSaxParserImpl::parse() sax/source/fastparser/fastparser.cxx:1058:52 > sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:852:13 > sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:1339:5 > non-virtual thunk to sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:1340:1 > writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:500:13 > WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) writerfilter/source/filter/ImportFilter.cxx:107:9 > non-virtual thunk to WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) writerfilter/source/filter/ImportFilter.cxx:173:1 > SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sfx2/source/doc/objstor.cxx:2271:21 > SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:767:23 > SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20 > SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int) sw/qa/core/filters-test.cxx:71:12 > test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) unotest/source/cpp/filters-test.cxx:111:24 > test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, unsigned int, unsigned int, unsigned int, bool) unotest/source/cpp/filters-test.cxx:137:5 > SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:162:5 Change-Id: I8249f962585def8c98327cce9939e2b96b648612
2014-10-14Resolve some unnecessary typedefsStephan Bergmann
Change-Id: If57e32d41fe03db402aad74d2bd3e4d03c5e0643
2014-10-13fdo#84213 Add show/hide ruler to sd context menuSamuel Mehrbrodt
Change-Id: Iee42ab31a82ed4459f956706cef513afcf70ef94
2014-10-13oox: refactor embedded media importMichael Stahl
Currently the oox import creates a temp file and leaks it, and there is no way to clean it up afterwards. Unfortunately it turns out that SdrModel has no way to access the imported OOXML storage, so add a really ugly hack to get the embedded media into the SdrMediaObj by setting both MediaURL and PrivateStream properties (currently oox really wants to set the properties in alphabetical order too...) Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09Improve wording on several actionsSamuel Mehrbrodt
* "More Styles" (Styles dropdown) * "More Fields" (Insert field dropdown and menu) * "More Options" (Table dropdown) Change-Id: I593a1d1dd68e666d05a4ac20ae97308ad45ff18e
2014-10-06loplugin: cstylecastNoel Grandin
Change-Id: Id2b5b2510fb13f77592d7a0455f34ccd8a20c2d7
2014-10-06loplugin: cstylecastNoel Grandin
Change-Id: I88a106081b7413bff6313d1e07f53e39d8350002
2014-10-02coverity#1242909 Unused value and const things upCaolán McNamara
Change-Id: Ib98a81a04f721917ee3c1fdd19d23a37c5d2c481
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#62081 Improve split menu on style dropdownSamuel Mehrbrodt
* Remove "Apply style" * Add "Update Style Based on Selection" * A11y: * Context menu key: Open submenu * Return key: Apply style Change-Id: Ib2960baa1412a05ea00b0e214d1af0a3d119e852
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29svx: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: Ib70d974817bcdd9a582e9be28d28b007cdc3a7a7
2014-09-25Resolves: fdo#83010 remove svx::WrapFieldCaolán McNamara
in favour of a wrap property on NumericField Change-Id: I62c6bdb69a16f37ae6018a2fe41070fb18dbe4a0
2014-09-25fdo#39468: translationJennifer Liebel
Change-Id: I8ee3c1cf551f5b242d20cf244d728b79e68616ed Reviewed-on: https://gerrit.libreoffice.org/11637 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>