summaryrefslogtreecommitdiff
path: root/include/svx
AgeCommit message (Collapse)Author
2024-09-02svx: prefix members of XPolyPolygonMiklos Vajna
See tdf#94879 for motivation. Change-Id: I09d2827c7e2dd91f9bf160e47c22180bde682932 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172727 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-08-29tdf#161826 - Add uniform Glow effect for texts in shapesBalazs Varga
- Add new text Glow effect properties for shapes - Using TextGlowPrimitive for rendering uniform text glow in shapes - Add/allow new UI Glow Effect for texts in shapes on sidebar (Only for Impress/Draw and Calc) - Import/Export ooxml files with Glow effect on texts in shapes (Only PPTX/XLSX) - Import/Export odf files with Glow effect on texts in shapes - Add unit test for glow text attributes in ODF - Add uni tests for OOXML import/export Note: Also this patch effects on tdf#144061 - Effects: Allow GLOW to apply to Text (as we have for shapes) Change-Id: I16586c01654f197f532129e4e06aa2ef9f214395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172216 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-08-28svx: fixed textbox text always black on dark themePranam Lashkari
problem: when doc is in dark mode and a textbox is inserted, even though text has automatic color it will be black on unselecting textbox Change-Id: I8736c15a1254682f06218a1eb1039b1985eda552 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170537 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 41b277224310b63a181d65a279e1d77950db9309) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172494 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-08-26svx: prefix members of SdrObjEditViewMiklos Vajna
See tdf#94879 for motivation. Change-Id: Id344aa38c431608432a6a274ee4ec6772b434557 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172376 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-08-22tdf#158556 make SvxGrfCrop hashableNoel Grandin
Change-Id: I30c8f44156a05519dc2f6db59734013e217c91b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-21cid#1555812 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556056 COPY_INSTEAD_OF_MOVE cid#1556907 COPY_INSTEAD_OF_MOVE cid#1556957 COPY_INSTEAD_OF_MOVE cid#1556970 COPY_INSTEAD_OF_MOVE cid#1607095 COPY_INSTEAD_OF_MOVE Change-Id: I51112b3a63b8e9333e3eaaeb55b764e6c449a5ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-18tdf#154018: Change corners to points for polyline and polygon context stringsTH Huang
Change-Id: Ic6b0835238e463e5c155b01a292a5eed72e446d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171743 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-08-15make SfxStringItem hashableNoel Grandin
which shaves some time off loading complex files. Note that this class is often used as a superclass, so I checked all of the subclasses and marked some of them as "does not support hashing" until they can be independently verified to be safe Change-Id: Id4187eda8d6145e89e17dc10c2e3113b7a93da85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-14svx: prefix members of SdrUndoSetPageNumMiklos Vajna
See tdf#94879 for motivation. Change-Id: I4231a19a562ede125f0f1819cbb224935a20c801 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171844 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-08-12tdf#156857: sd ooxml import: fix shape size if spAutofit is setBalazs Varga
and the size of the shape from ooxml file is different then the inew calculated by TextAutoGrowHeight. Furthermore, no need to check and resize the shape size during the spell checking. Change-Id: Iffd15e02579942d4f5f20db73f2194f8298c0838 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171621 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-08-07sw a11y: Add a11y names for bg settings in side barMichael Weghorn
Set a11y names for UI elements related to the page background in Writer's "Page" sidebar deck, section "Styles." Some of those combo boxes/menu buttons are reused for multiple background types, so set an a11y name depending on the currently selected background type in C++ code instead of a static one in the .ui file for these. This allows screen readers to announce what those comboboxes/menu buttons are for when they receive focus. Lack of some of those led to gla11y failures in pending Gerrit change [1], but is actually a preexisting issue as mentioned in [2]. (The gla11y issue even showed up after simply resaving pagestylespanel.ui with glade 3.40, see CI failure for [3], a previous change doing that in preparation for this commit, but now squashed into this commit.) [1] https://gerrit.libreoffice.org/c/core/+/171430 [2] https://gerrit.libreoffice.org/c/core/+/171430/comments/6fac1506_50ddcce5 [3] https://gerrit.libreoffice.org/c/core/+/171582 Change-Id: I4e78c61cfd5d5b9f198887eec53be368cb6a0716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171583 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-08-05svx: prefix members of SdrUndoReplaceObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: I70d2a1c4b1918683085d40208bed6f5f28ebee1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171471 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-01tdf#161968 UI Assign macro to shape crashes CALCNoel Grandin
regression from commit f690e8218a74a0f7792407a1d46198883d2528ff Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Jan 23 13:24:29 2024 +0200 make event config dialog async Change-Id: Ie68aeb1171831da3b457afd945ccaaa248e652af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171370 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-31tdf#161846 use more GetItemSurrogatesForItemNoel Grandin
lots of time spent searching surrogates, and we can use GetItemSurrogatesForItem here. Also, add another SfxItemType which I missed in my earlier changes Change-Id: I9b989d75dbc3cdcdc1e97bf41836b92dd2852113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-31Fix typoAndrea Gelmini
Change-Id: Ia3762c73a2787f404efb8f6005366283373641c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171267 Tested-by: Jenkins Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-07-30tdf#161846 remove one layout operations (v)Noel Grandin
of the 6 we perform per caption Change-Id: I57b3f12ca73e08e18be4d22da74e688969ae35b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-30Fix typoAndrea Gelmini
Change-Id: I908619bca56ac82b4f6696736907a51fbe825ddc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171231 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-30Fix typoAndrea Gelmini
Change-Id: I3d42b46e8f1c83a1979f04e8b4c103b9e181b467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171232 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-30Fix typoAndrea Gelmini
Change-Id: I637045d189aea162aec63297c1aed6372f09cd38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171229 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-30Fix typoAndrea Gelmini
Change-Id: I4181f5d1988a9ddb90b2a5e545143a3e794a5a61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171230 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-30tdf#161846 remove one layout operations (iii)Noel Grandin
of the 6 we perform per caption Change-Id: I5afbc296a9be4fcb732cfbe28d43a2ad45aa6c9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171172 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-30tdf#161846 remove one layout operations (iv)Noel Grandin
Change-Id: I0c09c7b4636a7ac4c3dc87a8a17efd278109c3c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171213 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-29tdf#161846 remove one layout operation (i)Noel Grandin
of the 6 we perform per caption object Change-Id: I8af5a0a4c859241fa350fcd3c45cfdfe1cfb6475 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-29svx: prefix members of SdrUndoObjSetTextMiklos Vajna
See tdf#94879 for motivation. Change-Id: I414fc94c35dc9caa2619b92eeaa436ad17fae5ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171168 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-07-29tdf#161875 buffer NameOrIndex Items for fast SurrogatesArmin Le Grand (Collabora)
Problem is that collecting the Items using the ItemSets and PoolItemHolders is too expensive when used too often. For read-only access it is okay to have the Items directly registerd (for write access we *need* the ItemSets and PoolItemHolders, see iterateItemSurrogates). This is limited to Items which need to support surrogates, but can further be limited to the here critical ones - the ones derived from NameOrIndex. This is done here by checking if the Item is a NameOrIndex based one by adding a bool to the item that gets set in the NameOrIndex constructor. If needed this can be changed, e.g. by using besides the SFX_ITEMINFOFLAG_SUPPORT_SURROGATE another flag signaling this. Since only Items that are currently held by an ItemSet or a PoolItemHolder get registered it is not necessary to change the Item's RefCount in any way, doing that may lead (again, we had that with directly set Items at the Pool in the past) to long-living Items that only get cleaned-up when the pool/ document gets destructed. This buffering is now SfxItemType-based, no longer using the WhichID, so the result needs to be checked for WhichID additionally - if needed (?). All in all it's anyways a compromize, every usage of the surrogate mechanism is a 'hack' in the sense that for lazy reasons not the model data is traversed directly, but assumed that all Items set at a pool/model *are* model/document data (what is not always true). CheckNamedItem does not need to be static, changed that. Also all accesses to maRegisteredNameOrIndex *have* to work on the MasterPool instance, same as buffered ItemSets or PoolItemHolders, corrected that, too. Number of instances in the buffer need to be counted, else an instance will be removed too early: The same instance of an Item can be referenced by multiple sets/holders, so the first remove from the buffer would already remove even when the Item is referenced multiple times. Added that. Added more asserts & made sure that all constructors/ destructors of SfxItemSet do take care of registering Items for the surrogate mechanism as needed. Change-Id: Ib33e7f0bd4abd32a3bb68278f33b0abb9a4754c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171084 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-26fix in some missing SfxItemTypesNoel Grandin
Change-Id: I7dcb9768a8cd63200b8f8c50d8170e78ff5aeec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171068 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-19reduce cost of dynamic casting in SdrMarkView::CheckSingleSdrObjectHitNoel Grandin
which shows up when navigating large complex documents with lots of shapes Change-Id: I0631daf1365387f1192815402921ada191ab6046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170760 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-19Fix typoAndrea Gelmini
Change-Id: I1b4316e9b02acbea96b596b26005bf1c774f9f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169228 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-18Fix typoAndrea Gelmini
Change-Id: Ieedbda914b5272e700a36f691f159f449603f264 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170502 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2024-07-18tdf#162006 Use contrast outline for the AutoFill/Cursor handle as wellRafael Lima
This patch draws a white line around the AutoFill handle for better contrast. It also adds an internal white outline to the cursor overlay. See bug ticket for screenshots. Change-Id: I1567d272fd5a2835192c50973e84cb8c269fb04e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170354 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-07-16Resolves tdf#105000 - Make shipped palette names translatableHeiko Tietze
Change-Id: Ifd062cf25c6e930da56571e01c21bd9d2ddf6ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170394 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-07-15delay parsing of formula in EnhancedCustomShape2dNoel Grandin
We create a bunch of temporary copies of these during layout in writer, and we don't appear to need the equation results at that point. Speeds up display of a complex DOCX file load by 10% Change-Id: Ic5870931caba13cd79b07617d04b70616f06c5b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170498 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-15remove RecalcObjOrdNums in DoTextBoxZOrderCorrectionNoel Grandin
(1) We already do this recalculation automatically using a dirty flag. (2) Add a custom method so we don't trigger that recalculation here Speeds up display of a complex DOCX file load by 10% Change-Id: I2a8c975ba0711172bc3e0c20c0e89f08351b6126 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170431 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-15svx: prefix members of SdrUndoObjOrdNumMiklos Vajna
See tdf#94879 for motivation. Change-Id: I0ab21ca5171b5d5b66542dbf7157db0c156e45b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170487 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-07-14cid#1608349 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I00f4afb09907b91c4d180a9dd7464226bb327af3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-14tdf#161811 Changes in TC manager dialog should be in order ofJim Raykowski
appearance in document Adds a drop down control to the Writer Manage Changes dialog/sidebar panel that can be used to select how the changes list is sorted. Change-Id: I9602322ec61ae6e15a08fbc26aa69de1b64294e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170390 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-07-10regain the SvxCharacterMap "pre-run" logic in async modeCaolán McNamara
since: commit 6a5ef1a2b009f208745a251828bf8e8c51146bfe Date: Mon Jan 22 12:35:50 2024 +0200 make charmap dialog async Change-Id: I5fc13e759eb8f1d1e6ab7c09f39cabc1d4c4ad7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170276 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-09Revert "fix and simplify the ItemInstanceManager mechanism"Noel Grandin
This reverts commit 85fd526fc681a994415bb422090d1d23aa7d54f6. Change-Id: I5019f72f88497f50a77666d57f2d16c2749bd1c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170218 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-09make SvxGrfCrop hashableNoel Grandin
Change-Id: I529b642072becd1171d02598d57a9237e893fa2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-09checkForUniqueItem should take a reference parameterNoel Grandin
Change-Id: Ibd9638f9716c4ce8db7ee5e652dc2f207617e7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170162 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08make some of the SfxStringItem subclasses hashableNoel Grandin
Change-Id: I7ad748b67266926f1e4e67e843a90b5ac3fe58b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170152 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08make SdrCustomShapeGeometryItem hashableNoel Grandin
Change-Id: Id27784da750e2cc9913c0d00df6e0b10d080f663 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08make SvxMarginItem hashableNoel Grandin
Change-Id: I9e0d23a81186231ebe314c14993b93e7c8a9d844 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170149 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-08make SvxDoubleItem hashableNoel Grandin
Change-Id: Ia52a4ce4bd9390872a89bdea0182de697e209180 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170148 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08make SvxB3DVectorItem hashableNoel Grandin
Change-Id: I759d5f225769d3833c6da664793a9d400a398a51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170147 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08make SvxGraphicItem hashableNoel Grandin
Change-Id: I2cfca6f61c0247947855f40d6b1cdee521e8382d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08svx: prefix members of SvxGrfCropMiklos Vajna
See tdf#94879 for motivation. Change-Id: Idbba42dd3af7a47db6a56c3a129a4da54af076d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170135 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-07Fix typoAndrea Gelmini
Change-Id: I68649c1b71fa5455f2bc2edd9d773820299e60f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170095 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-07move UniqueID to tools and rework to increase counter in constructorTomaž Vajngerl
In the tools module it can be used in more other modules. Changed the instantiation to increase the counter already in the constructor, so no need to check if the ID is 0. Also test for UniqueID Change-Id: I77c80461875c69496a7e218534d16d6550c168c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170061 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-07-06Fix typoAndrea Gelmini
Change-Id: I5d2030f1057f0a2232680ed60f4312331eca2926 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170063 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-02-04 11:14:18 +0000