summaryrefslogtreecommitdiff
path: root/include/svx
AgeCommit message (Collapse)Author
2018-09-18loplugin:unusedmethodsNoel Grandin
Change-Id: I5f63ac44654ed3fc658e72e0d1148a5a22decc47 Reviewed-on: https://gerrit.libreoffice.org/60662 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-18weld SvxMeasurePageCaolán McNamara
Change-Id: I08f177d74aff278c62f76e32a1401ff24f249c57 Reviewed-on: https://gerrit.libreoffice.org/60589 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17weld SvxSearchFormatDialogCaolán McNamara
Change-Id: Iefe6c616dc5f6bd525ed9708785846626f43c9b6 Reviewed-on: https://gerrit.libreoffice.org/60579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17rename to weld::ComboBox are they are not text only nowCaolán McNamara
Change-Id: Ice26d1fd2ad97a6959c6916fef428777efea9c2d Reviewed-on: https://gerrit.libreoffice.org/60500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17add image support to weld::ComboBoxTextCaolán McNamara
Change-Id: Ie7f00ed4aef5318a525a526d0377bb7952bdd5a0 Reviewed-on: https://gerrit.libreoffice.org/60499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-14weld SvxCharNamePageCaolán McNamara
Change-Id: Ia54a5ac4fe4a11b7c03508c336193bb52c616e7f
2018-09-12loplugin:unusedmethodsNoel Grandin
Change-Id: I0f96c41ab61bd4bfaf6c36d78d0a2ca768da0032 Reviewed-on: https://gerrit.libreoffice.org/60314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-12tdf#119392 write bitfield in <draw:layer-set> orderRegina Henschel
The view uses the SdrLayerIDSet bitfield in layer ID order. But file format knows no layer IDs and on loading the bitfield is interpreted in the layer order given by <draw:layer-set> element. Therefore reorder the bits on saving according <draw:layer-set>, which is order in SdrLayerAdmin. Change-Id: Id349dc7f42338e35ca8cc3b6409d061213b01691 Reviewed-on: https://gerrit.libreoffice.org/60178 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-09-11loplugin:unusedfieldsNoel Grandin
Change-Id: Ic7871f3a40668ba73aa0f0067a45455920d55890 Reviewed-on: https://gerrit.libreoffice.org/60313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:simplifyconstruct in svtools..svxNoel Grandin
Change-Id: Ia20fac7cec01ac658a903f8b001807b2e72dbf3e Reviewed-on: https://gerrit.libreoffice.org/60316 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:unusedmethodsNoel Grandin
Change-Id: I34009aabf0befb346470b5c0d96ad8fc476b7c4e Reviewed-on: https://gerrit.libreoffice.org/60300 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11Use [[nodiscard]] in SAL_WARN_UNUSED_RESULT where availableStephan Bergmann
...which required some lax placements of SAL_WARN_UNUSED_RESULT to be fixed. Also, Clang unfortunately is rather picky about the relative order of SAL_WARN_UNUSED_RESULT expanding to [[nodiscard]] and uses of the DLLPUBLIC macros (expanding to __attribute__(...) resp. __declspec(..) for clang-cl). Change-Id: Iae6ca36bef97f1864873aefdb5f05c7f5e045ad3 Reviewed-on: https://gerrit.libreoffice.org/60274 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-11weld SvxBitmapPickTabPageCaolán McNamara
Change-Id: I4c5fd94356f3640b150ef9fec48a166457f3b70b Reviewed-on: https://gerrit.libreoffice.org/60266 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-11loplugin:constantparamNoel Grandin
Change-Id: Ia11bf93768d5f722b7fe62df15f24809cb7e7f04 Reviewed-on: https://gerrit.libreoffice.org/60280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-10weld SvxBulletPickTabPageCaolán McNamara
Change-Id: I0b3e48cc63984208c8e4a090d6630dd5325d776e Reviewed-on: https://gerrit.libreoffice.org/60257 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10weld SvxCaptionTabDialogCaolán McNamara
Change-Id: If678c5f4834144f1c710465701dc4d13714a6b44 Reviewed-on: https://gerrit.libreoffice.org/60247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-09weld SvxAreaTabDialogCaolán McNamara
Change-Id: Ia6ec954c6d0117fddc17432301ddeda3b26bbc8e Reviewed-on: https://gerrit.libreoffice.org/60222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-09weld SvxShadowTabPageCaolán McNamara
Change-Id: I5447641216c8cba3d275d76c00bf7306df8acf19 Reviewed-on: https://gerrit.libreoffice.org/60221 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-09weld SvxGridTabPageCaolán McNamara
Change-Id: I04c2ead288547ecd0fba22a7a95a2497ab8dc768 Reviewed-on: https://gerrit.libreoffice.org/60217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-09unused typedefCaolán McNamara
Change-Id: Iaba97feb23b22930261b558f953a70aa3364a1ef Reviewed-on: https://gerrit.libreoffice.org/60219 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08weld FontFeaturesDialogCaolán McNamara
Change-Id: I67ab7388593aceb00b660e4d40904a4eef247620 Reviewed-on: https://gerrit.libreoffice.org/60148 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07weld SvxCharEffectsPageCaolán McNamara
Change-Id: I067b7a8c93e997fd554558f334a2968bf27965c6 Reviewed-on: https://gerrit.libreoffice.org/60147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07weld writer page style dialog and SvxBorderBackgroundDlgCaolán McNamara
writer, format page is complete Change-Id: I09f6e4354461c4374cdb0d0e0754dfee35415b45 Reviewed-on: https://gerrit.libreoffice.org/60058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06rename back now originals are fully replacedCaolán McNamara
Change-Id: I1911055f9bf6bd636561209cadfb1dbf5650affa Reviewed-on: https://gerrit.libreoffice.org/60057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06weld SwColumnPage and SwColumnDialogCaolán McNamara
Change-Id: Ia649785047db2551044b4d765881309f83b5c838 Reviewed-on: https://gerrit.libreoffice.org/60044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-05weld SvxBorderTabPageCaolán McNamara
Change-Id: I33f12f160ac5fea14c9a53c3846c6d31c7fd0084 Reviewed-on: https://gerrit.libreoffice.org/59954 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-05default focus colorset on popover gaining focusCaolán McNamara
Change-Id: Icb731c4c9544d754bb3ad88ecf15ffc04f216294 Reviewed-on: https://gerrit.libreoffice.org/60006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-05loplugin:useuniqueptr in ViewObjectContactOfPageObjNoel Grandin
Change-Id: I4f7af7bb8da2b4bfb27ab7cf748677fc3fa6fdbc Reviewed-on: https://gerrit.libreoffice.org/60004 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03weld SvxAreaTabPageCaolán McNamara
which itself has 5 sub tab pages Change-Id: If71e91248b5771af4845ad6dba997ac4c7841b5d Reviewed-on: https://gerrit.libreoffice.org/56112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03pass SdrUndoAction around by std::unique_ptrNoel Grandin
convert the LINK we use here to std::function, since LINK does not currently handle std::unique_ptr Change-Id: I9df80352e612445e5f5ca513d7d4196d65589778 Reviewed-on: https://gerrit.libreoffice.org/59804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-02Fix typoAndrea Gelmini
Change-Id: I3947c13a595f94ea56d01dc5c3db5e634e737342 Reviewed-on: https://gerrit.libreoffice.org/59902 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-08-30weld SvxHeaderPage/SvxHeaderPageCaolán McNamara
Change-Id: I86f14a38c32baf46ccb5674005192fea2665719d Reviewed-on: https://gerrit.libreoffice.org/59801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30rename GetMarkedObjModel to CreateMarkedObjModelNoel Grandin
and return std::unique_ptr Not that it helps much, the ownership quickly becomes complex once it hits the TransferableHelper. Change-Id: I3c6bd72072e092b71b32e4105fe859fdcea956af Reviewed-on: https://gerrit.libreoffice.org/59777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29Fix typo: s/an other/another/gAndrea Gelmini
Change-Id: Ifd83affcb16209f4134c725640fbd95077c8ab0f Reviewed-on: https://gerrit.libreoffice.org/59099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29remove 1 pixel white band in XRectPreviewCaolán McNamara
Change-Id: I3089f9305b8142e2c78405a4f9ae6a2066e90cfa Reviewed-on: https://gerrit.libreoffice.org/59725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-27tdf#101242 Support draw:display and draw:protect attributes of ODFRegina Henschel
LibreOffice writes the properties visible, printable and locked of layers into items in the subfile settings.xml and handles them as properties of the view. ODF handles them as property of the layer. To become more ODF conform as a first step these properties are now read and written. They are used to initialize the view in case they are missing in settings.xml, which is the case for foreign documents. The ODF properties are written in addition to the items in settings.xml, so that older versions will notice no difference with such documents. SdModelTestBase is changed to handle odg as Draw document. Change-Id: I190ecc51fc6ee91ec4b96d06bb216ce517bdfcfe Reviewed-on: https://gerrit.libreoffice.org/59269 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-08-27tdf#42949 Fix IWYU warnings in sd/source/ui/inc/[n-s]*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also a bit of fallout management overreaching into include/ Change-Id: I99bd4527ecf34e5193602f0e9dcb33b504e8c9e1 Reviewed-on: https://gerrit.libreoffice.org/58808 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-24pass DelFormats around using std::vectorNoel Grandin
instead of an array and a separate count Change-Id: Ia12a549da7e35092da2db35f8b2b9fc6a9e9c2be Reviewed-on: https://gerrit.libreoffice.org/59506 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24tdf#119236 Dimension dialog for Writer and CalcMaxim Monastirsky
Change-Id: Ifbc6c8959afcedac0fd9ec7a3f5e2cca63c11eda Reviewed-on: https://gerrit.libreoffice.org/59484 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-22new loplugin:conststringfieldNoel Grandin
Look for const string fields which can be static, and mostly convert them to OUStringLiteral And add a getLength() method to OUStringLiteral to make the transition easier. Remove dead code in XclExpRoot::GenerateDefaultEncryptionData, default password is never empty. Change-Id: Iae75514d9dbb87289fd5b016222f640abe755091 Reviewed-on: https://gerrit.libreoffice.org/59204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-21tdf#119282 Area tab, Pattern color changeNoel Grandin
regression from commit ccd316d1cb310734848bd20244f509024b549b8c use VirtualDevice in createHistorical8x8FromArray Move the code inside vcl so we don't need to expose BitmapWriteAccess. I tried to detect this thing by counting the number of independent colors in the bitmap, but that didn't work. It is used from more than one place, and appears to be very determined that it needs a 2-color palette to work properly. Change-Id: Id11dd9ea78e5e522a6083d6a799e801cac81fd5b Reviewed-on: https://gerrit.libreoffice.org/59331 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-08-20return weld widgets by std::unique_ptr from builderNoel Grandin
Change-Id: I20c007b13dae2d1155034711ad1ad48bfdfd0ba8 Reviewed-on: https://gerrit.libreoffice.org/59288 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-19Remove comment leftoversJohnny_M
This is a follow-up to commit 45ec1d9b56cec41596f806ebf845ebfcd30c9f46 , where the respective defines were removed, but their comments stayed behind. Change-Id: I205c5a36e0cd13e67293215c0be730ac7b17f111 Reviewed-on: https://gerrit.libreoffice.org/59284 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-16tdf#119284 bg for automatic not set while editingCaolán McNamara
refactor and reuse fdo#35779 solution for this case Change-Id: I0631cd2560aa2acc2310f95b5c4dea36a2845a58 Reviewed-on: https://gerrit.libreoffice.org/59165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16return std::unique_ptr from CreateOverlayObjectNoel Grandin
Change-Id: Ib4e8849cd82ee0374228405209a33554310579d7 Reviewed-on: https://gerrit.libreoffice.org/59115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15loplugin:useuniqueptr in disposeOutlinerNoel Grandin
Change-Id: I038d98a4d4b3dd2a73afd8ddb4c4a7396e52267f Reviewed-on: https://gerrit.libreoffice.org/59012 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15loplugin:useuniqueptr in GalleryThemeNoel Grandin
Change-Id: I6c709b9c38f24af37b355f85e5957790eb20a326 Reviewed-on: https://gerrit.libreoffice.org/59022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15loplugin:useuniqueptr in OverlayObjectListNoel Grandin
Change-Id: I641d93e54504c27bcc49bae8edf6286c0a9a471f Reviewed-on: https://gerrit.libreoffice.org/59024 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15loplugin:useuniqueptr pass SgaObject around by std::unique_ptrNoel Grandin
Change-Id: I88ef5de94f83cd8f7a7d2a60b072cc23bd147b27 Reviewed-on: https://gerrit.libreoffice.org/59009 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>