Age | Commit message (Collapse) | Author |
|
See the discussion at <https://gerrit.libreoffice.org/#/c/58170/>, and
this came up on IRC today again.
The above change broke the invariant that you can mix product and debug
(but not dbgutil) builds. Restore this, without mandating dbgutil for
the solar mutex assert code, which is useful for plain debug builds as
well.
Change-Id: I1f8bdb114b129fc4f39f186ba917e35e346a16b5
Reviewed-on: https://gerrit.libreoffice.org/85369
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I9dc920e9388f9e2aa4dcae1f0b3f7562d08f7f70
Reviewed-on: https://gerrit.libreoffice.org/61809
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
where our QA people are more likely to trigger it
Change-Id: I4ce7c8c72e7e21f2296c0f9cc9f019aaef32ed0b
Reviewed-on: https://gerrit.libreoffice.org/58170
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I68c67e77a2759c8542dd4a44a78a9fcf8aa7dcc0
Reviewed-on: https://gerrit.libreoffice.org/26056
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ia5acfb564f913d52cd25b5d64d06b5280b94cb72
|
|
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes
much more sense.
Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
|
|
and drop the macro
Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
|
|
See (short) discussion on the mailing list, "How was it again, is the
DbgDialog useful?".
Change-Id: Ibde1eb13f16edf94f1f7aebd0befd1b0b171d5c4
|
|
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.
Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
|
|
Change-Id: Iedee28da32a4333a414e06877f87851345bb4e9b
|
|
Change-Id: I86587025d397d2d84f9aed1e204ae21056829a1c
|
|
Change-Id: Ife048a705e899870a8b1d9987b109d5c0cd80599
|
|
Change-Id: I4fb4e7e6a5779801e135864781204a54250ce092
|
|
So that this is always wrong (on this platform) to write:
reinterpret_cast<foo>(reinterpret_cast<long>(bar))
it should be:
renterpret_cast<foo>(reinterpret_cast<sal_uIntPtr>(bar))
Change-Id: Ia286246ee1616988f755c2d2054b26efacc51af0
Reviewed-on: https://gerrit.libreoffice.org/13366
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Ic76ccc49b9291fe82c56974eb6237cd3b85d91c8
|
|
I introduce a template method into the PTR_CAST machinery
to maintain constness.
There is now a FIXME in sd/../docshell.cxx because I needed
to use a dynamic_cast there to work around the games it appears
to be playing with OLE in-place activation.
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>,
dropping the GCC-extension, unnecessary use of typeof from tools/rtti.hxx
Change-Id: Iba5ace1aa27e02b34fcc91af1e658c43371afd03
|
|
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.
Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
|
|
Change-Id: I1bc585af8f0189dfa219bd42a5f09871a006c6ea
|
|
Change-Id: Id5e3191ea1a505bd7d46af355edb99e184b5fcb1
|
|
Change-Id: Iaaf36d012e353f73f083c9c0ebbbb6d0953b16c8
|
|
Change-Id: I13adca8c2f929c8a9226b26ef57b26363dfdf0b3
|
|
Change-Id: Ia2d7eaaa1381fe46839b0d52a91bdc3a439fa418
|
|
...since the osl/diagnose.h macros got rebased onto sal/log.hxx, so remove the
corresponding tools/debug.h functionality.
Change-Id: Ife4b5b1a2608230d0dbfc3fa8852243c89ed292f
|
|
Change-Id: Ief6661ed4bb57546014deef5b10d20fc3a4894fe
|
|
...and thus DgbData::nWarningOut is unused, too.
Change-Id: I388d2be7dafbfdc173a731dc7daf1c8b5efcd61d
|
|
Change-Id: I719c0448ae3db291edfb32738404ff375deb3c3b
|
|
Change-Id: Ia3fd76aa70564cbc683d0d66cc39aa368bea29d9
|
|
Change-Id: I7b48d8b9e162f9e4447bfcfcc0bbd1158bd35f5b
|
|
Change-Id: I5f44f041e465230d10d562e8bd6f141848465e07
|
|
remove it, as it's nonsense
Change-Id: Id8171b81d42dfd3d391b7c5e6602d9271b6697c7
|
|
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655
Reviewed-on: https://gerrit.libreoffice.org/4627
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details
Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
|