Age | Commit message (Collapse) | Author |
|
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.
Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
|
|
Change-Id: If387291e9e145ee36338b1e560f18889c3b62674
|
|
Change-Id: I099258e449d0155154d60a839f9495236cb48cbb
|
|
Change-Id: I009e0f388cfe1861cef89d2148a02380dd47c1ff
|
|
SvMemoryStream remainingSize returned the size from current
position to internal buffer size instead to end of data. This
was not consistent with what remainingSize description says on
SvStream (and other SvStream implementations work) and what the
user expects.
Change-Id: I7ff391754a386c5f067a4bd4eed2ee7f2d7fd77e
|
|
Change-Id: Ib3f43db131cf5562ad011538873c2ee51839665c
|
|
Change-Id: If56233b5226cec9516d5e2f8992e1b0beae733bf
|
|
Change-Id: Ic496662d623c4732db41476109b3731cf1fd71a0
|
|
Change-Id: I2e12d923a07385fc6a036863070a10666542d39d
|
|
Change-Id: I853b6b1cfcd4847603d9920a47298d1b9105b46f
|
|
Change-Id: Idb909c205dfadaadeb8b98ce08fe2f4286cfce26
|
|
Change-Id: Id2fab3e4b7a8feed3107e66d02cdf2a278ae9ef7
|
|
by converting the bit munging to use bitfields.
Remove unused return values.
Add asserts to check that AddRef() is not called after the object
is deleted.
Fix the code in SfxObjectShell to not call AddRef() after
SfxObjectShell is deleted.
Change-Id: I3a3565a0bc45fc9d1d086222265ab8b8175818a7
|
|
which required making SfxFrame subclass SvCompatWeakBase,
but that makes the relationships clearer anyhow.
Change-Id: I209d05359d50111eacac72c971bb46ccf569ba49
Reviewed-on: https://gerrit.libreoffice.org/10285
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0d3d1a14d8eb880a5a054fe2e736f8ac97f8b727
Reviewed-on: https://gerrit.libreoffice.org/10284
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
|
|
.. which more accurately reflects it's purpose
Change-Id: Ibb87a47a3d1f3e35ac2820f14c71adf3b227c961
Reviewed-on: https://gerrit.libreoffice.org/10283
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
This reverts commit 09a90c2ff5d39c3ae61b4041c3b39d3da0c640c1.
Apparently causes a crash in CppunitTest_sc_macros_test; it is
suspicious that the copy ctor is not made private in this commit, since
the compiler generated one would do something different.
Change-Id: Icb1121332d83e9f08d89535e3da6e10d690ac88a
|
|
Change-Id: Ic38d7f5f816f2a91bfb468c0b7fb241b084a0c44
|
|
.. only used in 2 places in the same file
Change-Id: I5dc1dc77c3841bf86134f6a48597f8c1e71b2b3f
|
|
..it is only used in two places
Change-Id: If333936b26592ed44d3525f2eb3c21aafde7dddc
|
|
Change-Id: I81991231a2cc0b0c9d8289db8435ef8286f1c2bb
|
|
Change-Id: I1f7f566ea80723b188aab9c2f65437ca902ce9b9
|
|
Change-Id: Id0b3792b037b2e1a9357c7f26f554cc4222fed0b
|
|
because no-one is using the return value of ReleaseRef, but everyone is
calling ReleaseRef, so make ReleaseRef void-returning and remove
ReleaseReference
Change-Id: I0bedcb65a887ba7a4953132b4c1ccefbdd554a43
|
|
Saves ~40bn cycles, 10% of calculation for the bug document.
Change-Id: I9d48706ad2cfe290965b648306d95b4d66e5fc63
|
|
Change-Id: I339577c5b34de0cf3e5dcc644ec1dc080c35d01c
|
|
...in the same vein as 80a1a2599e04142683d2286d0e32d0e13fb45de3.
Change-Id: I5ffb27f0bc965aede03e6d1e849cd68ef6e16e2a
|
|
Change-Id: Ie111d9ed3534eb8892400d638eac4b38b3904646
|
|
...to avoid -fsanitize=function warnings in Link::Call.
Change-Id: I837b35bd3052716fbb41bf4f893961257d1f9b2c
|
|
Change-Id: Icebdf0cad5306ae42a30de0b4f997e3b611675eb
|
|
Change-Id: I4d558e9a6e2c4e4d9feb45eb5a3fd01ee322bef8
|
|
and strip away some stuff in rsc that should now be dead
Change-Id: I6411e706c50dff299099680f1f942bf61c4e79f2
|
|
Change-Id: I54880de44ee10d4f71c8a514f905e8e00774fde7
|
|
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
|
|
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
Conflicts:
tools/source/fsys/urlobj.cxx
Change-Id: I59b5b95cf9b65920ec04922fdb25e4228fd22995
|
|
...which does not make sense. On Linux and Mac OS X, they potentially end up
exported from multiple libs (weakly, though), while on Windows the potentially
even end up not emitted at all, which could cause link errors.
Change-Id: I092c9ba39e686c17b6e91581cdd4753f1c4d582f
|
|
Change-Id: Iafca1288e044ab4650b004439027c134e159b45f
|
|
The fun thing is that with the (only) call-site to ReadAsynchron in
PNGReaderImpl::ImplReadIDAT (vcl/source/gdi/pngread.cxx) passing in rIStm
references to stack-allocated SvMemoryStream instances, mpIStm could point to an
old, destroyed instance from a previous call, but which would have been located
at exactly the same stack address as the currently passed in rIStm, so the wrong
mpIStm->Read call would effectively behaved exactly the same as a correct
rIStm.Read call.
This went unnoticed "since the beginning" until AddressSanitizer's
UseAfterReturn check came along...
Change-Id: I7c75ed2d36a4c24c111d88eff647816bd2c5dbca
|
|
...(which can be called multiple times in a row). But which actually looks
wrong...
Change-Id: I2e4914e6fed8ced383e430699dd462add9da8c08
|
|
Change-Id: I2714b1f1dadc74f8501203bc8b0722c56c9c5fb9
|
|
...and document how the member functions are supposed to be called from client
code.
Change-Id: Ia4847945e4a361c43a0ed001e3e78e901c9abcad
|
|
Change-Id: I2103f8a323d0454bdd1c779aadb99889ae1cf6e5
|
|
Change-Id: I9741daf288c11dc8e0f0ad2f64e934e814c3ef8a
|
|
Change-Id: Id710a1fe4a3c1593add69bb2a7014d26f9499e87
|
|
Change-Id: Ibdf211b858c25a4b301cbde3dcab3a51765e4050
|
|
Change-Id: I275abafe81c8bb617c70646244b14f6cecc33854
|
|
Change-Id: I57a5a14a51c0441e0fed006457ac95057f188462
|
|
...and directly use zlib.h's Z_DEFAULT_STRATEGY
Change-Id: Ibf528cbc32afec4d442656aa2963f50c0875d6a5
|
|
Change-Id: Ie02fb495beebd02d8331e547cbe6648dc70f241f
|